Re: [openstreetmap/openstreetmap-website] Displays links for messaging and socialization on user profile only if user is singed in (PR #5203)

2024-09-14 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 1 commit. 8d77891fd6796f32f665f7524e0ed8f098507f6d Show friend options only when user is logged in -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5203/files/6d4fb42cfd2755a740bc425bf1d217df6e787c32..8d77891fd6796f32f665f7524e0ed8f098507f

Re: [openstreetmap/openstreetmap-website] Displays links for friend options on user profile only if user is signed in (PR #5203)

2024-09-14 Thread Nenad Vujicic via rails-dev
> I think we should definitely remove add/remove friend as they can't be > correctly rendered without knowing the current friendship state but I think > we should probably leave send message as it's reasonable to offer to > everybody, even those that would have to signup to send a message. Than

Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)

2024-09-17 Thread Nenad Vujicic via rails-dev
![image](https://github.com/user-attachments/assets/d2d72177-be5e-43fc-9985-58b87fccf049) CONTRIBUTING.md states "I18n keys under the geocoder.search_osm_nominatim keyspace are managed by the Nominatim maintainers.". Do we need to update CONTRIBUTING.md or to revert this removal (cities, towns,

Re: [openstreetmap/openstreetmap-website] Added workflow for PR labeling using Danger (PR #4988)

2024-10-07 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 1 commit. e307b9037a05fb6ea0a8790cb6f6e0824781e949 Added workflow for PR labeling using Danger -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4988/files/9dd7b1a24607511bb95c15953ff33d38c3ceedb1..e307b9037a05fb6ea0a8790cb6f6e0824781e949 Y

Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)

2024-10-15 Thread Nenad Vujicic via rails-dev
@nenad-vujicic approved this pull request. This works great on my side, thank you very much! Wild idea: since we already have decision procedure, which answers the question "do we have multiple pages?", why don't we use it for hiding pagination buttons when they are not required / usable? --

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-04 Thread Nenad Vujicic via rails-dev
@nenad-vujicic commented on this pull request. > @@ -9,6 +9,13 @@ SET xmloption = content; SET client_min_messages = warning; SET row_security = off; +-- +-- Name: public; Type: SCHEMA; Schema: -; Owner: - +-- + +-- *not* creating schema, since initdb creates it + + > There shouldn't be any

Re: [openstreetmap/openstreetmap-website] Added workflow for PR labeling using Danger (PR #4988)

2024-10-07 Thread Nenad Vujicic via rails-dev
Removed "Good" label and rebased again. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4988#issuecomment-2396594928 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Don't show older/newer buttons if all items fit on one page (PR #5276)

2024-10-21 Thread Nenad Vujicic via rails-dev
@nenad-vujicic approved this pull request. Works great! Thank you very much!!! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5276#pullrequestreview-2382493706 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Display old node versions on map view (PR #5278)

2024-10-22 Thread Nenad Vujicic via rails-dev
@nenad-vujicic approved this pull request. This works great on my side, thanks! I believe similar changes to remaining OSM.OldBrowse() occurrences will enable displaying old ways / relations versions? :-) Q: I found one strange behavior with nodes / ways / relations pagination controls. They i

Re: [openstreetmap/openstreetmap-website] Danger isn't working in CI (Issue #5267)

2024-10-22 Thread Nenad Vujicic via rails-dev
It seems GitHub also supports [tokens with fine-grained set permissions](https://docs.github.com/en/rest/authentication/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28), although they are still in Beta. Using these we can set write permissions for labels only.

[openstreetmap/openstreetmap-website] Proposal for adding support for map notes tags (Issue #5294)

2024-10-29 Thread Nenad Vujicic via rails-dev
### Problem Do you have some key-value meta-data you would like to store with map notes? Would you like to do it like with tags in nodes / ways / relations / changesets / .. instead of writing in description / comments? Note tags have already been mentioned / requested several times in #385 , #

[openstreetmap/openstreetmap-website] Test good PR (PR #5300)

2024-11-04 Thread Nenad Vujicic via rails-dev