@hlfan commented on this pull request.
> @@ -252,7 +247,7 @@ OSM.Query = function (map) {
*/
function queryOverpass(lat, lng) {
const latlng = L.latLng(lat, lng).wrap(),
- bounds = map.getBounds().wrap(),
+ bounds = map.wrapLatLngBounds(map.getBounds()),
Removed, p
hlfan left a comment (openstreetmap/openstreetmap-website#6092)
This has been an issue for the query tool since its introduction.
It is relatively easy to let i18n do the templating, my preferred method and
something I already implemented in cfb17435d1b11cd94aa865a6448e487b1a0cca17
before portin
hlfan left a comment (openstreetmap/openstreetmap-website#6091)
Please take a look at these links:
-
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Profiles.show.social+links.title
-
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Users.show.company
-
https:
hlfan left a comment (openstreetmap/openstreetmap-website#6094)
I've marked the [long
translations](https://translatewiki.net/w/i.php?title=Special:Search&profile=default&search=Osm:Directions.show.button+insource:/.{4,}/)
as [fuzzy](https://translatewiki.net/wiki/FAQ#!!FUZZY!!).
--
Reply to t
@hlfan pushed 2 commits.
d64be5d70174ad09e672ee405e0a423ff79a55a9 Add test for SVG sprite presence
b06cc0ede70d20140ec6b5327862ebc734fd6bef Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/3757e775ad0667cd78bc1a2a882d11
hlfan left a comment (openstreetmap/openstreetmap-website#6198)
>From the search, when selecting a result, the search input stays. It will
>persist when navigating to history or export, and only be removed once the
>sidebar is closed via the close button.
--
Reply to this email directly or vie
@hlfan commented on this pull request.
On app/assets/javascripts/leaflet.map.js:
What do you think of swapping the hierarchy of the new files, with
`leaflet.shortbread.js` required in `leaflet.maplibregl.js`?
The current way would need to require `leaflet.maplibregl.js` twice,
once in `leafle
@hlfan commented on this pull request.
> @@ -101,4 +112,108 @@
scrollableList.scrollLeft = scrollableList.scrollWidth -
scrollableList.offsetWidth;
}
}
+
+ function previewWikidataValue($btn) {
+if (!OSM.WIKIDATA_API_URL) return;
+const items = $btn.data("qids");
+if
@hlfan pushed 1 commit.
62b4087b78d9281f34c9e27ccecb976c3660d133 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/78d0571781958d9747d7f22b925d8dadb128cb12..62b4087b78d9281f34c9e27ccecb976c3660d133
You are rec
@hlfan pushed 1 commit.
5c417a3449d2df628225c2a6051a18dfa5486afb Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/1dd9297d0f40e1497a79c1cbf8d5c300170e4c39..5c417a3449d2df628225c2a6051a18dfa5486afb
You are rec
@hlfan pushed 7 commits.
fac2bcbd37de845d15f46fe77310c84fce059743 Make Rails handle SVG partials
77783d315d947d68e0673aa1fcd09814544c8455 Move search icons to partials
a0e08197d07dc6854f8899e4c3d3f9d1540be799 Move about icons to partials
a26a893c54f5cef6e1a3706bb4c59960c928f1b0 Move welcome ic
@hlfan pushed 1 commit.
7030501ae30d095ae1eab877c3db63c26b49f02c Add geo URI handler registration on
link interaction
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5968/files/16d3a21296bbaa8f605ef3c3f670919bc43ae226..7030501ae30d095ae1eab877c3db63c26b49f02c
@hlfan pushed 1 commit.
f4cac8897124af3ca2d987e4f8fbd6ff87384b9c Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/5089344ab6e3bcf59995623af13403b195af2d7d..f4cac8897124af3ca2d987e4f8fbd6ff87384b9c
You are r
@hlfan commented on this pull request.
> +.addClass("bg-body-tertiary");
+ labelLink
+.closest("tr")
+.after($("").append(cell));
+
+ if (data.icon) {
+$("")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, height: "3
hlfan left a comment (openstreetmap/openstreetmap-website#6092)
If you want to, you can copy this commit into a new PR, I'm not quite ready for
another round of this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6092#issueco
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6144#pullrequestreview-2969255540
You are receiving this because you are subscribed to this thread.
Message ID:
__
Addressing a part of #3123 to keep the search input longer, now that #6184
simplified the state management.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6198
-- Commit Summary --
* Keep search input until sidebar
@hlfan pushed 1 commit.
7b694cbc67f36656528f23f3af871f35c596412a Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/749f01e37f290f090ee915e7f96866da5a636c4e..7b694cbc67f36656528f23f3af871f35c596412a
You are r
@hlfan pushed 2 commits.
fedd6dd3a9e1e5ba8f3d8667cde3ca8c70ff1b59 Use only differences to OSM logo in
internal social link icons
4a008009824c82dd30dd6d77e30b01ea366c6780 Add OSM logo indicator for related
social links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 5 commits.
4eb552a0aeae685b5dd7dcf41dfd2966fc5f10c0 Use common note marker definitions
97cdf42730e21c8f2dd350252e4737bc99ad584f Generalize leaflet-marker-icon
selector
9f74425951f4982139ac0bebf97dd65030e95ea8 Add Bootstrap .position-absolute
class to print styles to hide svg def
@hlfan commented on this pull request.
> @@ -0,0 +1,44 @@
+
Added a copy of #5999 for `position-absolute`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2217096942
You are receiving this because you are subsc
hlfan left a comment (openstreetmap/openstreetmap-website#6207)
If Intl.DisplayNames is the only big hurdle as it looks to me, then moving it
inside the wikidata preview render method would be less blocking.
That said, there might be other modern features that get in the way of the js
controller
@hlfan commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
Could this code block be moved into the `// Image` section just below?
@hlfan commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/svg+
@hlfan pushed 5 commits.
a05cade7289d411f357bed9ba7693b24000c5c10 Store search icons separately
14072e6110c05274191e2adfb6d2f6027c6116c9 Store about icons separately
a9725cd2a94af85fcbbaa125790ca895d4623d73 Store welcome icons separately
d383095325ecdc5ac39a2852156413d97695faf8 Store diary ico
### Description
This avoids breaking page load in legacy browsers like Pale Moon by delaying
the instanciation of Intl.DisplayNames until it's needed.
Closes #6207.
### How has this been tested?
Sandboxed Pale Moon with a locally served site.
You can view, comment on, or merge this pull request on
hlfan left a comment (openstreetmap/openstreetmap-website#6207)
Well, AFAICT Intl.DisplayNames blocks OSM.MappedElement blocks OSM.router, so
this is an easy fix (#6208).
That doesn't mean future issues on legacy browsers will also get fixed.
--
Reply to this email directly or view it on GitHu
@hlfan pushed 4 commits.
d901d444ec1880ef070f486d26cbc3a3ab744c8b Store search icons separately
aea85108828419e98d8e71d537adeeedf68b4abf Store welcome icons separately
a567f51e6b37b489e1f4a76329a1de2975d21944 Store diary icons separately
ac5739982af584a98bd434a3271ae67bff9d2060 Store more icon
`_about_section.html.erb` was removed in #4868 due to the incompatibility with
manually inlined icons.
With the icons inlined with the new gem, we can re-add the layout partial.
This slims #5938. See also the changed files in [this
diff](https://github.com/openstreetmap/openstreetmap-website/comp
@hlfan commented on this pull request.
> @@ -8,7 +8,6 @@ L.OSM.share = function (options) {
function init(map, $ui) {
// Link / Embed
-
What has this empty line done to you? /j
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
Valhalla seems to use "stay" for forks, and "slight" icons
are already separate.
I was unable to find more concrete documentation, though.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6211
-- Commit Summary --
*
### Description
Using a few more form tag helpers makes the search layout quite a bit more
readable.
Less repetition and better integration of the inline_svg tags following #5938.
### How has this been tested?
Local installation.
You can view, comment on, or merge this pull request online at:
h
@hlfan approved this pull request.
Whether or not the style.json path definition changes, this now looks good to
me. That could also be worth revisiting when there's more than one vector style.
Tests pass in my fork https://github.com/hlfan/openstreetmap-website/pull/18.
If you wanna do other rev
@hlfan pushed 2 commits.
623db110e4d50b3b1f1177cdd3d1f4a49a4e1f11 Fix formatting of arrow function
45f8ed06bdb881b70188c1401061878e19281f28 Add reasonable workflow time limits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/df9d34c332cc26c6cd2d242ca
@hlfan pushed 1 commit.
86643d22c51ee3fed1c99d173a390b8a10a9a9bb Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/71aa64b26c32a3c21da04ad45fcd128780b2440d..86643d22c51ee3fed1c99d173a390b8a10a9a9bb
You are rec
@hlfan pushed 1 commit.
e81bb9bd7139faa95b0ef4f6b34163e7d7db001a Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/5ac1b483f08bab249fe63f03221748a26640..e81bb9bd7139faa95b0ef4f6b34163e7d7db001a
You are rec
hlfan created an issue (openstreetmap/openstreetmap-website#6173)
### Problem
The current solution could break.
### Description
Add a test to ensure the security vulnerability doesn't sneak back in.
### Screenshots
_No response_
--
Reply to this email directly or view it on GitHub:
https://
@hlfan pushed 1 commit.
5e03d30860ac50753d4d247edd1a96cb60532a82 Restructure button selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184/files/0e020c42e4bbdccf55ff36d2a43e96031a6b66d5..5e03d30860ac50753d4d247edd1a96cb60532a82
You are receiving this bec
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Let's take a look at the latest test run that didn't fail on "real bugs", [this
test
run](https://github.com/openstreetmap/openstreetmap-website/actions/runs/16122953585)
for #6170:
The three executions of `rails test:all` finishe
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Aha, so it's not really understanding on both sides!
I thought you meant manipulations of svg internals inside a helper module, not
on invocation.
> How is that supposed to work at the same time?
Well, since the `fill` and `stroke
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
> Why is it important to run the test to its completion if you're going to run
> it again anyway?
https://github.com/user-attachments/assets/edd82135-9d7f-4d38-90f8-a928df9eff2c";
/>
There's an option not to.
I'm not saying we sh
@hlfan commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+ end
+
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
@hlfan pushed 1 commit.
aa65a878f7f610554b8ad67f3731c49d7e07f8d3 Fix missing newline at end of file
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/86af97f5f827eb3f70eb4c217fd0f1d5a1d3210e..aa65a878f7f610554b8ad67f3731c49d7e07f8d3
You are receiving t
@hlfan pushed 1 commit.
bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/aa65a878f7f610554b8ad67f3731c49d7e07f8d3..bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e
You are receiving this
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
That should be doable by addin
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
@hlfan pushed 1 commit.
5017d1ac042012846fbe1168d0b06d6db244bbdd Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/01e3075722f58f0309a4599d2170256dbf2e2d2b..5017d1ac042012846fbe1168d0b06d6db244bbdd
You are receiving this
@hlfan pushed 1 commit.
ad3039224fded9b822a75fe62b8b7ad93ffca9ae Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/5017d1ac042012846fbe1168d0b06d6db244bbdd..ad3039224fded9b822a75fe62b8b7ad93ffca9ae
You are receiving this
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Well, there's already quite a
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
hlfan left a comment (openstreetmap/openstreetmap-website#6184)
Dependent on #6185
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184#issuecomment-3066976429
You are receiving this because you are subscribed to this thread.
Mes
@hlfan pushed 2 commits.
b1f6ade08bbb2307323e6a26581f7d9de8a33f5c Add test for SVG sprite presence
1d048bface26fc0703fb73b8957d2f06d3748661 Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/ad3039224fded9b822a75fe62b8b7a
@hlfan pushed 2 commits.
13eabbc8c9c3043b4d1eae06621862775db177df Add test for SVG sprite presence
3757e775ad0667cd78bc1a2a882d11fda349ea1b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/79539b4486449f3ea1237ee4c4d2e8
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
@hlfan pushed 1 commit.
79539b4486449f3ea1237ee4c4d2e8d230c309bc Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/1d048bface26fc0703fb73b8957d2f06d3748661..79539b4486449f3ea1237ee4c4d2e8d230c309bc
You are receiving this
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4191#pullrequestreview-3006287729
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6176#pullrequestreview-3006217290
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
I've recently found myself reviewing less frequently — not because I expected
progress on particularly my submissions in return, but because I didn't see my
reviews contributing meaningfully to overall progress.
A big part of that,
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
No, but going out of their way to submit a compact PR that is easily reviewable
(and mergeable - not self-merge though) to undermine a PR, forcing their point
with a necessary rebase rather than simply having a discussion.
--
Repl
@hlfan pushed 1 commit.
bde4e2f507807a1f689cf2c931a05e7dcd84d1e5 Add reasonable workflow time limits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/214482674768ef45d821993be280d3564c025947..bde4e2f507807a1f689cf2c931a05e7dcd84d1e5
You are receiving
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
Sent you a [c.osm.org](//c.osm.org) dm @1ec5.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-3058759408
You are receiving this because you are su
hlfan left a comment (openstreetmap/openstreetmap-website#6066)
Can
[origin/save-screenshots](https://github.com/openstreetmap/openstreetmap-website/tree/save-screenshots)
be deleted, or is it still needed?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
hlfan left a comment (openstreetmap/openstreetmap-website#6137)
> When this is ready for merging I'll rebase and squish before taking it out of
> draft.
Moving the layer definition out of
[leaflet.map.js](https://github.com/openstreetmap/openstreetmap-website/pull/6137/files#diff-f060eef487077b
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Another thing to note is that the preview in the rich diff sped up my reviews
of #6124 quite a bit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomme
@hlfan commented on this pull request.
> +**Important Notes:**
+- Loading an apidb database with Osmosis is about **twenty** times slower than
loading the equivalent data with osm2pgsql into a rendering database
+-
[`--log-progress`](https://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage#-
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6180#pullrequestreview-3011231088
You are receiving this because you are subscribed to this thread.
Message ID:
__
Use the input state to toggle the describe_location button's visibility
with CSS instead of manually updating.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6184
-- Commit Summary --
* Lock describe_location butto
hlfan left a comment (openstreetmap/openstreetmap-website#6194)
I'm kinda already looking forward to `v2.35.2`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6194#issuecomment-3068346132
You are receiving this because you are su
Test driving the inline_svg gem.
Continues #5753 and closes #5776 following the discussion in #5880.
The color replacement is still broken, and I don't know what else to try.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/
hlfan left a comment (openstreetmap/openstreetmap-website#6189)
Hmm. Interesting, but great!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-3066022208
You are receiving this because you are subscribed to this th
@hlfan pushed 1 commit.
01e3075722f58f0309a4599d2170256dbf2e2d2b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e..01e3075722f58f0309a4599d2170256dbf2e2d2b
You are receiving this
@hlfan requested changes on this pull request.
On app/assets/javascripts/leaflet.map.js:
See
https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3062857646,
no other layers are defined in this file
--
Reply to this email directly or view it on GitHub:
https://githu
hlfan left a comment (openstreetmap/openstreetmap-website#5854)
Should I split up the "Update and inline markers" commit into three parts and
temporarily make `OSM.getMarker` use a dict so I can update the options
separately?
Would that make this PR easier to digest?
--
Reply to this email dir
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Why should we cancel successfully run steps like [this
one](https://github.com/hlfan/openstreetmap-website/actions/runs/16058832401/job/45319779765#step:13:16)?
--
Reply to this email directly or view it on GitHub:
https://github.c
@hlfan pushed 1 commit.
5ac1b483f08bab249fe63f03221748a26640 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/d47b9f2e8a32e9ff5c92a19ab6b2b458c8d01105..5ac1b483f08bab249fe63f03221748a26640
You are rec
@hlfan commented on this pull request.
> +.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
> "Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
+ $btn
+.siblings(`a[href*="
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> we should add an Api-User-Agent header to the fetch in this PR
How does `OSM TagPreview
(https://github.com/openstreetmap/openstreetmap-website)` look to you? Any
other details I'm missing?
--
Reply to this email directly or vi
@hlfan pushed 1 commit.
4bbd8ce05d4c94992e0b996617d2b259b5ded96c Exclude wikidata explainers from
extreme wrapping
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/7fb08eae16c3c08d9669c18a5211905f2ff30d4a..4bbd8ce05d4c94992e0b996617d2b259b5ded96c
You
@hlfan pushed 1 commit.
f73f2315b6633fddea8edcb9659bb000b28c1751 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/4bbd8ce05d4c94992e0b996617d2b259b5ded96c..f73f2315b6633fddea8edcb9659bb000b28c1751
You are rec
Danger doesn't seem to like that:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#issuecomment-3001407276
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/d6c511ba68f0d7ad53b7d53d5c0de8c3b150cde9#r160737470
You ar
hlfan left a comment (openstreetmap/openstreetmap-website#6164)
Unfortunate merge timing Mr. Hughes:
https://github.com/openstreetmap/openstreetmap-website/blob/ef2f248e0075a4cd7d77eefc77665f1730d6bd4b/app/assets/javascripts/leaflet.share.js#L15
--
Reply to this email directly or view it on GitH
@hlfan commented on this pull request.
> @@ -11,6 +11,7 @@ permissions:
jobs:
danger:
runs-on: ubuntu-latest
+timeout-minutes: 1
Well that has to be revised:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/16033899766/job/45240902000?pr=6154
That's why I initia
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan pushed 1 commit.
19e739716360bf69d3ab06abbf4109f2ab549fb7 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/e81bb9bd7139faa95b0ef4f6b34163e7d7db001a..19e739716360bf69d3ab06abbf4109f2ab549fb7
You are rec
@hlfan pushed 1 commit.
c8f0ba4f5760a7593b574506de5a141e01fce39a Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/54d2eb08341fabe4b31942f87e781a75e8f67340..c8f0ba4f5760a7593b574506de5a141e01fce39a
You are rec
hlfan left a comment (openstreetmap/openstreetmap-website#6111)
Please remove the duplicate lines you added.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6111#issuecomment-3028249199
You are receiving this because you are subsc
@hlfan commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
+
@hlfan commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
+
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6105#pullrequestreview-2976539850
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2976547233
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan left a comment (openstreetmap/openstreetmap-website#6065)
If we go ahead with regarding the osm-related definition as too fuzzy for a
section, even with a two icon approach you still need to make a decision about
when to have two icons and when not.
Just an "H" as a logo could be enough in
@hlfan commented on this pull request.
I didn’t see anything particularly noteworthy in your changes compared to
4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86, the few comments I’ve left are about
things you haven't touched yet.
> + for (let i = 0; i < OSM.preferred_languages.length; i++) {
+
@hlfan commented on this pull request.
> @@ -79,3 +79,18 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "OpenMapTiles"
+ code: "V"
+ layerId: "openmaptiles_osm"
+ nameId: "openmaptiles_osm"
+ apiKeyId: "maptiler_key"
If yo
@hlfan commented on this pull request.
On vendor/assets/leaflet/leaflet.osm.vector.js:
This shouldn't be under vendor but next to the leaflet.map.js you pulled it out
of.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#p
901 - 1000 of 1116 matches
Mail list logo
