@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5794#pullrequestreview-2678368667
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan left a comment (openstreetmap/openstreetmap-website#5796)
Could Firefox be fixed to v135 in the meantime?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5796#issuecomment-2719194835
You are receiving this because you are su
@hlfan commented on this pull request.
> @@ -71,30 +71,28 @@ OSM.initializeNotesLayer = function (map) {
var size = bounds.getSize();
if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
- var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" +
bounds.toBBoxString();
+ var url = "
@hlfan commented on this pull request.
>
- noteLoader = null;
+ for (var id in oldNotes) {
+noteLayer.removeLayer(oldNotes[id]);
+ }
+})
+.catch(() => {})
Didn't have them there until I tested frantic map movement and AboetErrors
started to
hlfan created an issue (openstreetmap/openstreetmap-website#5670)
### URL
https://github.com/openstreetmap/openstreetmap-website/actions/workflows/tests.yml
### How to reproduce the issue?
Ehm...
1. Make sure the Coveralls API is in maintenance mode or something like that
2. Have a CI task try
### Description
Moves all AJAX requests that don't need OAuth to fetch. (except Matomo as
this fetches a script)
### How has this been tested?
Logpoints and quite a bit of erratic map movement to check for aborts
You can view, comment on, or merge this pull request online at:
https://github.c
hlfan left a comment (openstreetmap/openstreetmap-website#5668)
This planned outage was supposed to have ended about two hours from now:
https://status.coveralls.io
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5668#issuecommen
@hlfan commented on this pull request.
>
$(this).hide();
div.find(".loader").show();
-params[csrf_param] = csrf_token;
+params.append(csrf_param, csrf_token);
Nope, fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
@hlfan commented on this pull request.
>method: "POST",
- data: {
+ headers: { "Content-Type": "application/x-www-form-urlencoded" },
Removed all three.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#dis
@hlfan commented on this pull request.
>$("#browse_status").empty();
-}
-
-if (XMLHttpRequest.status === 400 && XMLHttpRequest.responseText) {
- displayLoadError(XMLHttpRequest.responseText, closeError);
-} else if (XMLHttpRequest.statusText) {
-
@hlfan commented on this pull request.
> @@ -71,30 +71,28 @@ OSM.initializeNotesLayer = function (map) {
var size = bounds.getSize();
if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
- var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" +
bounds.toBBoxString();
+ var url = "
hlfan left a comment (openstreetmap/openstreetmap-website#5558)
> All occurrences of `var` are changed with `let/const`. Checked all changed
> variables and `let` and `const` are set accordingly (every variable that is
> not changed after declaration, is `const`).
[ESLint
concurs](https://gith
@hlfan pushed 2 commits.
e87a71dca1a3001b736ddbc2486de9fb0de8acb3 Add button for directions from
location
1296aeec2920a1a9834c55129132db63efe5b02b Associate search input with route
destination instead of departure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
@hlfan pushed 1 commit.
659162256f7eec6dcd6afdea7d18cb6a5d565fd0 Transition more requests to fetch
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669/files/942fc190ebffe9dca6cb1f709da470034dccc823..659162256f7eec6dcd6afdea7d18cb6a5d565fd0
You are receiving th
hlfan left a comment (openstreetmap/openstreetmap-website#5671)
This will set the starting point marker regardless of whether the user is on
the directions page.
--
Reply to this email directly or view i
hlfan left a comment (openstreetmap/openstreetmap-website#5632)
This bug was introduced with [this
fix](https://github.com/openstreetmap/openstreetmap-website/compare/f359a73d5b64e046ab7f783aa37b685ebc65c052..5310c5b9dd67f7d416ee778a36f43c21126a1575)
to uninitialized variables. Making the remain
@hlfan commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"] =
endp
hlfan left a comment (openstreetmap/openstreetmap-website#5698)
idData already has the coordinates, so why can't this be used here?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2662635062
You are receiving thi
@hlfan pushed 1 commit.
3939f24460b6c32c25a5432764ff5f4ff5e8dea6 Enable exporting direction paths
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694/files/00d44580539494b7e85b56b294eafe523c6a4338..3939f24460b6c32c25a5432764ff5f4ff5e8dea6
You are receiving thi
@hlfan commented on this pull request.
> @@ -36,6 +36,9 @@ OSM.Directions = function (map) {
OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED,
endpointDragCallback, endpointChangeCallback)
];
+ const exportGroup = L.layerGroup([...endpoints.map(m => m.marker),
Closed #5670 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#event-16324305188
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
@hlfan commented on this pull request.
> @@ -34,17 +34,17 @@ OSM.NewNote = function (map) {
});
function createNote(location, text, callback) {
-$.ajax({
- url: "/api/0.6/notes.json",
- type: "POST",
- oauth: true,
- data: {
+fetch("/api/0.6/notes.json?", {
D
@hlfan pushed 1 commit.
cc458d1870ed22e2d3d1b8dceab69716ade2e8d0 Split engines into providers and modes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/850471ee5841a486d08ffeeaa6fd35f077fe28ef..cc458d1870ed22e2d3d1b8dceab69716ade2e8d0
You are receivi
hlfan left a comment (openstreetmap/openstreetmap-website#5700)
I already wanted to increase the zoom in general in
https://github.com/openstreetmap/openstreetmap-website/pull/5632#discussion_r1948124352
but if we already have a zoom set in the
[site_controller](https://github.com/openstreetmap
hlfan left a comment (openstreetmap/openstreetmap-website#5700)
That was done for Potlatch in
https://github.com/openstreetmap/openstreetmap-website/commit/50fafa14f86a9ff02458c1e055f24c199f14a8eb
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
Follow-up to #5700 to include the zoom as well
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5711
-- Commit Summary --
* Set zoom in id iframe data
-- File Changes --
M app/assets/javascripts/edit/id.js.erb (
Reopened #5670.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#event-16399114016
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
@hlfan pushed 1 commit.
a3071304109c3814bdff37a9554239c476d3d932 Add button for directions from
location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5635/files/b9ffd2fe4e83c2ffab659ce54196ccab7c1f62d0..a3071304109c3814bdff37a9554239c476d3d932
You are recei
@hlfan pushed 2 commits.
20f3bacd88d341a8bc4965210098614b696009a9 Split engine translations
eae7f3c1dcc2bffc5563d2ac64c8239b1795caba Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/bc3abc403aa
@hlfan commented on this pull request.
> +modeGroup.html("");
+for (const mode of new Set(modes)) {
+ modeGroup.append(``);
+ modeGroup.append(``);
+}
Disabling the buttons and the selects options seems better, disabling all in
the template and enabling each in js when su
@hlfan commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+if (!
@hlfan pushed 3 commits.
d5b3a70ac122e9b3ae4fbb7d14782ab85bc3f715 Split engine id into mode and provider
8277f29c907ba3240fdd409b3da2c24b5466cb42 Split engine translations
0a0835dbfa38bef1c1e19d852e349e13a6753e7c Split directions engine select into
modes and providers
--
View it on GitHub:
h
### Description
I modified the directions engine interface to return the steps grouped into
legs and create a turn instruction table for each leg. This change isn't
visible to the user, as there isn't a third endpoint yet.
### How has this been tested?
So much browser-based that I initially forgo
hlfan left a comment (openstreetmap/openstreetmap-website#5720)
The goal is to display the routing engines' responses more accurately. Since
all of these support multiple legs, the sidebar does too, now.
And while this is a step to support via points, I wouldn't call that the goal.
--
Reply to
@hlfan commented on this pull request.
> + { :id => "car", :icon => "M2.52 3.515A2.5 2.5 0 0 1 4.82
> 2h6.362c1 0 1.904.596 2.298 1.515l.792
> 1.848c.075.175.21.319.38.404.5.25.855.715.965 1.262l.335
> 1.679q.05.242.049.49v.413c0 .814-.39 1.543-1 1.997V13.5a.5.5 0 0
> 1-.5.5h-2
@hlfan pushed 1 commit.
5591008c24dbd81362c55713148a2355a0c6abd5 Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/eae7f3c1dcc2bffc5563d2ac64c8239b1795caba..5591008c24dbd81362c55713148a2355a0c6ab
@hlfan pushed 1 commit.
b7d293c28006a6823005075d3eb3016f7b4fb4b6 Split directions engine select into
modes and providers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/5591008c24dbd81362c55713148a2355a0c6abd5..b7d293c28006a6823005075d3eb3016f7b4fb4
@hlfan pushed 1 commit.
5f68458185f140c6ba61c8fff8ed282c3fad121a Improve download link translation
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694/files/3939f24460b6c32c25a5432764ff5f4ff5e8dea6..5f68458185f140c6ba61c8fff8ed282c3fad121a
You are receiving th
@hlfan commented on this pull request.
> @@ -3312,6 +3312,8 @@ en:
ninth: "9th"
tenth: "10th"
time: "Time"
+ download: "Download track as GeoJSON"
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
Closes #5635, closes #5671
An event-based variant of #5671, vectorizing the coordinates for more compact
fallback
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5727
-- Commit Summary --
* Set directions departure
@hlfan pushed 1 commit.
3ce4387967f7ba522ede2c71d252c510af4f5d7b Hard-code order
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/0a0835dbfa38bef1c1e19d852e349e13a6753e7c..3ce4387967f7ba522ede2c71d252c510af4f5d7b
You are receiving this because you are
Closed #5720.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5720#event-16470970823
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan commented on this pull request.
> -});
- }
-
- function setEngine(index) {
-chosenEngine = engines[index];
-select.val(index);
+ function setEngine(id) {
+const engines = OSM.Directions.engines;
+const desired = engines.find(engine => engine.id() === id);
+if (!
@hlfan commented on this pull request.
> +<% if Settings.key?(:maptiler_key) %>
+ MAPTILER_KEY: <%= Settings.maptiler_key.to_json %>,
+<% end %>
This should be with the other keys in the embedded Settings json
--
Reply to this email directly or view it on GitHub:
https://github.com/openstree
@hlfan commented on this pull request.
> @@ -76,5 +76,10 @@ document.addEventListener("DOMContentLoaded", function () {
const data = parent.OSM.mapParams();
goToLocation(data);
});
+
+const projectTitle = parent.document.title;
+new MutationObserver(() =>
+ parent
@hlfan pushed 1 commit.
7a8bc77219d111cc9f78cff0e32ee787b03aea20 Propagate iD title to parent
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5865/files/e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5..7a8bc77219d111cc9f78cff0e32ee787b03aea20
You are receiving this be
@hlfan pushed 1 commit.
dd4068c8c7638beeb8e39181ded99dfc82dec90f Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/2d9a37a61e1dabf65bed726f0a9f7df62877be91..dd4068c8c7638beeb8e39181ded99dfc82dec90f
You are receiving this because
@hlfan pushed 1 commit.
0f7b954def5bf58c24dba964d8825a3bb08c7e04 Remove svg symbol tags
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776/files/dd4068c8c7638beeb8e39181ded99dfc82dec90f..0f7b954def5bf58c24dba964d8825a3bb08c7e04
You are receiving this because
### Description
Fixes #5864
### How has this been tested?
With the dev tools
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5865
-- Commit Summary --
* Propagate iD title to parent
-- File Changes --
M app/a
### Description
The way the directions icons are currently drawn, the diagonal arrows are a
fair bit smaller than the arrows in cardinal directions. The size stays
consistent when the arrows are instead drawn with a marker.
Compare the icons in this chart, where the old icon is red, the new one g
@hlfan pushed 1 commit.
e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5 Propagate iD title to parent
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5865/files/5ff2d6a204f136158aabdb1bce3434e2145511df..e8ac8ffe3cdb4ebca7919d275ce5dc89f9a0aed5
You are receiving this be
@hlfan commented on this pull request.
> +const params = new URLSearchParams;
+for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon",
"maxlat"]) {
+ const paramValue = this.elements[paramName].value;
+ if (paramValue) {
+params.set(paramName, paramValu
@hlfan pushed 1 commit.
a8a6d039b087818095dab688f5ab88cf434fa9e4 Remove controls sprite
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752/files/73afa85266af789fef46f6be934e1eb476e62433..a8a6d039b087818095dab688f5ab88cf434fa9e4
You are receiving this because
@hlfan pushed 1 commit.
7419d9ff134c2ce4487b4fac70f1346cb825c3f2 Consolidate leaflet marker creation
in OSM.getMarker
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5860/files/59a6502072760d26b850303e983a4ad61f3c904b..7419d9ff134c2ce4487b4fac70f1346cb825c3f2
@hlfan pushed 1 commit.
59a6502072760d26b850303e983a4ad61f3c904b Make marker height a parameter
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5860/files/3f5fb9a200ff0e5e87b4fd38c800bf3a78bc62c7..59a6502072760d26b850303e983a4ad61f3c904b
You are receiving this
@hlfan pushed 1 commit.
0314155471019d6c16a4ad0e3043d41e7ee58e39 Keep rich text copyable
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/e833913b09a53cd55c16eb8cf55d3f269e5b7b8a..0314155471019d6c16a4ad0e3043d41e7ee58e39
You are receiving this because
@hlfan commented on this pull request.
> + - hosts: ["www.openstreetmap.org", "www.osm.org", "www.openstreetmap.com",
> "openstreetmap.org", "osm.org", "openstreetmap.com"]
+host_replacement: "osm.org"
idk if anybody still uses these, but I guess `path_prefix: "^/browse(?=/\w+)"`
would f
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
> > are not working anymore?
>
> Do you want to say they used to work? That text like `osm.org/node/1/history`
> used to be linkified?
When the plain text is copied from shortened links, the protocol is missing, so
it doesn't get
hlfan left a comment (openstreetmap/openstreetmap-website#5861)
Copying and pasting shortened osm.org links makes the pasted links not getting
linkified, as the current regex requires a protocol that is missing in the
copied shortened links.
--
Reply to this email directly or view it on GitHu
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Also previously when the whole url was displayed it could be copied and pasted
and it would be linkified again.
Now linkify strips the protocol, which makes it ignore the links on the "second
pass" after copying and pasting the text
@hlfan pushed 1 commit.
20f1ebbac52747210892c9e194f737825d536673 Update and inline markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/75a77bf7c809bb6ddde72935bce9947b30fec18f..20f1ebbac52747210892c9e194f737825d536673
You are receiving this becau
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Some SVGs could follow a straightforward process: read the file and remove
unnecessary attributes, like `xmlns`.
Like the magnifying glass in the search bar:
https://github.com/openstreetmap/openstreetmap-website/blob/2075eb8329e5e01
@hlfan pushed 1 commit.
c6da5e2cd097a84c4805c3fa122adc8e4416f556 Deduplicate note adding instructions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c7aa5d713bec17445fdff5c98c636536b5828233..c6da5e2cd097a84c4805c3fa122adc8e4416f556
You are receiving
There is not just a `formatHash` call in `fixthemap` but also one in `welcome`
that can be written in the template.
Looked through all `formatHash` calls and cleaned up another call.
Builds on the commit from #5752 that fixes gravitystorm#257.
See also #5869.
You can view, comment on, or merge thi
hlfan left a comment (openstreetmap/openstreetmap-website#5872)
Actually, requiring `leaflet.locatecontrol/dist/L.Control.Locate.umd` could be
moved into L.OSM.locate to make the index and user js cleaner.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/op
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5885#pullrequestreview-2742056636
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
7f4b6978983412e417160f1a3ee5ee6f313afae4 Fix add a note template render
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c39bb4921c29b220a8fc3b3015b635d396b87f1c..7f4b6978983412e417160f1a3ee5ee6f313afae4
You are receiving this
@hlfan commented on this pull request.
> + para_2_html: |
+Just click %{note_icon} or the same icon on the map display.
+This will add a marker to the map, which you can move
+by dragging. Add your message, then click save, and other mappers will
investigate.
Then
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5872#pullrequestreview-2742228212
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
7c72b894789fac7e5c7782972fd7d0099956ef24 Linkify known plain hosts
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/9f16fdaad39ea8680f791d2b5f77ae48514ab3d3..7c72b894789fac7e5c7782972fd7d0099956ef24
You are receiving this becau
@hlfan pushed 1 commit.
aa6f26b947e1dcc1e1450ade9f724744e59f17e3 Convert leaflet markers to SVG
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764/files/278a0c41365a3d5e5cb5a124e1f4583ad952d9ca..aa6f26b947e1dcc1e1450ade9f724744e59f17e3
You are receiving this
In some cases, an expired session only causes the window in the iframe to
reload on the `/edit` page.
This fixes #5807 (the issue for that bug)
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5823
-- Commit Summary --
@hlfan pushed 1 commit.
adb034d26e6f465d07c75a2fcfd3477c38539c4f Add reload on iframe redirect
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5823/files/99e73ddf81496eb2110c64f930d4288776cb45f3..adb034d26e6f465d07c75a2fcfd3477c38539c4f
You are receiving this b
@hlfan commented on this pull request.
> +<% if pages.page_count == 1 %>
+
+<%= t ".#{type.pluralize}_title" %>
+
+ <%= pages.item_count %>
+
+
+<% elsif pages.page_count > 1 %>
+
+<%= t ".#{type.pluralize}_title" %>
+
+ <%= t ".range", :x => pages.current_pag
hlfan left a comment (openstreetmap/openstreetmap-website#5780)
Pasting a full SHA for a commit makes it get formatted too, like
`1370741ca929d87714934c9cc8c52780291fe0c3` to
1370741ca929d87714934c9cc8c52780291fe0c3, so requiring a few digits could be
all that's necessary.
I'd say at least five
@hlfan commented on this pull request.
> -iconAnchor: [12, 41],
-popupAnchor: [1, -34],
-shadowUrl: OSM.MARKER_SHADOW,
-shadowSize: [41, 41]
- });
+OSM.getMarker = function ({ icon = "MARKER_RED", shadow = true }) {
+ const height = icon.includes("NOTE") ? 40 : 41;
+ const opt
@hlfan commented on this pull request.
> @@ -391,13 +391,17 @@ OSM.isDarkMap = function () {
return window.matchMedia("(prefers-color-scheme: dark)").matches;
};
-OSM.getUserIcon = function (url) {
- return L.icon({
-iconUrl: url || OSM.MARKER_RED,
-iconSize: [25, 41],
-iconAn
@hlfan pushed 1 commit.
b58b541d85519166dfbea4bfac28c846c0a4aa2a Linkify known plain hosts
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861/files/0314155471019d6c16a4ad0e3043d41e7ee58e39..b58b541d85519166dfbea4bfac28c846c0a4aa2a
You are receiving this becau
hlfan left a comment (openstreetmap/openstreetmap-website#5859)
Interesting that the viewbox parameter is present when the bbox parameters are
included in the querystring like
https://www.openstreetmap.org/search?query=github&minlon=0&maxlat=1&maxlon=1&minlat=0.
I couldn't find why the data sent
Removes the check for removed protocol that fails when copy-pasting links. See
https://github.com/openstreetmap/openstreetmap-website/issues/5780#issuecomment-2760445765
for details.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-
@hlfan pushed 4 commits.
94c61af78d1b1c8dba0c483ebcb286ce87e7675e Unify active control button behaviour
c6d9a8004661577e31bd0e4919da9cc88971b63f Write fixthemap note link without JS
02bb306dce35b4f9abf6ab980b36b27e9f4a1deb Click links instead of icons in tests
b0049cb3f12dbfee06eea1c8fd50f9d669
@hlfan pushed 1 commit.
78ba2ff31134e65562985c962076c7b03a22ec38 Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/09cd6456de59841c3eb8f2375285c57243c6fddd..78ba2ff31134e65562985c962076c7b03a22ec38
You are receiving this because
@hlfan pushed 1 commit.
f7be240322f35d2e893001a4b3e453d2e85881ac Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/78ba2ff31134e65562985c962076c7b03a22ec38..f7be240322f35d2e893001a4b3e453d2e85881ac
You are receiving this because
Makes the changeset icon definitions a bit more compact and doesn't
redefine them in every single history entry.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5884
-- Commit Summary --
* Remove changeset icon rede
hlfan left a comment (openstreetmap/openstreetmap-website#5879)
```css
background-position: bottom right;
```
And crop away the empty space on the left.
Then:
--
Reply to this email directly
@hlfan pushed 1 commit.
c39bb4921c29b220a8fc3b3015b635d396b87f1c Add add a note template
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/f7be240322f35d2e893001a4b3e453d2e85881ac..c39bb4921c29b220a8fc3b3015b635d396b87f1c
You are receiving this because
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
> How do you think I made them?
ctrl + C, ctrl + V
https://github.com/openstreetmap/openstreetmap-website/pull/5775#discussion_r1986100939
> Yes it is possible [to read the path]
Do we also not add accessibility features into the
@hlfan pushed 1 commit.
32647664df4e689780a40084c791b55217511950 Deduplicate note adding instructions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5870/files/c6da5e2cd097a84c4805c3fa122adc8e4416f556..32647664df4e689780a40084c791b55217511950
You are receiving
@hlfan pushed 4 commits.
731b167714fb6acb520f62602f321ff9cfb77f71 Unify active control button behaviour
07893ac5bbdbf3024131ad353514e9ee36e3c2b3 Set fixthemap note link in template
8d88b38e92943c49d0097010f83e85aa0327b5e7 Click links instead of icons in tests
73afa85266af789fef46f6be934e1eb476e
hlfan left a comment (openstreetmap/openstreetmap-website#5752)
Most aren't needed anywhere other than the map layout, so only the zoom/locate
icons need to be there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomm
### Description
This is an attempt at parametrifying marker colors with `currentColor` since it
has come up in #5764.
Together with optimizing the path geometry, this required rewriting the marker
layout to be compatible with partially transparent gradients.
While an even simpler path has been pr
Closed #5861.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5861#event-17091808717
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
hlfan left a comment (openstreetmap/openstreetmap-website#5822)
Yeah, I noticed just after I created the PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5822#issuecomment-2737521288
You are receiving this because you are subsc
@hlfan pushed 2 commits.
fb9b7fe68899306cdd4b06a13283b7289d1ae131 Update and inline markers
cb0e3d3575da000e9dbbde31bc85efc7a7f66a5d Clean up old markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/efa51b2d8cbdeb180fd658fcf57fc7d44d18c603..cb0e3
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5886#pullrequestreview-2744159542
You are receiving this because you are subscribed to this thread.
Message ID:
__
Moving away from the ever-increasing amount of code required to accommodate
CalHeatmap like in #5906 and going for a custom responsive solution.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5998
-- Commit Summary --
@hlfan pushed 1 commit.
ff71ef68f310ec719ff881c7fe27092c33b23d59 Extract getTooltipText() again
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/ccc56c468195ca68b2cf2303533f18a87e11c5a7..ff71ef68f310ec719ff881c7fe27092c33b23d59
You are receiving this
@hlfan commented on this pull request.
> +<%= map_hash = params[:lat].to_f && params[:lon].to_f ?
> "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}"
> : ""
+ t ".how_to_help.add_a_note.instructions_1_html",
+ :note_icon => link_to(render(:p
@hlfan pushed 1 commit.
966bd974ced71df614838a501d0a6e234eb75637 Prerender heatmap in partial
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/3e35cf00d0823716bdd5560444e6e8e9dbec614a..966bd974ced71df614838a501d0a6e234eb75637
You are receiving this be
@hlfan pushed 1 commit.
699ff148af9e759365c2a8e6904a3bae59283f27 Prerender heatmap in partial
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5998/files/064cf0e6203496f83fc1494259aaafa497dfb608..699ff148af9e759365c2a8e6904a3bae59283f27
You are receiving this be
601 - 700 of 1120 matches
Mail list logo
