> One size can't fit all.
> And by "develop" I mean also trialling them with a large number of users, not
> just launching into production a result satisfying you, me and four people in
> here.
You mean we shouldn't repeat what was done in #4712? /s
> the output will be a mess π
Exactly what's
> Everyone had ~6 months to test the dark mode before it was launched into
> production
Is this an "everyone who watched every single commit in this repo" everyone
(which likely isnβt many), or was this communicated anywhere else?
--
Reply to this email directly or view it on GitHub:
https://g
> Unfortunately it doesn't work for me in Firefox
Something to remember if SVG filters will be used: Firefox ignores filter
definitions if they are behind a `display: none`.
> Is there a way to test different layers?
Do you mean layering filters or changing the Map Tile URL under the heading Ma
Great work! I almost feel bad for missing this.
> Context menu selection is not remembered
What is currently planned for this? Just persistence via `localStorage` or
similar? Something more intricate? User syncing like mentioned in #5324 (also
how would this work for non logged-in users?)?
--
Should cartographers have the choice to use a specific style *and* a filter or
is it an exclusive or? Because this would change how I would implement this
choice.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecommen
If a hillshaded map is featured in light mode, and the cartographers' decision
for the dark mode variant is to have a light version of the style without
hillshading be inverted by the browser.
This would mean a different URL/style and a filter. Should this be permitted?
--
Reply to this email d
How would not logged-in users change this setting?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2480729037
You are receiving this because you are subscribed to this thread.
Message ID:
___
> Regarding option 3b (advanced filters) I'd like to suggest [this
> article](https://monochrome.sutic.nu/2024/02/25/hue-preserving-invert-css-filter-for-dark-mode.html)
> as explanation on why this is important, but hard.
If/When we're implementing an svg filter for that anyway, we can use the
I've looked at a few options for dimming and inverting involving SVG filters.
| no filter | current | heavy | gamma |
|-|-|-|-|
| 
| contrast(95%)` is written
> like this:
> Another I built on blending modes does this too, but with way more saturation
> (I already turned it down to 50% with `satur
> And I don't think the lighter background behind the π’ looks good.
How would you like to have the button indicate that it's disabled then?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2487685324
You are rec
Well, if we're going to think long term then the shortbread eclipse style comes
to my mind. But I don't think anyone here wants to have that stop gap
"solution" in there for _that_ long.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
However, for OSM's most prominent raster map, Carto, this isn't planned, as
it's considered out of scope.
https://github.com/gravitystorm/openstreetmap-carto/issues/5044#issue-2660981521
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
@hlfan approved this pull request.
This is definitely better than just a darkened bright map.
> @@ -504,7 +504,13 @@ body.small-nav {
@include color-mode(dark) {
.leaflet-tile-container,
.mapkey-table-entry td:first-child > * {
-filter: brightness(.8);
+filter: invert(100%) hue-rot
I don't think this preference mashup between local and database storage is a
great idea.
But if logged-in users have the preference synchronized and non-logged-in users
have the color and language (editor choice seems pointless for non-logged-in
users) stored in the cookies it could be interest
Adding onto @pkrasicki's proposal:
Modern CSS could even skip the body class:
```css
.leaflet-tile-pane .leaflet-layer:not(.dark), .mapkey-table-entry
td:first-child > * {
body:has(input[type="radio"][name="filter"][value="light"]:checked) & {
filter: none;
}
If that setting is stored in a cookie instead of in `localStorage` the server
can already set the theme to avoid flashbanging users reloading the site (e.g.
to see how their edits show up), as this would probably come rather late in the
packaged js.
--
Reply to this email directly or view it o
> Inversion with hillshading doesn't look better to me.
This issue remains with Dark 2 and 3.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480732052
You are receiving this because you are subscribed to this
I'd rank the Options 4 > 1 > 3 > 2 (current), since these performance issues
came up.
> > Option 4 would be the best.
>
> Tracestrack on low zooms doesn't look good even we ignore shadows.
But (as previously mentioned) [Option 4 for
Tracestrack](//console.tracestrack.com/explorer) has _the same
@AntonKhorev I don't think linking that PR / closing this issue was the best
idea.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2481387557
You are receiving this because you are subscribed to this thread.
M
I made a little utility to try out filter combinations more easily:
https://codepen.io/hlfan/full/GRVVGog
For convenient editing in the dev tools, the outputted filter is stored in a
custom property and the filter is also applied to the SVG that holds the
filters.
My first insight from using it:
This boils down to two choices: CSS filters yes/no or custom dark mode tiles
yes/no. If the filters would be loaded locally from user preference, and when
the vector tiles arrive (that styling shouldn't come from CSS anyway), then the
default should also be outside the main style file too.
But
> related to having an option to enable or disable dark mode
Just one option? Why not more?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
> For example, we got here believers in inverse+rotate. Why do they think that
> it's the best option? Probably because it generally works for the standard
> layer.
I'm generally in team invert, but here for the default of no filter. And I
don't think layer-wise filters add more than they take
Which dark style do you think of for this important default spot? Is it a dark
carto or some other layer?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480600198
You are receiving this because you are subscr
Couldn't the dark mode have waited for the release of the vector.osm.org tiles?
Then the light mode could've got the colorful style and the dark mode could've
got the eclipse style and that would be the point of conversation instead of
how dimming the map is seemingly the worst option.
--
Repl
> started by adding a dark mode toggle in the settings, staying in light mode
> by default until they were confident enough to link it to user preferences.
Which was done here, there was a flag that could be set in the html to enable
the dark mode. However, this was apparently not communicated a
> Did anyone try them with these layers?
Testing all possible combinations is unreasonable but for all osm-featured
hillshading layers a version of the feFunc-based dimming with a slight positive
offset, an amplitude of 0.6-0.9 and a gamma value of 1.5-3 * seems to yield the
best results.
\* t
@Collaborators, can you move specific comments to a new issue about improving
communication or would we have to start that from scratch again there? Does
github have a feature like Discourse or just mark as off-topic?
--
Reply to this email directly or view it on GitHub:
https://github.com/open
@hlfan requested changes on this pull request.
> @@ -917,6 +917,7 @@ en:
highway:
abandoned: "Abandoned Highway"
bridleway: "Bridleway"
+ highway: "Busway"
If you mean to resolve #5258, the key here should be busway.
--
Reply to this email directly or v
@hlfan commented on this pull request.
> @@ -516,6 +511,23 @@ body.small-nav {
}
}
+@mixin dark-map-color-scheme {
+ .leaflet-tile-container .leaflet-tile,
+ .mapkey-table-entry td:first-child > * {
+filter: brightness(.8);
Doesn't the mentioned step 5 include the need for the filte
> it's ridiculous that the filter still hasn't been rolled back in spite of
> overwhelming opposition from community members.
Well, the current proposal by the maintainers includes an impossible
requirement of "make it dark but don't pick any filter", as stated in
https://github.com/openstreetm
Are you deliberately trying to break _every_ third-party patch/extension for
the website that fixes the dimmed tiles?
If not, please let the color mode preference PR get merged first.
If so, merge ASAP.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openst
> You don't need to change the theme of the page
I did that for testing, but since listening increased the complexity
unnecessarily, I left that for a second pass.
But suppose the site needs a theme watcher anyway because the cal-heatmap
doesn't want to let CSS do the color mixing theme-agnosti
The page you changed the translations of has been redesigned in #5447, which
has already been merged. What would you like a review for?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5445#issuecomment-2565078388
You are receiving
The MutationObserver thought came from my tinkering with the site locally
wanting to reduce the reloads, forgetting that a toggle if added would already
have onchange events.
> So maybe you don't want one global watcher.
Yeah, I kinda missed that... Still, having a similar style on such similar
@hlfan commented on this pull request.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapContainer[0], { attributionControl: false,
zoomControl: false, keyboard: false })
.addLayer(new layer.constructor(layer.options));
+if (layer.optio
@hlfan commented on this pull request.
> @@ -31,6 +31,9 @@ L.OSM.layers = function (options) {
var miniMap = L.map(mapContainer[0], { attributionControl: false,
zoomControl: false, keyboard: false })
.addLayer(new layer.constructor(layer.options));
+if (layer.optio
Any manual theme change without a reload after
`$("html")[0].toggleAttribute("data-bs-theme")` bricks the themes. This
probably has to do with the split distribution of the stylesheets.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
So why have flags in the document at all if you can store the theme entirely by
which stylesheet you load? /s
I haven't seen any other major website load a different CSS file just because
the user changed their color theme preferences.
Are two separate files really necessary also given the comm
@hlfan commented on this pull request.
>
-if (id.data("gpx")) {
- params.set("gpx", id.data("gpx"));
-} else if (hashParams.gpx) {
- params.set("gpx", hashParams.gpx);
-}
+ params.set("map", [
+(mapParams.object && hashArgs.center && hashArgs.zoom) || (id.data("lat")
@hlfan pushed 2 commits.
518936bdb6a406af4df829c3033819148ae6fd05 Remove parseFloat calls and
restructure
500f0e49b8f6c86ef86b952e6f96eccd1ed1545f Collect parseFloat/Int and
restructure mapParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5598/files/deb
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5602#pullrequestreview-2591805229
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
> @@ -68,9 +95,6 @@ module.exports = [
"no-lone-blocks": "error",
"no-lonely-if": "error",
"no-loop-func": "error",
- "no-mixed-operators": "error",
- "no-multiple-empty-lines": "error",
Now the JSON diff (replacing `(\w+)(?=
@hlfan commented on this pull request.
> -
-if (mapParams.object) {
- params.set("id", mapParams.object.type + "/" + mapParams.object.id);
- mapParams = OSM.parseHash(location.hash);
- if (mapParams.center) {
-params.set("map", mapParams.zoom + "/" + mapParams.center.l
@hlfan commented on this pull request.
> }
var hash = OSM.parseHash(location.hash);
const loc = Cookies.get("_osm_location")?.split("|");
+function parseBounds({ minlon, minlat, maxlon, maxlat }) {
+ return L.latLngBounds([minlat, minlon], [maxlat, maxlon]);
+}
@hlfan requested changes on this pull request.
> @@ -68,9 +95,6 @@ module.exports = [
"no-lone-blocks": "error",
"no-lonely-if": "error",
"no-loop-func": "error",
- "no-mixed-operators": "error",
- "no-multiple-empty-lines": "error",
Why has [this rule](//eslint.s
@hlfan pushed 6 commits.
934c08bab0aea6ed70fe53b79a3586c05f6dacba Add early return
2b9477a412ea3f24acb5bbe53c4c7b95422cf6f9 Condense key passthrough
898c9e8ca54e74ca58839ce52637c7720feaeb5c Remove mapParams redefinition
f2b0dcde092829806dee820d3153ab3c778abcee Merge gpx parameter passthrough
2
@hlfan pushed 1 commit.
1f47a294b9f2c2a514a11dc2262d1d0b365e Collect parseFloat/Int and
restructure mapParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5598/files/e5b853eb8738a0fbdbdef2cb3b9b5ef621f605ff..1f47a294b9f2c2a514a11dc2262d1d0b365e
You
@hlfan pushed 1 commit.
1cec0586494e6c3f7c19596fa5e6e813a17e8522 Add eslint-plugin-erb to provide
linting of .js.erb files (#3)
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/87530daa135e258662dbbeea21d3bdb9e380cc75..1cec0586494e6c3f7c19596fa5e6e81
When parsing isn't required, I removed the calls, otherwise, I tried to
bundle them so they get less in the way of things.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5598
-- Commit Summary --
* Remove parseFloa
Over the years this script has grown an increasing amount of technical debt. I
tried to remove some.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5597
-- Commit Summary --
* Add early return
* Condense key pass
@hlfan approved this pull request.
Thanks for catching that!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5595#pullrequestreview-2590173409
You are receiving this because you are subscribed to this thread.
Message ID:
_
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#pullrequestreview-2590405179
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 6 commits.
ae5df1f71982e573cb4fda68f7e4c43ea6bb5ede Add early return
4830a42684d2f33aa76a244d42e2fdf9445f35c3 Condense key passthrough
8485d2aae7e0e940888ad71de7ddc0b751c45cef Remove mapParams redefinition
1cb0ebb96781da634dd37bcb1d49a893c4f600ed Merge gpx parameter passthrough
3
@hlfan pushed 1 commit.
be17c48b089849f2efbbd68f6f7578bba3728873 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/98f7005f37f1c92873fab1f081f10799e4b61e5a..be17c48b089849f2efbbd68f6f7578bba3728873
You are receiving this be
@hlfan pushed 1 commit.
dd9c62401c920a49f670337302e4fc03afbb8320 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/be17c48b089849f2efbbd68f6f7578bba3728873..dd9c62401c920a49f670337302e4fc03afbb8320
You are receiving this be
@hlfan pushed 1 commit.
7b421fa18b94df1d26fb6787d161126f3e34398f Add eslint-plugin-erb for .js.erb
file linting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/266988ed2b118932f0bba6c8b3fd880eaa2b9821..7b421fa18b94df1d26fb6787d161126f3e34398f
You ar
@hlfan pushed 1 commit.
242951579e20b8626cef12f644c1967f0f955048 Simplify initialisation of iD
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5597/files/d125835e82be1db5be1183f36da35cc4e3f4b781..242951579e20b8626cef12f644c1967f0f955048
You are receiving this b
@hlfan pushed 1 commit.
550e5d336f87d5b3c2eb3c4d9458b5162c1b7ed0 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/88257c2fc5d3b973a4563f4c849454c0feaadcf0..550e5d336f87d5b3c2eb3c4d9458b5162c1b7ed0
You are receiving this be
@hlfan commented on this pull request.
> +layers
+ .filter(other => other !== layer)
+ .forEach(map.removeLayer);
Always in the places where you least expect it...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
@hlfan commented on this pull request.
> + MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>,
+ SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>,
+ SERVER_URL: <%= Settings.server_url.to_json %>,
+ API_VERSION: <%= Settings.api_version.to_json %>,
+ STATUS: <%= Settings.sta
Converts more loops to for..of loops due to increased readability and change
.forEach() in combination with .push() to .map().
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5604
-- Commit Summary --
* Reevaluate i
@hlfan pushed 1 commit.
88257c2fc5d3b973a4563f4c849454c0feaadcf0 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/dd9c62401c920a49f670337302e4fc03afbb8320..88257c2fc5d3b973a4563f4c849454c0feaadcf0
You are receiving this be
@hlfan pushed 1 commit.
266988ed2b118932f0bba6c8b3fd880eaa2b9821 Move JS settings passthrough to Ruby
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/a8f1c586bd2e552aa48165779628dfae350aa5c8..266988ed2b118932f0bba6c8b3fd880eaa2b9821
You are receiving
Now that's an edge case too sophisticated for the plugin as it is
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#issuecomment-2634593257
You are receiving this because you are subscribed to this thread.
Message ID:
@hlfan commented on this pull request.
>
-if (!o || !d) return;
+if (!points[0] || !points[1]) return;
Which option would you prefer?
```js
if (!points[0] || !points[1]) return;
if (!(points[0] && points[1])) return;
if (!points.every(p => p)) return;
if (points.some(p => !p)) return;
Like #5571 but without fixup commits.
Closes #5550 and closes #5571
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5580
-- Commit Summary --
* Refactor embed.js.erb with layers.yml
-- File Changes --
M app/ass
The amount of `latlng.lat/lng.toFixed(precision)` calls has been bugging me.
I've put a function next to OSM.zoomPrecision that outputs a latlng array
that can be destructured, spread and `join`ed.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/
@hlfan requested changes on this pull request.
> @@ -42,7 +42,7 @@
code: "T"
layerId: "transportmap"
nameId: "transport_map"
- apiKeyId: "THUNDERFOREST_KEY"
+ apiKeyId: "thunderforest_key"
Now that this is used in embed.js.erb as well, that file would need to be
accommodated too.
-
Closes #5599 (literally)
### How has this been tested?
Adding a conditional breakpoint in the site.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5603
-- Commit Summary --
* Close directions popup with sidebar
--
@hlfan pushed 1 commit.
bc18e85d5c9ded603937b0a2dc92d08973f81a80 Add eslint-plugin-erb for .js.erb
file linting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/7b421fa18b94df1d26fb6787d161126f3e34398f..bc18e85d5c9ded603937b0a2dc92d08973f81a80
You ar
@hlfan commented on this pull request.
You don't need to touch every single line if you write the globals as
```js
const DemoEngine = function (id, costing) {
...
};
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#pul
@hlfan pushed 1 commit.
3528239e2c938965303ab75262f9e45d0de5236c Refactor direction engines and unify
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621/files/a56c74c1cd5a4cafe3e61c3f7f68a7292f9ab889..3528239e2c938965303ab75262f9e45d0de5236c
You ar
Splitting parameter population and assignment, enabling a singular later
default zoom value definition.
A new take on what was dropped in #5597.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5632
-- Commit Summary --
Simplifying if-else structures and condensing repeated expressions.
At least the things I found with my regex search.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5633
-- Commit Summary --
* Reduce condition compl
Another few steps in embracing URLSearchParams.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5634
-- Commit Summary --
* Further usage of URLSearchParams
* Build search params only after update
-- File Changes
Found some that improve legibility.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5643
-- Commit Summary --
* Enable sort-keys for eslint.js
* Enable more linting rules
-- File Changes --
M app/assets/javas
@hlfan pushed 1 commit.
9b96a79651c8f0ba26093549e1c2652be6c0f5b1 Enable more linting rules
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5643/files/f391fac3feecceb447c1695002055705bcc521c5..9b96a79651c8f0ba26093549e1c2652be6c0f5b1
You are receiving this becau
@hlfan commented on this pull request.
> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
-};
-return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: function ({ tri
@hlfan pushed 1 commit.
14f5e6345dc4ea14af774d33b41a039483aa8877 Return empty after callback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642/files/b4f0af369d005b15525b775d750cf83838077ffe..14f5e6345dc4ea14af774d33b41a039483aa8877
You are receiving this bec
@hlfan pushed 1 commit.
2602d1888b7c3dfaba91804b133a4b3b6d28543f Enable more linting rules
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5643/files/9b96a79651c8f0ba26093549e1c2652be6c0f5b1..2602d1888b7c3dfaba91804b133a4b3b6d28543f
You are receiving this becau
Start to move from $.ajax to fetch with the thing I recently restructured.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5642
-- Commit Summary --
* Get directions using fetch
-- File Changes --
M app/assets/
@hlfan pushed 1 commit.
cdacfafd11bd5265cc8d8b69468bca36010434ee Further usage of URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/080062d7ce75309abbe6542ec948068a727d7d64..cdacfafd11bd5265cc8d8b69468bca36010434ee
You are receiving thi
@hlfan commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat=" + latlng
@hlfan pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/7f3a036483f626684c5cb1d286f8050d0335dd91..2606a0a83134c954570a2c13c3de133ced69f772
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
080062d7ce75309abbe6542ec948068a727d7d64 Further usage of URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/2606a0a83134c954570a2c13c3de133ced69f772..080062d7ce75309abbe6542ec948068a727d7d64
You are receiving thi
@hlfan commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat=" + latlng
Dropping
https://github.com/hlfan/openstreetmap-website/commit/7f3a036483f626684c5cb1d286f8050d0335dd91
as tests didn't like it
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634#issuecomment-2646073042
You are receiving this b
@hlfan pushed 3 commits.
572029358a82e5e7925b92f21413376324a4fdb5 Reduce condition complexity
559ac7a9c7be9e8a86aa702baa6d7445c8e775f5 Lessen code repetition
a3089c574efd1543cf0942e14791940ec5b8c1f0 Remove IE<10 workaround
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
@hlfan pushed 1 commit.
55d16a42172be67ee33e95bb85343b18b45754dd Skip jQuery
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5633/files/a3089c574efd1543cf0942e14791940ec5b8c1f0..55d16a42172be67ee33e95bb85343b18b45754dd
You are receiving this because you are sub
@hlfan pushed 1 commit.
f1b0cbb0231d20388f197e447565fc89b32f2b70 Set map param with array
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632/files/8d93c73bf2cef030852b08d0cf9d5c493036974f..f1b0cbb0231d20388f197e447565fc89b32f2b70
You are receiving this becaus
@hlfan pushed 1 commit.
f359a73d5b64e046ab7f783aa37b685ebc65c052 Set map param with array
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632/files/f1b0cbb0231d20388f197e447565fc89b32f2b70..f359a73d5b64e046ab7f783aa37b685ebc65c052
You are receiving this becaus
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4511#pullrequestreview-2605547213
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
> +.get(0)
+.scrollIntoView({ block: "nearest" });
Removed the `newline-per-chained-call` rule.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5643#discussion_r194
Actually needs to be abortable...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#issuecomment-2648767172
You are receiving this because you are subscribed to this thread.
Message ID:
@hlfan pushed 1 commit.
63362cce7bac4e4e60f1c2c3ee888d311d029c3d Add less linting rules
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5643/files/2602d1888b7c3dfaba91804b133a4b3b6d28543f..63362cce7bac4e4e60f1c2c3ee888d311d029c3d
You are receiving this because
> * [ ] Export track to GPX
> * [ ] Export track to KML
Reformatting the data is the main hurdle here.
A simpler solution would be exporting to GeoJSON, since this can mostly be done
using L.FeatureGroup for routes.
--
Reply to this email directly or view it on GitHub:
https://github.com/open
@hlfan commented on this pull request.
> "eslint": "^9.0.0",
+"eslint-plugin-erb": "^2.1.0",
"@stylistic/eslint-plugin-js": "^3.0.0",
"eslint-formatter-compact": "^8.40.0"
How should we sort the plugins? (also @HolgerJeromin)
If we go semantically alphabetic,
* eslint,
* esl
1 - 100 of 1103 matches
Mail list logo
