[openstreetmap/openstreetmap-website] Update to iD v2.30.4 (PR #5250)

updates the editor layer index again, this time addressing https://github.com/openstreetmap/iD/issues/10486 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5250 -- Commit Summary -- * Update to iD v2.30.4 -- File C

[openstreetmap/openstreetmap-website] Update to iD v2.30.3 (PR #5248)

updates the editor layer index, adressing https://github.com/openstreetmap/iD/issues/10483 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5248 -- Commit Summary -- * Update to iD v2.30.3 -- File Changes -- M

[openstreetmap/openstreetmap-website] Update to iD v2.31.1 (PR #5623)

Small bugfix release, fixing flickering when switching background layers or zooming (https://github.com/openstreetmap/iD/issues/10738). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5623 -- Commit Summary -- * Upd

Re: [openstreetmap/openstreetmap-website] Automatic deselecting "Map Notes" when changing to/from Edit Mode is annoying (#1212)

> after clicking "edit", iD editor opens without notes visible FYI: With v2.31 (#5610), iD will load the notes layer if it was previously enabled on the osm.org map (also when no individual note is selected). Disabling the notes layer in the editor will however not disable it for the osm map.

[openstreetmap/openstreetmap-website] Update to iD v2.31.0 (PR #5610)

## changes to the osm-website code: This version of iD introduces a new hash parameter to enable to _notes_ layer on startup. For a seamless integration into the website, I have added a check if the notes layer is currently active, and pass it forward to the iD iframe. The implementation is cur

Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)

@tyrasd pushed 1 commit. 0b5fa06a39e1cd793e2c77116201c521aa02ec38 lint -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/051ae5953f18e2bcc4a4612e9851c95c0f86842e..0b5fa06a39e1cd793e2c77116201c521aa02ec38 You are receiving this because you are subscribe

[openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)

The current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761 : https://github.com/openstreetmap/iD/pull/10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back

Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)

@tyrasd pushed 1 commit. c025613ff6038439d3b5591aebee915f75999575 replace all occurrences of `+` -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5661/files/0b5fa06a39e1cd793e2c77116201c521aa02ec38..c025613ff6038439d3b5591aebee915f75999575 You are receiving this

Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)

> Also, wouldn't it be better to create an iD 2.31.2 patch for this It would be possible to create a patch release for this but I would prefer to only include this change in the next minor release version, as strictly speaking this does change the [API](https://github.com/openstreetmap/iD/blob/

Re: [openstreetmap/openstreetmap-website] Workaround for iD "bug" #10761 (PR #5661)

@tyrasd commented on this pull request. > @@ -33,5 +33,5 @@ $(document).ready(function () { if (id.data("gpx")) params.set("gpx", id.data("gpx")); - id.attr("src", id.data("url") + "#" + params); + id.attr("src", id.data("url") + "#" + params.toString().replace("+", "%20")); I've fixed

[openstreetmap/openstreetmap-website] iD: listen to URL hash changes (PR #5394)

When the `map` hash parameter is changed (and was not not triggered by map interaction from inside iD itself): pan to the new location. This mirrors the behaviour when manually editing the `map` hash parameter on osm.org outside of iD. This also fixes https://github.com/openstreetmap/iD/issues/

Re: [openstreetmap/openstreetmap-website] iD: listen to URL hash changes (PR #5394)

> using openstreetmap.org/id directly is not really supported :+1: agree -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5394#issuecomment-2539710967 You are receiving this because you are subscribed to this thread. Message ID:

[openstreetmap/openstreetmap-website] fix map panning to objects when url hash is not empty but has no map location (PR #5679)

Fix for #865. Unfortunately, the code is slightly different between OSM objects (nodes/ways/relations), notes and changesets. I tried to make it somewhat more coherent by always using the `map.addObject({}, callback)` approach to zoom to the location if the `hash` parameters had no location info

[openstreetmap/openstreetmap-website] don't re-pan the map when selecting another note that is already on screen (PR #5686)

Fixes #5683 (a regression in #5679): the problem was that when clicking on a new note on the map, the URL hash with the `map` parameter is cleared somewhere before `pushstate` gets called, resulting in the map to be panned in `map.addObject` during the `initialize` step. It's now solved by pass

Re: [openstreetmap/openstreetmap-website] don't re-pan the map when selecting another note that is already on screen (PR #5686)

@tyrasd pushed 1 commit. 793757a6ff4a6ca3cb7ad5454fec1c51fe63804f don't pan map wen closing/reopening/commenting a note, fixes #648 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5686/files/3a016a5f164ea40ebdc29cc6d3fdf799700172c2..793757a6ff4a6ca3cb7ad5454fe

Re: [openstreetmap/openstreetmap-website] Selecting a note centres the map on it and zooms (Issue #5683)

tyrasd left a comment (openstreetmap/openstreetmap-website#5683) sorry, this was an unintended side effect of #5679. working on a fix now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661343897 You are rece

Re: [openstreetmap/openstreetmap-website] Add reload on iframe redirect (PR #5823)

@tyrasd commented on this pull request. > @@ -36,4 +36,10 @@ $(function () { if (idData.gpx) params.set("gpx", idData.gpx); id.attr("src", idData.url + "#" + params); + + id.ready(function () { +if (!this.contentWindow.location.href.startsWith(idData.url)) { I get a `Uncaught TypeE

[openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)

release notes are available at https://github.com/openstreetmap/iD/releases/tag/v2.33.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5912 -- Commit Summary -- * Update to iD v2.33.0 -- File Changes -- A .Ve

Re: [openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)

@tyrasd pushed 1 commit. c48123ba70167817fd755622fd996ae7843ce5f5 Update to iD v2.33.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/7a9d2af0e09ea4eb2ac9a26b72ba7c6557b3a657..c48123ba70167817fd755622fd996ae7843ce5f5 You are receiving this because y

Re: [openstreetmap/openstreetmap-website] Update to iD v2.33.0 (PR #5912)

@tyrasd pushed 1 commit. d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 Update to iD v2.33.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5912/files/c48123ba70167817fd755622fd996ae7843ce5f5..d10ead2f2fcf26c0d9f36c1d312db761c5ef3cd1 You are receiving this because y

Re: [openstreetmap/openstreetmap-website] Add reload on iframe redirect (adb034d)

I get a `Uncaught TypeError: this.contentWindow is undefined` error every time I regularly start an iD editing session. Is that expected? Would it not be better to skip the check if everything is loaded correctly, maybe like this: ```js if (this.contentWindow && !this.contentWindow.location.hre

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

tyrasd left a comment (openstreetmap/openstreetmap-website#5700) Yeah, this seems good to me. Thanks @hlfan -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5700#issuecomment-2665645883 You are receiving this because you are subsc

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

tyrasd left a comment (openstreetmap/openstreetmap-website#5698) closing in favour of #5700 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2665640851 You are receiving this because you are subscribed to this thr

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

Closed #5698. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#event-16347893361 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)

tyrasd left a comment (openstreetmap/openstreetmap-website#5632) > fix to uninitialized variables yeah, but the previous version of the code used the _uninitialized_ state explicitly to encode the case for when the `#map` parameter should explicitly be absent in the url of the iD iframe. :wink:

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

@tyrasd pushed 1 commit. e56340b3ea6024738d03af3c1647019584a09bc3 drop superfluous semicolon -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698/files/1599c360b0517ac0f6d15d514e0afc7509983c66..e56340b3ea6024738d03af3c1647019584a09bc3 You are receiving this bec

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

tyrasd left a comment (openstreetmap/openstreetmap-website#5698) ehrm… Given that: * `mapParams.center/.zoom` get the location via different means (either via the URL's hash, `mlat/mlon` query parameters or the previously last visited location that's stored in a cookie) * iD will not auto-cent

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

tyrasd left a comment (openstreetmap/openstreetmap-website#5698) > idData already has the coordinates This one is also a bit confusing. Normally, `idData.lat/.lon` are not present. If I see this correctly, `idData.lat/.lon` are only set when the editor is loaded using a `…?note=xxx` link, see 6

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

tyrasd left a comment (openstreetmap/openstreetmap-website#5698) > The map parameter would always be set. not in the iframe's `src` parameter before 5310c5b :shrug:  > Why would you not want to use the coor

[openstreetmap/openstreetmap-website] Update to iD v2.32.0 (PR #5750)

Release notes: https://github.com/openstreetmap/iD/releases/tag/v2.32.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5750 -- Commit Summary -- * Update to iD v2.32.0 -- File Changes -- M vendor/assets/iD/iD.

[openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

fixes https://github.com/openstreetmap/iD/issues/10779 (a regression introduced in #5632) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5698 -- Commit Summary -- * don't set map coords if mapParams contains object

Re: [openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)

tyrasd left a comment (openstreetmap/openstreetmap-website#5632) FYI, this added a small bug, see https://github.com/openstreetmap/iD/issues/10779 / #5698 I really appreciate the cleanup efforts of the iD integration code. :+1: Nevertheless, it would have been nice to tag me in this (and the o

Re: [openstreetmap/openstreetmap-website] Update to iD v2.34.0 (PR #6008)

@tyrasd pushed 1 commit. 82c33d461469fd1fe129edba135414b9e11edffc Update to iD v2.34.0 -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6008/files/5e3d6ef224c76e17b736555903ec23c906da6c24..82c33d461469fd1fe129edba135414b9e11edffc You are receiving this because y

[openstreetmap/openstreetmap-website] Update to iD v2.34.0 (PR #6008)

Upstream changelog: https://github.com/openstreetmap/iD/releases/tag/v2.34.0 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6008 -- Commit Summary -- * Update to iD v2.34.0 -- File Changes -- A package-lock.js

[openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

Focus iD's iframe element to allow iD to receive keyboard shortcuts directly after loading. This is useful when people want to start adding new elements right away using the shortcuts (`1`, `2`, `3`), to pan/zoom the map using the arrow keys, to open the help dialog `?`, to directly perform ope

[openstreetmap/openstreetmap-website] Add banner for State of the Map 2025 (PR #6133)

Also removes the expired banners for sotm 2024, sotm-EU 2024 and the fundraiser in 2023. Looks like this on the website (dark/light mode): [openstreetmap/openstreetmap-website] Update to iD v2.34.1 (PR #6085)

2025-06-03 Thread Martin Raifer via rails-dev

Contains a singular bugfix for a major bug in iD: https://github.com/openstreetmap/iD/issues/11076 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6085 -- Commit Summary -- * Update to iD v2.34.1 -- File Changes --

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-03 Thread Martin Raifer via rails-dev

tyrasd left a comment (openstreetmap/openstreetmap-website#6083) > Does this run the fix of causing keyboards to popup on mobile devices? I tested it now, and it does not cause the keyboard from opening on a mobile browser. Is there a known bug where this is the case? :thinking: -- Reply to

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-03 Thread Martin Raifer via rails-dev

@tyrasd commented on this pull request. > @@ -37,7 +37,8 @@ $(function () { id.attr("src", idData.url + "#" + params); id.ready(function () { -if (!this.contentWindow.location.href.startsWith(idData.url)) { +id.focus(); +if (this.contentWindow && !this.contentWindow.location

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-03 Thread Martin Raifer via rails-dev

tyrasd left a comment (openstreetmap/openstreetmap-website#6083) > Have you tried adding > [`autofocus`](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/autofocus) > to the ``? I haven't, but given that the attribute is still marked as (kind of) _newly available_,

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-04 Thread Martin Raifer via rails-dev

tyrasd left a comment (openstreetmap/openstreetmap-website#6083) Ok, I changed it to use the `autofocus` attribute now. The most relevant browser with only "recent" implementation of the attribute is Firefox with its full implementation in early 2023. I guess that's acceptable. -- Reply to thi

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-04 Thread Martin Raifer via rails-dev

@tyrasd pushed 1 commit. c63df1d6b0b4358c06538f79640ed6e7595fe471 use autofocus attribute -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083/files/82c5034b0977fec2cf36b24eeb0a75aa30e4a905..c63df1d6b0b4358c06538f79640ed6e7595fe471 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-04 Thread Martin Raifer via rails-dev

@tyrasd commented on this pull request. > @@ -7,5 +7,5 @@ data[:zoom] = @zoom if @zoom data[:gpx] = trace_data_url(params[:gpx], :format => :xml) if params[:gpx] data[:url] = id_url(:locale => params[:locale]) %> - <%= tag.iframe "", :frameBorder => 0, :id => "id-embed", :clas

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-04 Thread Martin Raifer via rails-dev

@tyrasd pushed 1 commit. 145ee61e56b426f66f40acd5bea92db73f20c910 use autofocus attribute -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083/files/d50614f6a9c5354a857048be0bff43ef30a5a44b..145ee61e56b426f66f40acd5bea92db73f20c910 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Martin Raifer via rails-dev

@tyrasd pushed 1 commit. ac07dbfd69b5831d9f5ad2502ac1086aa1d3c6d2 make sure iD's iframe is focused on startup -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083/files/145ee61e56b426f66f40acd5bea92db73f20c910..ac07dbfd69b5831d9f5ad2502ac1086aa1d3c6d2 You are

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Martin Raifer via rails-dev

@tyrasd commented on this pull request. > @@ -7,5 +7,5 @@ data[:zoom] = @zoom if @zoom data[:gpx] = trace_data_url(params[:gpx], :format => :xml) if params[:gpx] data[:url] = id_url(:locale => params[:locale]) %> - <%= tag.iframe "", :frameBorder => 0, :id => "id-embed", :clas

[openstreetmap/openstreetmap-website] Update to iD v2.35.1 (PR #6194)

2025-07-14 Thread Martin Raifer via rails-dev

(replaces #6193) changelog: * [`v2.35.0`](https://github.com/openstreetmap/iD/releases/tag/v2.35.0) * [`v2.35.1`](https://github.com/openstreetmap/iD/releases/tag/v2.35.1) (bugfix for line label bug https://github.com/openstreetmap/iD/issues/11123) You can view, comment on, or merge this pull req

[openstreetmap/openstreetmap-website] Update to iD v2.35.0 (PR #6193)

2025-07-14 Thread Martin Raifer via rails-dev

For changelog see [release notes](https://github.com/openstreetmap/iD/releases/tag/v2.35.0) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6193 -- Commit Summary -- * Update to iD v2.35.0 -- File Changes -- M

Re: [openstreetmap/openstreetmap-website] Update to iD v2.35.0 (PR #6193)

2025-07-14 Thread Martin Raifer via rails-dev

Closed #6193. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6193#event-18612271044 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add user preferences support to iD editor via server-side rendering (PR #6199)

2025-07-15 Thread Martin Raifer via rails-dev

@tyrasd commented on this pull request. > +window.OSM = window.OSM || {}; +window.OSM.userPreferences = userPreferences; This could probably better handled in method of the `idContext` object, instead of as a new global variable. -- Reply to this email directly or view it on GitHub:

Re: [openstreetmap/openstreetmap-website] Add user preferences support to iD editor via server-side rendering (PR #6199)

2025-07-15 Thread Martin Raifer via rails-dev

@tyrasd commented on this pull request. > @@ -15,7 +15,15 @@ data[:token] = token.token end data[:locale] = ID::LOCALES.preferred(preferred_languages).to_s - data[:asset_map] = assets("iD").to_json %> + data[:asset_map] = assets("iD").to_json + + # Include user preferences for

Re: [openstreetmap/openstreetmap-website] Add user preferences support to iD editor via server-side rendering (PR #6199)

2025-07-15 Thread Martin Raifer via rails-dev

tyrasd left a comment (openstreetmap/openstreetmap-website#6199) > enables the iD editor to access user-specific preferences Just for clarity: this is not quite yet implemented in the current version of iD, but @Deeptanshu-sankhwar is working on it right now. This means that the code will only

[openstreetmap/openstreetmap-website] Update to iD v2.35.2 (PR #6203)

2025-07-18 Thread Martin Raifer via rails-dev

Bugfix release ([changelog](https://github.com/openstreetmap/iD/releases/tag/v2.35.2)). Fixes https://github.com/openstreetmap/iD/issues/11213, https://github.com/openstreetmap/iD/issues/11217 and https://github.com/openstreetmap/iD/issues/11220 You can view, comment on, or merge this pull requ

[openstreetmap/openstreetmap-website] Update to iD v2.35.3 (PR #6209)

2025-07-19 Thread Martin Raifer via rails-dev

Includes a backported fix for issue https://github.com/openstreetmap/iD/issues/11225. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6209 -- Commit Summary -- * Update to iD v2.35.3 -- File Changes -- M vendo