Closed #4361.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4361#event-14727982128
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5273#pullrequestreview-2380462466
You are receiving this because you are subscribed to this thread.
Message ID:
__
Not all projects work with assignments. Especially to new contributors. This
can result in [cookie licking](https://www.redhat.com/en/blog/dont-lick-cookie).
Go ahead, get familiar to the code base and work on this if you like.
If you solve this. Hurray!
--
Reply to this email directly or view
I get a redirect from
https://azimutt.app/create?sql=https://raw.githubusercontent.com/openstreetmap/openstreetmap-website/refs/heads/master/db/structure.sql&name=OpenStreetMap
to
https://azimutt.app/----/----
which is not helpful..
How does this help mappers?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5343#issuecomment-2485696176
You are receiving this because you are subscribed to this thread.
Message ID:
The [osm element highlight
color](https://www.openstreetmap.org/way/24240315#map=18/52.516070/13.379459)
is quite saturated. This depends on the monitor setting and for sure the color
of the rendered map.
I
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5365#pullrequestreview-2472234124
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5364#pullrequestreview-2472233213
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5366#pullrequestreview-2472240325
You are receiving this because you are subscribed to this thread.
Message ID:
__
This would result in having the projects name "never" visible for small
screens... not sure this is good
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5370#issuecomment-2513791593
You are receiving this because you are subscribe
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5371#pullrequestreview-2474831612
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5376#pullrequestreview-2478052628
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
0d6ac49a4880903c709091f0242bab0744b49a36 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/ebd82fc2c69f15eb258398dc43cdc45a90ed2a7f..0d6ac49a4880903c709091f0242bab0744b49
@HolgerJeromin commented on this pull request.
> @@ -68,9 +95,6 @@ module.exports = [
"no-lone-blocks": "error",
"no-lonely-if": "error",
"no-loop-func": "error",
- "no-mixed-operators": "error",
- "no-multiple-empty-lines": "error",
Good catch!
I readded it again
@HolgerJeromin pushed 1 commit.
ebd82fc2c69f15eb258398dc43cdc45a90ed2a7f Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/267183501e1bc9df671b3452d363389d19ccf5a1..ebd82fc2c69f15eb258398dc43cdc45a90ed2
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5595#pullrequestreview-2589632118
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> -
-if (mapParams.object) {
- params.set("id", mapParams.object.type + "/" + mapParams.object.id);
- mapParams = OSM.parseHash(location.hash);
- if (mapParams.center) {
-params.set("map", mapParams.zoom + "/" + mapParams.
@HolgerJeromin commented on this pull request.
> @@ -10,6 +10,7 @@
},
"devDependencies": {
"eslint": "^9.0.0",
+"@stylistic/eslint-plugin": "^3.0.0",
I have no idea how my old experiments with that did not worked. But now it does
without ts dependency.
--
Reply to this email
@HolgerJeromin pushed 1 commit.
2aefd97281ac74c78a8dec469d45a22cb8288c93 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/0d6ac49a4880903c709091f0242bab0744b49a36..2aefd97281ac74c78a8dec469d45a22cb8288
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5606#pullrequestreview-2594894008
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
>
-if (!o || !d) return;
+if (!points[0] || !points[1]) return;
I find the current PR version the easiest to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581#di
Can we have a decision here?
Or should I just go with `.vscode/settings.json` because most are using vscode
derivates and Tom (using another editor) is in favor of this, too?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#
Replace deprected eslint rules
no-new-object => no-object-constructor
https://eslint.org/docs/latest/rules/no-new-object
no-process-env => will be catched by no-undef
closes #5554
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-we
### Description
Add vscode style settings file which defines the location of eslint config file.
### How has this been tested?
Load folder in editor and break eslint rule => direct visual feedback
fixes #5572
You can view, comment on, or merge this pull request online at:
https://github.com/o
### Description
I also changed the eslint rule to an error in a separate commit.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5613
-- Commit Summary --
* Fix all no-implicit-globals eslint errors
* Change eslin
@HolgerJeromin pushed 2 commits.
c855d86bf8ca9e1c240e6f0fa803deb3f69e5e6c Mark valid usecases for alert
eee793f5e6e534442793c88f06caca2ccb5c12d1 change eslint rule no-alert to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614/files/b189286288238fe5615
@Satya900 We do [not work with
assigns](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues).
Just go ahead! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604#pullrequestreview-2594914388
You are receiving this because you are subscribed to this thread.
Message ID:
__
Mark valid usecases for alert
I think with marking this valid use cases it is ok to change eslint rule to
error.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5614
-- Commit Summary --
* Mark valid usecases for a
@HolgerJeromin pushed 2 commits.
a4e6934d599e92d755ab1ff949ed468eea1a9bf0 Fix all no-implicit-globals eslint
errors
49b65a09dd83764ee7c0bb2ab5661775cceeefab Change eslint no-implicit-globals
rule to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613/
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5631#pullrequestreview-2603997470
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -99,22 +99,18 @@
language: I18n.currentLocale()
}
})
-};
-return $.ajax({
- url: OSM.FOSSGIS_VALHALLA_URL,
- data,
- dataType: "json",
- success: functio
This pushes json parsing off the js main thread. Hurray
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#issuecomment-2647180475
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2604970286
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632#pullrequestreview-2604130700
You are receiving this because you are subscribed to this thread.
Message ID:
__
This needs rebasing and some adjustment after merge of my #5613
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621#issuecomment-2640783441
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
e838e9528c35de02c88e7089d4294a912997d5fa Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/2aefd97281ac74c78a8dec469d45a22cb8288c93..e838e9528c35de02c88e7089d4294a912997d
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
Oh, yes. Will fix the pr tomorrow
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#issuecomment-2637828616
You are receiving this because you are subscribed to this thread.
Message ID:
> You don't need to touch every single line via indenting if you write the
> globals as
> const DemoEngine = function (...) { ... };
Then we would have `DemoEngine` poluting the global scope...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
We do [not work with
assigns](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#assigning-issues).
Just go ahead! :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5540#issuecomment-2642729245
On a [website from me](https://www.gwc-gt.de/Turnierergebnisse.php) I added
this HTML property to all user added images (inline images in a blog like page).
Invisible images (down a few pages) are not loaded till the user scrolls down.
The browser is smart enough to fetch them early enough, so ev
> I still don't know what I need to change in the testing stub
I would guess:
```ruby
def stub_straight_routing(start_instruction: "Start here",
finish_instruction: "Finish there")
stub_routing <<~CALLBACK
const distance = points[0].distanceTo(points[1]);
const time = distance
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
Yeah, activate for this file in config and disable in most other parts is a bit
cumbersome:
```
/* eslint-disable sort-keys */
... start of th
### Description
A file comment combined with a config section is a bit confusing.
ref #5651
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5653
-- Commit Summary --
* eslint: Move file config to eslint section
--
@HolgerJeromin commented on this pull request.
> @@ -212,6 +202,13 @@ OSM.Directions = function (map) {
map.setSidebarOverlaid(true);
// TODO: collapse width of sidebar back to previous
});
+}).catch(function () {
+ map.removeLayer(polyline);
+ if (reportEr
@HolgerJeromin commented on this pull request.
> -routeRequest = chosenEngine.getRoute(points, function (err, route) {
- routeRequest = null;
-
- if (err) {
-map.removeLayer(polyline);
-
-if (reportErrors) {
- $("#sidebar_content").html("" +
I18n.t("javasc
@HolgerJeromin commented on this pull request.
> @@ -3,7 +3,8 @@
//= require_tree ./directions
OSM.Directions = function (map) {
- var routeRequest = null; // jqXHR object of an ongoing route request or null
+ let awaitingRoute = false; // true if a route request is in progress
Do we real
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
If you are willing to sort everything (not sure if this is good to read) this
should be done here:
```
rules: {eslint sort-keys: ["error"]}
-
@HolgerJeromin commented on this pull request.
> @@ -9,6 +13,35 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+
maplibregl.setRTLTextPlugin("https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
true);
I am pretty sure t
@HolgerJeromin commented on this pull request.
>globals: {
...globals.commonjs
- }
+ },
+ sourceType: "commonjs"
}
Ah, I see. We can [ignore some rules in some
lines](https://eslint.org/docs/latest/use/configure/rules#disabling-rules) with
eslint. But not
@HolgerJeromin commented on this pull request.
>engines:
-fossgis_osrm_bike: "Bicycle (OSRM)"
-fossgis_osrm_car: "Car (OSRM)"
-fossgis_osrm_foot: "Foot (OSRM)"
-graphhopper_bicycle: "Bicycle (GraphHopper)"
-graphhopper_car: "Car (GraphHopper)"
-
@HolgerJeromin commented on this pull request.
> @@ -45,34 +44,34 @@
*/
window.updateLinks = function (loc, zoom, layers, object) {
$(".geolink").each(function (index, link) {
-var href = link.href.split(/[?#]/)[0],
-args = Qs.parse(link.search.substring(1)),
-editlink
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2588542628
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -45,34 +44,34 @@
*/
window.updateLinks = function (loc, zoom, layers, object) {
$(".geolink").each(function (index, link) {
-var href = link.href.split(/[?#]/)[0],
-args = Qs.parse(link.search.substring(1)),
-editlink
I removed the eslint config part of the PR.
So we can merge this PR and discuss the needed place to reference eslint config
in the referenced item.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2624265562
You
> Does anyone know how long this maintenance work will last?
https://community.openstreetmap.org/t/openstreetmap-org-currently-offline-operations-team-are-working-to-restore-15-december-2024/122930
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
It is an known issue that not-logged-in users have no settings to change that.
So this is a duplicate to one of the open issues
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5407#issuecomment-2547576757
You are receiving this b
@HolgerJeromin commented on this pull request.
> + [CalendarLabel, {
+position: "left",
+key: "left",
+text: () => weekdays,
+textAlign: "end",
+width: 30,
+padding: [23, 10, 0, 0]
+ }],
+ [Tooltip, {
+text: (date, value) =>
@HolgerJeromin commented on this pull request.
> + const heatmapElement = document.querySelector("#cal-heatmap");
+
+ if (!heatmapElement) {
+console.warn("Heatmap element not found in the DOM.");
+return;
+ }
+
+
+ const heatmapData = heatmapElement.dataset.heatmap ?
JSON.parse(hea
Oh, I forgot about this.
But the user can now set his "Preferred Website Color Scheme" which should be
the basis of the theme not the browser setting.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2548889858
Y
> Maybe we should just remove the references to database maintenance in favour
> of this solution with a URL to an explanatory notice?
Perhaps this is generic enough:
```
The OpenStreetMap database is currently in read-only mode while essential
maintenance work is carried out.
--
Reply to this
@HolgerJeromin commented on this pull request.
> @@ -411,34 +416,20 @@ L.OSM.share = function (options) {
$("#mapnik_image_width").text(mapWidth);
$("#mapnik_image_height").text(mapHeight);
- const layerId = map.getMapBaseLayerId();
- const layerKeys = new Map([
-
missing 2023 in firefox
https://caniuse.com/mdn-javascript_builtins_weakmap_symbol_as_keys
Is a quite esotheric feature. But really needed stuff was not added in 2023. So
fine with going with 2022.
> I'm assuming that there's going to a be a proportion of people using browsers
> that don't supp
Jquery uses `JSON.parse` for parsing of `ajax()` result.
In a next step switching to `fetch" would allow using
https://developer.mozilla.org/en-US/docs/Web/API/Response/json
Where the parsing is done without blocking the main thread.
--
Reply to this email directly or view it on GitHub:
https://
@HolgerJeromin commented on this pull request.
> +gutter: 4
+ },
+ date: {
+start: startDate
+ },
+ range: 13,
+ data: {
+source: heatmapData,
+type: "json",
+x: "date",
+y: "total_changes"
+ },
+ scale: {
+
@HolgerJeromin commented on this pull request.
> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
-var parts = pairs[i].split('=');
-
@HolgerJeromin commented on this pull request.
> @@ -37,17 +36,17 @@ window.onload = function () {
map.attributionControl.setPrefix('');
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclem
@HolgerJeromin commented on this pull request.
> @@ -15,10 +15,9 @@ window.onload = function () {
var query = (window.location.search || '?').slice(1),
args = {};
- var pairs = query.split('&');
- for (var i = 0; i < pairs.length; i++) {
-var parts = pairs[i].split('=');
-
> but I guess this OK as head must have loaded in order for the javascript to
> load.
Yes.
FYI:
`document.body` is not ready sync (if your `
Duplicate of #5109 and your #3383
Do you have dark mode active?
If yes, this is more visible because the dark background has a bigger contrast
than the light background.
The linked issues are still open:
https://github.com/Leaflet/Leaflet/issues/3575
https://github.com/Leaflet/Leaflet/issues/93
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5550#pullrequestreview-2573998167
You are receiving this because you are subscribed to this thread.
Message ID:
__
We should discuss if we want to keep the current eslint config.
Most stylistic rules are now removed from eslint because most use a formatter
like prettier.io
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#issuecomment-261
Duplicate of #4946
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5525#issuecomment-2602397513
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5556#pullrequestreview-2575527413
You are receiving this because you are subscribed to this thread.
Message ID:
__
As a first step I migrated the deprecated rules.
After that I want to check which rules are already included in
`js.configs.recommended`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5554#issuecomment-2614532166
You are receiv
@HolgerJeromin commented on this pull request.
> -new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
-new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
-new L.OSM.HOT().addTo(map);
- } else
Sorry, I am not an native speaker. I dod not want to remove the config, but
change its content.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5554#issuecomment-2614426343
You are receiving this because you are subscribed to th
@HolgerJeromin commented on this pull request.
> -new L.OSM.CycleMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "transportmap") {
-new L.OSM.TransportMap(thunderforestOptions).addTo(map);
- } else if (args.layer === "hot") {
-new L.OSM.HOT().addTo(map);
- } else
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2575002097
You are receiving this because you are subscribed to this thread.
Message ID:
__
### Description
I moved all deprecated eslint to the https://eslint.style/ plugin.
To have easy editor support I added a workspace file for visual studio code.
Right now this only has a link to eslint config file.
I can remove that commit if you do not want editor config files.
### How has this
> Maybe create a new issue for this topic.
> https://github.com/prettier/plugin-ruby could be starting point.
I am not sure if this only formats ruby code.
I am an JS/TS expert so I focus on (native and embedded) js code.
--
Reply to this email directly or view it on GitHub:
https://github.com
@HolgerJeromin commented on this pull request.
On package.json:
The eslint plugin should be added to devDependency?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#pullrequestreview-2576756889
You are receiving this becaus
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#pullrequestreview-2577410086
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin pushed 1 commit.
4126ef0716ad50e416f174685fe1483180fd3304 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/896729fcc2cbfa076d1d688bc42072fb304b11af..4126ef0716ad50e416f174685fe1483180fd3
> Shouldn't this update yarn.lock as well as package.json?
added.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2618757934
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5565#pullrequestreview-2577989574
You are receiving this because you are subscribed to this thread.
Message ID:
__
In #5557 I added a visual studio code workspace file in the `config` folder.
This file can contain settings but also other stuff.
We have different possibilities:
## move `config/eslint.js` to root folder `eslint.config.cjs`
pro: works with every editor (?) without config
con: pollutes root folde
I would like to do a poll which editors are used by the main developers.
😄: Visual Studio Code
🚀: Visual Studio
🎉: emacs
❤️: vim
🚀: jetbrains
😕: other
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976393
Y
@HolgerJeromin pushed 1 commit.
267183501e1bc9df671b3452d363389d19ccf5a1 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/4126ef0716ad50e416f174685fe1483180fd3304..267183501e1bc9df671b3452d363389d19ccf
We could discuss if we want to keep the current [eslint
config](https://github.com/openstreetmap/openstreetmap-website/blob/master/config/eslint.js).
Most stylistic rules are now removed from eslint because most use a formatter
like prettier.io
But the style rules are moved to [another repo](htt
Can you show us the js code with the syntax error?
Should be reachable via click on the syntaxError in the console
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/#issuecomment-2614232212
You are receiving this because you ar
@HolgerJeromin commented on this pull request.
> +function getThemeFromColorScheme(colorScheme) {
+ if (colorScheme === "auto") {
+return window.matchMedia("(prefers-color-scheme: dark)").matches ? "dark"
: "light";
+ }
+ return colorScheme; // Return "light" or "dark" directly if specif
@hlfan This deprecates `addListener` (old IE invention) not `addEventListener`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2589971885
You are receiving this because you are subscribed to this thread.
Message
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421#pullrequestreview-2526939816
You are receiving this because you are subscribed to this thread.
Message ID:
__
1 - 100 of 186 matches
Mail list logo
