@nertc commented on this pull request.
> +# created_at :datetime not null
+# updated_at :datetime not null
+#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ b
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
Editor of the social links was moved below the description, as, I think,
description has higher priority and should be displayed higher in the editor,
and also social links are positioned next to the description and,
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
+<%= t ".social_links.legend" %>
+
+ <%= f.fields_for :social_links do |social_link_form| %>
+
+ <%= social_link_form.text_field :url, :hide_label => true,
:wrapper_class => "col-sm-8" %>
+
Thanks for the review
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2653844962
You are receiving this because you are subscribed to this thread.
Message ID:
___
rail
@nertc commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
+
Currently skipping is done using `isSkipped` object reference, but you are
right, probably saving ids and then clearing them using `clearTimeout` will be
a better way to approach a problem. I'll update a PR accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
@nertc commented on this pull request.
> @@ -65,6 +65,32 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_
### Problem
There are issues and PRs opened about adding new features and designs to the
profile page. On the one hand, to maintain easier management over them and, on
the other hand, to see and discuss whole picture and long-run results this page
should achieve, it will be great if there is an
This PR addresses "Please make contact information fields, how to contact
the user, email address, telegrams, various social networks
https://www.openstreetmap.org"; issue mentioned in the
https://github.com/openstreetmap/openstreetmap-website/issues/2245
### Description
This PR adds:
- DB: Soc
@nertc pushed 1 commit.
a1b03f9f696183d5bee5d9355ceae48a806db130 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/55c89e6cc0cf41327059dff1ddf1b8116d4580e6..a1b03f9f696183d5bee5d9355ceae48a806db130
You are receiving this becaus
@nertc commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
+
@nertc commented on this pull request.
> + belongs_to :befriender, :class_name => "User", :foreign_key => :user_id,
> :inverse_of => :follows
+ belongs_to :befriendee, :class_name => "User", :foreign_key =>
:friend_user_id, :inverse_of => :follows
I tried to change as few things in DB as po
This issue was about modifying "friends" functionality and changing it to the
"follow". As tomhughes mentioned:
> ... the facebook model that requires agreement and the twitter model which
> doesn't.
...
We chose to go with the second model.
And as Fizzie41 mentioned:
>In that case, no, it's p
Sorting reporters by their last reports is a good idea. I'll do it and update
PR accordingly. I think, after this PR is merged then, if needed, we can
enhance "reporters" functionality by adding some filters to it. As `reports`
and `issues` are different tables, adding filters to `reports` may c
@nertc commented on this pull request.
> @@ -44,6 +44,11 @@ def index
end
@issues, @newer_issues_id, @older_issues_id = get_page_items(@issues,
:limit => @params[:limit])
+
+@unique_reporters = @issues.each_with_object({}) do |issue, reporters|
+ reporters[issue.id] = issue
@tomhughes After this PR was merged, on 21 Jan there was a case when there was
an old version of the subject and a new version of the body in the mail. After
I saw this screenshot, I tried to find out the reason, but mail subject and
body were changed in the same PR, I couldn't reproduce it neit
@nertc pushed 1 commit.
f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14 Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/eb7309ccc79dd1da457c70e69d182d7d75fad70d..f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14
You are receiving
@nertc commented on this pull request.
> @@ -44,6 +44,11 @@ def index
end
@issues, @newer_issues_id, @older_issues_id = get_page_items(@issues,
:limit => @params[:limit])
+
+@unique_reporters = @issues.each_with_object({}) do |issue, reporters|
+ reporters[issue.id] = issue
Is there anything that should be fixed in this PR?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-2602117571
You are receiving this because you are subscribed to this thread.
Message ID:
___
PR was updated. Bootstrap tooltips were removed. Instead of the horizontal view
of reporters list, now it is vertical and after 3 users it shows "and X more".
I tried aligning data of the table vertically middle, but top one was visually
more appealing. This is screenshot of how it looks now:
![
@nertc pushed 1 commit.
0e69bdfa26f3fc0720d1e7a371ca36f06d53e0ac Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/7d67d4e879423a6628a192c2ba3a6a74cc9ec0ae..0e69bdfa26f3fc0720d1e7a371ca36f06d53e0ac
You are receiving
Merge conflict was fixed and `master` was rebased.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2615382657
You are receiving this because you are subscribed to this thread.
Message ID:
___
@nertc pushed 1 commit.
ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/777eb643422fcd5267c647b388e14144e8f5fe09..ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd
You are receiving this because yo
Thank you @gravitystorm. I asked Aleksandar, and it seems, you are right. He
has `en-GB` as `preferred language`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2615264654
You are receiving this because you are
@nertc pushed 1 commit.
8263827fa86f1b6a3b21919ee8e016ac5d64b6f2 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/dc9d0cb25294d9b69c78e5cade34a9ca4e38ac3e..8263827fa86f1b6a3b21919ee8e016ac5d64b6f2
You are receiving this becaus
Merge conflict was fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2615292764
You are receiving this because you are subscribed to this thread.
Message ID:
___
The reason I used word `followings` instead of `following` in the code is to
avoid ambiguities, as `following` can mean 10 different things and it heavily
depends on context, while `followings` is certainly a plural form of noun. When
model has property `following` it is not obvious if this prop
@nertc pushed 1 commit.
dc9d0cb25294d9b69c78e5cade34a9ca4e38ac3e Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/bfa37a02549d1a5ee3ffdf5b686141bd8fc60a50..dc9d0cb25294d9b69c78e5cade34a9ca4e38ac3e
You are receiving this becaus
@nertc pushed 1 commit.
1a23bfa1ecae74ea47dfb76eadd4e6bc856fed70 Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14..1a23bfa1ecae74ea47dfb76eadd4e6bc856fed70
You are receiving
@nertc commented on this pull request.
> @@ -44,6 +44,15 @@ def index
end
@issues, @newer_issues_id, @older_issues_id = get_page_items(@issues,
:limit => @params[:limit])
+
+@unique_reporters = @issues.each_with_object({}) do |issue, reporters|
+ user_ids = issue.reports.or
@nertc commented on this pull request.
> +1.upto(5).each do |n|
+ issue.reports << create(:report, :user => create(:user, :display_name =>
"Test Name #{n}"))
+end
Thanks for the suggestion. Both tests were changed to match smaller list
creation you suggested.
--
Reply to this e
@nertc pushed 1 commit.
d7eb8b668e0363b45b7f4eb15a17b2ed840e39af Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/0e69bdfa26f3fc0720d1e7a371ca36f06d53e0ac..d7eb8b668e0363b45b7f4eb15a17b2ed840e39af
You are receiving
PR was updated. Reporters are now sorted according to their last report
creation datetime in descending order. Tests were also added to test sorting
functionality.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment
Last update of the PR #5009 adds functionality for canceling layer
loading/unloading. Currently code in that PR works like this:
```
When checkmark is checked:
If unloading is in progress, cancel unloading
Run asynchronous layer loading
When checkmark is removed:
If loading is in progr
@nertc approved this pull request.
Tested and code works properly. I like this change, this kind of separation of
functionalities make code more readable and easier to work with.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@nertc approved this pull request.
Code works properly and solves the issue raised in the comment mentioned in the
description.
There is also a different idea to solve the problem
(https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578415862),
but this PR has other
@nertc pushed 1 commit.
9fcfc1af4cd0c32958e18ba35e228aa7a055e423 Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/a153faf0010fdf2b977a4f35f49bdaf3814c6fbc..9fcfc1af4cd0c32958e18ba35e228aa7a055e423
You are rec
@AntonKhorev I'll update this PR to have vertical list of `Reporting users`. Do
you also suggest to completely remove tooltips? I think tooltips are quite
handy even if user can't click on the profile links (to just take a glance at
reporting users' names), but it introduces additional complexit
@nertc commented on this pull request.
> - <%= link_to t(".remove as friend"),
> remove_friend_path(:display_name => @user.display_name), :method => :post %>
+ <%= link_to t(".unfollow"), follow_path(:display_name =>
@user.display_name), :method => :delete %>
@nertc commented on this pull request.
> + follow:
+heading: "Do you want to follow %{user}?"
+button: "Follow User"
+ unfollow:
+heading: "Do you want to unfollow %{user}?"
+button: "Unfollow"
`Unfollow` was changed to `Unfollow User`
--
Reply to thi
@nertc pushed 2 commits.
2b7a48029bff06c190544f91c5969b09aeae552b Modify the way Friends are added
be11f2075e8bbde0a1e0640fd254c64ee0c94f25 Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/9fcfc1af4cd0c32958
> > I think tooltips are quite handy even if user can't click on the profile
> > links (to just take a glance at reporting users' names)
>
> Can't you don this already by looking at the link location that the browse
> shows?
If there is no tooltip on the issues, which has more than 3 reporters,
@nertc pushed 1 commit.
77e3f39bdf29c9a41475e1ea1347560add9c65d3 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/ead1ba9ab27dd2ca00c395a36cf99403792e2be2..77e3f39bdf29c9a41475e1ea1347560add9c65d3
You are receiving this because yo
@nertc pushed 1 commit.
aac929d79e91cb554655a60b1a2cc81a364d6d7f Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/135ca1badb8f21f0047153547def0a954e6f7037..aac929d79e91cb554655a60b1a2cc81a364d6d7f
You are receiving this because yo
@nertc pushed 1 commit.
ead1ba9ab27dd2ca00c395a36cf99403792e2be2 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/5fd8b6165732618de7d8ef987d170809eacfb59a..ead1ba9ab27dd2ca00c395a36cf99403792e2be2
You are receiving this because yo
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Thanks for suggestions. I agree with you, it seems current solution has some UI
problems, but adding additional disabled input doesn't align with the UI
practices we are currently usi
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Yes, either on page load, or if we want to avoid an additional call on the page
load, we can call Nominatim twice on the first change of the pin (one for the
previous value and one fo
@nertc commented on this pull request.
> + if accumulated_length >= max_length
+node.remove unless !last_child.nil? &&
last_child.ancestors.include?(node)
+next
+ end
+
+ next unless node.children.empty?
+
+ accumulated_length += node.text? ? node.text.length
PR was updated. Truncation logic was moved to `RichText::Base` and now
`.to_html` can take truncation length as an argument (if not provided, full
content will be displayed).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#i
@nertc commented on this pull request.
> - <%= link_to t(".remove as friend"),
> remove_friend_path(:display_name => @user.display_name), :method => :post %>
+ <%= link_to t(".unfollow"), follow_path(:display_name =>
@user.display_name), :method => :delete %>
@nertc commented on this pull request.
> + follow:
+heading: "Do you want to follow %{user}?"
+button: "Follow User"
+ unfollow:
+heading: "Do you want to unfollow %{user}?"
+button: "Unfollow"
I tried to stick to the formulations from the `friendship`
@nertc commented on this pull request.
> + belongs_to :befriender, :class_name => "User", :foreign_key => :user_id,
> :inverse_of => :follows
+ belongs_to :befriendee, :class_name => "User", :foreign_key =>
:friend_user_id, :inverse_of => :follows
`:befriender` was changed to `:follower` an
@nertc commented on this pull request.
> + scope "/user/:display_name" do
+resource :follow, :only => [:create, :destroy, :edit], :path => "follow"
+ end
Redirections were added from `/make_friend` and `/remove_friend` to
`/follow/edit`
--
Reply to this email directly or view it on Git
@nertc commented on this pull request.
> + before_action :check_database_writable, :only => [:create, :destroy, :edit]
+ before_action :lookup_friend, :only => [:create, :destroy, :edit]
`:only` was removed
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
@nertc pushed 1 commit.
5c9c7b818519080ba96106e5cf8c0b92abba2874 Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/36fba94eaa196762872d337975836625a65c107e..5c9c7b818519080ba96106e5cf8c0b92abba2874
You are rec
@nertc commented on this pull request.
> + has_many :follows, -> { joins(:following).where(:users => { :status =>
> %w[active confirmed] }) }
+ has_many :followings, :through => :follows, :source => :following
> Maybe use "Following" instead of "Followed users" for better clarity. It
> alig
@nertc pushed 2 commits.
9f615bd98e9aba76eb0c712fce430109d8212575 Modify the way Friends are added
a153faf0010fdf2b977a4f35f49bdaf3814c6fbc Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/5c9c7b818519080ba9
@nertc pushed 1 commit.
bfa37a02549d1a5ee3ffdf5b686141bd8fc60a50 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/a1b03f9f696183d5bee5d9355ceae48a806db130..bfa37a02549d1a5ee3ffdf5b686141bd8fc60a50
You are receiving this becaus
> When I'm making a site for myself and there's this kind of UI with _Add_
> buttons adding an input and _Remove_ buttons next to added inputs, I don't
> bother doing it. I just put a ``, it's easier to edit. In this case
> I'd have a textarea with each nonempty line corresponding to a link. Why
> Do we need another set of icons in addition to
> `app/assets/images/social_icons`?
They have different design. They are more colorful and more like logos which
should gain users' attention (for example as share buttons), but icons added by
this PR are one color, simple icons, which should not
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
+<%= t ".social_links.legend" %>
+
+ <%= f.fields_for :social_links do |social_link_form| %>
+
+ <%= social_link_form.text_field :url, :hide_label => true,
:wrapper_class => "col-sm-8" %>
+
@nertc commented on this pull request.
> +# created_at :datetime not null
+# updated_at :datetime not null
+#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ b
@nertc commented on this pull request.
> @@ -225,4 +225,27 @@ $(document).ready(function () {
$("#read_tou").on("click", function () {
$("#continue").prop("disabled", !($(this).prop("checked") &&
$("#read_ct").prop("checked")));
});
+
+ $("#add-social-link").click(function (event) {
@nertc pushed 1 commit.
09f4fb63448798f0698efa82052576005ab6a533 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/f5a5cfc94be4aa89137401a308a7716effa640f5..09f4fb63448798f0698efa82052576005ab6a533
You are re
@nertc commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+ c
@nertc commented on this pull request.
> @@ -176,6 +206,64 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation(updateInput = true, lat =
$("#home_lat").val().trim(), lon = $("#home_lon").val().trim(), successFn) {
`respondToHomeUpdate` was changed with `respondToHom
nertc left a comment (openstreetmap/openstreetmap-website#5009)
@deevroman Thank you for your feedback. #5799 disabled asynchronous layer
loading and, therefore, there shouldn't be any flashes or slow rendering
process anymore.
--
Reply to this email directly or view it on GitHub:
https://gith
@nertc commented on this pull request.
> @@ -12,6 +12,7 @@
# home_lat :float
# home_lon :float
# home_zoom:integer default(3)
+# location_name:string
`location_name` was updated and renamed as `home_location_name`.
--
Reply to this e
nertc left a comment (openstreetmap/openstreetmap-website#5121)
@AntonKhorev Thank you for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#issuecomment-2743822549
You are receiving this
@nertc commented on this pull request.
> +def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_length = 0
+ last_child = nil
+
+ doc.traver
@nertc commented on this pull request.
> @@ -65,6 +65,32 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_
@nertc commented on this pull request.
> +locationInput = {
+ dirty: false,
+ requestController: null,
+ countryName: $("#location_name").val().trim(),
+ deletedText: null,
+ checkLocation: savedLat && savedLon && $("#location_name").val().trim()
+};
I created a
nertc left a comment (openstreetmap/openstreetmap-website#5009)
You are right, I thought, it disabled both asynchronous functionalities.
I pulled `master` and tested turning asynchronous loading off.
1. About flash: it is because data is loaded asynchronously and as everything
is rendered one by
@nertc commented on this pull request.
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
+ const endpoint = {
+dirty: false,
Property name `dirty` was inspired from Angular. It means that input was
changed manually. But, in this
@nertc commented on this pull request.
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
`HomeLocationNameEndpoint` was chosen to be similar to `OSM.DirectionsEndpoint`
from `app\assets\javascripts\index\directions-endpoint.js`.
Was
@nertc pushed 1 commit.
e74ecd48186bc7d019f71d27f8ded26f24a92410 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/f8c5cb47014e588952ac0dcbc528b5b8ff793d06..e74ecd48186bc7d019f71d27f8ded26f24a92410
You are receiving this because yo
@nertc pushed 1 commit.
691738c70898082000657ceb8537ea52fa8bf488 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/859d609fb2d519dab4253d9df5b1c718a30015d0..691738c70898082000657ceb8537ea52fa8bf488
You are re
@nertc commented on this pull request.
> @@ -65,6 +65,42 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, img_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ keep_or_discards =
@nertc pushed 1 commit.
4e5217d0cae2cbc977090f60b879d8fa17016ac5 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/e74ecd48186bc7d019f71d27f8ded26f24a92410..4e5217d0cae2cbc977090f60b879d8fa17016ac5
You are receiving this because yo
@nertc pushed 1 commit.
39a0abf336d858c85c09812b70a5378944242ded Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/8a3e211e938dedeafe021d09afb9c66fbf2325a9..39a0abf336d858c85c09812b70a5378944242ded
You are receiving this because you
@nertc pushed 1 commit.
859d609fb2d519dab4253d9df5b1c718a30015d0 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/09f4fb63448798f0698efa82052576005ab6a533..859d609fb2d519dab4253d9df5b1c718a30015d0
You are re
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@AntonKhorev Thanks for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2736015474
You are receiving this be
nertc left a comment (openstreetmap/openstreetmap-website#5121)
PR was updated.
@AntonKhorev `truncate_html` was moved to be done after `linkify` and
`sanitize`.
@tomhughes visual of `See full entry` link was changed. Now it is separate from
other links and easier to see (see screenshots).
Logic
@nertc pushed 1 commit.
be27c86c5f2c7f7497a9dc59e6d3ab0034099573 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/691738c70898082000657ceb8537ea52fa8bf488..be27c86c5f2c7f7497a9dc59e6d3ab0034099573
You are re
@nertc commented on this pull request.
> +if (updateLocationName) {
+ if (locationInput.checkLocation) {
+updateHomeLocation(false, savedLat, savedLon, updateHomeLocation);
+ } else {
+updateHomeLocation();
+ }
+}
It shouldn't t
nertc left a comment (openstreetmap/openstreetmap-website#5439)
`master` was rebased. Conflicts were resolved.
Tests have these errors:
`Selenium::WebDriver::Error::UnknownError: Failed to decode response from
marionette`
`Selenium::WebDriver::Error::NoSuchWindowError: Browsing context has been
@nertc commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if tru
nertc left a comment (openstreetmap/openstreetmap-website#5201)
Thanks for rerunning tests.
PR was updated. `master` was merged to avoid previous test errors.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-27835
@nertc pushed 1 commit.
491091b70e618b5c49df7a62f28738ae658a0fa6 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/4e5217d0cae2cbc977090f60b879d8fa17016ac5..491091b70e618b5c49df7a62f28738ae658a0fa6
You are receiving this because yo
nertc left a comment (openstreetmap/openstreetmap-website#5302)
PR was updated. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2812062046
You are receiving this because you are sub
nertc left a comment (openstreetmap/openstreetmap-website#5121)
Thanks for the review @tomhughes. PR was updated according to the suggestion.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#issuecomment-2809369142
You are re
@nertc commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if tru
@nertc pushed 1 commit.
738d1f97fe16770d044f512d6c006a6fca457d67 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/be27c86c5f2c7f7497a9dc59e6d3ab0034099573..738d1f97fe16770d044f512d6c006a6fca457d67
You are re
nertc created an issue (openstreetmap/openstreetmap-website#5986)
### Problem
Currently profile page doesn't provide functionality to add company or work
name on the profile (other than adding it manually in the description, which
makes visual representation of it inconsistent).
### Descriptio
This PR addresses "Company Name on Profile Page" issue mentioned in
#5986
PR adds Company Name functionality on Profile page. If user modifies company
field, value will be shown on the profile page. It can be changed from `Edit
Profile`. `company` field can be empty, in which case, company info
nertc left a comment (openstreetmap/openstreetmap-website#5987)
@tomhughes Yes, in my practice, `suitcase icon` is commonly used to refer to a
job or company. If it's not intuitive, it can be changed to the `building icon`
mentioned in the issue. My thought was that the `building icon` may be sl
@nertc pushed 1 commit.
bafaf78c7de4e8a224e1957f5b7c3f054ad05211 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/491091b70e618b5c49df7a62f28738ae658a0fa6..bafaf78c7de4e8a224e1957f5b7c3f054ad05211
You are receiving this because yo
@nertc commented on this pull request.
> +# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :messag
@nertc commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag
"/assets/social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' :
social_link.parsed[:platform]}.svg",
Was fixed accordingly, `/assets/` was removed.
--
Reply
@nertc commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+ c
101 - 200 of 277 matches
Mail list logo
