@AntonKhorev It's a good point, I'll try to fix it and, as we will need more
complex solution than just adding `max-height`, I'll also take @kcne's
recommendations into account.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/51
@AntonKhorev Currently, as I found in the project, for icons we use `.icon`
class, which uses sprite with `background-image` and `background-position`
properties. Adding icon to the sprite was solely for the accordance with the
current state and practices of the project.
--
Reply to this email
@nertc pushed 1 commit.
e02866a8b5003ae8a8c82c141db9c522b209680b Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/64c4f7e97c2dcf835e6ed9c1fc1242310def14d9..e02866a8b5003ae8a8c82c141db9c522b209680b
You are receiving this because you
Thank you for the review
@tomhughes I've updated accordingly
@AntonKhorev If it's okay to directly use SVG instead of the `.icon` class
practice of the project, I am all for it. I think it's even better solution and
produces cleaner, more reusable code.
--
Reply to this email directly or view
@AntonKhorev Okay, thanks. I'll update it to ``. It will be more
comfortable to reuse and will produce cleaner code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-2352793179
You are receiving this because you a
I almost finished the code. I think it will be ready tomorrow. The idea is to
truncate entries server-side and, for example, if we show only 1000 characters,
estimate that image will take space of 500, therefore, it will truncate text
and also won't allow to add many photos that will overload di
This PR addresses "Modify the way 'Friends' are added" issue
mentioned in https://github.com/openstreetmap/openstreetmap-website/issues/3310
This PR replaces all occurrences of "friends" to
"followers", including texts, tests and URLs.
This PR was not broken down to smaller pieces to maintain c
@nertc commented on this pull request.
> @@ -0,0 +1,12 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Language.order(:english_name).each do |language| %>
+><%=
language.name %>
If there was not a cookie, none of the options would be preselected. But for
the better UX this
@nertc pushed 1 commit.
f5754b8cd7e4c60add5abc9b7f7b247a1b77 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/34d2e252b3c9fe2735ea607d43caea8b849613c5..f5754b8cd7e4c60add5abc9b7f7b247a1b77
You are receiving this because you
@nertc commented on this pull request.
> @@ -78,6 +78,15 @@
<%= link_to t("layouts.about"), about_path, :class =>
"dropdown-item" %>
+
+<% if current_user && current_user.id %>
+ <%= link_to(preferences_path, :class => "nav-link text-secondary
Is there anything that prevents Bootstrap and `common.scss` to be used for the
error pages? It would need less SCSS code, and it would be much more consistent.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5131#issuecomment-2393
@nertc commented on this pull request.
> @@ -1,3 +1,5 @@
+
I know that these two lines were copied from the `_head.html.erb`, but for the
consistency of this file, I think, it will be better if we use `<%= tag.meta
... %>` instead.
--
Reply to this email directly or view it on GitHub:
https
@nertc pushed 1 commit.
8393857518195d145a5f1e8252b939f731cff25c Modify the way Friends are added
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/e1a1b87211fde02664d5a16a970a98c6df5d061a..8393857518195d145a5f1e8252b939f731cff25c
You are receiving thi
@nertc pushed 1 commit.
41cb49e6a084607132ed9818e9139925f924a19b Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/f5754b8cd7e4c60add5abc9b7f7b247a1b77..41cb49e6a084607132ed9818e9139925f924a19b
You are receiving this because you
@nertc pushed 1 commit.
80708ff796458168ebb1060bcb16e07ecf2e6fb5 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/41cb49e6a084607132ed9818e9139925f924a19b..80708ff796458168ebb1060bcb16e07ecf2e6fb5
You are receiving this because you
@nertc commented on this pull request.
> + <% Locale.available
+ .map { |locale| Language.find_by(:code => locale.to_s) }
+ .select { |locale| locale }
+ .sort_by { |locale| locale[:english_name] }
+ .each do |language| %>
+><%
@nertc commented on this pull request.
> @@ -91,7 +91,7 @@ en:
support_url: Support URL
allow_read_prefs: read their user preferences
allow_write_prefs: modify their user preferences
-allow_write_diary: create diary entries, comments and make friends
+
@nertc commented on this pull request.
>
- <%= render :partial => "contact", :collection => friends, :locals =>
{ :type => "friend" } %>
+ <%= render :partial => "contact", :collection => friends, :locals =>
{ :type => "followed user" } %>
`fo
@nertc commented on this pull request.
> - heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+follow_user:
+ heading: "Do you want to follow %{user}?"
+ but
@nertc commented on this pull request.
> @@ -1603,12 +1603,12 @@ en:
footer_html: "You can also read the message at %{readurl} and you can
send a message to the author at %{replyurl}"
friendship_notification:
hi: "Hi %{to_user},"
- subject: "[OpenStreetMap] %{user} added
@nertc commented on this pull request.
> - heading: "Add %{user} as a friend?"
- button: "Add as friend"
- success: "%{name} is now your friend!"
- failed: "Sorry, failed to add %{name} as a friend."
- already_a_friend: "You are already friends with %{name}."
- limi
@nertc commented on this pull request.
> @@ -27,19 +27,19 @@
- <%= t ".my friends" %>
+ <%= t ".followed users" %>
I agree with you. Wording was changed from `followed users` to `followings`. I
was also thinking about it. `followed users` is more understandable, but
`f
@nertc commented on this pull request.
> -remove_friend:
- heading: "Unfriend %{user}?"
- button: "Unfriend"
- success: "%{name} was removed from your friends."
- not_a_friend: "%{name} is not one of your friends."
+follow_user:
+ heading: "Do you want to follow
@nertc commented on this pull request.
> @@ -86,6 +86,16 @@ OSM.initializeDataLayer = function (map) {
if (dataLoader) dataLoader.abort();
+let spanLoading = $("#layers-data-loading");
+
+if (!spanLoading.length) {
+ spanLoading = $("")
+.attr("id", "layers-data-loa
If there are no other change requests for this PR, I'll create a new PR for the
[leaflet-osm](https://github.com/openstreetmap/leaflet-osm) to merge changes
done in the `vendor/assets/leaflet/leaflet.osm.js`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
@nertc commented on this pull request.
> @@ -60,6 +61,13 @@
<%= link_to t(".reports_count", :count =>
issue.reports_count), issue %>
<%= link_to reportable_title(issue.reportable),
reportable_url(issue.reportable) %>
<%= link_to issue.reported_user.display_name
@nertc commented on this pull request.
> @@ -60,6 +61,13 @@
<%= link_to t(".reports_count", :count =>
issue.reports_count), issue %>
<%= link_to reportable_title(issue.reportable),
reportable_url(issue.reportable) %>
<%= link_to issue.reported_user.display_name
@nertc commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "f
Thank you for the review. This PR was updated according to recommendations.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#issuecomment-2428445343
You are receiving this because you are subscribed to this thread.
Message ID:
@nertc commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "f
@nertc commented on this pull request.
> @@ -0,0 +1,6 @@
+$(document).ready(function () {
+ $(".language-change-trigger").on("change", function () {
Code was updated according to the recommendation.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openst
@nertc pushed 1 commit.
25fd157b9ce6e7945bf5d5e9871d04388e9e5f19 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/80708ff796458168ebb1060bcb16e07ecf2e6fb5..25fd157b9ce6e7945bf5d5e9871d04388e9e5f19
You are receiving this because you
This PR was updated according to the suggestion of @AntonKhorev.
As described in the `CONTRIBUTING.md` only updated language config was `en`:
> ## i18n
>
> If you make a change that involve the locale files (in `config/locales`) then
> please only submit changes to the `en.yml` file. The other fi
@nertc pushed 1 commit.
e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/d20e90d5a8e55b94805cbe21c3c0633ddea36cc6..e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda
You are receiving this because yo
PR adds location name info on the user profile page. Location name can be
changed from "Edit Profile" page either by manual typing or
auto-filling according to the home location.
One column was added to the user table to save user's location.
JS logics are responsible for handling:
1) Delete-Und
@nertc commented on this pull request.
> @@ -60,6 +61,13 @@
<%= link_to t(".reports_count", :count =>
issue.reports_count), issue %>
<%= link_to reportable_title(issue.reportable),
reportable_url(issue.reportable) %>
<%= link_to issue.reported_user.display_name
@nertc pushed 1 commit.
ca019cd28c25eed1bd211f070b0bd8f10293878d Map Data checkbox: perhaps use toggle
slider instead
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/41e606921c8d7a08800b07f43a22d7d64c0ed024..ca019cd28c25eed1bd211f070b0bd8f10293878d
PR was updated to include changes made in the
https://github.com/openstreetmap/leaflet-osm/pull/38. As leaflet-osm PR is now
merged, this PR can be reviewed and merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#issueco
@nertc pushed 1 commit.
713eaaaff248f5b0a91680e081f7217f69fd7c4b Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/e02866a8b5003ae8a8c82c141db9c522b209680b..713eaaaff248f5b0a91680e081f7217f69fd7c4b
You are receiving this because you
PR was updated to include SVG in the HTML. I tried several different methods to
move SVG from sprite, including adding it to the SvgHelper module and adding
separate file for it, but current solution turned out to be the most optimal
one (SvgHelper had conflicts with the linter because of long l
@nertc pushed 1 commit.
34d2e252b3c9fe2735ea607d43caea8b849613c5 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/713eaaaff248f5b0a91680e081f7217f69fd7c4b..34d2e252b3c9fe2735ea607d43caea8b849613c5
You are receiving this because you
@nertc commented on this pull request.
> @@ -76,6 +85,15 @@
<%= link_to t("layouts.copyright"), copyright_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.help"), help_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.about"), about_path, :clas
@nertc commented on this pull request.
> @@ -76,6 +85,15 @@
<%= link_to t("layouts.copyright"), copyright_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.help"), help_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.about"), about_path, :clas
@nertc commented on this pull request.
> @@ -76,6 +85,15 @@
<%= link_to t("layouts.copyright"), copyright_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.help"), help_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.about"), about_path, :clas
@nertc pushed 1 commit.
4b91e799bfed30f71dac5d10723dec016a34c26b Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/ca019cd28c25eed1bd211f070b0bd8f10293878d..4b91e799bfed30f71dac5d10723dec016a34c26b
You are receiving this
@AntonKhorev I couldn't reproduce JS errors in the console. But I changed logic
and now when user clicks "Map Data" checkbox, previous action is skipped
immediately. Therefore, there will be no 2*n loads and errors. When we will be
okay with the solution, I'll create a new PR in the
[leaflet-os
@nertc pushed 1 commit.
2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/d71a59541a80c6f5a821ee6bc7c1d08900d69a6b..2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c
You are re
This PR was updated. Now truncation is handled in the back end. After 1000
characters, entry is truncated and `...` are added to it. Every image is
handled as 500 characters to avoid entries with a big number of images.
@kcne @AntonKhorev Thank you for reviews and recommendations
--
Reply to th
@nertc approved this pull request.
Tested and works perfectly. Every occurrence of "shared/pagination" has its own
pair on top of the page.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5262#pullrequestreview-2418102474
You a
@tomhughes Thank you for the comment. I agree with you about the complexity of
the code, but there are several reasons for both methods.
Changing location name manually solves cases like:
1. Disputed areas - someone living in the area A may not want to show that area
is part of country B and no
@nertc pushed 1 commit.
5fd8b6165732618de7d8ef987d170809eacfb59a Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6..5fd8b6165732618de7d8ef987d170809eacfb59a
You are receiving this because yo
@nertc pushed 1 commit.
91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda..91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e
You are receiving this because yo
@nertc pushed 1 commit.
9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e..9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6
You are receiving this because yo
@nertc commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+const g
@nertc commented on this pull request.
> @@ -0,0 +1,22 @@
+require "application_system_test_case"
+
+class UserLocationChangeTest < ApplicationSystemTestCase
+ def setup
+stub_request(:get, /.*gravatar.com.*d=404/).to_return(:status => 404)
+ end
+
+ test "User can change their location"
@AntonKhorev It will make `Reporter Users` cells too high which will cause
additional whitespaces in other cells.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2484796738
You are receiving this because you are
@nertc pushed 1 commit.
f5a5cfc94be4aa89137401a308a7716effa640f5 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/e13e04e4bcaa5749f543b5e5d15bc96b8d69f808..f5a5cfc94be4aa89137401a308a7716effa640f5
You are re
@nertc commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+doc = Nokogiri::HTML::DocumentFragment.parse(html)
+accumulated_length = 0
+truncated_node = nil
+
+doc.traverse do |node|
+ if accumulated_length >= max_length
+
@nertc commented on this pull request.
> @@ -280,8 +280,10 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "
PR was updated. Paragraph truncation was removed. Max length of the diary entry
in the list was changed to 2000. Images now take size of 1000 character.
Additional parsing to the RichText was removed and now HTML is directly
sanitized and marked as safe.
--
Reply to this email directly or vi
@nertc commented on this pull request.
> @@ -2,7 +2,7 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.truncated_body(1000).to_html :
diary_entry.body.to_html %>
Addi
@nertc pushed 1 commit.
e13e04e4bcaa5749f543b5e5d15bc96b8d69f808 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c..e13e04e4bcaa5749f543b5e5d15bc96b8d69f808
You are re
@nertc commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+doc = Nokogiri::HTML::DocumentFragment.parse(html)
+accumulated_length = 0
+truncated_node = nil
+
+doc.traverse do |node|
+ if accumulated_length >= max_length
+
@nertc commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+const g
@nertc commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
Was changed with the button named "Autofill %{country}".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#discuss
Thank you for the review. PR was updated according to the comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2497515015
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #5103.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5103#event-15294308158
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@nertc commented on this pull request.
> @@ -280,8 +280,8 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "f
Closing this PR in favor of #5121 PR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5103#issuecomment-2475654591
You are receiving this because you are subscribed to this thread.
Message ID:
_
PR was updated. Now friendship controller and model are refactored to be named
as "follow" and also implement standard CRUD architecture using `create` and
`destroy`. Old controllers, models, views and tests were removed, and new ones
were added with the new names and architecture.
--
Reply to
> And if there's more than say 3, write something like
>
> > UserA
> > UserB...
> > UserC
> > and 2 more users
@AntonKhorev do you mean to make this kind of truncation in the tooltip?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
@nertc commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+doc = Nokogiri::HTML::DocumentFragment.parse(html)
+accumulated_length = 0
+truncated_node = nil
+
+doc.traverse do |node|
+ if accumulated_length >= max_length
+
@nertc pushed 2 commits.
aaffdaadbf13fff043f9171e815161a079014b11 Modify the way Friends are added
02bede750de8a388d0ef378e2c2c583bfba1ca4a Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/8393857518195d145a
I agree with the issue, current User Profile page provides functionalities for
social interactions like Friendship, Messaging, Profile Description and etc.
But to strengthen up community beyond the website and ease communication, it
would be great if Social Profile Links could be added to the pr
@nertc pushed 1 commit.
46f7da62f4bad5b672fb9193644a64c1c8c72083 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/471cbf6462bf835a1a3e35dbd72862d4a6e75b3c..46f7da62f4bad5b672fb9193644a64c1c8c72083
You are receiving this becaus
@nertc commented on this pull request.
> @@ -280,8 +280,10 @@
resource :profile, :only => [:edit, :update]
# friendships
- match "/user/:display_name/make_friend" => "friendships#make_friend", :via
=> [:get, :post], :as => "make_friend"
- match "/user/:display_name/remove_friend" => "
@nertc pushed 1 commit.
36fba94eaa196762872d337975836625a65c107e Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/02bede750de8a388d0ef378e2c2c583bfba1ca4a..36fba94eaa196762872d337975836625a65c107e
You are rec
@nertc pushed 1 commit.
777eb643422fcd5267c647b388e14144e8f5fe09 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/aac929d79e91cb554655a60b1a2cc81a364d6d7f..777eb643422fcd5267c647b388e14144e8f5fe09
You are receiving this because yo
@nertc pushed 1 commit.
defb24f00bf08f00b778c0270b9887502b48a340 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/77e3f39bdf29c9a41475e1ea1347560add9c65d3..defb24f00bf08f00b778c0270b9887502b48a340
You are receiving this because yo
@nertc commented on this pull request.
> +http://www.w3.org/2000/svg"; width="16"
> height="16" fill="currentColor" class="bi bi-geo-alt-fill" viewBox="0 0 16
> 16">
+
+
`<%= t ".home location" %>` was added to the svg.
--
Reply to this emai
@nertc commented on this pull request.
> +if (!locationInput.dirty ||
> locationName.includes(locationInput.countryName)) {
+ $("#location_name_warning").addClass("d-none");
+} else {
+ $("#location_name_warning").removeClass("d-none");
+}
As we updated logic, this code b
@nertc pushed 1 commit.
55c89e6cc0cf41327059dff1ddf1b8116d4580e6 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/46f7da62f4bad5b672fb9193644a64c1c8c72083..55c89e6cc0cf41327059dff1ddf1b8116d4580e6
You are receiving this becaus
> > It will make Reporter Users cells too high which will cause additional
> > whitespaces in other cells.
>
> Is that additional whitespace going to be a problem?
Sorry for the late answer. I think it will be a problem in terms of UI and UX:
UI - visually, additional whitespaces in the table ma
@nertc commented on this pull request.
> + if accumulated_length >= max_length
+node.remove unless !last_child.nil? &&
last_child.ancestors.include?(node)
+next
+ end
+
+ next unless node.children.empty?
+
+ accumulated_length += node.text? ? node.text.length
@nertc commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
+
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
+<%= t ".social_links.legend" %>
+
+ <%= f.fields_for :social_links do |social_link_form| %>
+
+ <%= social_link_form.text_field :url, :hide_label => true,
:wrapper_class => "col-sm-8" %>
+
PR was updated. Branch was synced with master and conflicts were resolved.
Also, instead of handling canceling layer loading in the `setTimeout` callback,
now it is handled by clearing `setTimeouts`.
Optimizations for layer rendering were done in
https://github.com/openstreetmap/leaflet-osm/pul
@nertc pushed 1 commit.
af830a16cb6e09c4d1d25ec96b9c2a6d315975d6 Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/4b91e799bfed30f71dac5d10723dec016a34c26b..af830a16cb6e09c4d1d25ec96b9c2a6d315975d6
You are receiving this
@nertc commented on this pull request.
> +def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_length = 0
+ last_child = nil
+
+ doc.traver
@nertc pushed 1 commit.
fca12a2c06dd0ddcf2b9a937e0eeb36d97a20747 Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/af830a16cb6e09c4d1d25ec96b9c2a6d315975d6..fca12a2c06dd0ddcf2b9a937e0eeb36d97a20747
You are receiving this
@nertc commented on this pull request.
> @@ -40,6 +40,21 @@
+
What do you think is a good place for it? Should it be between the description
and avatar, before the description or the last one?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
@nertc commented on this pull request.
> +if params[:format] == "json"
+ render :html => @results.pluck(:name).join(", ")
PR was updated. Instead of HTML now `format=json` returns JSON array. I thought
about plaintext, but I think, JSON object is much more versatile. Plus, it
contain
@nertc pushed 1 commit.
cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd..cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f
You are receiving this because yo
@nertc pushed 1 commit.
47191675b5aaea734dff6afa0cac4c961963c264 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f..47191675b5aaea734dff6afa0cac4c961963c264
You are receiving this because yo
@nertc commented on this pull request.
> @@ -231,10 +231,15 @@
<% end %>
-<%= @user.description.to_html
%>
-
-<% if current_user and @user.id == current_user.id %>
-
-<%= link_to t(".edit_profile"), edit_profile_path, :class => "btn
btn-outline-primary" %>
+
+
+<%= render "s
@nertc pushed 1 commit.
411888ca16b5ae3877497dc607b73bffe3fafaed Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/8263827fa86f1b6a3b21919ee8e016ac5d64b6f2..411888ca16b5ae3877497dc607b73bffe3fafaed
You are receiving this becaus
PR was updated according to the comments. Also, master was rebased as a base
for this branch.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2653813177
You are receiving this because you are subscribed to this t
@nertc commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
+
@nertc commented on this pull request.
> +:mastodon => %r{mastodon\.social/@([a-zA-Z0-9_]+)},
+:medium => %r{medium\.com/@([a-zA-Z0-9_]+)},
+:quora => %r{quora\.com/profile/([a-zA-Z0-9_-]+)},
+:reddit => %r{reddit\.com/user/([a-zA-Z0-9_-]+)},
+:skype => %r{join\.skype\.com/in
@nertc commented on this pull request.
> +
+<%= image_tag
"/assets/social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' :
social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" :
social_link.parsed[:platform],
+
1 - 100 of 277 matches
Mail list logo
