Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

> Assuming we need to convert SVGs to PNGs I'm not suggesting that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2366790325 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

>> do we need a smaller icon for waste baskets here just because it's smaller >> on the map render? > Yes, it matches exactly the size you see on the map. No, we don't need it to match *exactly the size you see on the (one particular rendering of the) map*. We need to decide what size the icons

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

> I've checked all 219 SVGs, and found that less than 10 of them might need > some fine tuning. The vast majority of new SVGs is just fine. Why making a pull request with 219 svgs with *the vast majority* just fine instead of a smaller pull request with all svg fine? -- Reply to this email dir

[openstreetmap/openstreetmap-website] Process trace files once (PR #5233)

Currently uploaded gpx files are unpacked and parsed each time the `points` method is called. This happens a dozen of times: once for storing the trackpoints in the db, once for generating a thumbnail and once for each frame of an animated trace image. Even if we don't mind reparsing the files o

Re: [openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

Now you can check *Map Data*, wait for the rendering to start then quickly click *Map Data* 2*n times and watch how data is added then removed then added then removed... n times. While this is happening and *Map Data* is checked, pan to a different place to get a stream of javascript errors. --

Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)

@AntonKhorev pushed 2 commits. ba732128a78e487df5cae1c53857e3f7279d3ec1 Store latitudes and longitudes during gpx parsing 6c6d306de97678515b3f3ed8ca4e56fd68a5d46b Use stored lats/lons to draw trace images -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5233/

Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)

Removed interface changes -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5233#issuecomment-2375333124 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

Tracepoint model doesn't need validations because nothing is written using that model. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2372559392 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

Do we even need to build `Tracepoint` models? The only nontrivial thing there is tile calculation. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2371090446 You are receiving this because you are subscribed to t

Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)

> I was wondering about the memory overhead Alternatively we can do two passes. After the first pass we'll know lat/lon spans and the number of trackpoints which lets us start rendering. Then on the second pass we render the thumbnail and all animation frames in parallel. This doesn't require s

Re: [openstreetmap/openstreetmap-website] Allow filtering of notes by status (open/closed) on user profile (PR #5239)

How about "All notes" tab to be able to see the list like it's shown now? "Open" and "closed" are not the only possible states. This list currently gives the only easy way to see hidden notes because #3934 is not merged. -- Reply to this email directly or view it on GitHub: https://github.com/o

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

@AntonKhorev commented on this pull request. > @@ -78,6 +78,15 @@ <%= link_to t("layouts.about"), about_path, :class => "dropdown-item" %> + +<% if current_user && current_user.id %> + <%= link_to(preferences_path, :class => "nav-link text-sec

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

This PR wasn't merged because > we have to jump through hoops and disable cops and I'm saying that we shouldn't worry here about model validations and what Rubocop thinks about them. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pu

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

@AntonKhorev commented on this pull request. > @@ -0,0 +1,12 @@ + + + + + <% unless disabled %> + + <% Language.order(:english_name).each do |language| %> +><%= language.name %> Shouldn't the comparison here be with `I18n.locale.to_s` instead of `request.cookies["_os

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

> Rubocop is reporting a false positive here and we mark it as such. Any use of `insert_all` etc that you want to keep is a false positive. You'll have to disable Rubocop for it one way or another. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] Rename browse controller to features/queries controller (PR #5024)

@AntonKhorev pushed 1 commit. 82efa48976437030d2c1b5ed2ead9ad6161dee10 Rename browse controller to features/queries controller -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5024/files/b1ecf51e3b582ba49e6d1d19a60877efcf843730..82efa48976437030d2c1b5ed2ead9ad6

Re: [openstreetmap/openstreetmap-website] Move users list to administrator module (PR #4969)

After back-and-forth in #4587 a different module scheme was chosen, so this probably needs updating. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4969#issuecomment-2358870920 You are receiving this because you are subscribed to

Re: [openstreetmap/openstreetmap-website] Show changeset element counts using badges (PR #4872)

@AntonKhorev pushed 2 commits. c9211b02640dd6f8c25eb83539826f8d7bdbb200 Remove type_and_paginated_count helper ad5fa6f96ee8a363389bd67969c7f6056af991e5 Show changeset element counts using badges -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4872/files/30d7f

Re: [openstreetmap/openstreetmap-website] Show edit history of deleted users (PR #4224)

@AntonKhorev pushed 3 commits. 28672330339cb4f9de3e5b757417858bf91f6ddb Add links to previous/next changesets of deleted user 5e1e31fe91a32a9eac7fb5b2d13db9403b5bed03 Show edit history of deleted users 929609481367512db39bfc50917aa1bfb75067bc Remove deleted authors from history feed -- View

Re: [openstreetmap/openstreetmap-website] Don't assume order when testing links to changeset elements (PR #4571)

Not needed if #5209 is merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4571#issuecomment-2358502610 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Don't assume order when testing links to changeset elements (PR #4571)

Closed #4571. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4571#event-14307932037 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

@AntonKhorev pushed 1 commit. 1c414a44d49d43389b814e9ed1b3de4dab9f8135 Remove classic pagination -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/8acfc36fcb94abec9bcbce4152b830f63943a0be..1c414a44d49d43389b814e9ed1b3de4dab9f8135 You are receiving this

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

@AntonKhorev pushed 2 commits. f2e302c6a8c57b6f1902c7bf869b185b0a7f25d5 Suppress writing xml parse errors to stderr 81bac0b09b2d03de76c8885f6d77c9297a3ead34 Don't include stack backtraces on xml errors when importing traces -- View it on GitHub: https://github.com/openstreetmap/openstreetmap

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

I'm thinking about detecting the filetype after an xml error happens. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363683587 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Allow exporting direction path tracks (Issue #5224)

> Is there a valid editing use case for this? For links to routing engines I guess it's the same as with Nominatim, which we have. Hopefully they provide more information about why the route was build this way. For exporting from the osm website, you can use the trace as a guide for downloadin

Re: [openstreetmap/openstreetmap-website] `/messages/{id}/mark?mark={unread/read}` returns HTML code (Issue #5222)

I'm not convinced that POST actually sends the response body even though Firefox shows it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5222#issuecomment-2363857242 You are receiving this because you are subscribed to this th

Re: [openstreetmap/openstreetmap-website] Removed unused translations in changesets namespace (PR #5223)

@AntonKhorev commented on this pull request. > @@ -40,9 +40,10 @@ <% next unless comment.visible || current_user&.moderator? %> -<%= t comment.visible ? ".comment_by_html" : ".hidden_comment_by_html", +<% comment_info = comment.visible ? "c

Re: [openstreetmap/openstreetmap-website] Removed unused translations in changesets namespace (PR #5223)

@AntonKhorev commented on this pull request. > @@ -132,6 +132,7 @@ ignore_unused: - 'reports.new.categories.*' # double interpolation in reports_helper - 'shared.pagination.*' - 'auth.providers.*' + - 'changesets.paging_nav.*' # used by string interpolation in elements pagination Won

[openstreetmap/openstreetmap-website] Don't use ?: in "Comment from user" changeset discussion strings (PR #5225)

Does what https://github.com/openstreetmap/openstreetmap-website/pull/5223/commits/4564073106d5d48f3781a207693c39a13c130b66 did but without triggering extra ignores by i18n-tasks. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-web

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

*Duplicate tab* is also broken. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175#issuecomment-2363928828 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

Merged #5228 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5228#event-14346647427 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Drop ignore of removed creation_ip column (PR #5228)

Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5228#issuecomment-2364735403 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

Turbo-rails issues: - https://github.com/hotwired/turbo-rails/issues/580 - https://github.com/hotwired/turbo-rails/issues/669 Turbo issues: - https://github.com/hotwired/turbo/issues/1008 - maybe the cache issues are unrelated to the head issues - https://github.com/hotwired/turbo/issues/1237 -

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

> Regarding "Entity: line 1: parser error : Start tag expected, '<' not found" > message, it's introduced by adding test_parse_error_notification which tries > to load JPG file with XML reader. Do you think that if you upload a binary file without this PR, the error won't be printed? > Perhaps

Re: [openstreetmap/openstreetmap-website] Email links in text/plain ending in "." - break links (#1844)

Only this option is translation-proof, if the url is wrapped before the substitution: > Reply or learn more about the note at > \. But it's not client-proof, as you can see here on Github. -- Reply to this email directly or view it on GitHub: https:

Re: [openstreetmap/openstreetmap-website] Add short links to OSM objects (Issue #5244)

`n6444542941`, `w138935876`, `r2389520` format for elements is used in Josm for some things, but I've never seen `t4276888` for notes. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5244#issuecomment-2387102035 You are receivi

Re: [openstreetmap/openstreetmap-website] Add short links to OSM objects (Issue #5244)

Users by uid: #4215 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5244#issuecomment-2387097197 You are receiving this because you are subscribed to this thread. Message ID: ___ rail

Re: [openstreetmap/openstreetmap-website] Order changeset elements for consistent pagination (PR #5209)

Merged #5209 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5209#event-14307035056 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

> Shouldn't we just be converting changesets to use the same pagination logic > as everything else That depends on how significant are the differences between changeset elements and everything else. The differences are: - Changesets have an upper bound on the number of elements. There can be a

Re: [openstreetmap/openstreetmap-website] Order changeset elements for consistent pagination (PR #5209)

> we're already reading it all anyway so having to sort it doesn't change much I can't check this because I don't know what's the distribution of requested changesets and their timings. Let's merge this and see. Maybe everything is going to work fast enough, then we don't need to bother with ext

Re: [openstreetmap/openstreetmap-website] Remove ability to upload/edit traces from blocked users (PR #4129)

@AntonKhorev pushed 7 commits. 05972a9bf0df4700b3fa6b87361a75c1b8c7e28b Remove ability to write traces from blocked users 4c07e8db5947f0f56af3bb82db70b4c3d974 Show link to block in blocked trace flash message a535629114f0e67d254bab89f84c221962a0b583 Style link in flash block message as a

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

Alternatively or in addition to this we can check file types. We already do, to detect archives https://github.com/openstreetmap/openstreetmap-website/blob/6595d43e3cda580508a069e174d0059febcdc6ea/lib/gpx.rb#L55-L58 I don't know if we can reliably detect gpx. We could detect obviously wrong fil

Re: [openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

It's not test runner spitting, it's the xml library. You can pass an option to suppress it. I was going to do another pull request to silence it when I find all of the places where this can happen. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] Improved error messages and UI when importing GPS trace files (PR #5117)

Merged #5117 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5117#event-14325034369 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] GPX Upload does not check for filetype (#2630)

Closed #2630 as completed via ef2c6ef026f263303d8c9fdd633c437f288d362c. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14325034278 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] GPX Upload does not check for filetype (#2630)

Reopened #2630. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14325052660 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mail

Re: [openstreetmap/openstreetmap-website] Improved error messages and UI when importing GPS trace files (PR #5117)

I merged this because it's an improvement, it tells now about file formats. But it doesn't fix #2630 as stack backtraces are still included in emails. Those backtraces are either sometimes (in case of xml parse errors) or maybe even always useless to the end user. -- Reply to this email direct

[openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

We've been including stack backtraces in gpx failure notifications since https://github.com/openstreetmap/openstreetmap-website/commit/93dab8a1272f8c807da841c0a55b37f74b65b8c3, but they are not useful for xml parse errors. If your file can't be parsed, the error is inside it, not in the code tha

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

@AntonKhorev commented on this pull request. > @@ -76,6 +85,15 @@ <%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %> <%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %> <%= link_to t("layouts.about"), about_path,

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

Don't insert data without timestamps. `delete_all` is already present in `trace.rb`. It doesn't call any hooks yet nobody is bothered by it. Might as well have `insert_all` and do all validations in `trace.rb`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreet

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

> These are good reasons why the paginator doesn't have to be cursor-based, but > they aren't reasons why it can't be cursor-based. So I think the > simplification of only having one type of pagination is worthwhile. Do you propose to remove the ability to go to page N? -- Reply to this email

Re: [openstreetmap/openstreetmap-website] Remove classic pagination (PR #5205)

Do you also propose to remove the ability to see how many elements of each type were changed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5205#issuecomment-2391412344 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

@AntonKhorev pushed 2 commits. e75ba668a10b73c4d1b0db91b6677f964b82c42a Use base64 encoding to support arbitrary tag keys 1e76290d42953a57335a0f138ce26e2be0396014 Handle incorrectly encoded tag keys -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5309/files/9

Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)

@AntonKhorev commented on this pull request. > @@ -34,6 +34,16 @@ class Note < ApplicationRecord scope :visible, -> { where.not(:status => "hidden") } scope :invisible, -> { where(:status => "hidden") } + scope :with_status, lambda { |status| +case status +when "open" + whe

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

> The big question for me is how updates are propagated to the changeset replication feed This is one of the excuses why hiding/deleting changeset tags wasn't done before. There are others such as we don't have changeset versions to store previous set of tags. If the feed is generated by [th

[openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5283 -- Commit Summary -- * Create note subscription table and model * Subscribe users when they interact with notes * Backfill note subscriptions * Send notific

Re: [openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

@AntonKhorev pushed 1 commit. 3b1657c342809c4395ac5c92699962fd8a5ba715 Add subscribe/unsubscribe buttons to note pages -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5283/files/433ae3df1656bbcb97f380dd7420111a15e85af1..3b1657c342809c4395ac5c92699962fd8a5ba715

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

@AntonKhorev commented on this pull request. > + <% Locale.available + .map { |locale| Language.find_by(:code => locale.to_s) } + .select { |locale| locale } + .sort_by { |locale| locale[:english_name] } + .each do |language| %> +

Re: [openstreetmap/openstreetmap-website] Note subscriptions (PR #5283)

@AntonKhorev pushed 5 commits. e1d3074c9a79200123a6247a0f04b0239baf07aa Backfill note subscriptions 199ad4b25c846f13345194927c258cd575be5099 Send notifications to note subscribers instead of commenters 2306e810f072d20afc5ec05d9ea8ea1c955f2a12 Add create note subscription api endpoint d7e67336

Re: [openstreetmap/openstreetmap-website] Use resourceful routes for granting/revoking user roles (PR #5293)

@AntonKhorev pushed 1 commit. b8247478f4f772df8d09a29f3acd383fc6d32cf0 Use resourceful routes for granting/revoking user roles -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5293/files/b24d52d5ca30e081ec799880bee6bc32616ad8fa..b8247478f4f772df8d09a29f3acd383f

Re: [openstreetmap/openstreetmap-website] Use resourceful routes for granting/revoking user roles (PR #5293)

@AntonKhorev commented on this pull request. > + def update @user.roles.create(:role => @role, :granter => current_user) The routing system requires some convincing to achieve that. The less ugly version I could come up with is singular resources for roles, despite there are multiple po

Re: [openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

@AntonKhorev approved this pull request. It's fine if we're ok with mastodonshare.com for now, but we can replace it later. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2418102922 You are receiving thi

[openstreetmap/openstreetmap-website] Backfill note subscriptions (PR #5304)

Part two of #5283. Creates a subscription for every note commented by a non-anonymous user. Does this by: - iterating through batches of note comments - getting distinct non-null (user, note) pairs - inserting these pairs using `upsert_all`, this skips already existing pairs You can view, commen

[openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

Lets moderators delete changeset tags You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5309 -- Commit Summary -- * Add blank page for managing changeset tags * Add 'not found' page for managing changeset tags * Ad

Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

@AntonKhorev pushed 1 commit. 4613119cb42a2197960a99aa3546a6ca9b9e354f Replace query marker fade animation with css -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307/files/ececb8bcdbc42ed9827eac8abe9022d25e5ae01d..4613119cb42a2197960a99aa3546a6ca9b9e354f Yo

[openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

Fixes #5305. Currently query markers are animated using javascript which requires managing timed events. We don't do it correctly, we don't cancel them when markers are removed. That's why #5305 happens. This PR replaces the javascript animation with the css which doesn't require any event han

Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)

> I believe we can implement them with minimal code adjustments. #4761 > Tables could benefit from some additional styling adjustments to better align with the overall UI appearance in dark mode. I’d be happy to dive deeper into this and prepare a PR. Here’s how the notes table currently appea

Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

@AntonKhorev pushed 1 commit. 771b75ed71198811a6661a146e3376f0489771d8 Replace query marker fade animation with css -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307/files/4613119cb42a2197960a99aa3546a6ca9b9e354f..771b75ed71198811a6661a146e3376f0489771d8 Yo

Re: [openstreetmap/openstreetmap-website] Backfill note subscriptions (PR #5304)

@AntonKhorev pushed 1 commit. c848a88240a627711635627d03fbd4ef90955c93 Backfill note subscriptions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5304/files/e1d3074c9a79200123a6247a0f04b0239baf07aa..c848a88240a627711635627d03fbd4ef90955c93 You are receiving th

[openstreetmap/openstreetmap-website] Send notifications to note subscribers instead of commenters (PR #5310)

Part 3 of #5283. Start using the subscriptions table to send notifications. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5310 -- Commit Summary -- * Send notifications to note subscribers instead of commenters --

[openstreetmap/openstreetmap-website] Restore loading spinner in richtext previews (PR #5311)

Richtext preview loading animation was added in https://github.com/openstreetmap/openstreetmap-website/commit/eb789dbf757e760e8348e0aa75343eb53996b7e3 but later probably got broken. Its `loading` css class was removed in https://github.com/openstreetmap/openstreetmap-website/commit/df1ec6b6809b5

[openstreetmap/openstreetmap-website] Browse element folding nested lists and icons (PR #5355)

#5317 + some other changes You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5355 -- Commit Summary -- * Show "node also part of ways" as nested lists on way pages * Put nested "also..." lists into collapsible detail

Re: [openstreetmap/openstreetmap-website] Browse element folding nested lists and icons (PR #5355)

@AntonKhorev pushed 3 commits. 9cd4bcba679ad1c1352485c7a69649816643d91b Group tagless way nodes with same related ways 5ad3bad2158dc7783015ae3e7127ed1f6a03de51 Show only one icon for way node group f794d36c03122e2c00fc7e057913bc2d4dbe835c Write browse element icons as -- View it on GitHub:

Re: [openstreetmap/openstreetmap-website] Put api keys directly in js layer definitions (PR #5352)

@AntonKhorev pushed 1 commit. 37ce56f225262db0017b44aed56e10c88925dc55 Put api keys directly in js layer definitions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5352/files/25279c4697a5805c6e0c3325ed8963bbca9d0d8b..37ce56f225262db0017b44aed56e10c88925dc55 Y

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

>> And by "develop" I mean also trialling them with a large number of users, >> not just launching into production a result satisfying you, me and four >> people in here. > You mean we shouldn't repeat what was done in > https://github.com/openstreetmap/openstreetmap-website/pull/4712? /s And

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

> Is there any possibile conflict in giving users both a Dark UI toggle and a > Dark Map choice? I don't think there's a conflict, but it's another choice that's going to affect the implementation. We'll have to store the dark map setting for each UI color mode in this case. -- Reply to this

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

> I use OSM almost daily, from time to time on Discord and forums, I even > contribute to iD occasionally, but I never saw any indication that a dark > mode was in active development and about to be released. It was in active development, six months ago. It would have been difficult to miss it

Re: [openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)

Most of error messages are not translated. `report_error` receives many from exceptions defined in `lib/osm.rb`, no translations there. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2489801776 You are receiving

Re: [openstreetmap/openstreetmap-website] Show "reporting user" on "issues" screen (PR #4990)

> It will make Reporter Users cells too high which will cause additional > whitespaces in other cells. Is that additional whitespace going to be a problem? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2504795

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

> However, the PR that implemented the filter > (https://github.com/openstreetmap/openstreetmap-website/pull/4712) was > created by another maintainer It wasn't created by another maintainer. Compare the dates of #4712 and #4911. -- Reply to this email directly or view it on GitHub: https://gi

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

I'm told by some people here that there should have been announcements "on the official OSM social media" etc and wasn't even a maintainer when I was working on dark mode. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5328#is

Re: [openstreetmap/openstreetmap-website] Browse element folding nested lists and icons (PR #5355)

@AntonKhorev pushed 6 commits. 1b743448d4a82973f49e34e8d3680cbb6e8afbbf Show "node also part of ways" as nested lists on way pages cfe13c548df22e00bba357b37910c399797b75a7 Put nested "also..." lists into collapsible details 4935fdcf6e1c68c03d4c83be6ca49b156c27281e Group tagless way nodes with

Re: [openstreetmap/openstreetmap-website] Show "node also part of ways" as nested lists on way pages (PR #5317)

About starting (not) expanded and vertical space: The first obvious thing that I came up this is to use roughly the same logic other `` elements are open/closed by default. Way nodes has this line `>` which expands way nodes if there are fewer than 10 of them. So I thought I'd expand node ways

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

@AntonKhorev pushed 3 commits. 0147a60b497eb4fe3043a1504bbb754216642e68 Add color scheme select to preferences form 9db0e9407a05b5abbc69c2f70f1dc30457654b86 Store selected color scheme 0f595ba520ad3fe6340165b71e5f26b64225e321 Don't change color scheme preference if the value wasn't provided

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

@AntonKhorev pushed 5 commits. 7b30d1756f787d5e116c62b2d825fd5654119bac Add auto/light color scheme stylesheets depending on user preferences 35c131fb700567d367599a39199df4cf978b0d37 Show color scheme on user preferences page 98b0b886966d035b00b97cd52c09654b1f5636aa Add color scheme select to

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

Updated with dark option -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5339#issuecomment-2504759860 You are receiving this because you are subscribed to this thread. Message ID: ___ r

Re: [openstreetmap/openstreetmap-website] Add light/dark mode preference (Issue #5324)

@gravitystorm Is 5 "let's make everyone use this particular filter in dark mode" (which filter?) or is it "let's make everyone have no filter until *the cartographers* let them have some filter"? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetma

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

I also think that it should have three options. The question is do you want a larger pull request that adds three options or do you want a smaller one (you usually say you want small pull requests) that lets you disable the auto dark mode? -- Reply to this email directly or view it on GitHub:

Re: [openstreetmap/openstreetmap-website] Color mode preference stored in db (PR #5339)

@AntonKhorev pushed 1 commit. 6f06d69342da5d2975d606b3c6fe855cc989a0a7 Don't change color scheme preference if the value wasn't provided -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5339/files/354f41b8453d3284872acb51153c6085a4119080..6f06d69342da5d2975d606

Re: [openstreetmap/openstreetmap-website] Dark mode menu (PR #5336)

@mxdanger Sorry, I overrwrote your comment and there seems to be no undo in Github UI. You said that there's an overwhelming feedback for not modifying the map and asked what should be the default. But there is a feedback for doing inverse+hue-rotate transform. -- Reply to this email directly

Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)

Merged #5297 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5297#event-15336203775 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)

Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5297#issuecomment-2483399111 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev

Re: [openstreetmap/openstreetmap-website] Enable dark mode attribution font color (PR #5338)

Merged #5338 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5338#event-15325496937 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)

Changed to have error messages right away. The original version had response bodies intentionally undefined, and they are still intentionally undefined for ok responses. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuec

Re: [openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)

There weren't any *problems* with the code. Not having an error message is not a *problem*. You could as well have said that not adding `destroy` together with `create` is a problem because it requires changing a.k.a. fixing routes and abilities. -- Reply to this email directly or view it on G

Re: [openstreetmap/openstreetmap-website] Slow objects fetching on backend (Ruby on Rails) (Issue #5342)

We have this in readme > A fully-functional openstreetmap-website installation depends on other > services, including map tile servers and geocoding services, that are > provided by other software. Maybe we should mention cgimap too. -- Reply to this email directly or view it on GitHub: https

Re: [openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)

> PR contains a fixup commit Let me guess what's a *fixup* here. The fact that looking up the note is not required in `destroy` if there aren't two different error messages (*note not found* or *not subscribed*)? Now I changed it to always look up the note. Is there still a fixup? -- Reply to

Re: [openstreetmap/openstreetmap-website] Note subscriptions API (PR #5314)

@AntonKhorev pushed 3 commits. f84d99b25969d17f8a4c95d65c0d58a2306e2462 Add create note subscription api endpoint 5c8769eb2ea827db7acb0ee1c665a64a84984bb6 Add destroy note subscription api endpoint 1fa9aa6ede6daa5e2bb222a45807eca7abea1d83 Add error messages for note subscribe/unsubscribe --

Re: [openstreetmap/openstreetmap-website] "Edit" menu shown on (small format) mobile devices largely non-functional (Issue #5326)

> edit on mobile version is a great idea, but it does not really make sense > without links to mobile editors Does enabling iD still counts as "not really making sense"? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5326#issu

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

Let's suppose we have a group of people who don't want any filter and a group of people who want inverse. > I think the principle should be that the decision on what each map looks like > in dark mode should be delegated to the cartographers for that map layer. This proposes to let *the cartogr

<    1   2   3   4   5   6   7   8   9   10   >