mmd-osm left a comment (openstreetmap/openstreetmap-website#6207)
OSM.router is probably the bigger issue. It blocks a number of other features,
such as adding notes, query features, directions, etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
@mmd-osm pushed 1 commit.
2ee3e989e4b9edb41378d275544d1cc3915e Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/67727a878643a2ccd4df03a6b0ee6a90aa557663..2ee3e989e4b9edb41378d275544d1cc3915e
You are receiving
@mmd-osm pushed 1 commit.
67727a878643a2ccd4df03a6b0ee6a90aa557663 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b514a848c5732df855e978748b94fcb87067bc1d..67727a878643a2ccd4df03a6b0ee6a90aa557663
You are receiving
@mmd-osm pushed 2 commits.
70e1eab3dad76200e2e16bc5b2191aa0bea127ee Restrict select options to supported
map export formats
08e788ba8c2b8e1c2a3589689bb4a6004456d59d Map download failure message
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/e4c1d3
@mmd-osm pushed 1 commit.
e4c1d373d9380fca420d6863a2e5fb8018a984ce Restrict select options to supported
map export formats
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/926535a2ffad5f5b7455ea6bc989a78572be778e..e4c1d373d9380fca420d6863a2e5fb8018a9
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
So the image download seems to work now. I still want to hardcode PNG format
for thunderforst (that's the only format available for download), and check how
the code handles bad request due to timeouts during image generation.
I'
@mmd-osm pushed 1 commit.
926535a2ffad5f5b7455ea6bc989a78572be778e Matching download file suffix
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/ac8bbfff948f471a46db7d6bd579069727ff63aa..926535a2ffad5f5b7455ea6bc989a78572be778e
You are receiving this
@mmd-osm pushed 3 commits.
81869381defa872638c9f6035586aed625530f76 Remove not needed submit handler
b50b9d192b1e0bb4b8f50ac7a541e0023f500887 Eslint fix
ac8bbfff948f471a46db7d6bd579069727ff63aa Added downloading text
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
@mmd-osm pushed 1 commit.
38d452e4356f62b9f304bb6ae6fd20d40fd0cff0 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/5008934940ce060263c0878334ecc0e08e63a337..38d452e4356f62b9f304bb6ae6fd20d40fd0cff0
You are receiving this
@mmd-osm pushed 1 commit.
5008934940ce060263c0878334ecc0e08e63a337 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/3d9d24d26e1dd9d44688f7e908e7b48afe07473c..5008934940ce060263c0878334ecc0e08e63a337
You are receiving this
@mmd-osm pushed 1 commit.
3d9d24d26e1dd9d44688f7e908e7b48afe07473c Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/012aec679f34a109865eaf12da1bc8ca4c200847..3d9d24d26e1dd9d44688f7e908e7b48afe07473c
You are receiving this
@mmd-osm pushed 1 commit.
012aec679f34a109865eaf12da1bc8ca4c200847 Fix unit test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b94b4a3fb03666a0f2598b71f6621b37b07a925f..012aec679f34a109865eaf12da1bc8ca4c200847
You are receiving this because you are
@mmd-osm pushed 4 commits.
25f0fda3ec69da488feb3f6ad83e4c3df7eab8fd Image download w/ submit_tag
c2748f8d8f6660e190dbd3ad365b0f5e532c861d Add image provider to CSP connect_src
ed404ae8f570a6db4794885ad5142dd04648c9d3 TOTP token as URL parameter
b94b4a3fb03666a0f2598b71f6621b37b07a925f Export i
@mmd-osm pushed 3 commits.
53149fd121112052ae9e511ad08e72a106304505 Add image provider to CSP connect_src
1f853ca1b57ff7b5186fe160199fd851e40bc519 TOTP token as URL parameter
730c56c58867732f2dee941809900648c6115c56 Export image as AJAX request
--
View it on GitHub:
https://github.com/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
It's available on the dev instance for testing now:
https://master.apis.dev.openstreetmap.org/user/mmd2mod/history
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The preflight request is failing with HTTP 500. There might be something wrong
with `form.getfirst("token")`. Elsewhere we're using `getvalue` to fetch the
parameter value, and check if a value is available:
```
elif "token" in f
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think we could skip the cookie altogether:
>From app/controllers/application_controller.rb -> update_totp -> generates new
>TOTP cookie today.
`ROTP::TOTP.new(Settings.totp_key, :interval => 3600).now` needs to be added to
app
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The other issue I've noticed is that Thunderforest maps (and all others) need
to be added to policy.connect_src as well.
Although the download is triggered, the resulting PNG file disappears into
nowhere.
--
Reply to this email
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Now I'm getting _Error - Missing or invalid token_, which makes sense because
we're not sending any cookies across.
I'm not even sure this works. fetch is using credentials option "same-origin"
by default, and even "include: alwa
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I'm using the code below, which includes `Access-Control-Request-Headers:
x-csrf-token,x-turbo-request-id` in the request.
The preflight fails, because we're not allowing these headers:
Reason: header ‘x-csrf-token’ is not allowe
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
https://render.openstreetmap.org/cgi-bin/export seems to return multiple /
deviating Access-Control-Allow-Origin headers:
https://github.com/user-attachments/assets/1f78a339-2e67-4639-bba6-a251cd67bf1a";
/>
https://github.com/u
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> is it preflighting because this will switch to POST or because of the cookie
> or something
In the AJAX case, it's the second (GET) request on render.osm.org that triggers
the preflight request.
--
Reply to this email di
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> During preflight the export script shouldn't look at cookies because it won't
> receive any cookies.
Agreed, the script isn't handling preflight requests properly at the moment.
Maybe Apache could also return something for OPT
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> the cookie is going to be valid if I exported on osm.org recently
I think the TOTP cookie is valid for an hour or so. I'm also testing locally by
running an export on osm.org to get a valid token, then continue with local
test
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> Would it? Is it even required by the exporter?
Yes, it's explicitly checked here:
https://github.com/openstreetmap/chef/blob/master/cookbooks/tile/templates/default/export.erb#L179-L183
--
Reply to this email directly or view
@mmd-osm commented on this pull request.
> @@ -15,7 +15,15 @@
data[:token] = token.token
end
data[:locale] = ID::LOCALES.preferred(preferred_languages).to_s
- data[:asset_map] = assets("iD").to_json %>
+ data[:asset_map] = assets("iD").to_json
+
+ # Include user preferences fo
mmd-osm left a comment (openstreetmap/openstreetmap-website#6137)
Did you plan to integrate the language selector as well, to show the `lang_en`
text version? I think this would be a nice addition, and frequently requested
since about 1872.
https://github.com/user-attachments/assets/b00ccc41-7b
@mmd-osm commented on this pull request.
> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
So the button is set to disabled in the setTimeout function below.
```javascript
$document.on('submit.rails', rails.formSubmitSelector, function(e) {
var form = $(this),
remote = rails.isRemote(form),
blan
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The click.rails event seems to be handled by jquery-ujs
(https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L524-L551).
There's also some code in place to re-enable form elements, but my debugger
isn't stopping there. I
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think what you describe is documented here:
https://turbo.hotwired.dev/handbook/drive#form-submissions
_During a submission, Turbo Drive will set the “submitter” element’s
[disabled](https://developer.mozilla.org/en-US/docs/Web
mmd-osm left a comment (openstreetmap/openstreetmap-website#6170)
> cgimap update is supposedly ready now
Right, PR https://github.com/zerebubuth/openstreetmap-cgimap/pull/510 is ready
to be merged.
My proposal to move ahead is as follows:
- Merge Rails part of the solution, which includes d
@mmd-osm pushed 1 commit.
85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/456ff4dfced1ee743bd2e3b0b9b51eae7cd31298..85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f
You are receiving this
@mmd-osm pushed 1 commit.
456ff4dfced1ee743bd2e3b0b9b51eae7cd31298 Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/6c4103c3b5f738a1813faf93d2a11aeb9da0f9b3..456ff4dfced1ee743bd2e3b0b9b51eae7cd31298
You are receiving this
mmd-osm left a comment (openstreetmap/openstreetmap-website#6191)
I'm using something similar that creates a few sample users + also registers an
app for JOSM: https://gist.github.com/mmd-osm/a3a0b5a8799a333e7fae578038aa7a93
I'm also generating a doorkeeper_signing_key in that script and add it
Once a user clicks on "Download" Image, there's currently no
visual feedback that anything happens. Since the image generation may take a
few seconds, a user may be tempted to hit the download button multiple times.
This PR disables the button as soon as a hits the download button, similar to
t
mmd-osm left a comment (openstreetmap/openstreetmap-website#6189)
I've tested your code, and for me color replacement is working ok. I also put
in some debug code in both library methods, and they're being called when
loading the page.
https://github.com/user-attachments/assets/470cba90-5f5d-4a
I was expecting `:rel => "noopener"` to be sufficient to prevent this sort of
issue. I found 1 or 2 places where this attribute isn't set. Can you maybe
comment if adding this attribute would have helped here, irrespective of adding
the COOP header?
--
Reply to this email directly or view it o
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
The issue here is that there's no client in every case. As an example, the
export feature on osm.org
(https://www.openstreetmap.org/export#map=13/51.48630/-0.08583) delegates the
download to
https://www.openstreetmap.org/api/0.6
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
We could change the text to "planet.osm.org". Adding a link is not a good idea
because the message originates from cgimap, and returned as plain text.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
mmd-osm created an issue (openstreetmap/openstreetmap-website#6186)
Sometimes diary discussions are not rendered underneath the diary post, as
shown on the screenshot below.
https://github.com/user-attachments/assets/3130625b-11ef-4f45-b23e-3c3f9cdd5788";
/>
Sample page: https://master.apis.d
mmd-osm left a comment (openstreetmap/openstreetmap-website#6173)
I'd suggest to check the respective repos instead, such as
https://github.com/facebook/Rapid/issues/1722
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6173#iss
mmd-osm left a comment (openstreetmap/openstreetmap-website#6119)
Adding
```css
.select_language_dialog {
display:none
}
```
to
https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/stylesheets/print.scss
should fix this.
--
Reply to this email directly or view it o
mmd-osm created an issue (openstreetmap/openstreetmap-website#6177)
I have to admit that I lost track at which point we have introduced dynamic
colors for changeset bounding boxes on the map. In any case, the changeset
color hint bar as shown in the screenshot below doesn't match these dynamic
mmd-osm left a comment (openstreetmap/openstreetmap-website#4109)
> _aggressively parallelizing_
Whatever this means in detail, it doesn't sound like it is covered by the [API
Usage policy](https://operations.osmfoundation.org/policies/api/).
--
Reply to this email directly or view it on GitHu
mmd-osm created an issue (openstreetmap/openstreetmap-website#6172)
### URL
_No response_
### How to reproduce the issue?
* We're starting on a page that supports paging (so either diaries or traces)
and navigate to an older entry. The resulting URL in the browser window is then
something lik
Well, they’re all using the same osm-auth library under the hood:
https://github.com/osmlab/osm-auth/network/dependents
HOT Tasking Manager is another much used site on the list that doesn’t seem to
work anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
This seems to break sites that are using a popup to sign in to OSM, like this
example: https://osmlab.github.io/osm-auth/
Error message: Uncaught TypeError: can't access property "authComplete", opener
is null
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
mmd-osm left a comment (openstreetmap/openstreetmap-website#6154)
I’ve frequently seen hanging test runs in cgimap, which turned out to be
related to a used up quota. The job was being silently killed, and eventually
hit the timeout, although it’s been dead for some minutes already. You should
mmd-osm left a comment (openstreetmap/openstreetmap-website#6139)
I think this has been forever this way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6139#issuecomment-3014331983
You are receiving this because you are subscr
mmd-osm left a comment (openstreetmap/openstreetmap-website#6138)
> I also did not manage to get an OAuth setup going locally for proper
> debugging (I don't have
> https://www.openstreetmap.org/.well-known/openid-configuration locally for
> some reason).
This topic came up recently:
https://
mmd-osm left a comment (openstreetmap/openstreetmap-website#6135)
This has already been implemented in #5403. Obviously some parameters would
have to be set to make this work. So not an issue for this repo but more of an
operations issue.
--
Reply to this email directly or view it on GitHub:
h
mmd-osm left a comment (openstreetmap/openstreetmap-website#6127)
According to https://www.mediawiki.org/wiki/Wikibase/API/en the endpoint
supports multiple ids in one request, separated by a pipe character. Since we
anyway know all ids upfront, we could do with a single page update (=less
flic
mmd-osm left a comment (openstreetmap/openstreetmap-website#6123)
You need to report issues regarding the built in iD editor in the following
place: https://github.com/openstreetmap/iD/issues
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
mmd-osm left a comment (openstreetmap/openstreetmap-website#6082)
> [github](https://github.com/CEPT-VZG/digipin)
This reference implementation is written in Javascript and would have to be
converted to Ruby (which is trivial thanks to LLMs). However, there are no unit
tests in the original rep
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058)
@1ec5: this change is probably only relevant for developers running their local
Rails instance. The code is not used in production.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
https://dupnotes.webmapping.cyou/creator_om.html has a few examples like
https://www.openstreetmap.org/note/4806005 and
https://www.openstreetmap.org/note/4806010 where the user has added additional
text "It is now changed to Bel
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
@AntonKhorev : the main issue here is about creating multiple identical notes
(same lat/lon & note description), presumably as a result of some technical
glitch. I don't think we would end up with that many identical notes for the
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
By the way, calling the original Rails code returns the following result:
```
QuadTile.tile_for_point(35.2000381, 114.6629926)
=> 3875963095
```
This matches:
```
id | latitude | longitude | changeset_id | visible |
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
> Here are some stats https://dupnotes.webmapping.cyou/ with a [subset of
> Organic Maps duplicated
> notes](https://dupnotes.webmapping.cyou/organic-maps/om-dupe-notes.json). So
> it is still an issue.
One thing I find interest
mmd-osm left a comment (openstreetmap/openstreetmap-website#2201)
In the meantime, there are Gems like https://github.com/julik/idempo available
that implement idempotency more generically (untested).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
Also, please stop spamming unrelated repos:
https://github.com/openstreetmap/iD/issues/11132
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6099#issuecomment-29
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
What you probably want are idempotent API endpoints like we’ve been discussing
in #2201
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6100#issuecomment-2972565
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099)
No idea what you’re trying to achieve. Why don’t you use the API or some
external tool like osmosis to load the data. It seems very odd that you’re
fudging with the tile field calculation.
--
Reply to this email directly or vie
mmd-osm left a comment (openstreetmap/openstreetmap-website#6098)
https://github.com/openstreetmap/openstreetmap-website/blob/4989c1fd8e2245fa9212c879a10630cc159c52da/app/models/concerns/geo_record.rb#L37
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/open
mmd-osm left a comment (openstreetmap/openstreetmap-website#6091)
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Profiles.show.social+links.title
and
https://translatewiki.net/w/i.php?title=Special:Search&search=Osm:Activerecord.attributes.user.company
appear to be the correc
mmd-osm left a comment (openstreetmap/openstreetmap-website#6091)
"Home location name" doesn't appear to be translated at all, try
https://www.openstreetmap.org/profile?locale=fr or
https://www.openstreetmap.org/profile?locale=de
--
Reply to this email directly or view it on GitHub:
https://gi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
https://github.com/openstreetmap/openstreetmap-website/issues/5950#issuecomment-2830201587
has some previous discussion on this topic.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
https://josm.openstreetmap.de/changeset/18991/josm talks about leveraging [RFC
8414](https://datatracker.ietf.org/doc/html/rfc8414) to determine
authorization_endpoint and token_endpoint fields. I think that's more of a
convenien
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
The issue is that JOSM requires the /.well-known/oauth-authorization-server
endpoint to be around, and for some reason Doorkeeper disables this endpoint
unless you define a doorkeeper_signing_key. That's mostly in place so that JO
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
Did you configure doorkeeper_signing_key in your settings.local.yml?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927568676
You are receivin
mmd-osm left a comment (openstreetmap/openstreetmap-website#2185)
I'm not seeing any error messages on Rails 8 anymore in case
config/settings.local.yml is missing. Is this working as expected? Maybe we
could remove the respective section in the readme file now.
--
Reply to this email directly
mmd-osm left a comment (openstreetmap/openstreetmap-website#1602)
@tomhughes : the PR is quite old... `bundle exec rails test` seems to work
without deadlock_retry Gem these days. Was there some other reason to add it
back then? Can we retire it?
--
Reply to this email directly or view it on
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058)
How much faster is this now compared to the original version?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-2916602284
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
I think this was already in place for quite some time, and looks like this
example: https://en.osm.town/@mapcomplete_edits/114543361361396417
In case people maintained a link to their mastodon account on their osm
profile, they w
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
Ok, please ignore my previous comment. Your bot was relying on the fact that
users put in a social media link in their profile description text, which you
were able to obtain from the description.
With the recent changes, users w
mmd-osm left a comment (openstreetmap/openstreetmap-website#6054)
I'd say, Mastodon links look almost the same as before:
Old:
```
[Edit your OSM profile], make it include My fediverse acount
```
New:
```
https://en.osm.town/@username";>
```
So there's still the "ref="...me" in place. The que
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038)
I also haven't addressed this bit yet:
https://github.com/openstreetmap/openstreetmap-website/blob/dcd886e3e37af9b5f0003aec0563eef5a7b02c1e/app/controllers/users_controller.rb#L142-L146
Should we remove it? It seems to be some sor
@mmd-osm pushed 1 commit.
706d167f08d9a5e6eaa55f024e346146e6bfb1f5 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/a52b33ba96918d3523c9c6e91c1cf218b50e9e25..706d167f08d9a5e6eaa55f024e346146e6bfb1f5
You are receiving this be
@mmd-osm commented on this pull request.
> @@ -24,9 +24,8 @@
:include_blank => t("auth.providers.none"),
:hide_label => true,
:wrapper => { :class => "col-auto mb-0" } %>
- <%= f.text_field(:auth_uid, :hide_label => true, :wrapper
@mmd-osm commented on this pull request.
>$("input#user_avatar").on("change", function () {
$("#user_avatar_action_new").prop("checked", true);
});
- function enableAuth() {
-$("#auth_prompt").hide();
-$("#auth_field").show();
-$("#user_auth_uid").prop("disabled", fals
@mmd-osm commented on this pull request.
><% end -%>
<% end %>
-
- <%# :tabindex starts high to allow rendering at the bottom of the template %>
- <%= form_tag auth_path(:provider => "openid"), :id => "openid_login_form",
:class => "collapse" do %>
-
-
-<%=
mmd-osm left a comment (openstreetmap/openstreetmap-website#6038)
Regarding the `preferred_auth_provider`, I was looking for the exact URL to
trigger the different layout. It seems I need to include this parameter along
with the respective auth provider in the referer parameter:
* http://localh
This pull request adds human readable HTTP 509 rate limiting error messages.
Before:
After:
You can view, comment on, or m
@mmd-osm pushed 1 commit.
a52b33ba96918d3523c9c6e91c1cf218b50e9e25 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/d9c9ea5f1cfa553da2bbc8586a1e83ae60271183..a52b33ba96918d3523c9c6e91c1cf218b50e9e25
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
Okay, I see what you mean. Obviously this particular feature will only be
relevant to a very small group, if at all. You can be assured that we
re-evaluate features from time to time and remove them when they are no longer
releva
@mmd-osm pushed 1 commit.
d9c9ea5f1cfa553da2bbc8586a1e83ae60271183 Remove legacy OpenID login
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6038/files/42f4bfc9e341d20275c6a096167acb9cc39a2f49..d9c9ea5f1cfa553da2bbc8586a1e83ae60271183
You are receiving this be
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
Not sure what exactly your point is, `not_public_flash` is still in use:
https://github.com/openstreetmap/openstreetmap-website/blob/1b63e9e16dff92df226aed707058b7228527bc6e/app/controllers/site_controller.rb#L100
--
Reply to thi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036)
@Nikerabbit : thanks a lot for the super quick fix, much appreciated!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901964263
You are receivi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6036)
Maybe @Nikerabbit could help here from TranslateWiki side?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6036#issuecomment-2901866257
You are receiving this bec
mmd-osm left a comment (openstreetmap/openstreetmap-website#6023)
Let's close this one, the issue has been fixed in the meantime.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6023#issuecomment-2901870479
You are receiving thi
### Description
Fixes #6020
### How has this been tested?
Scenarios tested on local instance:
1. GitHub as single third party provider
- Log in / Sign up
- Change external authentication on "My Account" from
"Github" to "None", and back to "Github", check
log in process
2. No third party prov
mmd-osm left a comment (openstreetmap/openstreetmap-website#6035)
https://wiki.openstreetmap.org/wiki/Anonymous_edits has some more background.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6035#issuecomment-2899942196
You are
mmd-osm left a comment (openstreetmap/openstreetmap-website#6028)
> Here's some other people reporting it on the community forums:
https://community.openstreetmap.org/t/actual-problems-with-id-editor/130320/2
At least some users mentioned in
https://community.openstreetmap.org/t/current-problems
mmd-osm left a comment (openstreetmap/openstreetmap-website#6020)
@tomhughes: So the issue with the current code seems to be related to
ruby-openid, which has been archived a couple of years ago:
https://github.com/openid/ruby-openid
During callback processing, the user session no longer includ
mmd-osm left a comment (openstreetmap/openstreetmap-website#6028)
Isn't that similar to #5987?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6028#issuecomment-2892302476
You are receiving this because you are subscribed to thi
mmd-osm left a comment (openstreetmap/openstreetmap-website#6022)
We never see these screenshots images taken when something is failing:
`[Screenshot Image]:
/home/runner/work/openstreetmap-website/openstreetmap-website/tmp/screenshots/failures_test_translated_links.png`
https://dev.to/ugifract
mmd-osm left a comment (openstreetmap/openstreetmap-website#6021)
Yes, I've also seen that. I gave it a try, seems to be working ok on Chrome:
--
Reply to this email directly or view it on GitHub:
https://
mmd-osm left a comment (openstreetmap/openstreetmap-website#6021)
Same results here: Chrome Version 128.0.6613.84 on Linux x64 is failing,
Firefox is ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6021#issuecomment-2888348
mmd-osm created an issue (openstreetmap/openstreetmap-website#6020)
Before starting a new PR, I wanted to get some feedback, if this login option
is working, and if anyone is still using it? My impression is that it is in
some broken state for quite a while. I would therefore suggest to remove i
1 - 100 of 325 matches
Mail list logo
