tomhughes left a comment (openstreetmap/openstreetmap-website#6207)
Ah it's being used in the new wikidata stuff and I guess it could possibly skip
showing the language name if that interface wasn't available but that only
resolves this immediate problem and fundamentally you're using a browser
tomhughes left a comment (openstreetmap/openstreetmap-website#6207)
So `Intl.DisplayNames` was only added by Firefox in version 86 which is likely
why you don't have it but as our baseline for javascript is ES2021 it's not
surprising that what is essentially a 2017 browser doesn't support everyt
tomhughes left a comment (openstreetmap/openstreetmap-website#6207)
If I understand the wikipedia page correctly the browser you're using is based
on Firefox 52 from 2017 and whilst I'm sure they may have added some features
since I'm sure there is no way they have kept up with the feature sets
tomhughes left a comment (openstreetmap/openstreetmap-website#6207)
I think it's unlikely there is much we can do - it really sounds your browser
is just too ancient I'm afraid. We have to strike a balance between supporting
a tiny handful of users using old browsers and being able to use modern
Merged #6191 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6191#event-18703881935
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6205 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6205#event-18703881910
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6205)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6205#issuecomment-3090011640
You are receiving this because you are subscribed to this t
@tomhughes approved this pull request.
Thanks. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6191#pullrequestreview-3034138740
You are receiving this because you are subscribed to this thread.
Mes
Merged #6206 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6206#event-18703772238
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6203 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6203#event-18703772283
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6204 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6204#event-18703772281
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6206)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6206#issuecomment-3089990012
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6204)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6204#issuecomment-3089984492
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
The python cgi library is weird and the form object it returns for the options
request doesn't work at all so we now ignore it.
We need to find a replacement anyway as the latest python release has dropped
it :-(
--
Reply to
@tomhughes requested changes on this pull request.
> @@ -57,6 +57,19 @@ There are two built-in applications which communicate via
> the API, and therefore
* iD
* The website itself (for the Notes functionality)
+You can register them by running a script and copying its output to
`config/se
tomhughes left a comment (openstreetmap/openstreetmap-website#5884)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884#issuecomment-3084751221
You are receiving this because you are subscribed to this t
Merged #5884 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884#event-18684218340
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
I've pushed a change to use the `token` parameter from the URL as the token if
there is no cookie.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomm
Merged #6200 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6200#event-18683857194
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5758 as completed via #6170.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5758#event-18683857725
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6170 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6170#event-18683857195
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6170)
This looks good to me, thanks, and it sounds like we're good to merge and
deploy it per @mmd-osm's plan.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6170#iss
tomhughes left a comment (openstreetmap/openstreetmap-website#6200)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6200#issuecomment-3084666378
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
I've updated this to send the full head by using our own layout...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187#issuecomment-3080050993
You are receiving
@tomhughes pushed 2 commits.
0b805abec2ef24ef6f493b730729c1de60103661 Use a minimal layout for turbo frame
renders
9ee3f3f83bcd98b7b15103f1bd74578c29338af1 Don't do partial renders for turbo
page visits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187/fi
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
Well yes I considered doing that as I said and it would be easy enough if
people prefer to go that way.
I don't see any point in limiting it to specific requests though - surely the
mechanism here that does it automatically for
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Maybe we should allow the token to be sent as a parameter instead of a cookie?
Would it be possible to send it that way?
The thunderforest layers are the only other ones which allow export so they're
the only ones that will nee
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Those should be allowed now...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3079806615
You are receiving this because you are subscribed to t
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Yes I'm just pushing a fix for that...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3079740395
You are receiving this because you are subscri
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Hopefully
https://github.com/openstreetmap/chef/commit/4f3db0dc494a192aab6c24fea6f81c23875d2bf3
will do the necessary to allow the preflight check.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
Merged #6198 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6198#event-18663602260
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6189 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#event-18663602249
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5776 via #6189.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776#event-18663602491
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
@tomhughes commented on this pull request.
> @@ -0,0 +1,25 @@
+# A map of each OSM key to its formatter URL. For example:
+# { "ref:vatin" => "https://example.com/$1"; }
+TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
Why do we ne
tomhughes left a comment (openstreetmap/openstreetmap-website#6189)
Thanks for working on this... I think it looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-3079353187
You are receiving this becau
tomhughes left a comment (openstreetmap/openstreetmap-website#6198)
That's what I thought it was supposed to do but for some reason it didn't seem
to be doing that when I tried it.
Today it does seem to be working though so I must have been doing something
wrong!
--
Reply to this email direct
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
> CORS still wouldn't work though, until render.openstreetmap.org supports
> preflight requests.
That shouldn't be hard to fix if we need to - is it preflighting because this
will switch to POST or because of the cookie or some
@tomhughes commented on this pull request.
> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/inde
tomhughes left a comment (openstreetmap/openstreetmap-website#6198)
What exactly is this supposed to change? Because I can't manage to find
anything that's behaving differently with it merged...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap
@tomhughes commented on this pull request.
> @@ -0,0 +1,24 @@
+# A map of each OSM key to its formatter URL. For example:
+# { "ref:vatin" => "https://example.com/$1"; }
+TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
+ # So, conv
Merged #6196 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6196#event-18625870951
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #6186 as completed via #6196.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6186#event-18625871610
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#6196)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6196#issuecomment-3071015846
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Like I say it won't help anyway with the current code but I turned on event
logging to see if there was an event we could use and I say an event being
fired from rails form submission code and it looked like it had code to
re-e
tomhughes left a comment (openstreetmap/openstreetmap-website#6195)
They may not be used - there's a section of the translations that just gives a
name for each model class which rails will sometimes use in messages or as a
default value for buttons and things but it's quite possible some are ne
Closed #6195 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6195#event-18622155307
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Merged #6194 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6194#event-18621299795
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
I think it definitely needs more work on the re-enablement but I'm not sure
there's a good way to do it without changing the way the download works.
I'm not actually sure that you even need that code as I think rails does it
al
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
I've added that in now although I don't think it's a perfect solution - it
restore the CSRF meta tags which is the immediate problem here but there's lots
of other stuff that gets lost from the `head` element.
In principle the
@tomhughes pushed 2 commits.
b973bd1d67916d0de4beee0aa0e8261272f981d3 Use a minimal layout for turbo frame
renders
1e7010d0855846a2959878d4654c49fdb16dcb19 Don't do partial renders for turbo
page visits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187/fi
Merged #6184 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184#event-18606649196
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6191)
This should probably be a rake task in `lib/tasks` I think... I keep meaning to
convert the current random tools in `scripts` to be proper tasks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
@tomhughes commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+ en
@tomhughes commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase =
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Yes I was looking at that
@tomhughes commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase =
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Sure. I wonder why the URL
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Is there an api key I can use for testing? You can let me have it privately if
you prefer...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-30
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
The problem with making th
@tomhughes commented on this pull request.
> @@ -0,0 +1,7 @@
+require Rails.root.join("lib/svg_to_symbol_transform.rb")
+require Rails.root.join("lib/replace_magenta_svg_color.rb")
I'd probably just put the custom transform classes inline here rather than
putting them in `lib` especially as au
tomhughes left a comment (openstreetmap/openstreetmap-website#6189)
Yes if you change initialisers you need to restart and they're only run once at
startup.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-306681
As
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cross-Origin-Opener-Policy
explains `rel=noopener` doesn't affect things opened with `window.open()`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
No you're right that you don't have to send the whole page - you can do `render
"_page"` to render the template but not as a partial but you still get the
whole of the layout so you don't really save much.
Yes I guess your solu
tomhughes left a comment (openstreetmap/openstreetmap-website#5880)
I've read through all the comments on this issue and also had a look at
@hlfan's work in #5938 and on the whole I think that I have to agree with
@gravitystorm and @hlfan that it would better if we could keep the SVGs
separate.
Setting `turbo-action=advance` as our pagination helper does causes a frame
navigation to be [promoted to a page
visit](https://turbo.hotwired.dev/handbook/frames#promoting-a-frame-navigation-to-a-page-visit)
which means turbo will try and [merge the head
elements](https://turbo.hotwired.dev/ha
@tomhughes commented on this pull request.
>
+---
+
+**Platform Support:** These instructions are based on Ubuntu 24.04 LTS, which
is the platform used by the OSMF servers. The instructions also work, with only
minor amendments, for all other current Ubuntu releases, Fedora and macOS.
The O
tomhughes left a comment (openstreetmap/openstreetmap-website#6182)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6182#issuecomment-3065095455
You are receiving this because you are subscribed to this t
Merged #6181 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6181#event-18599066638
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6182 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6182#event-18599066637
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6181)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6181#issuecomment-3065087328
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6185)
Note that even ignoring #6184 this may be affecting some bootstrap rules that
use placeholder matches.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6185#issue
@tomhughes requested changes on this pull request.
In addition to my inline comment there's a separate issue on Firefox which I've
opened #6185 for.
> @@ -556,6 +556,10 @@ header .search_forms,
.search_form {
.describe_location {
font-size: 10px;
+
+input:not(:placeholder-shown) + .
While reviewing #6184 I discovered a problem with Firefox causing by
autoprefixer adding a `-moz-placeholder` rule alongside the `placeholder-shown`
rule.
The details are discussed in
https://github.com/postcss/autoprefixer/issues/1533 but basically Firefox has
supported `placeholder-shown` si
Merged #6183 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6183#event-18598851506
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6179 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6179#event-18591838967
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6179)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6179#issuecomment-3063263382
You are receiving this because you are subscribed to this t
Merged #5706 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5706#event-18591308937
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6178 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6178#event-18591308966
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6178)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6178#issuecomment-3063166569
You are receiving this because you are subscribed to this t
Merged #6180 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6180#event-18591308951
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the extra tests. I think this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5706#pullrequestreview-3011280535
You are receiving this because you are subscribed
tomhughes left a comment (openstreetmap/openstreetmap-website#6180)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6180#issuecomment-3063106035
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6154)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3058816461
You are receiving this because you are subscribed to this t
Merged #6154 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#event-18572612596
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6066)
Err That must have been an accidental push to the wrong repo. I'll delete
it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6066#issuecomment-3058808256
Yo
tomhughes left a comment (openstreetmap/openstreetmap-website#3815)
Are you suggesting that maintainers have been merging their own PRs? I can only
think of one case of that in the last year or so?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Merged #6176 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6176#event-18569567989
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6174 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6174#event-18569567951
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #4191 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4191#event-18569568059
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#4191)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4191#issuecomment-3058102990
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6176)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6176#issuecomment-3058094957
You are receiving this because you are subscribed to this t
Closed #6175.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6175#event-18538692422
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
I've explained the high level reason - we received a vulnerability report that
needed to be acted on urgently.
The specific issue is that if a malicious site can open a window on
openstreetmap.org and continue to interact with it then it can observe login
flows and steal sensitive information.
As I explained above this resolves a critical security vulnerability and cannot
be reverted.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a16074103cd9#commitcomment-161621856
You are receiving this
Looks like rapid is the same issue and an equally horrible user interface.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a16074103cd9#commitcomment-161613711
You are receiving this because you are su
So in the case of https://osmlab.github.io/osm-auth/ it looks like the problem
is that final redirect page is trying to access the parent page to pass the
authorization code back but I can't see any value for the COOP header that
would allow that while not allowing the parent to interfere with t
I will need to understand further what the exact requirements of those sites
are to determine if a solution is possible but for important security reasons
we cannot revert to the previous behaviour.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
Merged #6171 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6171#event-18509290028
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6171)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6171#issuecomment-3045869275
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6169)
Is this when you are logged in, or logged out?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6169#issuecomment-3037062393
You are receiving this because you a
1 - 100 of 1684 matches
Mail list logo
