tordans left a comment (openstreetmap/openstreetmap-website#6138)
> > You also still haven't explained why your site appears to be doing the
> > authorize flow via fetch in javascript which is really weird and which is
> > breaking some browsers
>
> I cannot reproduce the issue you had with Fir
@tordans pushed 1 commit.
5c63390f699335b8d422a1ca3b7baa3e6a57619f Remove code comment
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6138/files/0e160369a76b968b4fc71468f06506aabe8693c7..5c63390f699335b8d422a1ca3b7baa3e6a57619f
You are receiving this because y
@tordans commented on this pull request.
> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
before_action :require_cookies, :only => [:confirm]
def confirm
+# The post happens in confirm.html.erb and user.js
```suggestion
```
--
Reply to this email directly
tordans left a comment (openstreetmap/openstreetmap-website#6138)
> You also still haven't explained why your site appears to be doing the
> authorize flow via fetch in javascript which is really weird and which is
> breaking some browsers
I cannot reproduce the issue you had with Firefox on my
@tordans commented on this pull request.
> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
before_action :require_cookies, :only => [:confirm]
def confirm
+# The post happens in confirm.html.erb and user.js
Please feel free to improve the wording and even rem
tordans created an issue (openstreetmap/openstreetmap-website#6141)
I think we should document how to setup OAuth locally the same way it work on
staging and production servers. The main thing that is different ATM is that
https://www.openstreetmap.org/.well-known/openid-configuration is missin
Closes https://github.com/openstreetmap/openstreetmap-website/issues/6130
Someone helped me debug
https://github.com/openstreetmap/openstreetmap-website/issues/6130 and this
change fixes the issue.
The OAuth process starts as a GET and becomes a POST by submitting the form
below in JS automati
tordans left a comment (openstreetmap/openstreetmap-website#6130)
Another part that is weird is, that in some tests I have a different return URL
after using the confirmation link: Instead of getting the welcome page, I get
directed to the map (without flash message and without being logged in).
tordans left a comment (openstreetmap/openstreetmap-website#6130)
> Do you have any idea when it changed?
Unfortunately not. I know that it worked when we had the old design because
that is when we documented the flow in a PDF.
I looked at the history a bit but nothing stood out to me.
> I thi
tordans created an issue (openstreetmap/openstreetmap-website#6130)
### URL
_No response_
### How to reproduce the issue?
I am having trouble with our registration workflow. It used to redirect users
back to our application. Now it returns them to the osm.org map.
(Logging into an existing ac
tordans created an issue (openstreetmap/openstreetmap-website#5810)
I am very happy to see
https://github.com/openstreetmap/openstreetmap-website/pull/5402 merged and
live. Congratulations!
I want to suggest to add a bit of space, a headline and maybe a subheadline
above the new element to gi
UX thoughts:
- Do we want users to be able to disable this feature in their profile? – I am
not a fan of this kind of configurations, but we do give a lot more visibility
to once activity with this that we had before and the page is public (AKA no
login required).
- How do we want to handle the
> > Ping https://github.com/openstreetmap/openstreetmap-website/issues/5356
> > which looks like the ambrella issue for this.
> Thanks for suggestion but in the end i ended up just mocking data in the
> database locally. Since the table is indexed it should not present issues
> performance wise.
@tomhughes Thanks. Is there capacity to improve the handing of this error case
by showing the "we are in readonly" message in step 1 of the oAuth process so
users don't run into the uncaught 500?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
Ping https://github.com/openstreetmap/openstreetmap-website/issues/5356 which
looks like the ambrella issue for this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5373#issuecomment-2544945799
You are receiving this because yo
We are seeing the same issue.
OSM is in Readonly-Mode https://en.osm.town/@osm_tech/113656639378201391 but
since I can log into the website, the readonly has to be only for certain parts
of the website. I assumed the Rails parts would work but the editing part
wouldn't. But then again commentin
@AntonKhorev just a quick reminder that we will have to re think the dropdown
as well as the settings once
https://github.com/openstreetmap/operations/issues/877 is resolved and we can
finally talk about adding more mobile editors to the UI. The discussion on this
[seems to be
ongoing](https:/
Closed #4839.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4839#event-15489846328
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
18 matches
Mail list logo
