> giving space to something like this
There was the [suggestion to put the configuration into the
preferences](https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2477533827),
and I kind of like it. Maybe a dropdown that allows you to choose how you'd
like it to be. (T
Closed #5325.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5325#event-15316401315
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@scy commented on this pull request.
> + const darkModeMenuItems = [
+{
+ name: "brightness100",
+ filter: "none"
+},
+{
+ name: "brightness80",
+ filter: "brightness(.8)"
+},
+{
+ name: "brightness60",
+ filter: "brightness(.6)"
+},
+{
Let me start by saying that yes, I'm disappointed, but I don't mean to hate. I
understand that you're all busy, and that this is volunteer work. I'm not
expecting anything from you. Please read my comments more as feedback on how I
feel and how things are looking like from my end, written in the
It seems pretty clear to me that this PR is not going to get merged. Instead,
#5330 is being fast-tracked, because "making it a little less dim" is assumed
to clearly fix everyone's problem with the changes.
Meanwhile, #2332 is being closed, with the suggestion being that people just
make their
@scy commented on this pull request.
> @@ -504,7 +504,13 @@ body.small-nav {
@include color-mode(dark) {
.leaflet-tile-container,
.mapkey-table-entry td:first-child > * {
-filter: brightness(.8);
+filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);
This PR isn'
@scy commented on this pull request.
> @@ -504,7 +504,13 @@ body.small-nav {
@include color-mode(dark) {
.leaflet-tile-container,
.mapkey-table-entry td:first-child > * {
-filter: brightness(.8);
+filter: invert(100%) hue-rotate(180deg) brightness(95%) contrast(90%);
It doesn't l
> We're not going to be merging anything in a hurry anyway so talk of a
> "hotfix" or of not having time to do things properly is not helpful.
In that case, please revert the dark mode, and I'll close this PR.
I'm proposing this change as a service to the community, with multiple people
having
> how does it look with the other map styles?
![image](https://github.com/user-attachments/assets/1143154e-f2a8-4d4a
> This "feauture" should at minimum be opt-in.
I agree, but that is out of scope for this issue. It would need JavaScript
changes (basically the [code from the Bootstrap
docs](https://getbootstrap.com/docs/5.3/customize/color-modes/#javascript)) and
an additional UI element. That's no longer a
As an alternative to reverting, I have created PR #5325 as a quick fix that
basically uses one of the filters from this issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2477469696
You are receiving this b
### Description
This is basically a hotfix to address the dark mode rollout from today. I'm
new to contributing here and kind of in a hurry, sorry in advance if anything
in this PR isn't perfect.
The current implementation of dark mode is already pretty good, but the tile
display (i.e. the actu
12 matches
Mail list logo
