Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-13 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) Sorry if my commit history has been a tad untidy as I am pretty new to contributing to OSM. I have just removed my change in the en-GB.yml file as it is not needed. I am also open to any suggestions on how to tidy up thi

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
@Jimmykhangnguyen pushed 1 commit. ae999db12fd14f444a82e43145b3fdd5e36c5460 Revert grammatical changes to "log-in" in en-GB.yml -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784/files/cefda7e5db50dd9084703c37c9712c9f0b52aa83..ae999db12fd14f444a82e43145b3fdd

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) Oh that's a great idea for some extra practice. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#issuecomment-2714663561 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Closed #5784. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#event-16689864834 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Reopened #5784. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#event-16689838362 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailin

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) I see, thank you for the tips! I'll keep them in mind for future contribution! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#issuecomment-2714632397

[openstreetmap/openstreetmap-website] Fixed the grammatical mistake regarding the hyphen in "sign-up" and "log-in" mentioned in Issue #5772 (PR #5792)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
### Description I've sent up this change again as I messed up the Git flow for my last PR. Hopefully this will not need any further changes!

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
@Jimmykhangnguyen pushed 10 commits. e241d1d938309a8e4e6772113d650b6a43b2ea78 Localisation updates from https://translatewiki.net. cb4060bb2e2f94e4939608303e422366a97d0300 Order issue reports by id 66b93a1a7e0bfeb7a49d928c3c9ea28e03376f26 Show dates of reported items on issue pages c8b23418f0

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) At this point, I'll just close this Pull Request and send up a cleaner one! Sorry for the untidy PR! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-11 Thread Ngoc Phuc Khang Nguyen via rails-dev
Closed #5784. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5784#event-16687052635 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-10 Thread Ngoc Phuc Khang Nguyen via rails-dev
@Jimmykhangnguyen pushed 2 commits. 9b44996c365f4d489b50a0d44a397f5f82ecb52a Fixed the grammatical mistake regarding the hyphen in "sign-up" and "log-in" mentioned in Issue #5772 cefda7e5db50dd9084703c37c9712c9f0b52aa83 Merge branch 'typoFixIssue#5772' of https://github.com/Jimmykhangnguyen/op

Re: [openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-10 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5784) I assume "log-in" in the `setup_user_auth` section of both `config\locales\en.yml` and `config\locales\en-GB.yml` will have to be tackled. This, however, touches on the "log-in" found in `config\locales` files of other l

Re: [openstreetmap/openstreetmap-website] Sign-in > Sign in (Issue #5772)

2025-03-09 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5772) I've just sent a PR to fix this grammatical mistake. I believe the citations are sufficient and that this is indeed a grammatical mistake. Pull Request: #5784 -- Reply to this email directly or view it on GitHub: https:

[openstreetmap/openstreetmap-website] Fixed the grammatical mistake mentioned in Issue #5772 (PR #5784)

2025-03-09 Thread Ngoc Phuc Khang Nguyen via rails-dev
### Description This Pull Request is to tackle the grammatical mistake mentioned in Issue #5772. In particular, the use of "sign-in" as a noun in this context is incorrect, as it is inconsistent with the other verbs within the permission list. **Fix:** "Sign-in" has been changed to "sign in" (w

Re: [openstreetmap/openstreetmap-website] Sign-in > Sign in (Issue #5772)

2025-03-08 Thread Ngoc Phuc Khang Nguyen via rails-dev
Jimmykhangnguyen left a comment (openstreetmap/openstreetmap-website#5772) Hey! If the citation is appropriate and "Sign-in" is indeed misspelt here, I would love to be assigned this issue and send up a PR to fix it! -- Reply to this email directly or view it on GitHub: https://github.com/opens