@1ec5 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6208#pullrequestreview-3035481036
You are receiving this because you are subscribed to this thread.
Message ID:
___
A fix is pending in facebook/Rapid#1724. See the temporary workaround at
https://github.com/facebook/Rapid/issues/1722#issuecomment-3060409827.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a1607410
@1ec5 commented on this pull request.
This is another subtle difference between Special:Redirect and the MediaWiki
API, which is why the initial request for the item details doesn’t run into
this problem.
> @@ -171,8 +171,8 @@
.addClass("bg-body-tertiary");
if (icon && OSM.WIKIMED
1ec5 left a comment (openstreetmap/openstreetmap-website#6197)
Or at least preferring `osmwiki:P8` and `wikidata:P1630` as sources before
falling back to `wikidata:P3303`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6197#issu
1ec5 left a comment (openstreetmap/openstreetmap-website#5880)
Pardon my ignorance, but could someone remind me why we wound up using inline
SVGs all over in the first place? Was there a particular benefit we were aiming
for, or is it just convenient? I see some potential tangible benefits of
s
1ec5 left a comment (openstreetmap/openstreetmap-website#3815)
> A big part of that, I think, comes down to differing review criteria between
> contributors and maintainers. That’s fair to some extent, but it becomes
> frustrating when a maintainer fast-tracks their PR that renders an earlier,
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@1ec5 commented on this pull request.
> @@ -1,10 +1,16 @@
(function () {
+ let abortController = null;
+ const langs = [...new Set([...OSM.preferred_languages.map(l =>
l.toLowerCase()), "mul", "en"])];
+ const wikis = [...new Set(langs.map(l => l.split("-")[0] + "wiki"))];
Wikimedia wiki c
1ec5 left a comment (openstreetmap/openstreetmap-website#6165)
> This would make copying coordinates into development tools and code snippets
> much more convenient and reduce confusion or errors.
If one of the internal result’s labels is just regurgitating what the user
entered into the search
@1ec5 commented on this pull request.
> + icon: ["P8972", "P154", "P14"].reduce((out, prop) => out ??
> entity.claims[prop]?.[0]?.mainsnak?.datavalue?.value, null),
+ description: localizedProperty("descriptions", langs)?.value,
+ article: localizedProperty("sitelinks", wikis)
+
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
@1ec5 approved this pull request.
The logic looks correct to me. Just to confirm, does this PR result in actively
presenting pre-2019 users with some sort of notice about the new terms, without
having to visit the account settings first? If not, we still need to do that as
tail work based on th
@1ec5 commented on this pull request.
> not_agreed_with_pd: "You haven't declared that you consider your
> edits to be in the Public Domain."
-pd_link_text: "declare"
+review: "Review the Terms"
+review_and_accept: "Review and accept the Terms"
+consider
1ec5 left a comment (openstreetmap/openstreetmap-website#6127)
> Copy and pasting certainly isn't the way we want to be interacting with an
> upstream repository...
If this becomes a built-in feature, I assume it would obviate the Chrome and
Firefox plugins, right @ZeLonewolf? So probably no ne
1ec5 left a comment (openstreetmap/openstreetmap-website#6094)
Finnish, French, Guadaloupean Creole, and Punjab have long translations for
[km](https://translatewiki.net/wiki/Special:Translations?message=Osm%3ADirections.show.button+km&namespace=1222)
and/or
[mi](https://translatewiki.net/wiki/
1ec5 left a comment (openstreetmap/openstreetmap-website#5853)
> Has there been any policy decision yet?
By the way, I think this is in reference to the question in
https://github.com/openstreetmap/openstreetmap-website/pull/5706#issuecomment-2744397402
about whether the terms of service apply
1ec5 left a comment (openstreetmap/openstreetmap-website#6072)
What if we reduce the OHM icon to the outline of the map with the H centered
inside of it, similar to [the Public Domain Map
logo](https://commons.wikimedia.org/wiki/File:Public_Domain_Map_logo.svg)? This
would just be an icon anywa
@1ec5 commented on this pull request.
> @@ -12,6 +14,14 @@ def create
# ask nominatim
response = fetch_xml(nominatim_reverse_query_url(:format => "xml"))
+ # add lang attribute for frontend in certain regions
+ addressparts = response.elements["reversegeocode/addresspar
1ec5 left a comment (openstreetmap/openstreetmap-website#6065)
And with my wiki hat on, the difference is very minor with the low contrast. I
don’t expect this small deviation from the wiki’s current full-size logo to be
a problem. For those who squint, it’s just a little more legible, so it can
1ec5 left a comment (openstreetmap/openstreetmap-website#6065)
Something like an ⌛ or 🕐 or just an **H**? Otherwise, with my OHM hat on, I’d
say you can do whatever you want with the OHM logo, such as recoloring it to
sepia or defacing it with a spike to represent abandoned railways. (For what
1ec5 left a comment (openstreetmap/openstreetmap-website#6065)
> It is the logo in the wiki, idk why it isn't the favicon.
Tracking in openstreetmap/operations#1245.
> @1ec5 was involved in the discussion about it not showing up in the vector
> 2022 skin.
In [that
discussion](https://wiki.ope
1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
> Or we could leave it as an absolute timestamp and rely on JavaScript to
> relativize it on the fly.
Another advantage of client-side relative dates is that we can make them update
dynamically as you’re viewing the page. For exampl
@1ec5 commented on this pull request.
> @@ -153,6 +153,14 @@
<%= @user.home_location_name %>
<% end %>
+<% if @user.company&.strip.present? %>
+
+http://www.w3.org/2000/svg"; width="16" height="16"
fill="curre
@1ec5 commented on this pull request.
> @@ -153,6 +153,14 @@
<%= @user.home_location_name %>
<% end %>
+<% if @user.company&.strip.present? %>
+
+http://www.w3.org/2000/svg"; width="16" height="16"
fill="curre
1ec5 created an issue (openstreetmap/openstreetmap-website#6023)
### URL
https://www.openstreetmap.org/user/Minh%20Nguyen
### How to reproduce the issue?
Open certain user profile pages (can’t figure out a pattern yet).
### Screenshot(s) or anything else?
![Application error: The OpenStreetMa
@1ec5 commented on this pull request.
> +class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with =>
%r{\A(https?://.+|@([a-zA-Z0-9_]+)@([\w\-\.]+))\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.
@1ec5 commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mess
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
@1ec5 commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <% e
1ec5 left a comment (openstreetmap/openstreetmap-website#5979)
Oh! My bad. I [reverted the
change](https://wiki.openstreetmap.org/wiki/Special:Diff/2852676).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#issuecomment-28717
1ec5 left a comment (openstreetmap/openstreetmap-website#5979)
I [updated the
documentation](https://wiki.openstreetmap.org/wiki/Special:Diff/2852642) to
reflect the removal.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5979#
@1ec5 commented on this pull request.
> +#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesk
@1ec5 commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mess
1ec5 left a comment (openstreetmap/openstreetmap-website#1807)
> My suggestion for next steps is to adopt the syntax `geo:$x,$y;u=$u` as a
> Latitude/Longitude input. For example, `geo:-23.55,-46.63;u=15`.
#1123 tracks accepting a geo: URI as search input.
The topic of standing up a companion w
@1ec5 commented on this pull request.
This will make the stats much more readable at a glance.
Do we know of anything that scrapes this page and possibly expects these
numbers to remain unformatted? Does this also affect [the statistics page on
the planet site](https://planet.openstreetmap.org/
1ec5 left a comment (openstreetmap/openstreetmap-website#5991)
The welcome mat for corporate and institutional editing teams is a separate
website. Unfortunately it doesn’t appear to be translatable yet:
osmfoundation/welcome-mat#8.
--
Reply to this email directly or view it on GitHub:
https:/
1ec5 left a comment (openstreetmap/openstreetmap-website#5987)
There’s already a fairly strong disincentive to claim corporate affiliation in
at least some parts of the OSM community. 😅 Maybe optimistically linking to a
matching wiki page could help by giving the user a way to verify for
themse
1ec5 left a comment (openstreetmap/openstreetmap-website#5984)
> aren't you guys sort of competing with Google?
Only in the sense of providing geographic data about on-the-ground stuff that
others could use to create services that compete with Google. You’ve basically
asked the plumber to bake
1ec5 left a comment (openstreetmap/openstreetmap-website#5966)
> I also wouldn't say it's that common for open source projects that are
> primarily code based to go to the trouble of specifying a different license
> for artwork. I'm sure it does happen but I can't think of any examples off
> th
1ec5 left a comment (openstreetmap/openstreetmap-website#5950)
Yes, I’m looking into starting a series of posts on the forum periodically
highlighting noteworthy changes as they go in, similar to what I’ve been doing
for OpenHistoricalMap. These won’t technically be release notes, since this
pr
1ec5 left a comment (openstreetmap/openstreetmap-website#5880)
Conceivably the project could have SVGs that aren’t just paths, for example the
larger decorative image on the login screen or the occasional banner
advertisement on the homepage, in order to make it scalable or more easily
translat
@1ec5 commented on this pull request.
> @@ -10,9 +10,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
feed.logo image_url("mag_map-rss2.0.png")
feed.rights :type => "xhtml" do |xhtml|
-xhtml.a :href => "https://creativecommons.org/licenses/by-sa/2.0/"; do |a|
- a.i
@1ec5 commented on this pull request.
> @@ -10,9 +10,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
feed.logo image_url("mag_map-rss2.0.png")
feed.rights :type => "xhtml" do |xhtml|
-xhtml.a :href => "https://creativecommons.org/licenses/by-sa/2.0/"; do |a|
- a.i
@1ec5 commented on this pull request.
> @@ -10,9 +10,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
feed.logo image_url("mag_map-rss2.0.png")
feed.rights :type => "xhtml" do |xhtml|
-xhtml.a :href => "https://creativecommons.org/licenses/by-sa/2.0/"; do |a|
- a.i
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
That would seem more reasonable to me. 👍
--
Reply to t
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
> You mean at 0.1 miles?
Yep, that was a typo, fixed. T
@1ec5 commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
For what it’s worth, the [MapLibre Navigation
SDK](http
1ec5 left a comment (openstreetmap/openstreetmap-website#5882)
> I'm not sure if it's very useful because you can just share the current page
> url from the browser menu.
In Safari on macOS, a share sheet appears with a variety of options, including
shortcuts to people I’ve chatted with recentl
1ec5 left a comment (openstreetmap/openstreetmap-website#5777)
> and the `driving_side` is wrong more often.
As noted in
https://github.com/Project-OSRM/osrm-backend/issues/2269#issuecomment-357154269,
a GeoJSON of [left-hand-drive
regions](https://github.com/Project-OSRM/osrm-backend/blob/4ee
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
> Also osm.wiki could be considered another URL variant, but idk how official
> that one is.
The OSMF owns the osm.wiki domain.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
Longer comments are more likely to prompt respondents to quote individual
passages. In changeset and note discussions, this is usually a sign that the
discussion should move outside the confines of the sidebar, to either direct
mess
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
That reminds me of another detail about GitHub’s pretty-printing: if you copy
the pretty-printed text, some rich text formatting get paired with it, so that
pasting the text will result in a working link in any rich text editor or
M
1ec5 left a comment (openstreetmap/openstreetmap-website#5780)
GitHub gets around this problem by requiring a `#` in front of the number, or
the full URL. Even just detecting and linkifying the URL would be a significant
improvement.
By the way, the URL format for elements used to be slightly d
1ec5 left a comment (openstreetmap/openstreetmap-website#5819)
Right, I’ve definitely found this test useful. I’ll have to look into why it
isn’t running on Translatewiki.net PRs like OpenHistoricalMap/ohm-website#276.
I recall you’ve periodically had to go into osm-community-index to report
is
Closed #5819 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5819#event-16852904738
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
1ec5 left a comment (openstreetmap/openstreetmap-website#5819)
Sorry, the title of the issue was misleading; I changed it. This is
specifically about when a string in the YAML file includes a `%{foo}` but `foo`
isn’t one of the arguments passed into `I18n.t`.
--
Reply to this email directly or
1ec5 created an issue (openstreetmap/openstreetmap-website#5819)
Fall back to English when a string is missing from the localization or the
translation refers to a nonexistent interpolation argument.
## Rationale
Sometimes a localizable string has to get changed to a different ID whenever
the
@1ec5 commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)
1ec5 left a comment (openstreetmap/openstreetmap-website#5802)
> Not sure if timezone would affect this, but I'm in UTC -4.
Ah, that’s a good insight. I’m in UTC−7. Changing my system clock to UTC works
around the issue:
https://github.com/user-attachments/assets/ea4c16eb-c893-48d8-b085-4a2c72
1ec5 left a comment (openstreetmap/openstreetmap-website#5802)
I can reliably reproduce this issue:
* In Firefox 137.0b6 and Safari 18.3.1 on macOS 15.3.2, and Safari on iOS 16.7
* With `I18n.locale` evaluating to `en` or `vi`
* With a screen 1,728 pixels wide or 375 pixels wide
--
Reply to thi
1ec5 left a comment (openstreetmap/openstreetmap-website#5804)
Who is this widget’s intended audience and what’s its purpose?
https://github.com/openstreetmap/openstreetmap-website/issues/5373#issue-2714677416
frames it this way:
> The current user profile page provides a detailed summary of co
1ec5 left a comment (openstreetmap/openstreetmap-website#5802)
Ah sorry, I’m [Minh Nguyen](https://www.openstreetmap.org/user/Minh%20Nguyen)
on OSM, though I’m seeing this on everyone’s heatmap, such as
[Steve](https://www.openstreetmap.org/user/Steve) and [Mateusz Konieczny - bot
account](http
1ec5 created an issue (openstreetmap/openstreetmap-website#5802)
The horizontal axis on the user contribution heatmap is off by a month. Each
label across the top appears to be centered over the following month. For
example, if you’ll excuse me showing off my own profile:
https://github.com/use
1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
CLDR has string formats for [future/past relative
years/months/etc.](https://www.unicode.org/cldr/charts/47/summary/sk.html#38e7d288d00bc475)
However, it doesn’t have any provisions for “about”. As far as I know, “about”
timestamps
1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
Are rails-i18n and homegrown translation strings the only options for
formatting dates? On the client side, JavaScript has [a robust API for
formatting relative
dates](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Referenc
1ec5 left a comment (openstreetmap/openstreetmap-website#5373)
This landed in #5402. This issue didn’t close automatically because “addresses”
isn’t one of [GitHub’s closing
keywords](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issu
@1ec5 commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)
1ec5 left a comment (openstreetmap/openstreetmap-website#4975)
> Isn't Canadian English similar to US English?
For the kinds of strings being translated in this repository, Canadian English
spelling is closer to Australian English than American English, for example,
“cancelled”, “centre”, and “
1ec5 left a comment (openstreetmap/openstreetmap-website#844)
Many websites that accept Markdown end up pretty-printing raw URLs. For
example, GitHub turns
`https://github.com/openstreetmap/openstreetmap-website/issues/844#issuecomment-2705479356`
into
https://github.com/openstreetmap/openstre
1ec5 left a comment (openstreetmap/openstreetmap-website#5261)
I just noticed this renaming as I went to update translations over on
Translatewiki.net. Like others here, I was also struck by the oddity of
describing an individual as “a following” and a set of individuals as
“followings”. It’s b
1ec5 left a comment (openstreetmap/openstreetmap-website#4975)
No, currently there is no U.S. English localization. This issue was closed
almost immediately, and #5029 is only a draft for discussion about what a U.S.
English localization would contain, if we could find a
Translatewiki.net-compa
1ec5 left a comment (openstreetmap/openstreetmap-website#4975)
As the original post and #5029 illustrate, `en` is currently a mix of British
English, American English, OSM English, and some outright mistakes. Regardless,
Translatewiki.net assumes `en` is American English, as does pretty much eve
1ec5 left a comment (openstreetmap/openstreetmap-website#5493)
Thanks for your patience. I’ve addressed the code-level feedback.
https://github.com/openstreetmap/openstreetmap-website/pull/5493#discussion_r1912562048
is unresolved; there are a couple options for making it briefer (in English at
@1ec5 pushed 3 commits.
ad5d67931fa1cbfe0049db3cb5a0a910f351c07f Label administrative boundaries by
level
7006aa983947fde2a48ea4143059668d50d1cb16 Level 2 is always an international
boundary
84ca7f4d897b8361d2209968a3abeb4f78dfb86b Label boundaries by regional official
designations
--
View
@1ec5 commented on this pull request.
> @@ -101,9 +101,13 @@ def search_osm_nominatim
if klass == "boundary" && type == "administrative"
rank = (place.attributes["address_rank"].to_i + 1) / 2
prefix_name = t
"geocoder.search_osm_nominatim.admin_levels.level#{rank}", :de
@1ec5 pushed 1 commit.
7869631e83a7686c06d92aaefb8a23245e930b57 Label boundaries by regional official
designations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493/files/84ca7f4d897b8361d2209968a3abeb4f78dfb86b..7869631e83a7686c06d92aaefb8a23245e930b57
You
@1ec5 commented on this pull request.
> + border_type = t
> "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}",
> :default => prefix_name if extratag.attributes["key"] == "border_type"
+ place_type = t
"geocoder.search_osm_nominatim.prefix.place.#{e
@1ec5 commented on this pull request.
> +
+ var copyright = I18n.t("javascripts.map.copyright_text", {
copyright_link: copyright_link });
+
+ var openmaptiles_link = I18n.t("javascripts.map.openmaptiles", {
+openmaptiles_url: "https://openmaptiles.org/";,
+maptiler_url
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
See
https://github.com/opens
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
To avoid this external depend
@1ec5 commented on this pull request.
> +level3: "Administrative Boundary (Level 3)"
+level4: "Administrative Boundary (Level 4)"
+level5: "Administrative Boundary (Level 5)"
+level6: "Administrative Boundary (Level 6)"
+level7: "Administrative Boundary (L
@1ec5 commented on this pull request.
> +level3: "Administrative Boundary (Level 3)"
+level4: "Administrative Boundary (Level 4)"
+level5: "Administrative Boundary (Level 5)"
+level6: "Administrative Boundary (Level 6)"
+level7: "Administrative Boundary (L
@1ec5 commented on this pull request.
> + border_type = t
> "geocoder.search_osm_nominatim.border_types.#{extratag.attributes['value']}",
> :default => prefix_name if extratag.attributes["key"] == "border_type"
+ place_type = t
"geocoder.search_osm_nominatim.prefix.place.#{e
@1ec5 commented on this pull request.
> +level3: "Administrative Boundary (Level 3)"
+level4: "Administrative Boundary (Level 4)"
+level5: "Administrative Boundary (Level 5)"
+level6: "Administrative Boundary (Level 6)"
+level7: "Administrative Boundary (L
@1ec5 commented on this pull request.
> +level2: "International Border"
+level3: "Regional Administrative Boundary"
+level4: "Regional Administrative Boundary"
+level5: "Regional Administrative Boundary"
+level6: "Local Administrative Boundary"
+le
@1ec5 pushed 1 commit.
e7f1141fc1d3c78ce808db55ee53b13ec770444c Label boundaries by regional official
designations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5493/files/1b9dcca4a9fca8ac670188bf313c8ef78173aeec..e7f1141fc1d3c78ce808db55ee53b13ec770444c
You
#5493 implements the enhancements above except for distinguishing a given
`border_type=*` value that needs to be translated differently depending on the
country.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5450#issuecomment
Search results for Nominatim and Overpass queries now label administrative
boundaries according to the real-world designation according to the
`border_type=*` tag. If the value of this tag is unrecognized, the label falls
back to a more generic “Administrative Boundary (Level _n_)”, where _n_ is
@1ec5 commented on this pull request.
> +arrondissement: "Arrondissement Boundary"
+borough: "Borough Boundary"
+cercle: "Cercle Boundary"
+city: "City Boundary"
+comarca: "Comarca Boundary"
+county: "County Boundary"
+departement: "Departm
Fortunately, Nominatim does expose `border_type` in the `extratags` field of
the response, and both Overpass queries (for nearby and enclosing features)
include all the element’s tags.
Unfortunately, `border_type=*` values are unlocalized and un-namespaced. We’d
only be able to pretty-print the
For Overpass queries, there’s currently a special case that pulls in a
dedicated string based on the `admin_level=*` if it’s present. Maybe instead we
could use the generic “Administrative Boundary” label, using the normal code
path, but add a suffix like “(Level 3)”?
https://github.com/openstr
95 matches
Mail list logo
