@hlfan commented on this pull request.
> @@ -8,7 +8,6 @@ L.OSM.share = function (options) {
function init(map, $ui) {
// Link / Embed
-
What has this empty line done to you? /j
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/svg+
@hlfan commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
Could this code block be moved into the `// Image` section just below?
hlfan left a comment (openstreetmap/openstreetmap-website#6207)
Well, AFAICT Intl.DisplayNames blocks OSM.MappedElement blocks OSM.router, so
this is an easy fix (#6208).
That doesn't mean future issues on legacy browsers will also get fixed.
--
Reply to this email directly or view it on GitHu
### Description
This avoids breaking page load in legacy browsers like Pale Moon by delaying
the instanciation of Intl.DisplayNames until it's needed.
Closes #6207.
### How has this been tested?
Sandboxed Pale Moon with a locally served site.
You can view, comment on, or merge this pull request on
@hlfan pushed 5 commits.
a05cade7289d411f357bed9ba7693b24000c5c10 Store search icons separately
14072e6110c05274191e2adfb6d2f6027c6116c9 Store about icons separately
a9725cd2a94af85fcbbaa125790ca895d4623d73 Store welcome icons separately
d383095325ecdc5ac39a2852156413d97695faf8 Store diary ico
@hlfan commented on this pull request.
> @@ -0,0 +1,44 @@
+
Added a copy of #5999 for `position-absolute`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2217096942
You are receiving this because you are subsc
@hlfan pushed 5 commits.
4eb552a0aeae685b5dd7dcf41dfd2966fc5f10c0 Use common note marker definitions
97cdf42730e21c8f2dd350252e4737bc99ad584f Generalize leaflet-marker-icon
selector
9f74425951f4982139ac0bebf97dd65030e95ea8 Add Bootstrap .position-absolute
class to print styles to hide svg def
@hlfan pushed 2 commits.
fedd6dd3a9e1e5ba8f3d8667cde3ca8c70ff1b59 Use only differences to OSM logo in
internal social link icons
4a008009824c82dd30dd6d77e30b01ea366c6780 Add OSM logo indicator for related
social links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 1 commit.
7b694cbc67f36656528f23f3af871f35c596412a Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/749f01e37f290f090ee915e7f96866da5a636c4e..7b694cbc67f36656528f23f3af871f35c596412a
You are r
hlfan left a comment (openstreetmap/openstreetmap-website#6207)
If Intl.DisplayNames is the only big hurdle as it looks to me, then moving it
inside the wikidata preview render method would be less blocking.
That said, there might be other modern features that get in the way of the js
controller
@hlfan approved this pull request.
The reason I didn't invest much time in this file is that all the changes have
to be repeated once the decision is made to incorporate
https://wiki.openstreetmap.org/wiki/File:OSM_Community_Forum_Logo.svg.
--
Reply to this email directly or view it on GitHu
@hlfan pushed 1 commit.
a0666021d9d251a9d9cf5a8ee1ddcd3527937368 Inline social link icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6201/files/119a5a2e3c1a79ca049e85aad9dc2515968c369c..a0666021d9d251a9d9cf5a8ee1ddcd3527937368
You are receiving this becaus
@hlfan pushed 2 commits.
de89ba6611a3b9583b5fffa531ddbd6fb51a1301 Use only differences to OSM logo in
internal social link icons
b8aae7060360884c21659e3ff91fc60cab800fd4 Add OSM logo indicator for related
social links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 2 commits.
cbd0ad01f69f12da2ed86329efaf1490d7e86b64 Update and inline markers
ea5ae93b8a5f7c3e37f6981faa3a6bd620249be5 Clean up old markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/1d5cb8816344271fb73d5c3d8c153c181d86d218..ea5ae
@hlfan approved this pull request.
Personally, I'd define `check_pagination_of_50_entries` before
`test_index_paged`, but this is mostly for git blame tidiness.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6204#pullrequestre
@hlfan pushed 2 commits.
d457802ad89d11c932c42bc0e15ea0c20d09de3b Update and inline markers
1d5cb8816344271fb73d5c3d8c153c181d86d218 Clean up old markers
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/f07fc6ae097d2baa72a8ba06bf3908cb70e20f2e..1d5cb
For mobile devices, the request to `OSM.WIKIMEDIA_COMMONS_URL` from #6127 will
be redirected to `commons.m.wikimedia.org`, which is subsequently blocked by
the CSP.
Directly requesting the desktop version removes the extra redirect.
You can view, comment on, or merge this pull request online at:
@hlfan pushed 4 commits.
859b17faf488cc925a187d60746e8e8b4126a876 Use common note marker definitions
ded64d5459e7a2d0a27a53c516fc9bd3478c1666 Generalize leaflet-marker-icon
selector
dfb7e5adcb00ddfbb05fa9ab2ce9c5d590253cd6 Update and inline markers
f07fc6ae097d2baa72a8ba06bf3908cb70e20f2e Cle
@hlfan pushed 3 commits.
c273fb3d9f817cea92ae620dd03daece893e7cdc Align route regex initialisation
80af72cc4a05dc75e370daf03ee3c846cf676905 Add scoped placeholders for router
0908e97e95606d5a05e2b2b0c7adc335319e1383 Specify element handlers more
compactly
--
View it on GitHub:
https://github
@hlfan commented on this pull request.
> + icon: ["P8972", "P154", "P14"].reduce((out, prop) => out ??
> entity.claims[prop]?.[0]?.mainsnak?.datavalue?.value, null),
+ description: localizedProperty("descriptions", langs)?.value,
+ article: localizedProperty("sitelinks", wikis)
+
@hlfan pushed 2 commits.
bff4b557417da0f063cded5b6e906807b58b3b47 Use only differences to OSM logo in
internal social link icons
01c9faeec783ac0e0037321e6c08af5b76e769b4 Add OSM logo indicator for related
social links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 1 commit.
219a11259d71018c258bc3a09e3809f7ebe48a5b Merge branch 'openstreetmap:master'
into social-no-reiterate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/6bac01a5c7e3ffa47a476cb69d1e9fef982ee3a4..219a11259d71018c258bc3a09e3809f7e
@hlfan pushed 1 commit.
5e8576462633a9dacb00c580159fc62bf890ea31 Simplify changeset icon definitions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884/files/73ef13fa723428f181237e481671cec9a7c8508b..5e8576462633a9dacb00c580159fc62bf890ea31
You are receiving
Removes the patch from #6049.
This is waiting on #6159 or #6072.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6201
-- Commit Summary --
* Refine dom structure assertions in profile and user tests
* Store social
@hlfan pushed 1 commit.
e03e9bb8f97f8beb728c922a8ccb2a3cd698199e Store gear icon separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/6da3b594f69ea1ef3794610943c433403181891d..e03e9bb8f97f8beb728c922a8ccb2a3cd698199e
You are receiving this beca
@hlfan pushed 6 commits.
c63daf5b4f133676c11bead0aaa61b99c4d243a1 Refine dom structure assertions in
profile and user tests
107aa6ae04007db9df9be43ac3898d254775d382 Store search icons separately
8ddec148ecf98407ee6b4b1e05309223d0537bc1 Store about icons separately
c1818b9b5a72f76066586536b27cc
Reopened #5777.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777#event-18668138800
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Closed #5777.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777#event-18668125460
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/8a97b03a38ea226077a88b682c58a661d9602339..dc6e1e370446d03ac8374e91d8c42f9202b05db2
You are receiving this because you are subscribed to this thread.
Message ID:
__
Cleaning up the map controls sprite creation after #6189 added the way to do
that.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6200
-- Commit Summary --
* Use svg symbols for map controls icons
-- File Changes
hlfan left a comment (openstreetmap/openstreetmap-website#3123)
@mjourdan I'm looking for another round of feedback, let's get this resolved!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3123#issuecomment-3080020500
You are r
@hlfan pushed 2 commits.
d64be5d70174ad09e672ee405e0a423ff79a55a9 Add test for SVG sprite presence
b06cc0ede70d20140ec6b5327862ebc734fd6bef Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/3757e775ad0667cd78bc1a2a882d11
@hlfan commented on this pull request.
> @@ -101,4 +112,108 @@
scrollableList.scrollLeft = scrollableList.scrollWidth -
scrollableList.offsetWidth;
}
}
+
+ function previewWikidataValue($btn) {
+if (!OSM.WIKIDATA_API_URL) return;
+const items = $btn.data("qids");
+if
@hlfan pushed 1 commit.
62b4087b78d9281f34c9e27ccecb976c3660d133 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/78d0571781958d9747d7f22b925d8dadb128cb12..62b4087b78d9281f34c9e27ccecb976c3660d133
You are rec
@hlfan commented on this pull request.
On app/assets/javascripts/leaflet.map.js:
What do you think of swapping the hierarchy of the new files, with
`leaflet.shortbread.js` required in `leaflet.maplibregl.js`?
The current way would need to require `leaflet.maplibregl.js` twice,
once in `leafle
@hlfan pushed 1 commit.
78d0571781958d9747d7f22b925d8dadb128cb12 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/63c4b8712bd3c1e11826f44e40fddf22349c805d..78d0571781958d9747d7f22b925d8dadb128cb12
You are rec
@hlfan commented on this pull request.
> +if (data.icon && OSM.WIKIMEDIA_COMMONS_URL) {
+ let src = OSM.WIKIMEDIA_COMMONS_URL + "Special:Redirect/file/" +
encodeURIComponent(data.icon);
+ if (!data.icon.endsWith(".svg")) src += "?width=128";
+ $("")
+.attr("href", OSM
@hlfan pushed 1 commit.
63c4b8712bd3c1e11826f44e40fddf22349c805d Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/19e739716360bf69d3ab06abbf4109f2ab549fb7..63c4b8712bd3c1e11826f44e40fddf22349c805d
You are rec
@hlfan commented on this pull request.
> +.appendTo(cell);
+}
+if (data.label) {
+ const label = $btn
+.siblings(`a[href*="wikidata.org/entity/${data.qid}"]`)
+.clone()
+.text(data.label.value)
+.attr("dir", "auto");
+ cell.append($("").a
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@hlfan commented on this pull request.
> @@ -101,4 +112,108 @@
scrollableList.scrollLeft = scrollableList.scrollWidth -
scrollableList.offsetWidth;
}
}
+
+ function previewWikidataValue($btn) {
+if (!OSM.WIKIDATA_API_URL) return;
+const items = $btn.data("qids");
+if
hlfan left a comment (openstreetmap/openstreetmap-website#6198)
>From the search, when selecting a result, the search input stays. It will
>persist when navigating to history or export, and only be removed once the
>sidebar is closed via the close button.
--
Reply to this email directly or vie
Addressing a part of #3123 to keep the search input longer, now that #6184
simplified the state management.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6198
-- Commit Summary --
* Keep search input until sidebar
@hlfan commented on this pull request.
> @@ -0,0 +1,30 @@
+//= require leaflet.maplibre
+
+const styleURL =
"https://vector.openstreetmap.org/demo/shortbread/colorful.json";;
Why is this a global constant?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
hlfan left a comment (openstreetmap/openstreetmap-website#6194)
I'm kinda already looking forward to `v2.35.2`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6194#issuecomment-3068346132
You are receiving this because you are su
@hlfan pushed 2 commits.
13eabbc8c9c3043b4d1eae06621862775db177df Add test for SVG sprite presence
3757e775ad0667cd78bc1a2a882d11fda349ea1b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/79539b4486449f3ea1237ee4c4d2e8
@hlfan pushed 1 commit.
79539b4486449f3ea1237ee4c4d2e8d230c309bc Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/1d048bface26fc0703fb73b8957d2f06d3748661..79539b4486449f3ea1237ee4c4d2e8d230c309bc
You are receiving this
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
@hlfan commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+ end
+
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
@hlfan pushed 2 commits.
b1f6ade08bbb2307323e6a26581f7d9de8a33f5c Add test for SVG sprite presence
1d048bface26fc0703fb73b8957d2f06d3748661 Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/ad3039224fded9b822a75fe62b8b7a
hlfan left a comment (openstreetmap/openstreetmap-website#6184)
Dependent on #6185
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184#issuecomment-3066976429
You are receiving this because you are subscribed to this thread.
Mes
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Well, there's already quite a
@hlfan pushed 1 commit.
ad3039224fded9b822a75fe62b8b7ad93ffca9ae Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/5017d1ac042012846fbe1168d0b06d6db244bbdd..ad3039224fded9b822a75fe62b8b7ad93ffca9ae
You are receiving this
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
That should be doable by addin
@hlfan pushed 1 commit.
5017d1ac042012846fbe1168d0b06d6db244bbdd Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/01e3075722f58f0309a4599d2170256dbf2e2d2b..5017d1ac042012846fbe1168d0b06d6db244bbdd
You are receiving this
@hlfan requested changes on this pull request.
On app/assets/javascripts/leaflet.map.js:
See
https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3062857646,
no other layers are defined in this file
--
Reply to this email directly or view it on GitHub:
https://githu
@hlfan pushed 1 commit.
01e3075722f58f0309a4599d2170256dbf2e2d2b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e..01e3075722f58f0309a4599d2170256dbf2e2d2b
You are receiving this
@hlfan pushed 1 commit.
bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/aa65a878f7f610554b8ad67f3731c49d7e07f8d3..bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e
You are receiving this
hlfan left a comment (openstreetmap/openstreetmap-website#6189)
Hmm. Interesting, but great!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-3066022208
You are receiving this because you are subscribed to this th
@hlfan pushed 1 commit.
aa65a878f7f610554b8ad67f3731c49d7e07f8d3 Fix missing newline at end of file
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/86af97f5f827eb3f70eb4c217fd0f1d5a1d3210e..aa65a878f7f610554b8ad67f3731c49d7e07f8d3
You are receiving t
Test driving the inline_svg gem.
Continues #5753 and closes #5776 following the discussion in #5880.
The color replacement is still broken, and I don't know what else to try.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
> Why is it important to run the test to its completion if you're going to run
> it again anyway?
https://github.com/user-attachments/assets/edd82135-9d7f-4d38-90f8-a928df9eff2c";
/>
There's an option not to.
I'm not saying we sh
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Aha, so it's not really understanding on both sides!
I thought you meant manipulations of svg internals inside a helper module, not
on invocation.
> How is that supposed to work at the same time?
Well, since the `fill` and `stroke
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Let's take a look at the latest test run that didn't fail on "real bugs", [this
test
run](https://github.com/openstreetmap/openstreetmap-website/actions/runs/16122953585)
for #6170:
The three executions of `rails test:all` finishe
@hlfan pushed 1 commit.
5e03d30860ac50753d4d247edd1a96cb60532a82 Restructure button selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184/files/0e020c42e4bbdccf55ff36d2a43e96031a6b66d5..5e03d30860ac50753d4d247edd1a96cb60532a82
You are receiving this bec
Use the input state to toggle the describe_location button's visibility
with CSS instead of manually updating.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6184
-- Commit Summary --
* Lock describe_location butto
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Another thing to note is that the preview in the rich diff sped up my reviews
of #6124 quite a bit.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomme
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6180#pullrequestreview-3011231088
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
> +**Important Notes:**
+- Loading an apidb database with Osmosis is about **twenty** times slower than
loading the equivalent data with osm2pgsql into a rendering database
+-
[`--log-progress`](https://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage#-
hlfan left a comment (openstreetmap/openstreetmap-website#6137)
> When this is ready for merging I'll rebase and squish before taking it out of
> draft.
Moving the layer definition out of
[leaflet.map.js](https://github.com/openstreetmap/openstreetmap-website/pull/6137/files#diff-f060eef487077b
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
Sent you a [c.osm.org](//c.osm.org) dm @1ec5.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-3058759408
You are receiving this because you are su
@hlfan pushed 1 commit.
bde4e2f507807a1f689cf2c931a05e7dcd84d1e5 Add reasonable workflow time limits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/214482674768ef45d821993be280d3564c025947..bde4e2f507807a1f689cf2c931a05e7dcd84d1e5
You are receiving
hlfan left a comment (openstreetmap/openstreetmap-website#6066)
Can
[origin/save-screenshots](https://github.com/openstreetmap/openstreetmap-website/tree/save-screenshots)
be deleted, or is it still needed?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
No, but going out of their way to submit a compact PR that is easily reviewable
(and mergeable - not self-merge though) to undermine a PR, forcing their point
with a necessary rebase rather than simply having a discussion.
--
Repl
hlfan left a comment (openstreetmap/openstreetmap-website#3815)
I've recently found myself reviewing less frequently — not because I expected
progress on particularly my submissions in return, but because I didn't see my
reviews contributing meaningfully to overall progress.
A big part of that,
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4191#pullrequestreview-3006287729
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6176#pullrequestreview-3006217290
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan created an issue (openstreetmap/openstreetmap-website#6173)
### Problem
The current solution could break.
### Description
Add a test to ensure the security vulnerability doesn't sneak back in.
### Screenshots
_No response_
--
Reply to this email directly or view it on GitHub:
https://
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan pushed 1 commit.
19e739716360bf69d3ab06abbf4109f2ab549fb7 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/e81bb9bd7139faa95b0ef4f6b34163e7d7db001a..19e739716360bf69d3ab06abbf4109f2ab549fb7
You are rec
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan pushed 1 commit.
e81bb9bd7139faa95b0ef4f6b34163e7d7db001a Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/5ac1b483f08bab249fe63f03221748a26640..e81bb9bd7139faa95b0ef4f6b34163e7d7db001a
You are rec
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> +.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
> "Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
+ $btn
+.siblings(`a[href*="
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Why should we cancel successfully run steps like [this
one](https://github.com/hlfan/openstreetmap-website/actions/runs/16058832401/job/45319779765#step:13:16)?
--
Reply to this email directly or view it on GitHub:
https://github.c
@hlfan pushed 1 commit.
5ac1b483f08bab249fe63f03221748a26640 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/d47b9f2e8a32e9ff5c92a19ab6b2b458c8d01105..5ac1b483f08bab249fe63f03221748a26640
You are rec
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> we should add an Api-User-Agent header to the fetch in this PR
How does `OSM TagPreview
(https://github.com/openstreetmap/openstreetmap-website)` look to you? Any
other details I'm missing?
--
Reply to this email directly or vi
hlfan left a comment (openstreetmap/openstreetmap-website#5854)
Should I split up the "Update and inline markers" commit into three parts and
temporarily make `OSM.getMarker` use a dict so I can update the options
separately?
Would that make this PR easier to digest?
--
Reply to this email dir
@hlfan approved this pull request.
Whether or not the style.json path definition changes, this now looks good to
me. That could also be worth revisiting when there's more than one vector style.
Tests pass in my fork https://github.com/hlfan/openstreetmap-website/pull/18.
If you wanna do other rev
@hlfan commented on this pull request.
> @@ -11,6 +11,7 @@ permissions:
jobs:
danger:
runs-on: ubuntu-latest
+timeout-minutes: 1
Well that has to be revised:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/16033899766/job/45240902000?pr=6154
That's why I initia
@hlfan pushed 2 commits.
623db110e4d50b3b1f1177cdd3d1f4a49a4e1f11 Fix formatting of arrow function
45f8ed06bdb881b70188c1401061878e19281f28 Add reasonable workflow time limits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/df9d34c332cc26c6cd2d242ca
hlfan left a comment (openstreetmap/openstreetmap-website#6154)
Maybe both?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3028913120
You are receiving this because you are subscribed to this thread.
Message ID
@hlfan pushed 1 commit.
86643d22c51ee3fed1c99d173a390b8a10a9a9bb Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/71aa64b26c32a3c21da04ad45fcd128780b2440d..86643d22c51ee3fed1c99d173a390b8a10a9a9bb
You are rec
1 - 100 of 1072 matches
Mail list logo
