### Problem
According to
https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-2858925494,
as @mmd-osm mentioned, it will be good if `Home Location Name` has maximum
field length.
### Description
Changes length of the `Home Location Name` field to be stretched to the max
@nertc commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each
@nertc commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
Locale selector was changed according to
https://github.com/openstreetmap/
@nertc commented on this pull request.
> + gl: Galician
+ gsw: Alemannic (specifically Swiss German, Alsatian)
+ gu: Gujarati
+ he: Hebrew
+ hi: Hindi
+ hr: Croatian
+ hsb: Sorbian, Upper
+ hu: Hungarian
+ ia: Interlingua
+ id: Indonesian
+
@nertc commented on this pull request.
> +
+ <% Locale.available
+ .select { |locale| I18n.exists?
"shared.language_selector.#{locale}" }
+ .sort_by { |locale| t(".#{locale}") }
+ .each do |locale| %>
+><%= t(".#{locale}") %>
+ <%
nertc left a comment (openstreetmap/openstreetmap-website#5201)
PR was updated. `master` was merged.
@AntonKhorev Thank you for your PR. `Locale selector` was changed accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
nertc left a comment (openstreetmap/openstreetmap-website#5987)
PR was updated. `master` was merged. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-2918612267
You are receiving thi
@nertc pushed 1 commit.
35cc26cb6ad172ab85eb49c484199cc87dadc2f7 Company Name on Profile Page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/1581f36730d20e9c91b10ea5dfd904b9f2edf7b7..35cc26cb6ad172ab85eb49c484199cc87dadc2f7
You are receiving this be
nertc left a comment (openstreetmap/openstreetmap-website#5987)
PR was updated. `master` was merged. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-2915775616
You are receiving thi
@nertc pushed 1 commit.
1581f36730d20e9c91b10ea5dfd904b9f2edf7b7 Company Name on Profile Page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/6bc4fab7bc1427966d4615afe42bc5e31ec244bc..1581f36730d20e9c91b10ea5dfd904b9f2edf7b7
You are receiving this be
@nertc commented on this pull request.
> +class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with =>
%r{\A(https?://.+|@([a-zA-Z0-9_]+)@([\w\-\.]+))\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was merged and conflicts were resolved. Code was
changed according to the reviews.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issu
@nertc pushed 1 commit.
c410c5704ac3e3649f3e64293b6628e8becee5b8 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/2c79d415e458aa91ceb7deaa330f1e3e56a838e1..c410c5704ac3e3649f3e64293b6628e8becee5b8
You are receiving this becaus
@nertc commented on this pull request.
> @@ -153,6 +153,14 @@
<%= @user.home_location_name %>
<% end %>
+<% if @user.company&.strip.present? %>
+
+http://www.w3.org/2000/svg"; width="16" height="16"
fill="curr
@nertc commented on this pull request.
> @@ -153,6 +153,14 @@
<%= @user.home_location_name %>
<% end %>
+<% if @user.company&.strip.present? %>
+
+http://www.w3.org/2000/svg"; width="16" height="16"
fill="curr
nertc left a comment (openstreetmap/openstreetmap-website#5987)
Thank you for the reviews. PR was updated according to the comments.
@tomhughes icon was changed from the `suitcase` to the `building`.
@mmd-osm length of the `company field` was changed (I'll create a separate
small PR for `home_lo
@nertc pushed 1 commit.
6bc4fab7bc1427966d4615afe42bc5e31ec244bc Company Name on Profile Page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/be64551ad822cb20d7e29022e4f57fb40a76f8a2..6bc4fab7bc1427966d4615afe42bc5e31ec244bc
You are receiving this be
@nertc commented on this pull request.
> +#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :mes
@nertc pushed 1 commit.
a7bd92a69a0ec4489a54cbbeaae136548950d8d3 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/4c88ed958a347124a4068568944e1ae422cf5b17..a7bd92a69a0ec4489a54cbbeaae136548950d8d3
You are receiving this becaus
nertc left a comment (openstreetmap/openstreetmap-website#5439)
Last commits from `master` were merged and `Metrics/ClassLength` was changed to
623.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2883014297
You
@nertc pushed 1 commit.
2c79d415e458aa91ceb7deaa330f1e3e56a838e1 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/a7bd92a69a0ec4489a54cbbeaae136548950d8d3..2c79d415e458aa91ceb7deaa330f1e3e56a838e1
You are receiving this becaus
@nertc commented on this pull request.
> +
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was merged. All conflicts were resolved.
PR was changed according to the suggestions.
Only RuboCop error is about the length of the `User` class (this PR added only
2 necessary lines to it). I can change `Met
@nertc commented on this pull request.
> +#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:blues
nertc left a comment (openstreetmap/openstreetmap-website#5987)
@tomhughes generally, users are responsible for the correctness of their
information on the web and validation of the information of others. Even now,
anyone can claim anything in the description field. If someone finds any
incorre
nertc left a comment (openstreetmap/openstreetmap-website#5439)
@tomhughes sorry for the delay on this PR. Yes, I am currently focused on this
one and will push as soon as possible.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull
nertc left a comment (openstreetmap/openstreetmap-website#5987)
@tomhughes Yes, in my practice, `suitcase icon` is commonly used to refer to a
job or company. If it's not intuitive, it can be changed to the `building icon`
mentioned in the issue. My thought was that the `building icon` may be sl
This PR addresses "Company Name on Profile Page" issue mentioned in
#5986
PR adds Company Name functionality on Profile page. If user modifies company
field, value will be shown on the profile page. It can be changed from `Edit
Profile`. `company` field can be empty, in which case, company info
nertc created an issue (openstreetmap/openstreetmap-website#5986)
### Problem
Currently profile page doesn't provide functionality to add company or work
name on the profile (other than adding it manually in the description, which
makes visual representation of it inconsistent).
### Descriptio
@nertc pushed 1 commit.
bafaf78c7de4e8a224e1957f5b7c3f054ad05211 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/491091b70e618b5c49df7a62f28738ae658a0fa6..bafaf78c7de4e8a224e1957f5b7c3f054ad05211
You are receiving this because yo
@nertc pushed 1 commit.
491091b70e618b5c49df7a62f28738ae658a0fa6 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/4e5217d0cae2cbc977090f60b879d8fa17016ac5..491091b70e618b5c49df7a62f28738ae658a0fa6
You are receiving this because yo
nertc left a comment (openstreetmap/openstreetmap-website#5302)
PR was updated. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2812062046
You are receiving this because you are sub
@nertc commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if tru
nertc left a comment (openstreetmap/openstreetmap-website#5121)
Thanks for the review @tomhughes. PR was updated according to the suggestion.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#issuecomment-2809369142
You are re
@nertc pushed 1 commit.
738d1f97fe16770d044f512d6c006a6fca457d67 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/be27c86c5f2c7f7497a9dc59e6d3ab0034099573..738d1f97fe16770d044f512d6c006a6fca457d67
You are re
@nertc commented on this pull request.
> @@ -2,7 +2,10 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html
%>
+<% if tru
@nertc pushed 1 commit.
be27c86c5f2c7f7497a9dc59e6d3ab0034099573 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/691738c70898082000657ceb8537ea52fa8bf488..be27c86c5f2c7f7497a9dc59e6d3ab0034099573
You are re
nertc left a comment (openstreetmap/openstreetmap-website#5121)
PR was updated.
@AntonKhorev `truncate_html` was moved to be done after `linkify` and
`sanitize`.
@tomhughes visual of `See full entry` link was changed. Now it is separate from
other links and easier to see (see screenshots).
Logic
nertc left a comment (openstreetmap/openstreetmap-website#5201)
Thanks for rerunning tests.
PR was updated. `master` was merged to avoid previous test errors.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-27835
@nertc pushed 1 commit.
39a0abf336d858c85c09812b70a5378944242ded Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/8a3e211e938dedeafe021d09afb9c66fbf2325a9..39a0abf336d858c85c09812b70a5378944242ded
You are receiving this because you
@nertc pushed 1 commit.
e74ecd48186bc7d019f71d27f8ded26f24a92410 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/f8c5cb47014e588952ac0dcbc528b5b8ff793d06..e74ecd48186bc7d019f71d27f8ded26f24a92410
You are receiving this because yo
@nertc pushed 1 commit.
4e5217d0cae2cbc977090f60b879d8fa17016ac5 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/e74ecd48186bc7d019f71d27f8ded26f24a92410..4e5217d0cae2cbc977090f60b879d8fa17016ac5
You are receiving this because yo
@nertc pushed 1 commit.
691738c70898082000657ceb8537ea52fa8bf488 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/859d609fb2d519dab4253d9df5b1c718a30015d0..691738c70898082000657ceb8537ea52fa8bf488
You are re
@nertc commented on this pull request.
> @@ -65,6 +65,42 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, img_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ keep_or_discards =
@nertc commented on this pull request.
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
+ const endpoint = {
+dirty: false,
Property name `dirty` was inspired from Angular. It means that input was
changed manually. But, in this
@nertc commented on this pull request.
> @@ -0,0 +1,65 @@
+OSM.HomeLocationNameEndpoint = function Endpoint(latInput, lonInput,
locationNameInput) {
`HomeLocationNameEndpoint` was chosen to be similar to `OSM.DirectionsEndpoint`
from `app\assets\javascripts\index\directions-endpoint.js`.
Was
@nertc commented on this pull request.
> @@ -65,6 +65,42 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, img_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ keep_or_discards =
nertc left a comment (openstreetmap/openstreetmap-website#5121)
PR was updated. `master` was merged and merge conflicts were fixed.
PR was changed according to reviews. @tomhughes to indicate if an entry has
been truncated, as @AntonKhorev suggested, `See full entry` will not be shown
on entrie
nertc left a comment (openstreetmap/openstreetmap-website#5121)
> If the truncation was the last step, I'd move to another module/class, which
> I'd use only when I need to truncate. But currently html conversion is
> followed by sanitize and linkify (why not first linkify then sanitize?). Can
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@tomhughes Thanks for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2772374827
You are receiving this beca
@nertc commented on this pull request.
> @@ -139,6 +139,16 @@
+<% if @user.home_location_name &&
@user.home_location_name.strip.present? %>
Was changed accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@AntonKhorev Thanks for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2736015474
You are receiving this be
@nertc pushed 1 commit.
859d609fb2d519dab4253d9df5b1c718a30015d0 Provide a truncated view of recent
diaries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/09f4fb63448798f0698efa82052576005ab6a533..859d609fb2d519dab4253d9df5b1c718a30015d0
You are re
nertc left a comment (openstreetmap/openstreetmap-website#5009)
For `CPU slowdown` I use browser built-in functionality.
Difference between getting data from server and rendering them is that while
getting data, there are no CPU intense tasks and loading icon is shown next to
the `data layer` c
nertc left a comment (openstreetmap/openstreetmap-website#5121)
@AntonKhorev Thank you for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#issuecomment-2743822549
You are receiving this
@nertc commented on this pull request.
> @@ -65,6 +65,32 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_
@nertc commented on this pull request.
> +def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_length = 0
+ last_child = nil
+
+ doc.traver
nertc left a comment (openstreetmap/openstreetmap-website#5009)
You are right, I thought, it disabled both asynchronous functionalities.
I pulled `master` and tested turning asynchronous loading off.
1. About flash: it is because data is loaded asynchronously and as everything
is rendered one by
@nertc commented on this pull request.
> +locationInput = {
+ dirty: false,
+ requestController: null,
+ countryName: $("#location_name").val().trim(),
+ deletedText: null,
+ checkLocation: savedLat && savedLon && $("#location_name").val().trim()
+};
I created a
@nertc commented on this pull request.
> @@ -12,6 +12,7 @@
# home_lat :float
# home_lon :float
# home_zoom:integer default(3)
+# location_name:string
`location_name` was updated and renamed as `home_location_name`.
--
Reply to this e
nertc left a comment (openstreetmap/openstreetmap-website#5009)
@deevroman Thank you for your feedback. #5799 disabled asynchronous layer
loading and, therefore, there shouldn't be any flashes or slow rendering
process anymore.
--
Reply to this email directly or view it on GitHub:
https://gith
@nertc commented on this pull request.
> @@ -176,6 +206,64 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation(updateInput = true, lat =
$("#home_lat").val().trim(), lon = $("#home_lon").val().trim(), successFn) {
`respondToHomeUpdate` was changed with `respondToHom
nertc left a comment (openstreetmap/openstreetmap-website#5439)
`master` was rebased. Conflicts were resolved.
Tests have these errors:
`Selenium::WebDriver::Error::UnknownError: Failed to decode response from
marionette`
`Selenium::WebDriver::Error::NoSuchWindowError: Browsing context has been
@nertc commented on this pull request.
> +if (updateLocationName) {
+ if (locationInput.checkLocation) {
+updateHomeLocation(false, savedLat, savedLon, updateHomeLocation);
+ } else {
+updateHomeLocation();
+ }
+}
It shouldn't t
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was rebased. Conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2721275936
You are receiving this bec
@nertc pushed 1 commit.
4c88ed958a347124a4068568944e1ae422cf5b17 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/26406e204ea25ef6ff42a2f5e6ff54c7ea9d468b..4c88ed958a347124a4068568944e1ae422cf5b17
You are receiving this becaus
@nertc pushed 1 commit.
a0478eab9484280aa1be6c4b15a2e96b2ced14ca Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/d4f0011abe0f02421d3657aab38abdfddee89704..a0478eab9484280aa1be6c4b15a2e96b2ced14ca
You are receiving this because you
nertc left a comment (openstreetmap/openstreetmap-website#5201)
PR was updated. `master` was rebased as a base for this PR.
@tomhughes Code was changed according to comments.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#is
@nertc commented on this pull request.
> @@ -52,6 +52,13 @@ time[title] {
color: $blue;
}
+/* Utility for transparent color */
+
+.text-transparent{
Space was added.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#di
@nertc commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
For now, I haven't changed anything related to this comment. If you prefer any
of these or other solutions, I'll update PR accordingly.
--
Reply to this email directly or view it on GitHu
@nertc commented on this pull request.
> @@ -1984,6 +1984,8 @@ en:
users:
older: Older Users
newer: Newer Users
+language_selector:
+ language: English
Language codes were added in `en.yml`. Now even before translation of these new
keys, all languages will app
nertc left a comment (openstreetmap/openstreetmap-website#5009)
PR was updated. `master` was rebased.
@tomhughes Thank you for the review. Spinner issue on page refresh was fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
@nertc pushed 1 commit.
3b26551122cd26f48f43b6e7ff05e2eded6d0bf8 Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/4b1e8f2eae6fd51988a2604ad74f7ca07267fe8b..3b26551122cd26f48f43b6e7ff05e2eded6d0bf8
You are receiving this
@nertc pushed 1 commit.
4b1e8f2eae6fd51988a2604ad74f7ca07267fe8b Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/fca12a2c06dd0ddcf2b9a937e0eeb36d97a20747..4b1e8f2eae6fd51988a2604ad74f7ca07267fe8b
You are receiving this
nertc left a comment (openstreetmap/openstreetmap-website#5009)
This PR is linked to the https://github.com/openstreetmap/leaflet-osm/pull/47.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#issuecomment-2711715222
You are re
nertc left a comment (openstreetmap/openstreetmap-website#4931)
This issue is not closed and needs to be reopened. Sorry, it seems I wrongly
used `Fixes` keyword. I meant that
https://github.com/openstreetmap/leaflet-osm/pull/38 was part of the fix, not
the whole fix.
--
Reply to this email d
@nertc pushed 1 commit.
daee2fd4adb7813f8b7168ad2b6d1ee6e936f34c Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/418929188fbc31a640defff703b102ddbf354afe..daee2fd4adb7813f8b7168ad2b6d1ee6e936f34c
You are receiving this becaus
nertc left a comment (openstreetmap/openstreetmap-website#5439)
> That seems to have been some glitch with the tests. I forced a rerun and they
> passed fine.
I rebased `master` to
https://github.com/openstreetmap/openstreetmap-website/pull/5009 and it has the
same exact errors.
--
Reply to
nertc left a comment (openstreetmap/openstreetmap-website#5009)
PR was updated. `master` was rebased. Conflicts were resolved. Failed tests
were not impacted by this PR (for more information see
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2711306484).
--
Reply
@nertc commented on this pull request.
> @@ -0,0 +1,15 @@
+
+
+
+
+ <% unless disabled %>
+
I tried several different methods to solve it, but still for me the best one is
the current solution. If you prefer any of them, I can change code accordingly:
1. Showing dropdown next to
@nertc commented on this pull request.
> + return;
+}
+
+const geocodeUrl = "/geocoder/search_osm_nominatim_reverse";
+const params = {
+ format: "json",
+ lat,
+ lon,
+ zoom: 3
+};
+
+if (locationInput.request) {
+ locationInput.request.abort();
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@tomhughes Thanks for the review. PR was updated accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2700150865
You are receiving this beca
@nertc commented on this pull request.
> @@ -148,7 +148,11 @@ def search_osm_nominatim_reverse
:type => object_type, :id => object_id)
end
-render :action => "results"
+if params[:format] == "json"
+ render :json => @results
+else
+ render :actio
@nertc pushed 1 commit.
f8c5cb47014e588952ac0dcbc528b5b8ff793d06 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/a445843a26adcfb92c627c152068cb78190319ce..f8c5cb47014e588952ac0dcbc528b5b8ff793d06
You are receiving this because yo
nertc left a comment (openstreetmap/openstreetmap-website#5201)
PR was updated. `master` was rebased as a base for this PR. Conflicts were
resolved. There were some changes related to the header in the `master`, so
logic and HTML of this PR was changed accordingly to fix problems related to
loc
@nertc pushed 1 commit.
d4f0011abe0f02421d3657aab38abdfddee89704 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/b6c464ad5a74b2bc1dbb4814340cde4209800cba..d4f0011abe0f02421d3657aab38abdfddee89704
You are receiving this because you
@nertc pushed 1 commit.
b6c464ad5a74b2bc1dbb4814340cde4209800cba Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/25fd157b9ce6e7945bf5d5e9871d04388e9e5f19..b6c464ad5a74b2bc1dbb4814340cde4209800cba
You are receiving this because you
nertc left a comment (openstreetmap/openstreetmap-website#5302)
@AntonKhorev PR was updated. Merge conflicts were fixed and `master` was
rebased as a base for this branch.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#issu
@nertc pushed 1 commit.
a445843a26adcfb92c627c152068cb78190319ce Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/47191675b5aaea734dff6afa0cac4c961963c264..a445843a26adcfb92c627c152068cb78190319ce
You are receiving this because yo
@nertc commented on this pull request.
Tested and works perfectly for all kinds of situations. I like the last
solution that UI watches only author and the last comment. It provides
intuitive UI/UX.
> @@ -24,7 +26,15 @@
<% @notes.each do |note| -%>
- class="table-primary"<%
@nertc commented on this pull request.
> +
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" :
social_link.parsed[:platform],
+ :
@nertc commented on this pull request.
> +# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecord
+ belongs_to :user
+
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :messag
@nertc commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+ c
@nertc commented on this pull request.
> +
+ validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message =>
:http_parse_error }
+
+ URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.
@nertc commented on this pull request.
> + URL_PATTERNS = {
+:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)},
+:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.]+)},
+:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
+:gitlab => %r{\Ah
@nertc commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "oth
@nertc commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "oth
@nertc commented on this pull request.
> @@ -0,0 +1,8 @@
+<% social_links.each do |social_link| %>
+
+<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ?
'other' : social_link.parsed[:platform]}.svg",
`:size => "16"` was added to the `` tag to avoid text jumps. Thanks
@nertc commented on this pull request.
> +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)}
+ }.freeze
+
+ NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze
+
+ def parsed
+URL_PATTERNS.each do |platform, pattern|
+ names = url.match(pattern)
+
@nertc pushed 1 commit.
418929188fbc31a640defff703b102ddbf354afe Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/6d3d9316d353ab824a9046f2c92dc94039fd23b4..418929188fbc31a640defff703b102ddbf354afe
You are receiving this becaus
1 - 100 of 277 matches
Mail list logo
