Re: [openstreetmap/openstreetmap-website] Inline social link icons (PR #6201)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6201) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6201#issuecomment-3089956536 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Inline social link icons (PR #6201)

Merged #6201 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6201#event-18703544392 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > @@ -0,0 +1,44 @@ + I know that `d-none` here won't entirely work, but this is also not entirely working. You'll get this gap in print https://github.com/user-attachments/assets/a7798bb3-4bce-47f8-9ffa-9d7a2e8ca5ba"; /> which doesn't look like muc

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > +MARKER_COLORS = { + :red => "#f6110a", + :green => "#9cef11", + :blue => "#0b8ef1" +}.freeze Although there is a gotcha with print css. If markers are supposed to be colored in print style, these colors need to be included there too. -- Repl

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > +MARKER_COLORS = { + :red => "#f6110a", + :green => "#9cef11", + :blue => "#0b8ef1" +}.freeze Why not css properties? That's where I'd expect to find color definitions. You can put something like this in `common.scss`: ```css :root { --marker

[openstreetmap/openstreetmap-website] Change edit link to profile location in dashboard (PR #6206)

When you don't have your home location set, this link in your dashboard leads to *Profile Description*: It makes more sense to link to *Profile Location* instead.

[openstreetmap/openstreetmap-website] Remove inkscape/sodipodi tags/attributes from osm forum icon (PR #6205)

...because I looked at the file in #6159. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6205 -- Commit Summary -- * Remove from osm forum icon * Remove inkscape:collect attributes from osm

Re: [openstreetmap/openstreetmap-website] Switch inline style to attributes (PR #6159)

Merged #6159 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6159#event-18701240526 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6204) It's a private method. We have private methods at the end of the file. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6204#issuecomment-3089469079 You are rece

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > @@ -3,6 +3,7 @@ <% end %> <%= render :partial => "layouts/control_icons", :locals => { :icons => %w[zoomin zoomout geolocate] } %> +<%= render :partial => "layouts/markers", :locals => { :types => %w[dot] } %> The same thing is needed in: - `a

Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)

@AntonKhorev commented on this pull request. > @@ -79,3 +79,12 @@ osm_france_link: id: "osm_france" href: "https://openstreetmap.fr/"; + +- leafletOsmId: "Shortbread" + code: "S" + layerId: "shortbread" + nameId: "shortbread" You can add `maxZoom: 22` here because va

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6197) > Or at least preferring `osmwiki:P8` and `wikidata:P1630` as sources before > falling back to `wikidata:P3303`. But I assume the `preferred` rank would > take care of most of that anyways. In my example with `icao=*` preferr

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6202) Merged, thanks. Apparently GitHub doesn't generate notifications if the only thing that changes are commit messages. You might want to leave a reply in this case. -- Reply to this email directly or view it on GitHub: https:/

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

Merged #6202 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6202#event-18699136608 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > + draggable="true"> + + Changes I had to make to keep drag events working (1/3): ```suggestion ``` > + dra

[openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

Sometimes items passed to get_page_items are already ordered. That order needs to be replaced by cursor_column instead of adding cursor_column after the existing order. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev pushed 1 commit. 4116ebf421f853a055880c04a00310a71586b3f0 Add a task to register iD and web OAuth apps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/ae9e66619e9f2d92bbc677000e70616cff86680d..4116ebf421f853a055880c04a00310a71586b3f0 Yo

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev commented on this pull request. > @@ -57,6 +57,19 @@ There are two built-in applications which communicate via > the API, and therefore * iD * The website itself (for the Notes functionality) +You can register them by running a script and copying its output to `config/settings

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev pushed 1 commit. ae9e66619e9f2d92bbc677000e70616cff86680d Add a task to register iD and web OAuth apps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/65f03637b17e90e455fe9f571dcf9c7c78e23a6d..ae9e66619e9f2d92bbc677000e70616cff86680d Yo

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

@AntonKhorev commented on this pull request. > @@ -171,8 +171,8 @@ .addClass("bg-body-tertiary"); if (icon && OSM.WIKIMEDIA_COMMONS_URL) { - let src = OSM.WIKIMEDIA_COMMONS_URL + "Special:Redirect/file/" + encodeURIComponent(icon); - if (!icon.endsWith(".svg")) src += "?

Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)

@AntonKhorev commented on this pull request. > @@ -56,151 +62,158 @@ sudo dnf install ruby ruby-devel rubygem-rdoc > rubygem-bundler rubygems \ If you didn't already have PostgreSQL installed then create a PostgreSQL instance and start the server: -``` +```bash sudo postgresql-setup init

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6191) Updated as a rake task. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191#issuecomment-3084943417 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev pushed 1 commit. 65f03637b17e90e455fe9f571dcf9c7c78e23a6d Add a task to register iD and web OAuth apps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/2fa08b44f1be1b1f2a63fcd5b33fe4c21b6a56a1..65f03637b17e90e455fe9f571dcf9c7c78e23a6d Yo

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6197) Can we start with rejecting `"source": "wikidata:P3303"` *third-party formatter URL*? Because why should `icao=*` be linked to uk.flightaware.com and not anything else? -- Reply to this email directly or view it on GitHub: h

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127) Merged, thanks. For admins: if Wikimedia wouldn't like hotlinking to their images, set `wikimedia_commons_url` to an empty string. But we're doing this and more from iD already. -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

Merged #6127 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127#event-18680589895 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Don't do partial renders for turbo page visits (PR #6187)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187) Not using Turbo is even more future proof, if we're not interested in making responses faster. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6187#issuecommen

Re: [openstreetmap/openstreetmap-website] Don't do partial renders for turbo page visits (PR #6187)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187) I updated my #5175. It only changes controllers that use turbo pagination. Their `frame.html.erb` isn't entirely working for us because we have a lot of stuff inside `` that's not added using `content_for :head`. I'm including

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. ecd71349bc68c8d74aeef43e6df318c787dd2967 Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c..ecd71349bc68c8d74aeef43e6df318c787dd2967 You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. 4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4cb5a6d73854711b4d4731d50ef84a983f56eb21..4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. 4cb5a6d73854711b4d4731d50ef84a983f56eb21 Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/da7a6e401c41792692119fda54ddf2e0386d69f3..4cb5a6d73854711b4d4731d50ef84a983f56eb21 You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. da7a6e401c41792692119fda54ddf2e0386d69f3 Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782..da7a6e401c41792692119fda54ddf2e0386d69f3 You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. 4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782 Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/6069986a2ddd5a4910762fcf8719ba4781f7ee2f..4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782 You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. 6069986a2ddd5a4910762fcf8719ba4781f7ee2f Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/84358dd483aaedec305bcc9d35c3d7b97675e46f..6069986a2ddd5a4910762fcf8719ba4781f7ee2f You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. 84358dd483aaedec305bcc9d35c3d7b97675e46f Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/f08e7510615d0e20fc11b72e9bed43a6c4945fde..84358dd483aaedec305bcc9d35c3d7b97675e46f You are rece

Re: [openstreetmap/openstreetmap-website] Send along with pagination frames (PR #5175)

@AntonKhorev pushed 1 commit. f08e7510615d0e20fc11b72e9bed43a6c4945fde Send along with pagination frames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/20ab67e603ef795bb0fc77f420df79a22d6b6204..f08e7510615d0e20fc11b72e9bed43a6c4945fde You are rece

Re: [openstreetmap/openstreetmap-website] Image download w/ submit_tag (PR #6192)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192) > > Would it? Is it even required by the exporter? > > Yes, it's explicitly checked here [...] I didn't notice that the cookie is being sent even when I'm using my own osm-website instance, and the cookie is going to be valid

Re: [openstreetmap/openstreetmap-website] Image download w/ submit_tag (PR #6192)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192) During preflight the export script shouldn't look at cookies because it won't receive any cookies. So it should quit with 204 [here](https://github.com/openstreetmap/chef/blob/849abef3edeac8e563ad793f55dd4bdea4b9b232/cookbooks

Re: [openstreetmap/openstreetmap-website] Image download w/ submit_tag (PR #6192)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192) > Somehow this last bit never worked when testing the new code. If I don't > manually remove the "disabled" attribute, it will remain disabled until I > reload the page. Add `data-turbo="true"` to the form: ```html ``` --

Re: [openstreetmap/openstreetmap-website] Image download w/ submit_tag (PR #6192)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192) > CSP doesn't allow render.openstreetmap.org Easily fixed by allowing them. They are already allowed for `form_action`, just add them to `connect_src` too. > the required totp cookie would be lost Would it? Is it even requir

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > +if (!entities) return Promise.reject(entities); +$btn + .closest("tr") + .after( +items + .filter(qid => entities[qid]) + .map(qid => getLocalizedResponse(entities[qid])) +

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > @@ -1,10 +1,18 @@ (function () { + let abortController = null; + const langs = [...new Set([...OSM.preferred_languages.map(l => l.toLowerCase()), "mul", "en"])]; Can we give this a more specific name than `langs` to avoid guessing what it actu

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > @@ -101,4 +112,108 @@ scrollableList.scrollLeft = scrollableList.scrollWidth - scrollableList.offsetWidth; } } + + function previewWikidataValue($btn) { +if (!OSM.WIKIDATA_API_URL) return; +const items = $btn.data("qids"); +

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > +if (data.icon && OSM.WIKIMEDIA_COMMONS_URL) { + let src = OSM.WIKIMEDIA_COMMONS_URL + "Special:Redirect/file/" + encodeURIComponent(data.icon); + if (!data.icon.endsWith(".svg")) src += "?width=128"; + $("") +.attr("href

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > +.appendTo(cell); +} +if (data.label) { + const label = $btn +.siblings(`a[href*="wikidata.org/entity/${data.qid}"]`) +.clone() +.text(data.label.value) +.attr("dir", "auto"); + cell.append($

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > + $("") +.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + encodeURIComponent(data.icon)) +.append($("").attr({ src, height: "32" })) +.addClass("float-end mb-1 ms-2") +.appendTo(cell); +} +if (data.la

Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

@AntonKhorev commented on this pull request. > @@ -101,4 +112,108 @@ scrollableList.scrollLeft = scrollableList.scrollWidth - scrollableList.offsetWidth; } } + + function previewWikidataValue($btn) { +if (!OSM.WIKIDATA_API_URL) return; +const items = $btn.data("qids"); +

[openstreetmap/openstreetmap-website] Clear floats in diary entries (PR #6196)

Fixes #6186. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6196 -- Commit Summary -- * Clear floats in diary entries -- File Changes -- M app/views/diary_entries/_diary_entry.html.erb (2) M test/system/di

Re: [openstreetmap/openstreetmap-website] What is aria-label? (Issue #6195)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6195) The ones you found on a profile page are `diary_entries.profile_diaries.*_label`. They are used to label icons. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issu

Re: [openstreetmap/openstreetmap-website] Store routing icons separately (PR #6189)

@AntonKhorev commented on this pull request. > - - - - - - - - - - - - + + <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %> +<%= inline_svg_tag "routing/#{File.basename(path)}", :id => "routing-sprite-#{File.basename(path, '.svg')}",

Re: [openstreetmap/openstreetmap-website] Drop KaiOS 2.5 support to fix placeholder styling in Firefox (PR #6185)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6185) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6185#issuecomment-3067257973 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Drop KaiOS 2.5 support to fix placeholder styling in Firefox (PR #6185)

Merged #6185 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6185#event-18606475890 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 18 commits. 6e664ca309503202f007fac0fc33e98a0c3a4d53 Add create/modify/delete counts to changeset table b362026db078d85205d7adb17cad00e4d187ef4c Validate changeset num_*_changes 57a204d591f543d6a4c24f98830f9355deae5d39 Add type changes in sync predicate to changesets fb3a4

[openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

I had to reinstall openstreetmap-website and decided to automate the [OAuth app registration step](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONFIGURE.md#oauth-consumer-keys). You can view, comment on, or merge this pull request online at: https://github.com/openstree

Re: [openstreetmap/openstreetmap-website] Store routing icons separately (PR #6189)

@AntonKhorev commented on this pull request. > - - - - - - - - - - - - + + <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %> +<%= inline_svg_tag "routing/#{File.basename(path)}", :id => "routing-sprite-#{File.basename(path, '.svg')}",

Re: [openstreetmap/openstreetmap-website] Store routing icons separately (PR #6189)

@AntonKhorev commented on this pull request. > +module OpenStreetMap + class SvgCurrentColorTransform < InlineSvg::CustomTransformation +def transform(doc) + doc.xpath("//@fill|//@stroke").each do |attr| +attr.value = "currentColor" if attr.value.strip.downcase == value +

Re: [openstreetmap/openstreetmap-website] Store routing icons separately (PR #6189)

@AntonKhorev commented on this pull request. > +module OpenStreetMap + class SvgCurrentColorTransform < InlineSvg::CustomTransformation +def transform(doc) + doc.xpath("//@fill|//@stroke").each do |attr| +attr.value = "currentColor" if attr.value.strip.downcase == value +

Re: [openstreetmap/openstreetmap-website] Don't do partial renders for turbo page visits (PR #6187)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187) This is the intended layout: https://github.com/hotwired/turbo-rails/blob/main/app/views/layouts/turbo_rails/frame.html.erb -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-

Re: [openstreetmap/openstreetmap-website] Data layer: When requesting too much data, link directly to planet.openstreetmap.org (Issue #6188)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6188) I don't think cgimap should say which service to use in case of an error. Isn't cgimap also used on OpenHistoricalMap too? The link to planet.openstreetmap.org should be displayed by the client, if it's possible to determine t

Re: [openstreetmap/openstreetmap-website] Stop GitHub form cancelling related workflows early (PR #6151)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151) > And currently, I don't see test failures being even close to the necessary > 95.2% bug-caused failure rate. The premise of [your question](https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-301954

Re: [openstreetmap/openstreetmap-website] Don't do partial renders for turbo page visits (PR #6187)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187) But you don't have to resend the entire page. #5175 fixed this by sending `` + partial without the rest of the page. However that wasn't the only issue, another one was #6112 and at the time I didn't know how/if it was relate

Re: [openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880) I [asked](https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813465994) @hlfan how the following *both* things are supposed to work together: - manipulations of svg internals like https://github.co

Re: [openstreetmap/openstreetmap-website] Stop GitHub form cancelling related workflows early (PR #6151)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151) The step was either successful or it was cancelled. The entire run was cancelled to not waste time running tests that need to be rerun after fixing bugs that are already found by other tests (assuming https://github.com/opens

[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split relation tests (PR #6182)

Part of https://github.com/openstreetmap/openstreetmap-website/pull/6170. Like https://github.com/openstreetmap/openstreetmap-website/pull/6178 and #6181 but for relations controller. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap

[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split way tests (PR #6181)

Part of https://github.com/openstreetmap/openstreetmap-website/pull/6170. Like #6178 but for ways controller. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6181 -- Commit Summary -- * Split create way tests * Sp

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 35 commits. 11ebba70651d2d20211f926bce3d4fb97f59034a Split create way tests ace80ff3e2f3cbcc505fa70c12d1b263f2fddf52 Split create way with invalid payload tests fc15dccc6228df59b03e4707eddae4b6ab9e96bc Split destroy way tests a2c0f7a2b0c38e478f03acfa1277302db8429cf3 Split

Re: [openstreetmap/openstreetmap-website] Paging interferes with logout flow (Issue #6172)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6172) Logout is not the only thing paging interferes with. See #5175 and #6112. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6172#issuecomment-3063082430 You are

[openstreetmap/openstreetmap-website] Add Bootstrap .modal class to print styles to hide language select dialog (PR #6180)

Fixes https://github.com/openstreetmap/openstreetmap-website/pull/6119#issuecomment-3059447787 by making Bootstrap modals hidden by default. Similar to #5999. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6180 -- C

Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

@AntonKhorev commented on this pull request. > + session_for(user) + + freeze_time do +put account_terms_path, :params => { :referer => "/test", :read_ct => 1, :read_tou => 1 } + +assert_redirected_to "/test" +assert_equal "Thanks for accepting the new contribu

Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

@AntonKhorev pushed 3 commits. bdb65921f1cb953b5488e88c62f815d3a9c791f9 Allow to revisit terms page if already agreed 18a25c66f9df096d5b7b1f5593c8b4945a583c00 Allow to agree to new terms if already agreed to old terms d97ef45337c07e80840b3ba24447f8161d5aa68a Show terms acceptance dates and li

[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Element upload tests (PR #6179)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6179 -- Commit Summary -- * Test create single element changeset uploads * Test modify single element changeset uploads * Test delete single element changeset uplo

[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split node tests (PR #6178)

Part of #6170. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6178 -- Commit Summary -- * Create api elements test helper module * Add common api element testing methods * Split create node tests * Split creat

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 46 commits. c2159c5d0069acace5799f8b7702fb8c0beb7d68 Create api elements test helper module 9956a64e05f6b1a60c66fbcd70cdb1c601f52682 Add common api element testing methods 37570ffd3fe52d8b7ea4bc514a7bb90ab71f12b2 Split create node tests dc3c5aa783cb01ea72f2d8432ce91cc082f254

Re: [openstreetmap/openstreetmap-website] Should we remove changeset-color-hint-bar again? (Issue #6177)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6177) You can't remove them "again" because they were never removed before. Color mismatch is because of opacity, and opacity is there for a couple of reasons[^1] that can be addressed. [^1]: *viewport size for intersection observe

[openstreetmap/openstreetmap-website] Various API changesets/elements controller test updates (PR #6176)

A number of changes to api changesets, nodes, ways and relations controllers going towards #6170. I split the existing tests there to make them independent. This PR contains changes prior to the splits. You can view, comment on, or merge this pull request online at: https://github.com/openstre

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 15 commits. cf3067864676a551fdefd911c24bdaae65fede61 Add total created/modified/deleted counts to changesets 9afb74fd91722126e2b26478c806c402bc3b0bac Test that new changeset has type changes in sync 1e23d6f2ba3a998868df1ac0f65ba578c4d83f47 Test that failed/empty changeset

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 2 commits. 686eff4f80c5b74cd7a6afcf31ebe124e87384fc Update number of deleted ways in changeset 0dd348608bd46c92d79e292fa8ea6c49b707db5a Update number of deleted relations in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/f

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 14 commits. b3cb0a70e3245eca22048feece3cc54aab83a958 Test delete single element changeset uploads fed064a9422f2ce9a4285f0c755df78511afd21c Add create/modify/delete counts to changeset table f2ee239121c129f07cb17d804c3fff544f3c5c74 Validate changeset num_*_changes 5f8bac642

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 16 commits. 15954c94931f183200c52aefaf5678720d5b1f85 Test updating relation 1ecf57e6926a6dd5ebda9286114191355db4115b Split destroy relation tests 0468e267154bbd3a8b0ffdf79467df03c14366a3 Test create single element changeset uploads 0833aee2ee9639b4387e4fa3bfc7c2275996445b

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 1 commit. 11223a0aaebec03b2da2cda78e7270154fbfc56a Update number of modified ways in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/9aac311abfbf8cf59b501dbc79d64e63a398c303..11223a0aaebec03b2da2cda78e7270154fbfc56a You

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 1 commit. 9aac311abfbf8cf59b501dbc79d64e63a398c303 Update number of modified nodes in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/53f1e6041faad325111facf528f7963ae3eac673..9aac311abfbf8cf59b501dbc79d64e63a398c303 Yo

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 11 commits. bfe3f726c061479418311967fef865bf11018c14 Test create single element changeset uploads 6bd01c573cd9b0c432c5bfa861db8a74069e8189 Test modify single element changeset uploads d734135797e2fff58000a0c02b48069a8740495d Add create/modify/delete counts to changeset ta

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 1 commit. 2810430540abd27f4f9e6a4e71aa03c5a4658efd Update number of created relations in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/44eddda13c7b96f49a9b563cb242e6c3c290ecf8..2810430540abd27f4f9e6a4e71aa03c5a4658efd

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 31 commits. b17492914e509d01d1087791c39366620fd4d07c Split create node tests b09723a6cd08860200fc9f37715d554bdd5e68af Split create node with invalid payload tests 6241c5b8b1d81bfa83dedc11e4c4b64d3e5a2e2f Rename node decimal format test afda4398765aceaabb389c05f0af1d8662a726

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 34 commits. 74daf133ca0fa3dbb49bd6ac956848670c258aea Replace multiline strings with heredocs api elements test xml c0abe142ebb23be3d1416fdde9e38165ba9977cf Create api elements test helper module 6abd375f769f63b05f82bffad57976b8f8bb588e Add common api element testing methods

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 3 commits. 3b3c450e3c0d78ce9be85f9d210ea248120c1fc3 Add common api element test methods 70ce9eb59713da400e85b3c1bedb483d5d28b825 Make other relation id update test similar to other relation tests c21c622956455ffa94ea53a4755640e757e0ab99 Split destroy relation tests -- Vie

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 1 commit. 4108002fb5405053edbb392c08b8a06c40ef7f95 WIP refactor with_unchanging_request -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/e0ddd55543beb9d13d5519861e0252c4e12751e9..4108002fb5405053edbb392c08b8a06c40ef7f95 You are rec

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 1 commit. e0ddd55543beb9d13d5519861e0252c4e12751e9 WIP refactor WaysControllerTest -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/a9b46711aea39cac09674c892108ba58709c7ac6..e0ddd55543beb9d13d5519861e0252c4e12751e9 You are receivin

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 14 commits. 0fd88662d3624b046f2fde69662594deb8e307e4 Split tests of node updates with invalid attr values e5737886275284bd53fa8db1e0986115fd2cb8b5 WIP assert_no_changes_in_db; +18 lines 94fcfdfe61d2a570034fdbb37f0b5f99471afaf9 WIP with_actor cb5561e1daf9dfdd80a9a266de5a8934

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 7 commits. 29d33a7942728c272ebb07338917ac6c9b39bbfd Test that failed changeset uploads keep type changes in sync 09e7c658be6690239649265b993a95f5f971d7dc Test that failed node actions keep type changes in sync 515ad1d6eded39f17276db1e998331aa05ee4ee3 Test that failed way a

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 2 commits. eedf13ed3fdc0b41dd380f2a935bd2d08c1357cb Make missing node member test similar to create relation tests 4ef94eb40f6a25b97574856db8082fb63c34e31e Make invalid type member test similar to create relation tests -- View it on GitHub: https://github.com/openstreetma

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 23 commits. ab543fe4359d16203a6111f4313c11207c2a9bec Split create way tests 0b4a8243c8ccb78f69728aac288be60b5d68f909 Split create way with invalid payload tests 60809bbf6d31aa73c72a931b501742b5e777995b Split destroy way tests e41bc14da9e45c2be372d096359f8c7dafb77b2f Split

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 2 commits. 24c1429b50b94b865b4a4977fd6b08ff1c4c248a Update number of created nodes in changeset 3c4bb0026252182b2862255e58ced9f7d8d9ebe5 Update number of created ways in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 4 commits. 72b173456f315f3b30c1817930b0f6ac075ea8bc Test that failed create way actions keep type changes in sync 3b4bf2aa4b7ce81d94704e8258f0b82cb82b4584 Test that failed destroy way actions keep type changes in sync 5f49339b530ad449d236f83f7d2c437d3fd42e82 Test that fail

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 32 commits. be5ff68aa616eeb538e9a27a487ee5d94428440f Remove redundant changeset create by private user test f3597d5a30b9933e2c5640ef802a858774a4676d Test that changeset create action creates one changeset 28a5ee8a0a9614a2d716bc932f3a3b3bfb387d0b Actually test if changeset

[openstreetmap/openstreetmap-website] Move integration tests out of api relation controller tests (PR #6171)

You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6171 -- Commit Summary -- * Assert that hashes are equal without iterating over items * Remove sorting before converting tags to hash * Shorten tags to hash conver

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 16 commits. 873585bd7bdf54920e544281dd9d7acebcf63d95 Split destroy way tests 6feb5c7d394795f2e8f7453425953f6c8ed224f1 Split update way tests d734bf47376cdf79ea66447fdde4d212f028dd71 Test single element changeset uploads c8dc2388722148032014e537047d54d22d3499fc Add create/mo

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 17 commits. 87e2e57eddcf4c2bb93e3a8f1ee31a72a4bef023 Split create way with invalid payload tests f6aaaec7002d0698ba7f55e151acfe4cb13d9978 Split destroy way tests fd4c3bd9a9ac2fcd54b062d278e2bddda9417dcf Split update way tests 610b72d01a22a659b743a827a6f1dbb60e22c4a8 Test s

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 18 commits. 21b232abc26df5bcf03a7390eac04f2e0e6a118f Split create way tests 85bbf45fc78207c0661ba0423f264469e18aedf6 Split create way with invalid payload tests 3487f1bb564c9e251c3bafa394eccf6608d835c2 Split destroy way tests cd390afbd1beaa0b74dd5e84276193f671778aa5 Split

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

@AntonKhorev pushed 2 commits. d0909acd35e2b78d5b881bb834828d64e7afa473 Split update way with existing duplicate tags tests 8ec06edcaa1ced42ad22c76e2e3700885b3d4038 Split update way with new duplicate tags tests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pul

  1   2   3   4   5   6   7   8   9   10   >