gravitystorm left a comment (openstreetmap/openstreetmap-website#5979)
> I [updated the
> documentation](https://wiki.openstreetmap.org/wiki/Special:Diff/2852642) to
> reflect the removal.
It hasn't been removed - see https://www.openstreetmap.org/api/capabilities .
This PR was just some refac
gravitystorm left a comment (openstreetmap/openstreetmap-website#5979)
> I think, as long as API clients don't implement the new way, you can't make
> any progress on the deprecation
My original plan, fwiw, was to keep the /api/capabilities call as returning the
same response as /api/0.6/capabi
gravitystorm left a comment (openstreetmap/openstreetmap-website#5979)
> JOSM needs to call /api/versions + /api/0.6/capabilities, instead of
> /api/capabilities as it is today.
Only if it supports multiple API versions. From the original commit message,
"If a client only supports one version
t
gravitystorm left a comment (openstreetmap/openstreetmap-website#5988)
> You can just bump that limit - anything in `.rubocop_todo.yml` is just there
> to allow things that we haven't got around to doing anything yet and for
> those metrics ones at least it's not at all clear what if anything we
gravitystorm left a comment (openstreetmap/openstreetmap-website#5932)
>From https://bugs.ruby-lang.org/issues/20205
> And any application for which all dependencies have been made fully frozen
> string literal compatible can set RUBYOPT="--enable=frozen_string_literal"
> and start immediately
Closed #5908.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5908#event-17192941623
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878)
This is a problem in the `ru` (and perhaps other) translations. The translators
have hard-coded the "specifically one" translation into the "numbers that
behave like one" key:
```yaml
datetime:
distance_in_words_ago:
Merged #5876 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5876#event-17098197107
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#2392)
I've fixed the remaining links over the last few weeks myself, so this task is
finally complete! Thanks to everyone who helped here and over at translatewiki
too.
--
Reply to this email directly or view it on GitHub:
https:
This removes the arbitrary pixel-based alignment of the globe, which did not
take tab label translations into account. Instead, we give as much space as
possible to the tabs, by aligning to the end of the container (right-hand side
on LTR, left hand side on RTL).
Refs #4773
You can view, comme
Closed #4773 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4773#event-17097865600
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
gravitystorm left a comment (openstreetmap/openstreetmap-website#5670)
I've seen the thumbs up from both @matkoniecz and @hlfan for my suggestion to
close this, so closing now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/56
Closed #5670 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#event-16842790977
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
gravitystorm left a comment (openstreetmap/openstreetmap-website#5869)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#issuecomment-2773223180
You are receiving this because you are subscribed to this thread.
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878)
And on the wider topic, perhaps we should enforce the usage of the `%{count}`
interpolation in all translations, to avoid similar things from happening
there? Not all of our translators know about these edge cases.
--
Reply
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878)
> Can `%{count}` be anything other that 1 in "less than %{count} second ago"?
https://github.com/rails/rails/blob/3235827585d87661942c91bc81f64f56d710f0b2/actionview/lib/action_view/helpers/date_helper.rb#L114-L116
For `:less
Closed #5789.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5789#event-17098210229
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
gravitystorm created an issue (openstreetmap/openstreetmap-website#5880)
I've seen a lot of PRs recently where we are inlining SVGs into the output
html, rather than having them as sprites or standalone images. I can see the
benefit of doing so, particularly for the ability to set
`stroke="curr
gravitystorm left a comment (openstreetmap/openstreetmap-website#5789)
I'm going to close this now, since we haven't had a response from @Artyom10-Pt
. Please feel free to get in touch when you have time to respond.
--
Reply to this email directly or view it on GitHub:
https://github.com/openst
gravitystorm left a comment (openstreetmap/openstreetmap-website#5878)
> * "yesterday" instead of "%{count} day ago"
Those are incorrect, and they should be converted to be "1 day ago" (or "one
day ago" at least). The `x_days` key is used with `:count => 1` [for 24...42
hours
ago](https://git
Merged #5873 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5873#event-17097886509
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5876)
Looks good! Thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5876#issuecomment-2773244974
You are receiving this because you are subscribed to this thre
Merged #5869 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5869#event-17098072609
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5873)
Merged, thanks. Thanks also to @hlfan and @HolgerJeromin for your reviews.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5873#issuecomment-2773193183
You are
gravitystorm left a comment (openstreetmap/openstreetmap-website#4773)
I've reviewed the remaining work on this issue, and aside from
https://github.com/openstreetmap/openstreetmap-website/pull/5879 I don't think
there's more here that's worth tackling (on an effort/reward basis). So I'm
closin
Closed #2392 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2392#event-17075960544
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Merged #5849 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5849#event-17008459672
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5849)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5849#issuecomment-2757253579
You are receiving this because you are subscribed to this thread.
Closed #5329 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#event-16994273641
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
gravitystorm left a comment (openstreetmap/openstreetmap-website#5848)
Merged, thanks for figuring this out!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5848#issuecomment-2755089600
You are receiving this because you are subsc
Closed #5847 as completed via #5848.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#event-16996710379
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5847 as completed via 1d89cee94672ed09ba1733cae76142b69f72b3cc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5847#event-16996710444
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5848 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5848#event-16996710106
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5845)
@RilusMahmud Thanks for reporting this problem! We've now fixed it in the
latest commits. If you update your repository, the migrations will now run
properly.
--
Reply to this email directly or view it on GitHub:
https://gi
gravitystorm left a comment (openstreetmap/openstreetmap-website#5329)
If there's any dark-mode inconsistencies or similar in the UI that have been
missed, please open separate issues for them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5328)
I'm closing this issue now, because the dark mode maps are now implemented as
described above.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issueco
gravitystorm created an issue (openstreetmap/openstreetmap-website#5847)
We have code to run the migrations in CI, mostly to make sure that when they
run, they produce the same results as structure.sql
When we upgraded to Rails 8, however, these migrations no longer run. I believe
it's because,
We previously pinned to an old version for ruby 3.1 support, but that's no
longer required since rails needs 3.2 anyway.
Fixes #5845
I'll follow up with the issue about why CI didn't catch this.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/o
Closed #5328 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#event-16994261489
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Closed #557 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/557#event-16907702765
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
gravitystorm left a comment (openstreetmap/openstreetmap-website#5785)
Thanks for following up on this. I still stand by it being a duplicate
(although I apologise for having missed that part of your description) because
changeset comment bodies are just a single example of what the existing iss
Closed #5785 as duplicate.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5785#event-16907949306
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
gravitystorm left a comment (openstreetmap/openstreetmap-website#5785)
Duplicate of #3428
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5785#issuecomment-2740265238
You are receiving this because you are subscribed to this thr
gravitystorm left a comment (openstreetmap/openstreetmap-website#557)
Fixed by https://github.com/openstreetmap/openstreetmap-website/pull/4133
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/557#issuecomment-2740258100
You are
Merged #5430 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430#event-16907147953
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5430)
Thanks! Merged now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5430#issuecomment-2740190320
You are receiving this because you are subscribed to this thre
gravitystorm left a comment (openstreetmap/openstreetmap-website#5430)
All looks good to me, just need to clarify what's happening with
canonical_rails. This PR has the config completely commented out. Is the config
no longer necessary, or is the gem not working?
--
Reply to this email directl
gravitystorm left a comment (openstreetmap/openstreetmap-website#5820)
Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#issuecomment-2737282084
You are receiving this because you are subscribed to this thread.
Merged #5820 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5820#event-16871421060
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5797)
Thanks both!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5797#issuecomment-2734350231
You are receiving this because you are subscribed to this thread.
Me
gravitystorm left a comment (openstreetmap/openstreetmap-website#5539)
@rkoeze Yes, that one definitely needs some refactoring!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5539#issuecomment-2732628902
You are receiving this
Closed #5772 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5772#event-16733951896
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
gravitystorm left a comment (openstreetmap/openstreetmap-website#5789)
Hi @Artyom10-Pt thanks for your PR. It looks like you've removed lots of gems
that we rely on, like bootstrap. You can see more information in the output of
the CI checks.
If you'd like to tell us a bit more about what you a
gravitystorm left a comment (openstreetmap/openstreetmap-website#5772)
Closed by #5792
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5772#issuecomment-2720893378
You are receiving this because you are subscribed to this thread
gravitystorm left a comment (openstreetmap/openstreetmap-website#5769)
@aceman444 Thanks for the additional details. It would be helpful if you can
share the exact slovakian translations of:
- A duration of time: "about 10 years"
- A time in the future: "in about 10 years"
- Describing somet
gravitystorm left a comment (openstreetmap/openstreetmap-website#5769)
As far as I can see so far, we have a few issues here.
* We can't translate every sentence that contains a duration, future time or
past time separately. We have [13 different types of
time](https://github.com/openstreetmap/
Reopened #5769.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5769#event-16694291283
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
gravitystorm left a comment (openstreetmap/openstreetmap-website#5769)
> It will come from https://github.com/svenfuchs/rails-i18n but some of them
> have been copied into our locale files I think.
You might be thinking of
https://github.com/openstreetmap/openstreetmap-website/issues/2255, wher
gravitystorm left a comment (openstreetmap/openstreetmap-website#5784)
> I am also open to any suggestions on how to tidy up this PR of mine if that's
> possible! Thank you!
Yes it's possible, using something like `git rebase -i`. This allows you to
rearrange commits, squash two commits togethe
gravitystorm left a comment (openstreetmap/openstreetmap-website#5766)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5766#issuecomment-2706628260
You are receiving this because you are subscribed to this thread.
Merged #5766 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5766#event-16633632928
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5733)
Re-opening, since we try to support developers with fresh installs, up to the
point that they can get the tests running.
@jessequinn I'm sorry to see that it's not working for you. Can you confirm for
me (and everyone else w
Reopened #5733.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5733#event-16516312905
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
@gravitystorm commented on this pull request.
> @@ -581,6 +581,15 @@ header .search_forms,
}
}
+.search_forms {
We try hard to avoid writing custom CSS for features on the website -
typically, we only use Bootstrap classes applied directly to the elements.
Most existing CSS in this file
gravitystorm left a comment (openstreetmap/openstreetmap-website#5696)
> Thanks. I don't know what the answer is on the redirects but I'll merge this
> - we can always remove those later if we can confirm they're not being used.
I've always assumed that any "GET" page might be linked from elsewh
These were not needed at the end of most tests for quite some time, since rails
clears them by default for controller and integration tests, and also no longer
required in system tests after #5691
There's still some calls that could be removed, for example by also
automatically clearing `job` t
gravitystorm left a comment (openstreetmap/openstreetmap-website#5692)
Yes, I agree. I used to think this was useful, but see all my previous mentions
of "Github flavoured Ubuntu" that shows it is of limited utility.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
Merged #5692 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5692#event-16324606222
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5687 as completed via #5691.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5687#event-16324419577
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5687 as completed via 8fcd4513fcbffec76cc2c1a807810f7ab9b3446f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5687#event-16324419587
You are receiving this because you are subscribed to this thread.
Message ID:
__
gravitystorm left a comment (openstreetmap/openstreetmap-website#5691)
Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5691#issuecomment-2661465853
You are receiving this because you are subscribed to this thread.
Message
gravitystorm left a comment (openstreetmap/openstreetmap-website#5690)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5690#issuecomment-2661465692
You are receiving this because you are subscribed to this thread.
Merged #5691 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5691#event-16324419542
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5690 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5690#event-16324416245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5688 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5688#event-16324354818
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5689 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5689#event-16324350553
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5689)
Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5689#issuecomment-2661453329
You are receiving this because you are subscribed to this thread.
gravitystorm left a comment (openstreetmap/openstreetmap-website#5619)
> Have you also evaluated the other way around, i.e. change the model names to
> match the db table names?
Yes, I've considered it. But I think that in some cases this would not be
wanted - for example, renaming the `Follow
@gravitystorm requested changes on this pull request.
Needs tests. Mostly just to demonstrate to other developers what it's supposed
to achieve, but also so that if we add auto-close for issues (or similar) in
future, we don't accidentally break this part during refactoring.
--
Reply to this
gravitystorm left a comment (openstreetmap/openstreetmap-website#5453)
I think I would prefer something similar to #5449 (reasoning at
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578415862
).
--
Reply to this email directly or view it on GitHub:
https://githu
gravitystorm left a comment (openstreetmap/openstreetmap-website#5670)
> Reporting failed job as success would not be really better in this case.
If I understand correctly, this is not failed jobs but jobs with errors. So if
the job runs, but for example the overall coverage is too low, then the
gravitystorm left a comment (openstreetmap/openstreetmap-website#5676)
Merged thanks. As discussed, a followup could be for the report creation
process to also trigger the `user.spam_check` process
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Merged #5558 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#event-16324026567
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5676 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5676#event-16324034251
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5558)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2661394390
You are receiving this because you are subscribed to this thread.
gravitystorm created an issue (openstreetmap/openstreetmap-website#5687)
In the last few days I've seen a lot of test suite failures with messages
similar to:
```
Failure:
UserSignupTest#test_Sign_up_with_confirmation_email
[test/system/user_signup_test.rb:37]:
expected to find text "new_user_a
@gravitystorm approved this pull request.
Needs rebase, but otherwise looks good to me. I agree it would be good to merge
this as soon as we can.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2619575372
gravitystorm left a comment (openstreetmap/openstreetmap-website#5677)
Could do with some tests, and there's no handling of error states if you (ahem)
make a mistake when entering IP subnets.
But otherwise looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.c
Merged #5677 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5677#event-16322233551
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@gravitystorm pushed 1 commit.
2edceb4b613c572ca330e5bb1fcd9974f23119d5 Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/552f82ad4e37c5dffc2d2d3b18822a6eedefea2e..2edceb4b613c572ca330e5bb1fcd9974f23119d5
It's hard to make a distinction between 'Preferences' and
'Settings' in some languages, and many other sites use the term
'Account' for things like changing email.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5681
@gravitystorm pushed 1 commit.
b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/0a4977c0654e91bf8643e2495d42878056a2834b..b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c
@gravitystorm pushed 1 commit.
552f82ad4e37c5dffc2d2d3b18822a6eedefea2e Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c..552f82ad4e37c5dffc2d2d3b18822a6eedefea2e
In almost all tab navs we already use [title
case](https://en.wikipedia.org/wiki/Title_case), and this PR changes the
remaining few to match.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5680
-- Commit Summary --
Merged #5363 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5363#event-16321783639
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #4130 as completed via #5363.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4130#event-16321783673
You are receiving this because you are subscribed to this thread.
Message ID:
_
gravitystorm left a comment (openstreetmap/openstreetmap-website#5363)
This looks good to me, and in particular I'm grateful for the move towards
resolving #4130.
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
gravitystorm left a comment (openstreetmap/openstreetmap-website#5514)
Merged, thanks @AntonKhorev
I also agree with @simonpoole, and I would be happy to remove the check box
entirely and drop the database column too. However, I feel that this would be a
topic that would benefit from wider fee
Merged #5514 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5514#event-16321709529
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@gravitystorm commented on this pull request.
> @@ -347,15 +347,22 @@ L.OSM.Map = L.Map.extend({
},
setSidebarOverlaid: function (overlaid) {
-var sidebarWidth = 350;
+var mobileDeviceWidth =
window.getComputedStyle(document.documentElement).getPropertyValue("--bs-breakpoint-md"
1 - 100 of 342 matches
Mail list logo
