Re: [openstreetmap/openstreetmap-website] Rephrase strings with the word "followings" (PR #5857)

2025-04-05 Thread Amir E. Aharoni via rails-dev
@amire80 commented on this pull request. > @@ -578,7 +578,7 @@ en: use_map_link: Use Map index: title: "Users' Diaries" - title_followed: "Followings' Diaries" + title_followed: "Your Followed Users' diaries" Done in another commit. Thank you! -- Reply to this ema

Re: [openstreetmap/openstreetmap-website] Rephrase strings with the word "followings" (PR #5857)

2025-04-05 Thread Amir E. Aharoni via rails-dev
@amire80 pushed 1 commit. b6060413573ff720678d1bd47f56a3cd66363170 Update tests with "Followings" -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5857/files/1f5f2504edacc6942c54e5c558d5ece701affeb9..b6060413573ff720678d1bd47f56a3cd66363170 You are receiving thi

Re: [openstreetmap/openstreetmap-website] Rephrase strings with the word "followings" (PR #5857)

2025-04-05 Thread Amir E. Aharoni via rails-dev
@amire80 pushed 1 commit. c3e139f5834a06d29864f6ad710dabde551ed2ca Update the title_followed string according to code review comment -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5857/files/b6060413573ff720678d1bd47f56a3cd66363170..c3e139f5834a06d29864f6ad71

[openstreetmap/openstreetmap-website] Rephrase strings with the word "followings" (PR #5857)

2025-03-27 Thread Amir E. Aharoni via rails-dev
See issue #5856. I updated these strings to the best of my understanding, but I'm open to better suggestion to rephrase those strings. Thank you! You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5857 -- Commit Summary

[openstreetmap/openstreetmap-website] The word "followings" should probably be replaced in English strings (Issue #5856)

2025-03-27 Thread Amir E. Aharoni via rails-dev
amire80 created an issue (openstreetmap/openstreetmap-website#5856) "Friend" was replaced with "following" in 2b7a48029bff06c190544f91c5969b09aeae552b. I understand the general idea of it, but this created several instances of the word "followings", which sounds weird in this context as a plura

Re: [openstreetmap/openstreetmap-website] Add articles before "exit" and "roundabout" (PR #5292)

2024-10-26 Thread Amir E. Aharoni via rails-dev
I just clicked the wrong button by mistake :) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5292#issuecomment-2439627665 You are receiving this because you are subscribed to this thread. Message ID:

[openstreetmap/openstreetmap-website] Consistent use of quotes (PR #5291)

2024-10-26 Thread Amir E. Aharoni via rails-dev
Most strings used single quotes, and a few used opening backticks. Now it's single quotes everywhere. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5291 -- Commit Summary -- * Consistent use of quotes -- File Chan

Re: [openstreetmap/openstreetmap-website] Add articles before "exit" and "roundabout" (PR #5292)

2024-10-26 Thread Amir E. Aharoni via rails-dev
Reopened #5292. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5292#event-14906361286 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailin

Re: [openstreetmap/openstreetmap-website] Add articles before "exit" and "roundabout" (PR #5292)

2024-10-26 Thread Amir E. Aharoni via rails-dev
Closed #5292. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5292#event-14906082387 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Consistent use of quotes (PR #5291)

2024-10-26 Thread Amir E. Aharoni via rails-dev
@amire80 pushed 1 commit. 0d650217f4e805d7d40314bd471be0e53f0fde29 Consistent use of quotes -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5291/files/6e6cfa062ba87e3bd0cf83b0cc975f0b2e00..0d650217f4e805d7d40314bd471be0e53f0fde29 You are receiving this beca

[openstreetmap/openstreetmap-website] Add articles before "exit" and "roundabout" (PR #5292)

2024-10-26 Thread Amir E. Aharoni via rails-dev
There are articles before "ramp" everywhere, and it sounds more correct with articles before "exit" and "roundabout", too. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5292 -- Commit Summary -- * Add articles befo

Re: [openstreetmap/openstreetmap-website] Remove unnecessary comma from several translatable messages (PR #5220)

2024-09-17 Thread Amir E. Aharoni via rails-dev
Yes, but it's still unnecessary :) "data" or "history" is the subject (подлежащее), "took" is the verb (сказуемое), and there's no need for a comma between a subject and a verb. The old message with the unnecessary comma was probably copied to the recently-added ones, and it should be removed f

[openstreetmap/openstreetmap-website] Remove unnecessary comma from several translatable messages (PR #5220)

2024-09-17 Thread Amir E. Aharoni via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5220 -- Commit Summary -- * Remove unnecessary comma from several translatable messages -- File Changes -- M config/locales/en.yml (14) -- Patch Links -- https