hlfan left a comment (openstreetmap/openstreetmap-website#6192)
That includes the title in the HTML head, too; you'd probably only want to
output the body's text.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Well, the response really has to be HTML. In case of Thunderforest where we're
getting some plain text, jquery will fail with an exception "Error: Syntax
error, unrecognized expression: Requested image is too large."
For the form
hlfan left a comment (openstreetmap/openstreetmap-website#6192)
How about trying to parse the HTML?
```js
detailMessage = $(detailMessage).text()
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3095293681
You
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Last update for today. I did a bit of refactoring and split the larger
functions into smaller parts.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomm
@mmd-osm pushed 1 commit.
7370d311b26655911f0cf09390beddb1e9f2b7a7 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/ba31ffd976f9aa672c2e5a1c42068e80a604eaef..7370d311b26655911f0cf09390beddb1e9f2b7a7
You are receiving
ckdexterhaven left a comment (openstreetmap/openstreetmap-website#6214)
Thanks Tom
You’re awesome!
Greg Hechler
CEO Art Street Interactive, Inc.
***@***.**@***.***>
619 702 5069 direct
877 630 2033 toll free
From: Tom Hughes ***@***.***>
Sent: Sunday, July 20, 2025 1:24 PM
To: openstreetmap/
tomhughes left a comment (openstreetmap/openstreetmap-website#6214)
Edge will be the same because it uses the same engine as Chrome.
Firefox doesn't though, and unlike Chrome when a form redirects it doesn't
require the redirect to match the security policy.
--
Reply to this email directly or
ckdexterhaven left a comment (openstreetmap/openstreetmap-website#6214)
WOW! Thanks for the super quick response on a Sunday!!
Should I respond here or through the website support?
We were using Chrome, but I get the same error on Firefox, and Edge.
I wanted to confirm that I am on https://www.ope
@mmd-osm pushed 1 commit.
ba31ffd976f9aa672c2e5a1c42068e80a604eaef Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19..ba31ffd976f9aa672c2e5a1c42068e80a604eaef
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I gave it a quick try and reverted to the previous version. I'd say, let's keep
the text version, to avoid showing HTML tags in the popup:
https://github.com/user-attachments/assets/1d7f97f3-7e3d-4b22-a334-caf16c7dbc17";
/>
Mayb
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Seems reasonable to me... Should I maybe revert the change to our export to
match?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094721174
Y
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I'm not sure I have enough karma points to propose such a change.
Anyway, one alternative I found is to handle the Turbo before-fetch-response
event. In case the endpoint is sending us failures in html format, we tell
Turbo to no
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Mmh, Thunderforst is still sending us HTML error messages. Can we change this
somehow?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094690120
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Well only by asking Andy nicely!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094690325
You are receiving this because you are subscribed to
@mmd-osm pushed 1 commit.
cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/2d614082c31b689b7913ff08b045e230ed698ee6..cf0fc1cdb176798f6c6a838fa1f4b4b76ae12d19
You are receiving
mmd-osm left a comment (openstreetmap/openstreetmap-website#6214)
#6192 also fixes this issue, you won’t be able to select non png for
thunderforest layers.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6214#issuecomment-3094
Closed #6214 as completed via 5d260f6785e2a3ef728fb8925814c6daffad1db1.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6214#event-18717466676
You are receiving this because you are subscribed to this thread.
Message ID:
__
tomhughes left a comment (openstreetmap/openstreetmap-website#6214)
OK I think I know what's going on but it will only happen with Chrome and other
related browsers, and only for the cycling and transport layers, not for the
main layer.
--
Reply to this email directly or view it on GitHub:
htt
tomhughes left a comment (openstreetmap/openstreetmap-website#6214)
It hasn't been reported because it works for everybody else - as the error you
have quoted says `self` is an allowed target for `form-action` so if the page
has been loaded from `www.openstreetmap.org` then it should be able to
ckdexterhaven created an issue (openstreetmap/openstreetmap-website#6214)
### URL
_No response_
### How to reproduce the issue?
On a PC (not a MAC), using any current browser, select a map area.
Select Share, and any of the format options (I was looking for an SVG file)
Click Download.
You'll i
Nothing dynamic yet, as that's also not yet implemented for the
Thunderforest raster tiles, but at least basic dark mode compatibility for
another layer.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6213
-- Commit
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Yes I deliberately didn't ask for that here as there's no point having two
people do the same work - it's just a conflict I can resolve when merging.
Indeed I've just done a test this afternoon of merging them both and resolving
hlfan left a comment (openstreetmap/openstreetmap-website#4042)
@tomhughes given your comments at #6137, I think it would be better to split up
the `leaflet.osm.vector.js` into a `leaflet.maplibregl.js` and a
`leaflet.openmaptiles.js` file.
--
Reply to this email directly or view it on GitHub:
tomhughes left a comment (openstreetmap/openstreetmap-website#6137)
Other than the zoom question, which is a minor issue that we can fix in a
followon PR if necessary I think this is good to merge. Are you happy that this
is ready to go for production on the server side @pnorman?
--
Reply to t
@tomhughes commented on this pull request.
> @@ -79,3 +79,12 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "Shortbread"
+ code: "S"
+ layerId: "shortbread"
+ nameId: "shortbread"
The maptiler PR went with 23 as a maximum,
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Thanks @petr-hajek I had in fact already registered a key there I had just
forgotten about it ;-)
I think this is good to merge now - what do you want to do about a key for us
to use in production? Am I OK just to register a ke
Merged #6211 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6211#event-18716676686
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6212 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6212#event-18716676684
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6212)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6212#issuecomment-3094548449
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6211)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6211#issuecomment-3094529975
You are receiving this because you are subscribed to this t
### Description
Using a few more form tag helpers makes the search layout quite a bit more
readable.
Less repetition and better integration of the inline_svg tags following #5938.
### How has this been tested?
Local installation.
You can view, comment on, or merge this pull request online at:
h
Valhalla seems to use "stay" for forks, and "slight" icons
are already separate.
I was unable to find more concrete documentation, though.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6211
-- Commit Summary --
*
Closed #5880 as completed via #5938.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5880#event-18716228311
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5938 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938#event-18716228254
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5938)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-3094473670
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Sounds reasonable to me... I've changed the export script to use plain text now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094470639
You
@mmd-osm pushed 1 commit.
723ee4bcbab76b7e599cb6bd986a7ee98f217b6b Simplify code
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/e1311a90607d422f7f0e4c8d4d76d08a637de9af..723ee4bcbab76b7e599cb6bd986a7ee98f217b6b
You are receiving this because you are
@hlfan pushed 4 commits.
d901d444ec1880ef070f486d26cbc3a3ab744c8b Store search icons separately
aea85108828419e98d8e71d537adeeedf68b4abf Store welcome icons separately
a567f51e6b37b489e1f4a76329a1de2975d21944 Store diary icons separately
ac5739982af584a98bd434a3271ae67bff9d2060 Store more icon
Merged #6210 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6210#event-18715475958
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6209 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6209#event-18715475965
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6208 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6208#event-18715475968
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #6207 as completed via #6208.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6207#event-18715476030
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#6210)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6210#issuecomment-3094364971
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6208)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6208#issuecomment-3094363836
You are receiving this because you are subscribed to this t
@mmd-osm pushed 1 commit.
e1311a90607d422f7f0e4c8d4d76d08a637de9af Handle response error message
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/6f098b047258b6bf1d0f13ac8638040757c1874d..e1311a90607d422f7f0e4c8d4d76d08a637de9af
You are receiving this
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Currently the export script returns errors as text/html, which Turbo happily
picks up to replace the osm.org page. In this case, the user has to reload the
page. Browser back button would take them to a random place, which is quit
46 matches
Mail list logo
