@1ec5 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6208#pullrequestreview-3035481036
You are receiving this because you are subscribed to this thread.
Message ID:
___
@mmd-osm commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
+ if (event.detail.success) {
+event.detail.fetchResponse
@mmd-osm commented on this pull request.
> @@ -8,7 +8,6 @@ L.OSM.share = function (options) {
function init(map, $ui) {
// Link / Embed
-
oops, fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2
@mmd-osm commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/sv
@mmd-osm pushed 1 commit.
6f098b047258b6bf1d0f13ac8638040757c1874d Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/0f027550cff731114749a11cfa1b18bdc1e6a498..6f098b047258b6bf1d0f13ac8638040757c1874d
You are receiving
@hlfan commented on this pull request.
> @@ -8,7 +8,6 @@ L.OSM.share = function (options) {
function init(map, $ui) {
// Link / Embed
-
What has this empty line done to you? /j
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/svg+
@mmd-osm pushed 1 commit.
0f027550cff731114749a11cfa1b18bdc1e6a498 Image download with user feedback
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/2ee3e989e4b9edb41378d275544d1cc3915e..0f027550cff731114749a11cfa1b18bdc1e6a498
You are receiving
@mmd-osm commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
good point
--
Reply to this email directly or view it on GitHub:
ht
@mmd-osm commented on this pull request.
> + const contentType = blob.type;
+ let extension = "bin";
+ if (contentType === "image/png") extension = "png";
+ else if (contentType === "image/jpeg") extension = "jpg";
+ else if (contentType === "image/sv
@hlfan commented on this pull request.
> @@ -7,8 +7,33 @@ L.OSM.share = function (options) {
});
function init(map, $ui) {
-// Link / Embed
+$("#export-image").on("turbo:submit-end", function (event) {
Could this code block be moved into the `// Image` section just below?
Includes a backported fix for issue
https://github.com/openstreetmap/iD/issues/11225.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6209
-- Commit Summary --
* Update to iD v2.35.3
-- File Changes --
M vendo
mmd-osm left a comment (openstreetmap/openstreetmap-website#6207)
Indeed, now everything seems to be working fine again.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6207#issuecomment-3092270750
You are receiving this because
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Instead of hardcoding formats, I have added a new attribute "formats" to
layers.yml, and disable non-supported formats in the select options:
https://github.com/user-attachments/assets/e5a5639e-69f5-45d2-aacc-96af327a91cf";
/>
T
hlfan left a comment (openstreetmap/openstreetmap-website#6207)
Well, AFAICT Intl.DisplayNames blocks OSM.MappedElement blocks OSM.router, so
this is an easy fix (#6208).
That doesn't mean future issues on legacy browsers will also get fixed.
--
Reply to this email directly or view it on GitHu
### Description
This avoids breaking page load in legacy browsers like Pale Moon by delaying
the instanciation of Intl.DisplayNames until it's needed.
Closes #6207.
### How has this been tested?
Sandboxed Pale Moon with a locally served site.
You can view, comment on, or merge this pull request on
k-yle left a comment (openstreetmap/openstreetmap-website#6197)
i think excluding all
[`wikidata:P3303`](https://wikidata.org/wiki/Property:P3303) is reasonable.
There are only 4 keys where every URL is unofficial (`icao`, `ref:admiralty`,
`ref:UAI`, `uic_ref`). So these 4 would have no link.
mmd-osm left a comment (openstreetmap/openstreetmap-website#6207)
OSM.router is probably the bigger issue. It blocks a number of other features,
such as adding notes, query features, directions, etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
18 matches
Mail list logo
