Re: [openstreetmap/openstreetmap-website] Inline SVGs with inline_svg gem (PR #5938)

@hlfan pushed 5 commits. a05cade7289d411f357bed9ba7693b24000c5c10 Store search icons separately 14072e6110c05274191e2adfb6d2f6027c6116c9 Store about icons separately a9725cd2a94af85fcbbaa125790ca895d4623d73 Store welcome icons separately d383095325ecdc5ac39a2852156413d97695faf8 Store diary ico

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan commented on this pull request. > @@ -0,0 +1,44 @@ + Added a copy of #5999 for `position-absolute`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2217096942 You are receiving this because you are subsc

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan pushed 5 commits. 4eb552a0aeae685b5dd7dcf41dfd2966fc5f10c0 Use common note marker definitions 97cdf42730e21c8f2dd350252e4737bc99ad584f Generalize leaflet-marker-icon selector 9f74425951f4982139ac0bebf97dd65030e95ea8 Add Bootstrap .position-absolute class to print styles to hide svg def

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

@hlfan pushed 2 commits. fedd6dd3a9e1e5ba8f3d8667cde3ca8c70ff1b59 Use only differences to OSM logo in internal social link icons 4a008009824c82dd30dd6d77e30b01ea366c6780 Add OSM logo indicator for related social links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websi

Re: [openstreetmap/openstreetmap-website] Invert icons in dark mode with common class (PR #6052)

@hlfan pushed 1 commit. 7b694cbc67f36656528f23f3af871f35c596412a Invert icons in dark mode with common class -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/749f01e37f290f090ee915e7f96866da5a636c4e..7b694cbc67f36656528f23f3af871f35c596412a You are r

Re: [openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

hlfan left a comment (openstreetmap/openstreetmap-website#6207) If Intl.DisplayNames is the only big hurdle as it looks to me, then moving it inside the wikidata preview render method would be less blocking. That said, there might be other modern features that get in the way of the js controller

Re: [openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

tomhughes left a comment (openstreetmap/openstreetmap-website#6207) Ah it's being used in the new wikidata stuff and I guess it could possibly skip showing the language name if that interface wasn't available but that only resolves this immediate problem and fundamentally you're using a browser

Re: [openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

tomhughes left a comment (openstreetmap/openstreetmap-website#6207) So `Intl.DisplayNames` was only added by Firefox in version 86 which is likely why you don't have it but as our baseline for javascript is ES2021 it's not surprising that what is essentially a 2017 browser doesn't support everyt

Re: [openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

tomhughes left a comment (openstreetmap/openstreetmap-website#6207) If I understand the wikipedia page correctly the browser you're using is based on Firefox 52 from 2017 and whilst I'm sure they may have added some features since I'm sure there is no way they have kept up with the feature sets

Re: [openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

tomhughes left a comment (openstreetmap/openstreetmap-website#6207) I think it's unlikely there is much we can do - it really sounds your browser is just too ancient I'm afraid. We have to strike a balance between supporting a tiny handful of users using old browsers and being able to use modern

[openstreetmap/openstreetmap-website] Search function don't work on PaleMoon browser (Issue #6207)

damjang created an issue (openstreetmap/openstreetmap-website#6207) ### URL _No response_ ### How to reproduce the issue? Today I try to do a search on OSM website: I write the text to search but nothing happen. I'm sure the search work some time ago, but now don't. Then I go to check the bro

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm pushed 1 commit. 2ee3e989e4b9edb41378d275544d1cc3915e Image download with user feedback -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/67727a878643a2ccd4df03a6b0ee6a90aa557663..2ee3e989e4b9edb41378d275544d1cc3915e You are receiving

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm pushed 1 commit. 67727a878643a2ccd4df03a6b0ee6a90aa557663 Image download with user feedback -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b514a848c5732df855e978748b94fcb87067bc1d..67727a878643a2ccd4df03a6b0ee6a90aa557663 You are receiving

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm pushed 2 commits. 70e1eab3dad76200e2e16bc5b2191aa0bea127ee Restrict select options to supported map export formats 08e788ba8c2b8e1c2a3589689bb4a6004456d59d Map download failure message -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/e4c1d3

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

@mmd-osm pushed 1 commit. e4c1d373d9380fca420d6863a2e5fb8018a984ce Restrict select options to supported map export formats -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/926535a2ffad5f5b7455ea6bc989a78572be778e..e4c1d373d9380fca420d6863a2e5fb8018a9

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

Merged #6191 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191#event-18703881935 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove inkscape/sodipodi tags/attributes from osm forum icon (PR #6205)

Merged #6205 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6205#event-18703881910 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove inkscape/sodipodi tags/attributes from osm forum icon (PR #6205)

tomhughes left a comment (openstreetmap/openstreetmap-website#6205) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6205#issuecomment-3090011640 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@tomhughes approved this pull request. Thanks. I think this looks good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191#pullrequestreview-3034138740 You are receiving this because you are subscribed to this thread. Mes

Re: [openstreetmap/openstreetmap-website] Change edit link to profile location in dashboard (PR #6206)

Merged #6206 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6206#event-18703772238 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Update to iD v2.35.2 (PR #6203)

Merged #6203 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6203#event-18703772283 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

Merged #6204 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6204#event-18703772281 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Change edit link to profile location in dashboard (PR #6206)

tomhughes left a comment (openstreetmap/openstreetmap-website#6206) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6206#issuecomment-3089990012 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

tomhughes left a comment (openstreetmap/openstreetmap-website#6204) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6204#issuecomment-3089984492 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Inline social link icons (PR #6201)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6201) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6201#issuecomment-3089956536 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Inline social link icons (PR #6201)

Merged #6201 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6201#event-18703544392 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > @@ -0,0 +1,44 @@ + I know that `d-none` here won't entirely work, but this is also not entirely working. You'll get this gap in print https://github.com/user-attachments/assets/a7798bb3-4bce-47f8-9ffa-9d7a2e8ca5ba"; /> which doesn't look like muc

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > +MARKER_COLORS = { + :red => "#f6110a", + :green => "#9cef11", + :blue => "#0b8ef1" +}.freeze Although there is a gotcha with print css. If markers are supposed to be colored in print style, these colors need to be included there too. -- Repl

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > +MARKER_COLORS = { + :red => "#f6110a", + :green => "#9cef11", + :blue => "#0b8ef1" +}.freeze Why not css properties? That's where I'd expect to find color definitions. You can put something like this in `common.scss`: ```css :root { --marker

Re: [openstreetmap/openstreetmap-website] Remove inkscape/sodipodi tags/attributes from osm forum icon (PR #6205)

@hlfan approved this pull request. The reason I didn't invest much time in this file is that all the changes have to be repeated once the decision is made to incorporate https://wiki.openstreetmap.org/wiki/File:OSM_Community_Forum_Logo.svg. -- Reply to this email directly or view it on GitHu

[openstreetmap/openstreetmap-website] Change edit link to profile location in dashboard (PR #6206)

When you don't have your home location set, this link in your dashboard leads to *Profile Description*: It makes more sense to link to *Profile Location* instead.

Re: [openstreetmap/openstreetmap-website] Inline social link icons (PR #6201)

@hlfan pushed 1 commit. a0666021d9d251a9d9cf5a8ee1ddcd3527937368 Inline social link icons -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6201/files/119a5a2e3c1a79ca049e85aad9dc2515968c369c..a0666021d9d251a9d9cf5a8ee1ddcd3527937368 You are receiving this becaus

[openstreetmap/openstreetmap-website] Remove inkscape/sodipodi tags/attributes from osm forum icon (PR #6205)

...because I looked at the file in #6159. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6205 -- Commit Summary -- * Remove from osm forum icon * Remove inkscape:collect attributes from osm

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

@hlfan pushed 2 commits. de89ba6611a3b9583b5fffa531ddbd6fb51a1301 Use only differences to OSM logo in internal social link icons b8aae7060360884c21659e3ff91fc60cab800fd4 Add OSM logo indicator for related social links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websi

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan pushed 2 commits. cbd0ad01f69f12da2ed86329efaf1490d7e86b64 Update and inline markers ea5ae93b8a5f7c3e37f6981faa3a6bd620249be5 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/1d5cb8816344271fb73d5c3d8c153c181d86d218..ea5ae

Re: [openstreetmap/openstreetmap-website] Switch inline style to attributes (PR #6159)

Merged #6159 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6159#event-18701240526 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6204) It's a private method. We have private methods at the end of the file. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6204#issuecomment-3089469079 You are rece

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > @@ -3,6 +3,7 @@ <% end %> <%= render :partial => "layouts/control_icons", :locals => { :icons => %w[zoomin zoomout geolocate] } %> +<%= render :partial => "layouts/markers", :locals => { :types => %w[dot] } %> The same thing is needed in: - `a

Re: [openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

@hlfan approved this pull request. Personally, I'd define `check_pagination_of_50_entries` before `test_index_paged`, but this is mostly for git blame tidiness. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6204#pullrequestre

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@hlfan pushed 2 commits. d457802ad89d11c932c42bc0e15ea0c20d09de3b Update and inline markers 1d5cb8816344271fb73d5c3d8c153c181d86d218 Clean up old markers -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5854/files/f07fc6ae097d2baa72a8ba06bf3908cb70e20f2e..1d5cb

Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)

@AntonKhorev commented on this pull request. > @@ -79,3 +79,12 @@ osm_france_link: id: "osm_france" href: "https://openstreetmap.fr/"; + +- leafletOsmId: "Shortbread" + code: "S" + layerId: "shortbread" + nameId: "shortbread" You can add `maxZoom: 22` here because va

Re: [openstreetmap/openstreetmap-website] use JOSM/tag2link to linkify tag values (PR #6197)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6197) > Or at least preferring `osmwiki:P8` and `wikidata:P1630` as sources before > falling back to `wikidata:P3303`. But I assume the `preferred` rank would > take care of most of that anyways. In my example with `icao=*` preferr

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#6202) Merged, thanks. Apparently GitHub doesn't generate notifications if the only thing that changes are commit messages. You might want to leave a reply in this case. -- Reply to this email directly or view it on GitHub: https:/

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

Merged #6202 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6202#event-18699136608 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Switch to inline colourable markers (PR #5854)

@AntonKhorev commented on this pull request. > + draggable="true"> + + Changes I had to make to keep drag events working (1/3): ```suggestion ``` > + dra

Re: [openstreetmap/openstreetmap-website] Image download with user feedback (PR #6192)

mmd-osm left a comment (openstreetmap/openstreetmap-website#6192) So the image download seems to work now. I still want to hardcode PNG format for thunderforst (that's the only format available for download), and check how the code handles bad request due to timeouts during image generation. I'

[openstreetmap/openstreetmap-website] Reorder paginated items (PR #6204)

Sometimes items passed to get_page_items are already ordered. That order needs to be replaced by cursor_column instead of adding cursor_column after the existing order. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev pushed 1 commit. 4116ebf421f853a055880c04a00310a71586b3f0 Add a task to register iD and web OAuth apps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/ae9e66619e9f2d92bbc677000e70616cff86680d..4116ebf421f853a055880c04a00310a71586b3f0 Yo

[openstreetmap/openstreetmap-website] Update to iD v2.35.2 (PR #6203)

Bugfix release ([changelog](https://github.com/openstreetmap/iD/releases/tag/v2.35.2)). Fixes https://github.com/openstreetmap/iD/issues/11213, https://github.com/openstreetmap/iD/issues/11217 and https://github.com/openstreetmap/iD/issues/11220 You can view, comment on, or merge this pull requ

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev commented on this pull request. > @@ -57,6 +57,19 @@ There are two built-in applications which communicate via > the API, and therefore * iD * The website itself (for the Notes functionality) +You can register them by running a script and copying its output to `config/settings

Re: [openstreetmap/openstreetmap-website] Configure builtin apps script (PR #6191)

@AntonKhorev pushed 1 commit. ae9e66619e9f2d92bbc677000e70616cff86680d Add a task to register iD and web OAuth apps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/65f03637b17e90e455fe9f571dcf9c7c78e23a6d..ae9e66619e9f2d92bbc677000e70616cff86680d Yo

Re: [openstreetmap/openstreetmap-website] Stop Commons from redirecting outside CSP (PR #6202)

@AntonKhorev commented on this pull request. > @@ -171,8 +171,8 @@ .addClass("bg-body-tertiary"); if (icon && OSM.WIKIMEDIA_COMMONS_URL) { - let src = OSM.WIKIMEDIA_COMMONS_URL + "Special:Redirect/file/" + encodeURIComponent(icon); - if (!icon.endsWith(".svg")) src += "?