Thank you, I couldn't figure out the workaround, so I guess I'll wait for the
fix.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a16074103cd9#commitcomment-162327255
You are receiving this because y
A fix is pending in facebook/Rapid#1724. See the temporary workaround at
https://github.com/facebook/Rapid/issues/1722#issuecomment-3060409827.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a1607410
@1ec5 commented on this pull request.
This is another subtle difference between Special:Redirect and the MediaWiki
API, which is why the initial request for the item details doesn’t run into
this problem.
> @@ -171,8 +171,8 @@
.addClass("bg-body-tertiary");
if (icon && OSM.WIKIMED
For mobile devices, the request to `OSM.WIKIMEDIA_COMMONS_URL` from #6127 will
be redirected to `commons.m.wikimedia.org`, which is subsequently blocked by
the CSP.
Directly requesting the desktop version removes the extra redirect.
You can view, comment on, or merge this pull request online at:
Is there a way to use https://rapideditor.org/ yet? I have the same issue.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e633e479568572090eb6a16074103cd9#commitcomment-162319760
You are receiving this because you are su
@hlfan pushed 4 commits.
859b17faf488cc925a187d60746e8e8b4126a876 Use common note marker definitions
ded64d5459e7a2d0a27a53c516fc9bd3478c1666 Generalize leaflet-marker-icon
selector
dfb7e5adcb00ddfbb05fa9ab2ce9c5d590253cd6 Update and inline markers
f07fc6ae097d2baa72a8ba06bf3908cb70e20f2e Cle
@hlfan pushed 3 commits.
c273fb3d9f817cea92ae620dd03daece893e7cdc Align route regex initialisation
80af72cc4a05dc75e370daf03ee3c846cf676905 Add scoped placeholders for router
0908e97e95606d5a05e2b2b0c7adc335319e1383 Specify element handlers more
compactly
--
View it on GitHub:
https://github
@mmd-osm pushed 1 commit.
926535a2ffad5f5b7455ea6bc989a78572be778e Matching download file suffix
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/ac8bbfff948f471a46db7d6bd579069727ff63aa..926535a2ffad5f5b7455ea6bc989a78572be778e
You are receiving this
@mmd-osm pushed 3 commits.
81869381defa872638c9f6035586aed625530f76 Remove not needed submit handler
b50b9d192b1e0bb4b8f50ac7a541e0023f500887 Eslint fix
ac8bbfff948f471a46db7d6bd579069727ff63aa Added downloading text
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website
@pnorman pushed 1 commit.
61f61b47370f943bf7a8005a7de9637b2de49c17 Add Shortbread-based Vector Tile layer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/7a80c3c3b57f5568b6bc06f83e5f51364f137b62..61f61b47370f943bf7a8005a7de9637b2de49c17
You are recei
@hlfan commented on this pull request.
> + icon: ["P8972", "P154", "P14"].reduce((out, prop) => out ??
> entity.claims[prop]?.[0]?.mainsnak?.datavalue?.value, null),
+ description: localizedProperty("descriptions", langs)?.value,
+ article: localizedProperty("sitelinks", wikis)
+
@mmd-osm pushed 1 commit.
38d452e4356f62b9f304bb6ae6fd20d40fd0cff0 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/5008934940ce060263c0878334ecc0e08e63a337..38d452e4356f62b9f304bb6ae6fd20d40fd0cff0
You are receiving this
@mmd-osm pushed 1 commit.
5008934940ce060263c0878334ecc0e08e63a337 Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/3d9d24d26e1dd9d44688f7e908e7b48afe07473c..5008934940ce060263c0878334ecc0e08e63a337
You are receiving this
@mmd-osm pushed 1 commit.
3d9d24d26e1dd9d44688f7e908e7b48afe07473c Download image on turbo event
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/012aec679f34a109865eaf12da1bc8ca4c200847..3d9d24d26e1dd9d44688f7e908e7b48afe07473c
You are receiving this
@mmd-osm pushed 1 commit.
012aec679f34a109865eaf12da1bc8ca4c200847 Fix unit test
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/b94b4a3fb03666a0f2598b71f6621b37b07a925f..012aec679f34a109865eaf12da1bc8ca4c200847
You are receiving this because you are
@mmd-osm pushed 4 commits.
25f0fda3ec69da488feb3f6ad83e4c3df7eab8fd Image download w/ submit_tag
c2748f8d8f6660e190dbd3ad365b0f5e532c861d Add image provider to CSP connect_src
ed404ae8f570a6db4794885ad5142dd04648c9d3 TOTP token as URL parameter
b94b4a3fb03666a0f2598b71f6621b37b07a925f Export i
@mmd-osm pushed 3 commits.
53149fd121112052ae9e511ad08e72a106304505 Add image provider to CSP connect_src
1f853ca1b57ff7b5186fe160199fd851e40bc519 TOTP token as URL parameter
730c56c58867732f2dee941809900648c6115c56 Export image as AJAX request
--
View it on GitHub:
https://github.com/openstr
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
The python cgi library is weird and the form object it returns for the options
request doesn't work at all so we now ignore it.
We need to find a replacement anyway as the latest python release has dropped
it :-(
--
Reply to
mmd-osm left a comment (openstreetmap/openstreetmap-website#5758)
It's available on the dev instance for testing now:
https://master.apis.dev.openstreetmap.org/user/mmd2mod/history
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The preflight request is failing with HTTP 500. There might be something wrong
with `form.getfirst("token")`. Elsewhere we're using `getvalue` to fetch the
parameter value, and check if a value is available:
```
elif "token" in f
@tomhughes requested changes on this pull request.
> @@ -57,6 +57,19 @@ There are two built-in applications which communicate via
> the API, and therefore
* iD
* The website itself (for the Notes functionality)
+You can register them by running a script and copying its output to
`config/se
@AntonKhorev commented on this pull request.
> @@ -56,151 +62,158 @@ sudo dnf install ruby ruby-devel rubygem-rdoc
> rubygem-bundler rubygems \
If you didn't already have PostgreSQL installed then create a PostgreSQL
instance and start the server:
-```
+```bash
sudo postgresql-setup init
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6191)
Updated as a rake task.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6191#issuecomment-3084943417
You are receiving this because you are subscribed to this t
@AntonKhorev pushed 1 commit.
65f03637b17e90e455fe9f571dcf9c7c78e23a6d Add a task to register iD and web
OAuth apps
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6191/files/2fa08b44f1be1b1f2a63fcd5b33fe4c21b6a56a1..65f03637b17e90e455fe9f571dcf9c7c78e23a6d
Yo
tomhughes left a comment (openstreetmap/openstreetmap-website#5884)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884#issuecomment-3084751221
You are receiving this because you are subscribed to this t
Merged #5884 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884#event-18684218340
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
1ec5 left a comment (openstreetmap/openstreetmap-website#6197)
Or at least preferring `osmwiki:P8` and `wikidata:P1630` as sources before
falling back to `wikidata:P3303`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6197#issu
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
I've pushed a change to use the `token` parameter from the URL as the token if
there is no cookie.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomm
Merged #6200 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6200#event-18683857194
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5758 as completed via #6170.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5758#event-18683857725
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6170 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6170#event-18683857195
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6170)
This looks good to me, thanks, and it sounds like we're good to merge and
deploy it per @mmd-osm's plan.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6170#iss
tomhughes left a comment (openstreetmap/openstreetmap-website#6200)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6200#issuecomment-3084666378
You are receiving this because you are subscribed to this t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6197)
Can we start with rejecting `"source": "wikidata:P3303"` *third-party formatter
URL*? Because why should `icao=*` be linked to uk.flightaware.com and not
anything else?
--
Reply to this email directly or view it on GitHub:
h
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
Merged, thanks.
For admins:
if Wikimedia wouldn't like hotlinking to their images, set
`wikimedia_commons_url` to an empty string. But we're doing this and more from
iD already.
--
Reply to this email directly or view it on
Merged #6127 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#event-18680589895
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
pnorman left a comment (openstreetmap/openstreetmap-website#6199)
> This enables the iD editor to access user-specific preferences (such as
> display settings, editor configurations, etc.) that were previously only
> available through separate API calls, improving performance and reducing
> cli
@k-yle commented on this pull request.
> @@ -0,0 +1,25 @@
+# A map of each OSM key to its formatter URL. For example:
+# { "ref:vatin" => "https://example.com/$1"; }
+TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
yeah I just didn
@k-yle commented on this pull request.
> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.js
@k-yle pushed 1 commit.
bd1f6aecf812046ae653ffc74b8b613b4cf4079c code review suggestions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6197/files/82ddcbd1c3efab24959148a8cf7fe059385e2bc5..bd1f6aecf812046ae653ffc74b8b613b4cf4079c
You are receiving this because
@Deeptanshu-sankhwar commented on this pull request.
> @@ -15,7 +15,15 @@
data[:token] = token.token
end
data[:locale] = ID::LOCALES.preferred(preferred_languages).to_s
- data[:asset_map] = assets("iD").to_json %>
+ data[:asset_map] = assets("iD").to_json
+
+ # Include user pr
@Deeptanshu-sankhwar commented on this pull request.
> +window.OSM = window.OSM || {};
+window.OSM.userPreferences = userPreferences;
I have now embedded a function in the `idContext` object to store and then
consume user preferences
--
Reply to this email directly or view it on Git
@Deeptanshu-sankhwar pushed 1 commit.
af76c9c15e512c81c1cbb611e62f9d5b396ada7e handle user prefs in idContext object
and remove redundant auth check for user prefs
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6199/files/762d69c5878411774aad58293a55c10c1e352
43 matches
Mail list logo
