mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think we could skip the cookie altogether:
>From app/controllers/application_controller.rb -> update_totp -> generates new
>TOTP cookie today.
`ROTP::TOTP.new(Settings.totp_key, :interval => 3600).now` needs to be added to
app
@hlfan pushed 2 commits.
bff4b557417da0f063cded5b6e906807b58b3b47 Use only differences to OSM logo in
internal social link icons
01c9faeec783ac0e0037321e6c08af5b76e769b4 Add OSM logo indicator for related
social links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-websi
@hlfan pushed 1 commit.
219a11259d71018c258bc3a09e3809f7ebe48a5b Merge branch 'openstreetmap:master'
into social-no-reiterate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/6bac01a5c7e3ffa47a476cb69d1e9fef982ee3a4..219a11259d71018c258bc3a09e3809f7e
@hlfan pushed 1 commit.
5e8576462633a9dacb00c580159fc62bf890ea31 Simplify changeset icon definitions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5884/files/73ef13fa723428f181237e481671cec9a7c8508b..5e8576462633a9dacb00c580159fc62bf890ea31
You are receiving
Removes the patch from #6049.
This is waiting on #6159 or #6072.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6201
-- Commit Summary --
* Refine dom structure assertions in profile and user tests
* Store social
@hlfan pushed 1 commit.
e03e9bb8f97f8beb728c922a8ccb2a3cd698199e Store gear icon separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5938/files/6da3b594f69ea1ef3794610943c433403181891d..e03e9bb8f97f8beb728c922a8ccb2a3cd698199e
You are receiving this beca
@hlfan pushed 6 commits.
c63daf5b4f133676c11bead0aaa61b99c4d243a1 Refine dom structure assertions in
profile and user tests
107aa6ae04007db9df9be43ac3898d254775d382 Store search icons separately
8ddec148ecf98407ee6b4b1e05309223d0537bc1 Store about icons separately
c1818b9b5a72f76066586536b27cc
Reopened #5777.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777#event-18668138800
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Closed #5777.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777#event-18668125460
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5777/files/8a97b03a38ea226077a88b682c58a661d9602339..dc6e1e370446d03ac8374e91d8c42f9202b05db2
You are receiving this because you are subscribed to this thread.
Message ID:
__
Cleaning up the map controls sprite creation after #6189 added the way to do
that.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6200
-- Commit Summary --
* Use svg symbols for map controls icons
-- File Changes
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187)
Not using Turbo is even more future proof, if we're not interested in making
responses faster.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187#issuecommen
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
I've updated this to send the full head by using our own layout...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187#issuecomment-3080050993
You are receiving
@tomhughes pushed 2 commits.
0b805abec2ef24ef6f493b730729c1de60103661 Use a minimal layout for turbo frame
renders
9ee3f3f83bcd98b7b15103f1bd74578c29338af1 Don't do partial renders for turbo
page visits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187/fi
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
Well yes I considered doing that as I said and it would be easy enough if
people prefer to go that way.
I don't see any point in limiting it to specific requests though - surely the
mechanism here that does it automatically for
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187)
I updated my #5175. It only changes controllers that use turbo pagination.
Their `frame.html.erb` isn't entirely working for us because we have a lot of
stuff inside `` that's not added using `content_for :head`. I'm including
hlfan left a comment (openstreetmap/openstreetmap-website#3123)
@mjourdan I'm looking for another round of feedback, let's get this resolved!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3123#issuecomment-3080020500
You are r
@AntonKhorev pushed 1 commit.
ecd71349bc68c8d74aeef43e6df318c787dd2967 Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c..ecd71349bc68c8d74aeef43e6df318c787dd2967
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Maybe we should allow the token to be sent as a parameter instead of a cookie?
Would it be possible to send it that way?
The thunderforest layers are the only other ones which allow export so they're
the only ones that will nee
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The other issue I've noticed is that Thunderforest maps (and all others) need
to be added to policy.connect_src as well.
Although the download is triggered, the resulting PNG file disappears into
nowhere.
--
Reply to this email
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
Now I'm getting _Error - Missing or invalid token_, which makes sense because
we're not sending any cookies across.
I'm not even sure this works. fetch is using credentials option "same-origin"
by default, and even "include: alwa
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Those should be allowed now...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3079806615
You are receiving this because you are subscribed to t
@AntonKhorev pushed 1 commit.
4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4cb5a6d73854711b4d4731d50ef84a983f56eb21..4f6ee01bbc05229237adc3d2ea2acfe8f90bbf4c
You are rece
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I'm using the code below, which includes `Access-Control-Request-Headers:
x-csrf-token,x-turbo-request-id` in the request.
The preflight fails, because we're not allowing these headers:
Reason: header ‘x-csrf-token’ is not allowe
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Yes I'm just pushing a fix for that...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3079740395
You are receiving this because you are subscri
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
https://render.openstreetmap.org/cgi-bin/export seems to return multiple /
deviating Access-Control-Allow-Origin headers:
https://github.com/user-attachments/assets/1f78a339-2e67-4639-bba6-a251cd67bf1a";
/>
https://github.com/u
@AntonKhorev pushed 1 commit.
4cb5a6d73854711b4d4731d50ef84a983f56eb21 Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/da7a6e401c41792692119fda54ddf2e0386d69f3..4cb5a6d73854711b4d4731d50ef84a983f56eb21
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Hopefully
https://github.com/openstreetmap/chef/commit/4f3db0dc494a192aab6c24fea6f81c23875d2bf3
will do the necessary to allow the preflight check.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
@AntonKhorev pushed 1 commit.
da7a6e401c41792692119fda54ddf2e0386d69f3 Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782..da7a6e401c41792692119fda54ddf2e0386d69f3
You are rece
@AntonKhorev pushed 1 commit.
4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782 Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/6069986a2ddd5a4910762fcf8719ba4781f7ee2f..4db7cdfdfd0e270fc89d5f0c5fc378601a6cd782
You are rece
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> is it preflighting because this will switch to POST or because of the cookie
> or something
In the AJAX case, it's the second (GET) request on render.osm.org that triggers
the preflight request.
--
Reply to this email di
Merged #6198 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6198#event-18663602260
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6189 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#event-18663602249
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5776 via #6189.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5776#event-18663602491
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
@tomhughes commented on this pull request.
> @@ -0,0 +1,25 @@
+# A map of each OSM key to its formatter URL. For example:
+# { "ref:vatin" => "https://example.com/$1"; }
+TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient
for lookups.
Why do we ne
@AntonKhorev pushed 1 commit.
6069986a2ddd5a4910762fcf8719ba4781f7ee2f Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/84358dd483aaedec305bcc9d35c3d7b97675e46f..6069986a2ddd5a4910762fcf8719ba4781f7ee2f
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#6189)
Thanks for working on this... I think it looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-3079353187
You are receiving this becau
tomhughes left a comment (openstreetmap/openstreetmap-website#6198)
That's what I thought it was supposed to do but for some reason it didn't seem
to be doing that when I tried it.
Today it does seem to be working though so I must have been doing something
wrong!
--
Reply to this email direct
@AntonKhorev pushed 1 commit.
84358dd483aaedec305bcc9d35c3d7b97675e46f Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/f08e7510615d0e20fc11b72e9bed43a6c4945fde..84358dd483aaedec305bcc9d35c3d7b97675e46f
You are rece
@AntonKhorev pushed 1 commit.
f08e7510615d0e20fc11b72e9bed43a6c4945fde Send along with pagination
frames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5175/files/20ab67e603ef795bb0fc77f420df79a22d6b6204..f08e7510615d0e20fc11b72e9bed43a6c4945fde
You are rece
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> During preflight the export script shouldn't look at cookies because it won't
> receive any cookies.
Agreed, the script isn't handling preflight requests properly at the moment.
Maybe Apache could also return something for OPT
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> the cookie is going to be valid if I exported on osm.org recently
I think the TOTP cookie is valid for an hour or so. I'm also testing locally by
running an export on osm.org to get a valid token, then continue with local
test
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192)
> > Would it? Is it even required by the exporter?
>
> Yes, it's explicitly checked here [...]
I didn't notice that the cookie is being sent even when I'm using my own
osm-website instance, and the cookie is going to be valid
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192)
During preflight the export script shouldn't look at cookies because it won't
receive any cookies. So it should quit with 204
[here](https://github.com/openstreetmap/chef/blob/849abef3edeac8e563ad793f55dd4bdea4b9b232/cookbooks
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
> CORS still wouldn't work though, until render.openstreetmap.org supports
> preflight requests.
That shouldn't be hard to fix if we need to - is it preflighting because this
will switch to POST or because of the cookie or some
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
> Would it? Is it even required by the exporter?
Yes, it's explicitly checked here:
https://github.com/openstreetmap/chef/blob/master/cookbooks/tile/templates/default/export.erb#L179-L183
--
Reply to this email directly or view
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192)
> Somehow this last bit never worked when testing the new code. If I don't
> manually remove the "disabled" attribute, it will remain disabled until I
> reload the page.
Add `data-turbo="true"` to the form:
```html
```
--
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6192)
> CSP doesn't allow render.openstreetmap.org
Easily fixed by allowing them. They are already allowed for `form_action`, just
add them to `connect_src` too.
> the required totp cookie would be lost
Would it? Is it even requir
@hlfan pushed 2 commits.
d64be5d70174ad09e672ee405e0a423ff79a55a9 Add test for SVG sprite presence
b06cc0ede70d20140ec6b5327862ebc734fd6bef Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/3757e775ad0667cd78bc1a2a882d11
@hlfan commented on this pull request.
> @@ -101,4 +112,108 @@
scrollableList.scrollLeft = scrollableList.scrollWidth -
scrollableList.offsetWidth;
}
}
+
+ function previewWikidataValue($btn) {
+if (!OSM.WIKIDATA_API_URL) return;
+const items = $btn.data("qids");
+if
@hlfan pushed 1 commit.
62b4087b78d9281f34c9e27ccecb976c3660d133 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/78d0571781958d9747d7f22b925d8dadb128cb12..62b4087b78d9281f34c9e27ccecb976c3660d133
You are rec
@AntonKhorev commented on this pull request.
> +if (!entities) return Promise.reject(entities);
+$btn
+ .closest("tr")
+ .after(
+items
+ .filter(qid => entities[qid])
+ .map(qid => getLocalizedResponse(entities[qid]))
+
@AntonKhorev commented on this pull request.
> @@ -1,10 +1,18 @@
(function () {
+ let abortController = null;
+ const langs = [...new Set([...OSM.preferred_languages.map(l =>
l.toLowerCase()), "mul", "en"])];
Can we give this a more specific name than `langs` to avoid guessing what it
actu
@AntonKhorev commented on this pull request.
> @@ -101,4 +112,108 @@
scrollableList.scrollLeft = scrollableList.scrollWidth -
scrollableList.offsetWidth;
}
}
+
+ function previewWikidataValue($btn) {
+if (!OSM.WIKIDATA_API_URL) return;
+const items = $btn.data("qids");
+
54 matches
Mail list logo
