@hlfan commented on this pull request.
> @@ -0,0 +1,30 @@
+//= require leaflet.maplibre
+
+const styleURL =
"https://vector.openstreetmap.org/demo/shortbread/colorful.json";;
Why is this a global constant?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
@pnorman pushed 1 commit.
63e13015955d7b9272950e6a4f8491add46c98c0 Add Shortbread-based Vector Tile layer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/292606319ccceff6e63aad613533695a4a04831e..63e13015955d7b9272950e6a4f8491add46c98c0
You are recei
Merged #6196 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6196#event-18625870951
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #6186 as completed via #6196.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6186#event-18625871610
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#6196)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6196#issuecomment-3071015846
You are receiving this because you are subscribed to this t
Fixes #6186.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6196
-- Commit Summary --
* Clear floats in diary entries
-- File Changes --
M app/views/diary_entries/_diary_entry.html.erb (2)
M test/system/di
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6195)
The ones you found on a profile page are
`diary_entries.profile_diaries.*_label`. They are used to label icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issu
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
The click.rails event seems to be handled by jquery-ujs
(https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L524-L551).
There's also some code in place to re-enable form elements, but my debugger
isn't stopping there. I
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
Like I say it won't help anyway with the current code but I turned on event
logging to see if there was an event we could use and I say an event being
fired from rails form submission code and it looked like it had code to
re-e
tomhughes left a comment (openstreetmap/openstreetmap-website#6195)
They may not be used - there's a section of the translations that just gives a
name for each model class which rails will sometimes use in messages or as a
default value for buttons and things but it's quite possible some are ne
Closed #6195 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6195#event-18622155307
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
mmd-osm left a comment (openstreetmap/openstreetmap-website#6192)
I think what you describe is documented here:
https://turbo.hotwired.dev/handbook/drive#form-submissions
_During a submission, Turbo Drive will set the “submitter” element’s
[disabled](https://developer.mozilla.org/en-US/docs/Web
maro-21 created an issue (openstreetmap/openstreetmap-website#6195)
I'm trying to translate messages on Translatewiki and there are such strings:
* `Diary Entry`
* `Comments`
* `Date`
but I don't see what are they used for. I found that they are probably used on
users profiles who have diary ent
Merged #6194 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6194#event-18621299795
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6192)
I think it definitely needs more work on the re-enablement but I'm not sure
there's a good way to do it without changing the way the download works.
I'm not actually sure that you even need that code as I think rails does it
al
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Is there an api key I can use for testing? You can let me have it privately
> if you prefer...
I believe it should work with the Free account so just by signing up here you
can get one: https://cloud.maptiler.com/account/key
hlfan left a comment (openstreetmap/openstreetmap-website#6194)
I'm kinda already looking forward to `v2.35.2`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6194#issuecomment-3068346132
You are receiving this because you are su
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6194)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
(replaces #6193)
changelog:
* [`v2.35.0`](https://github.com/openstreetmap/iD/releases/tag/v2.35.0)
* [`v2.35.1`](https://github.com/openstreetmap/iD/releases/tag/v2.35.1) (bugfix
for line label bug https://github.com/openstreetmap/iD/issues/11123)
You can view, comment on, or merge this pull req
Closed #6193.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6193#event-18612271044
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6193)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
For changelog see [release
notes](https://github.com/openstreetmap/iD/releases/tag/v2.35.0)
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6193
-- Commit Summary --
* Update to iD v2.35.0
-- File Changes --
M
22 matches
Mail list logo
