@hlfan pushed 2 commits.
13eabbc8c9c3043b4d1eae06621862775db177df Add test for SVG sprite presence
3757e775ad0667cd78bc1a2a882d11fda349ea1b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/79539b4486449f3ea1237ee4c4d2e8
@hlfan pushed 1 commit.
79539b4486449f3ea1237ee4c4d2e8d230c309bc Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/1d048bface26fc0703fb73b8957d2f06d3748661..79539b4486449f3ea1237ee4c4d2e8d230c309bc
You are receiving this
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
mmd-osm left a comment (openstreetmap/openstreetmap-website#6170)
> cgimap update is supposedly ready now
Right, PR https://github.com/zerebubuth/openstreetmap-cgimap/pull/510 is ready
to be merged.
My proposal to move ahead is as follows:
- Merge Rails part of the solution, which includes d
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
I've added that in now although I don't think it's a perfect solution - it
restore the CSRF meta tags which is the immediate problem here but there's lots
of other stuff that gets lost from the `head` element.
In principle the
@tomhughes pushed 2 commits.
b973bd1d67916d0de4beee0aa0e8261272f981d3 Use a minimal layout for turbo frame
renders
1e7010d0855846a2959878d4654c49fdb16dcb19 Don't do partial renders for turbo
page visits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6187/fi
Merged #6184 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184#event-18606649196
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@mmd-osm pushed 1 commit.
85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/456ff4dfced1ee743bd2e3b0b9b51eae7cd31298..85f452adfc5fb9fc87f1b08b0c4ad8219b2d152f
You are receiving this
@mmd-osm pushed 1 commit.
456ff4dfced1ee743bd2e3b0b9b51eae7cd31298 Image download w/ submit_tag
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6192/files/6c4103c3b5f738a1813faf93d2a11aeb9da0f9b3..456ff4dfced1ee743bd2e3b0b9b51eae7cd31298
You are receiving this
@AntonKhorev commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}",
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6185)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6185#issuecomment-3067257973
You are receiving this because you are subscribed to this thread.
Merged #6185 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6185#event-18606475890
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
mmd-osm left a comment (openstreetmap/openstreetmap-website#6191)
I'm using something similar that creates a few sample users + also registers an
app for JOSM: https://gist.github.com/mmd-osm/a3a0b5a8799a333e7fae578038aa7a93
I'm also generating a doorkeeper_signing_key in that script and add it
Once a user clicks on "Download" Image, there's currently no
visual feedback that anything happens. Since the image generation may take a
few seconds, a user may be tempted to hit the download button multiple times.
This PR disables the button as soon as a hits the download button, similar to
t
@hlfan commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}", :to_s
@hlfan commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+ end
+
tomhughes left a comment (openstreetmap/openstreetmap-website#6191)
This should probably be a rake task in `lib/tasks` I think... I keep meaning to
convert the current random tools in `scripts` to be proper tasks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstre
@AntonKhorev pushed 18 commits.
6e664ca309503202f007fac0fc33e98a0c3a4d53 Add create/modify/delete counts to
changeset table
b362026db078d85205d7adb17cad00e4d187ef4c Validate changeset num_*_changes
57a204d591f543d6a4c24f98830f9355deae5d39 Add type changes in sync predicate to
changesets
fb3a4
I had to reinstall openstreetmap-website and decided to automate the [OAuth app
registration
step](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONFIGURE.md#oauth-consumer-keys).
You can view, comment on, or merge this pull request online at:
https://github.com/openstree
@AntonKhorev commented on this pull request.
> -
-
-
-
-
-
-
-
-
-
-
-
+
+ <% Rails.root.glob("app/assets/images/routing/*.svg").each do |path| %>
+<%= inline_svg_tag "routing/#{File.basename(path)}", :id =>
"routing-sprite-#{File.basename(path, '.svg')}",
@AntonKhorev commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+
@tomhughes commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+ en
@AntonKhorev commented on this pull request.
> +module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == value
+
Woazboat created an issue (openstreetmap/openstreetmap-website#6190)
### Problem
Pages for elements and element history have a little speech bubble icon with a
counter next to it that shows the number of comments on the corresponding
changeset that created/modified the element.
The icon and nu
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187)
This is the intended layout:
https://github.com/hotwired/turbo-rails/blob/main/app/views/layouts/turbo_rails/frame.html.erb
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
@hlfan pushed 2 commits.
b1f6ade08bbb2307323e6a26581f7d9de8a33f5c Add test for SVG sprite presence
1d048bface26fc0703fb73b8957d2f06d3748661 Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/ad3039224fded9b822a75fe62b8b7a
hlfan left a comment (openstreetmap/openstreetmap-website#6184)
Dependent on #6185
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184#issuecomment-3066976429
You are receiving this because you are subscribed to this thread.
Mes
@tomhughes commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase =
@hlfan commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase == va
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Yes I was looking at that
@tomhughes commented on this pull request.
> @@ -0,0 +1,23 @@
+module OpenStreetMap
+ class SvgCurrentColorTransform < InlineSvg::CustomTransformation
+def transform(doc)
+ doc.xpath("//@fill|//@stroke").each do |attr|
+attr.value = "currentColor" if attr.value.strip.downcase =
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Well, there's already quite a
@hlfan pushed 1 commit.
ad3039224fded9b822a75fe62b8b7ad93ffca9ae Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/5017d1ac042012846fbe1168d0b06d6db244bbdd..ad3039224fded9b822a75fe62b8b7ad93ffca9ae
You are receiving this
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
Sure. I wonder why the URL
@hlfan commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
That should be doable by addin
@hlfan pushed 1 commit.
5017d1ac042012846fbe1168d0b06d6db244bbdd Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/01e3075722f58f0309a4599d2170256dbf2e2d2b..5017d1ac042012846fbe1168d0b06d6db244bbdd
You are receiving this
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
Is there an api key I can use for testing? You can let me have it privately if
you prefer...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-30
@tomhughes commented on this pull request.
> L.extend(L.LatLngBounds.prototype, {
getSize: function () {
return (this._northEast.lat - this._southWest.lat) *
(this._northEast.lng - this._southWest.lng);
}
});
+if (OSM.SHORTBREAD_STYLE_URL) {
The problem with making th
@tomhughes commented on this pull request.
> @@ -0,0 +1,7 @@
+require Rails.root.join("lib/svg_to_symbol_transform.rb")
+require Rails.root.join("lib/replace_magenta_svg_color.rb")
I'd probably just put the custom transform classes inline here rather than
putting them in `lib` especially as au
tomhughes left a comment (openstreetmap/openstreetmap-website#6189)
Yes if you change initialisers you need to restart and they're only run once at
startup.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-306681
@hlfan requested changes on this pull request.
On app/assets/javascripts/leaflet.map.js:
See
https://github.com/openstreetmap/openstreetmap-website/pull/6137#issuecomment-3062857646,
no other layers are defined in this file
--
Reply to this email directly or view it on GitHub:
https://githu
@pnorman pushed 1 commit.
292606319ccceff6e63aad613533695a4a04831e Add Shortbread-based Vector Tile layer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/2700ec23e92960f2ebe5df1b2cc9395dddfb..292606319ccceff6e63aad613533695a4a04831e
You are recei
43 matches
Mail list logo
