@pnorman commented on this pull request.
> @@ -56,151 +62,158 @@ sudo dnf install ruby ruby-devel rubygem-rdoc
> rubygem-bundler rubygems \
If you didn't already have PostgreSQL installed then create a PostgreSQL
instance and start the server:
-```
+```bash
sudo postgresql-setup initdb
As
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cross-Origin-Opener-Policy
explains `rel=noopener` doesn't affect things opened with `window.open()`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6
@hlfan pushed 1 commit.
01e3075722f58f0309a4599d2170256dbf2e2d2b Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e..01e3075722f58f0309a4599d2170256dbf2e2d2b
You are receiving this
tomhughes left a comment (openstreetmap/openstreetmap-website#6187)
No you're right that you don't have to send the whole page - you can do `render
"_page"` to render the template but not as a partial but you still get the
whole of the layout so you don't really save much.
Yes I guess your solu
@hlfan pushed 1 commit.
bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e Store routing icons separately
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/aa65a878f7f610554b8ad67f3731c49d7e07f8d3..bb2b9f3ddcb9488578cff5a2bd787d56538b4b8e
You are receiving this
hlfan left a comment (openstreetmap/openstreetmap-website#6189)
Hmm. Interesting, but great!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189#issuecomment-3066022208
You are receiving this because you are subscribed to this th
mmd-osm left a comment (openstreetmap/openstreetmap-website#6189)
I've tested your code, and for me color replacement is working ok. I also put
in some debug code in both library methods, and they're being called when
loading the page.
https://github.com/user-attachments/assets/470cba90-5f5d-4a
@hlfan pushed 1 commit.
aa65a878f7f610554b8ad67f3731c49d7e07f8d3 Fix missing newline at end of file
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6189/files/86af97f5f827eb3f70eb4c217fd0f1d5a1d3210e..aa65a878f7f610554b8ad67f3731c49d7e07f8d3
You are receiving t
Test driving the inline_svg gem.
Continues #5753 and closes #5776 following the discussion in #5880.
The color replacement is still broken, and I don't know what else to try.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/
I was expecting `:rel => "noopener"` to be sufficient to prevent this sort of
issue. I found 1 or 2 places where this attribute isn't set. Can you maybe
comment if adding this attribute would have helped here, irrespective of adding
the COOP header?
--
Reply to this email directly or view it o
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
The issue here is that there's no client in every case. As an example, the
export feature on osm.org
(https://www.openstreetmap.org/export#map=13/51.48630/-0.08583) delegates the
download to
https://www.openstreetmap.org/api/0.6
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6188)
I don't think cgimap should say which service to use in case of an error. Isn't
cgimap also used on OpenHistoricalMap too? The link to planet.openstreetmap.org
should be displayed by the client, if it's possible to determine t
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
> Why is it important to run the test to its completion if you're going to run
> it again anyway?
https://github.com/user-attachments/assets/edd82135-9d7f-4d38-90f8-a928df9eff2c";
/>
There's an option not to.
I'm not saying we sh
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151)
> And currently, I don't see test failures being even close to the necessary
> 95.2% bug-caused failure rate.
The premise of [your
question](https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-301954
hlfan left a comment (openstreetmap/openstreetmap-website#5880)
Aha, so it's not really understanding on both sides!
I thought you meant manipulations of svg internals inside a helper module, not
on invocation.
> How is that supposed to work at the same time?
Well, since the `fill` and `stroke
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Let's take a look at the latest test run that didn't fail on "real bugs", [this
test
run](https://github.com/openstreetmap/openstreetmap-website/actions/runs/16122953585)
for #6170:
The three executions of `rails test:all` finishe
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6187)
But you don't have to resend the entire page. #5175 fixed this by sending
`` + partial without the rest of the page. However that wasn't the only
issue, another one was #6112 and at the time I didn't know how/if it was
relate
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5880)
I
[asked](https://github.com/openstreetmap/openstreetmap-website/pull/5938#issuecomment-2813465994)
@hlfan how the following *both* things are supposed to work together:
- manipulations of svg internals like
https://github.co
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151)
The step was either successful or it was cancelled.
The entire run was cancelled to not waste time running tests that need to be
rerun after fixing bugs that are already found by other tests (assuming
https://github.com/opens
mmd-osm left a comment (openstreetmap/openstreetmap-website#6188)
We could change the text to "planet.osm.org". Adding a link is not a good idea
because the message originates from cgimap, and returned as plain text.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6188)
### Problem
> Either request a smaller area, or use planet.osm
I would like to suggest linking directly to planet.openstreetmap.org website at
https://planet.openstreetmap.org/
### Description
_No response_
### Screen
tomhughes left a comment (openstreetmap/openstreetmap-website#5880)
I've read through all the comments on this issue and also had a look at
@hlfan's work in #5938 and on the whole I think that I have to agree with
@gravitystorm and @hlfan that it would better if we could keep the SVGs
separate.
Setting `turbo-action=advance` as our pagination helper does causes a frame
navigation to be [promoted to a page
visit](https://turbo.hotwired.dev/handbook/frames#promoting-a-frame-navigation-to-a-page-visit)
which means turbo will try and [merge the head
elements](https://turbo.hotwired.dev/ha
@hlfan pushed 1 commit.
5e03d30860ac50753d4d247edd1a96cb60532a82 Restructure button selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6184/files/0e020c42e4bbdccf55ff36d2a43e96031a6b66d5..5e03d30860ac50753d4d247edd1a96cb60532a82
You are receiving this bec
@tomhughes commented on this pull request.
>
+---
+
+**Platform Support:** These instructions are based on Ubuntu 24.04 LTS, which
is the platform used by the OSMF servers. The instructions also work, with only
minor amendments, for all other current Ubuntu releases, Fedora and macOS.
The O
mmd-osm created an issue (openstreetmap/openstreetmap-website#6186)
Sometimes diary discussions are not rendered underneath the diary post, as
shown on the screenshot below.
https://github.com/user-attachments/assets/3130625b-11ef-4f45-b23e-3c3f9cdd5788";
/>
Sample page: https://master.apis.d
tomhughes left a comment (openstreetmap/openstreetmap-website#6182)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6182#issuecomment-3065095455
You are receiving this because you are subscribed to this t
Merged #6181 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6181#event-18599066638
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6182 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6182#event-18599066637
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6181)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6181#issuecomment-3065087328
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6185)
Note that even ignoring #6184 this may be affecting some bootstrap rules that
use placeholder matches.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6185#issue
@tomhughes requested changes on this pull request.
In addition to my inline comment there's a separate issue on Firefox which I've
opened #6185 for.
> @@ -556,6 +556,10 @@ header .search_forms,
.search_form {
.describe_location {
font-size: 10px;
+
+input:not(:placeholder-shown) + .
While reviewing #6184 I discovered a problem with Firefox causing by
autoprefixer adding a `-moz-placeholder` rule alongside the `placeholder-shown`
rule.
The details are discussed in
https://github.com/postcss/autoprefixer/issues/1533 but basically Firefox has
supported `placeholder-shown` si
Merged #6183 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6183#event-18598851506
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
34 matches
Mail list logo
