[openstreetmap/openstreetmap-website] Lock describe_location button to query placeholder (PR #6184)
Use the input state to toggle the describe_location button's visibility with CSS instead of manually updating. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6184 -- Commit Summary -- * Lock describe_location butto
Re: [openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)
hlfan left a comment (openstreetmap/openstreetmap-website#5880) Another thing to note is that the preview in the rich diff sped up my reviews of #6124 quite a bit. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomme
[openstreetmap/openstreetmap-website] Bump eslint from 9.30.1 to 9.31.0 (PR #6183)
Bumps [eslint](https://github.com/eslint/eslint) from 9.30.1 to 9.31.0.github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6182) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split relation tests (PR #6182)
Part of https://github.com/openstreetmap/openstreetmap-website/pull/6170. Like https://github.com/openstreetmap/openstreetmap-website/pull/6178 and #6181 but for relations controller. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split way tests (PR #6181)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6181) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split way tests (PR #6181)
Part of https://github.com/openstreetmap/openstreetmap-website/pull/6170. Like #6178 but for ways controller. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6181 -- Commit Summary -- * Split create way tests * Sp
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Element upload tests (PR #6179)
Merged #6179 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6179#event-18591838967 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Element upload tests (PR #6179)
tomhughes left a comment (openstreetmap/openstreetmap-website#6179) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6179#issuecomment-3063263382 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)
@AntonKhorev pushed 35 commits. 11ebba70651d2d20211f926bce3d4fb97f59034a Split create way tests ace80ff3e2f3cbcc505fa70c12d1b263f2fddf52 Split create way with invalid payload tests fc15dccc6228df59b03e4707eddae4b6ab9e96bc Split destroy way tests a2c0f7a2b0c38e478f03acfa1277302db8429cf3 Split
Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)
Merged #5706 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5706#event-18591308937 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split node tests (PR #6178)
Merged #6178 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6178#event-18591308966 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split node tests (PR #6178)
tomhughes left a comment (openstreetmap/openstreetmap-website#6178) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6178#issuecomment-3063166569 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Add Bootstrap .modal class to print styles to hide language select dialog (PR #6180)
Merged #6180 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6180#event-18591308951 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Can we avoid inlining svgs into erb templates? (Issue #5880)
1ec5 left a comment (openstreetmap/openstreetmap-website#5880) Pardon my ignorance, but could someone remind me why we wound up using inline SVGs all over in the first place? Was there a particular benefit we were aiming for, or is it just convenient? I see some potential tangible benefits of s
Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)
@tomhughes approved this pull request. Thanks for the extra tests. I think this looks good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5706#pullrequestreview-3011280535 You are receiving this because you are subscribed
Re: [openstreetmap/openstreetmap-website] Add Bootstrap .modal class to print styles to hide language select dialog (PR #6180)
tomhughes left a comment (openstreetmap/openstreetmap-website#6180) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6180#issuecomment-3063106035 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Add Bootstrap .modal class to print styles to hide language select dialog (PR #6180)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6180#pullrequestreview-3011231088 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Paging interferes with logout flow (Issue #6172)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6172) Logout is not the only thing paging interferes with. See #5175 and #6112. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6172#issuecomment-3063082430 You are
[openstreetmap/openstreetmap-website] Add Bootstrap .modal class to print styles to hide language select dialog (PR #6180)
Fixes https://github.com/openstreetmap/openstreetmap-website/pull/6119#issuecomment-3059447787 by making Bootstrap modals hidden by default. Similar to #5999. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6180 -- C
Re: [openstreetmap/openstreetmap-website] Restructure core developer docs (PR #6111)
@hlfan commented on this pull request. > +**Important Notes:** +- Loading an apidb database with Osmosis is about **twenty** times slower than loading the equivalent data with osm2pgsql into a rendering database +- [`--log-progress`](https://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage#-
Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)
@AntonKhorev commented on this pull request. > + session_for(user) + + freeze_time do +put account_terms_path, :params => { :referer => "/test", :read_ct => 1, :read_tou => 1 } + +assert_redirected_to "/test" +assert_equal "Thanks for accepting the new contribu
Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)
@AntonKhorev pushed 3 commits. bdb65921f1cb953b5488e88c62f815d3a9c791f9 Allow to revisit terms page if already agreed 18a25c66f9df096d5b7b1f5593c8b4945a583c00 Allow to agree to new terms if already agreed to old terms d97ef45337c07e80840b3ba24447f8161d5aa68a Show terms acceptance dates and li
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
hlfan left a comment (openstreetmap/openstreetmap-website#6137) > When this is ready for merging I'll rebase and squish before taking it out of > draft. Moving the layer definition out of [leaflet.map.js](https://github.com/openstreetmap/openstreetmap-website/pull/6137/files#diff-f060eef487077b
[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Element upload tests (PR #6179)
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6179 -- Commit Summary -- * Test create single element changeset uploads * Test modify single element changeset uploads * Test delete single element changeset uplo
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split node tests (PR #6178)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6178) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Enhanced changeset statistics - Split node tests (PR #6178)
Part of #6170. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6178 -- Commit Summary -- * Create api elements test helper module * Add common api element testing methods * Split create node tests * Split creat
Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)
@AntonKhorev pushed 46 commits. c2159c5d0069acace5799f8b7702fb8c0beb7d68 Create api elements test helper module 9956a64e05f6b1a60c66fbcd70cdb1c601f52682 Add common api element testing methods 37570ffd3fe52d8b7ea4bc514a7bb90ab71f12b2 Split create node tests dc3c5aa783cb01ea72f2d8432ce91cc082f254
Re: [openstreetmap/openstreetmap-website] Add Cross-Origin-Opener-Policy header (2ff4d6a)
Creating some outreach about the security update: * https://operations.osmfoundation.org/2025/07/11/security-notice.html * https://en.osm.town/@osm_tech/114835178232370008 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/commit/2ff4d6a4e
Re: [openstreetmap/openstreetmap-website] Should we remove changeset-color-hint-bar again? (Issue #6177)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6177) You can't remove them "again" because they were never removed before. Color mismatch is because of opacity, and opacity is there for a couple of reasons[^1] that can be addressed. [^1]: *viewport size for intersection observe
Re: [openstreetmap/openstreetmap-website] Test Cross-Origin-Opener-Policy header (Issue #6173)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6173) I'd suggest to check the respective repos instead, such as https://github.com/facebook/Rapid/issues/1722 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6173#iss
Re: [openstreetmap/openstreetmap-website] Test Cross-Origin-Opener-Policy header (Issue #6173)
shaomingquan left a comment (openstreetmap/openstreetmap-website#6173) Hi, I'm maintaining a third-party editor based on the iDEditor. Currently, I found I cannot log in to my OSM account in my application, on the callback page, the following error occurred `Uncaught TypeError: Cannot read prop
Re: [openstreetmap/openstreetmap-website] Language select modal dialog (PR #6119)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6119) Adding ```css .select_language_dialog { display:none } ``` to https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/stylesheets/print.scss should fix this. -- Reply to this email directly or view it o
