Re: [openstreetmap/openstreetmap-website] Language select modal dialog (PR #6119)

2025-07-10 Thread Frederik Ramm via rails-dev
woodpeck left a comment (openstreetmap/openstreetmap-website#6119) After this pull request has been merged, an attempt to print a map from the web site now generates a four-page printout of which the first three pages are a language selector: https://github.com/user-attachments/assets/c77e7e9f-

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Emin Kocan via rails-dev
kcne left a comment (openstreetmap/openstreetmap-website#3815) > I've recently found myself reviewing less frequently, not because I expected > progress on particularly my submissions in return, but because I didn't see > my reviews contributing meaningfully to overall progress. I've experience

[openstreetmap/openstreetmap-website] Should we remove changeset-color-hint-bar again? (Issue #6177)

2025-07-10 Thread mmd via rails-dev
mmd-osm created an issue (openstreetmap/openstreetmap-website#6177) I have to admit that I lost track at which point we have introduced dynamic colors for changeset bounding boxes on the map. In any case, the changeset color hint bar as shown in the screenshot below doesn't match these dynamic

Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)

2025-07-10 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6154) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3058816461 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)

2025-07-10 Thread Tom Hughes via rails-dev
Merged #6154 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154#event-18572612596 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Save any screenshots when tests fail in CI (PR #6066)

2025-07-10 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6066) Err That must have been an accidental push to the wrong repo. I'll delete it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6066#issuecomment-3058808256 Yo

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#3815) Sent you a [c.osm.org](//c.osm.org) dm @1ec5. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-3058759408 You are receiving this because you are su

Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. bde4e2f507807a1f689cf2c931a05e7dcd84d1e5 Add reasonable workflow time limits -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/214482674768ef45d821993be280d3564c025947..bde4e2f507807a1f689cf2c931a05e7dcd84d1e5 You are receiving

Re: [openstreetmap/openstreetmap-website] Save any screenshots when tests fail in CI (PR #6066)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6066) Can [origin/save-screenshots](https://github.com/openstreetmap/openstreetmap-website/tree/save-screenshots) be deleted, or is it still needed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Minh Nguyễn via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#3815) > A big part of that, I think, comes down to differing review criteria between > contributors and maintainers. That’s fair to some extent, but it becomes > frustrating when a maintainer fast-tracks their PR that renders an earlier,

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#3815) No, but going out of their way to submit a compact PR that is easily reviewable (and mergeable - not self-merge though) to undermine a PR, forcing their point with a necessary rebase rather than simply having a discussion. -- Repl

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#3815) Are you suggesting that maintainers have been merging their own PRs? I can only think of one case of that in the last year or so? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] Please help with pull requests! (Issue #3815)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#3815) I've recently found myself reviewing less frequently — not because I expected progress on particularly my submissions in return, but because I didn't see my reviews contributing meaningfully to overall progress. A big part of that,

Re: [openstreetmap/openstreetmap-website] Increase changeset query max limit (Issue #4109)

2025-07-10 Thread Roman Deev via rails-dev
deevroman left a comment (openstreetmap/openstreetmap-website#4109) Well, I know. But you now have a way to make a win-win solution. p.s. I do not plan to discuss the ethical side and the impact on the infrastructure of my solution here (spoiler: no impact). -- Reply to this email directly or

Re: [openstreetmap/openstreetmap-website] Increase changeset query max limit (Issue #4109)

2025-07-10 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#4109) > _aggressively parallelizing_ Whatever this means in detail, it doesn't sound like it is covered by the [API Usage policy](https://operations.osmfoundation.org/policies/api/). -- Reply to this email directly or view it on GitHu

Re: [openstreetmap/openstreetmap-website] Various API changesets/elements controller test updates (PR #6176)

2025-07-10 Thread Tom Hughes via rails-dev
Merged #6176 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6176#event-18569567989 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump @types/leaflet from 1.9.19 to 1.9.20 (PR #6174)

2025-07-10 Thread Tom Hughes via rails-dev
Merged #6174 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6174#event-18569567951 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Refactor diaries index with guard clauses (PR #4191)

2025-07-10 Thread Tom Hughes via rails-dev
Merged #4191 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4191#event-18569568059 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Refactor diaries index with guard clauses (PR #4191)

2025-07-10 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#4191) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4191#issuecomment-3058102990 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Various API changesets/elements controller test updates (PR #6176)

2025-07-10 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6176) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6176#issuecomment-3058094957 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Refactor diaries index with guard clauses (PR #4191)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4191#pullrequestreview-3006287729 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Various API changesets/elements controller test updates (PR #6176)

2025-07-10 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6176#pullrequestreview-3006217290 You are receiving this because you are subscribed to this thread. Message ID: __

[openstreetmap/openstreetmap-website] Various API changesets/elements controller test updates (PR #6176)

2025-07-10 Thread Anton Khorev via rails-dev
A number of changes to api changesets, nodes, ways and relations controllers going towards #6170. I split the existing tests there to make them independent. This PR contains changes prior to the splits. You can view, comment on, or merge this pull request online at: https://github.com/openstre

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 15 commits. cf3067864676a551fdefd911c24bdaae65fede61 Add total created/modified/deleted counts to changesets 9afb74fd91722126e2b26478c806c402bc3b0bac Test that new changeset has type changes in sync 1e23d6f2ba3a998868df1ac0f65ba578c4d83f47 Test that failed/empty changeset

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. 686eff4f80c5b74cd7a6afcf31ebe124e87384fc Update number of deleted ways in changeset 0dd348608bd46c92d79e292fa8ea6c49b707db5a Update number of deleted relations in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/f

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 14 commits. b3cb0a70e3245eca22048feece3cc54aab83a958 Test delete single element changeset uploads fed064a9422f2ce9a4285f0c755df78511afd21c Add create/modify/delete counts to changeset table f2ee239121c129f07cb17d804c3fff544f3c5c74 Validate changeset num_*_changes 5f8bac642

Re: [openstreetmap/openstreetmap-website] Add Cross-Origin-Opener-Policy header (2ff4d6a)

2025-07-10 Thread Harel M via rails-dev
I've looked at the code changes made in other libraries but I'm not sure I understand how one knows that the popup window was closed and that the login flow needs to be cancelled. Have any of you found a solution to this scenario? I'm using an updated "private" version of osm-oauth since I also n

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 16 commits. 15954c94931f183200c52aefaf5678720d5b1f85 Test updating relation 1ecf57e6926a6dd5ebda9286114191355db4115b Split destroy relation tests 0468e267154bbd3a8b0ffdf79467df03c14366a3 Test create single element changeset uploads 0833aee2ee9639b4387e4fa3bfc7c2275996445b

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 11223a0aaebec03b2da2cda78e7270154fbfc56a Update number of modified ways in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/9aac311abfbf8cf59b501dbc79d64e63a398c303..11223a0aaebec03b2da2cda78e7270154fbfc56a You

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 9aac311abfbf8cf59b501dbc79d64e63a398c303 Update number of modified nodes in changeset -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/53f1e6041faad325111facf528f7963ae3eac673..9aac311abfbf8cf59b501dbc79d64e63a398c303 Yo

Re: [openstreetmap/openstreetmap-website] Enhanced changeset statistics (PR #6170)

2025-07-10 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 11 commits. bfe3f726c061479418311967fef865bf11018c14 Test create single element changeset uploads 6bd01c573cd9b0c432c5bfa861db8a74069e8189 Test modify single element changeset uploads d734135797e2fff58000a0c02b48069a8740495d Add create/modify/delete counts to changeset ta