@AntonKhorev pushed 11 commits.
cdcaa816c1eec75757d5ca1b715ba41dd09ea500 Split update node tests
f169c8e5c091029732c53e7087566f2a567d0c53 Make duplicate tags test similar to
update node tests
0c299b88b8fcabdf9c433e399ed6374b78d834ed Split node string injection tests
d6028657020a15f31ee15813ba0
@AntonKhorev pushed 12 commits.
4fcddefd5dca0826a37c7c6931ddc66f6449628b Split destroy node tests
1f8cc1b6e79005f795609a1873bd33debeb5fad5 Remove incorrect node update test
a272722fc3ccb7e3d4aae0017510c89dcb6cfd4b Split update node tests
9e0b11d3c95fd661ceed81860aa77642a2c28f18 Make duplicate
@AntonKhorev pushed 14 commits.
fcb2b308f31639cbb57a45993613622365f9c398 Split create node tests
82fd291ffed2e343b2a5ffc34de31105dea3dd32 Split create node with invalid xml
tests
2d0db1f2e90ed8bc535ece85d4586ccc9522b27c Rename node decimal format test
52aa76eadf7b9577b77e821d0b3dcd6ac044cd08
@AntonKhorev pushed 8 commits.
461bac547d19026e7b2d5fc6d3e5bd23ffc29c89 Split create node tests
eb158147807c09ef15692ebbc805d7cbcba04a33 Split create node with invalid xml
tests
37596c2766e7d30b7bd311961ded8174c9e7848f Rename node decimal format test
c45d49f9b8bd9636746eedf19a92d4c4e44d29f0 S
@AntonKhorev pushed 1 commit.
d43dc13f6444702decf53fa0f22b624dd03f8052 Make duplicate tags test similar to
update node tests
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6170/files/fe6cdddbda259825992e2063e02ab80172032ef6..d43dc13f6444702decf53fa0f22b624dd0
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6170)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
Rails part of https://github.com/zerebubuth/openstreetmap-cgimap/pull/510
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6170
-- Commit Summary --
* Remove redundant changeset create by private user test
* Test th
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan pushed 1 commit.
19e739716360bf69d3ab06abbf4109f2ab549fb7 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/e81bb9bd7139faa95b0ef4f6b34163e7d7db001a..19e739716360bf69d3ab06abbf4109f2ab549fb7
You are rec
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6169)
Happens only when logged in. When logged in is of course only time 'preferences
updated' is shown..
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6169#i
tomhughes left a comment (openstreetmap/openstreetmap-website#6169)
Is this when you are logged in, or logged out?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6169#issuecomment-3037062393
You are receiving this because you a
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6169)
### URL
https://www.openstreetmap.org/changeset/168370364
### How to reproduce the issue?
Ref #6119
1. Go to a changeset. Try language selection, it works fine. (i.e. EN-GB <=> NL
or vice versa)
2. Go to History, or cl
@tomhughes requested changes on this pull request.
> + session_for(user)
+
+ freeze_time do
+put account_terms_path, :params => { :referer => "/test", :read_ct =>
1, :read_tou => 1 }
+
+assert_redirected_to "/test"
+assert_equal "Thanks for accepting the new co
Merged #6168 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6168#event-18476619580
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6168)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6168#issuecomment-3037002019
You are receiving this because you are subscribed to this t
As requested in FIXME:
```
# FIXME: This should really be moded to a integration test due to the
with_controller
```
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6168
-- Commit Summary --
* Move changeset bbox te
Closed #6167 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6167#event-18472218766
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomass left a comment (openstreetmap/openstreetmap-website#6167)
Yes, I've successfully deleted the messages now.
Thank you for blazing fast response!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6167#issuecomment-3036225599
tomhughes left a comment (openstreetmap/openstreetmap-website#6167)
I've fixed the broken titles now, so those messages should be deletable.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6167#issuecomment-3036207966
You are re
tomhughes left a comment (openstreetmap/openstreetmap-website#6167)
Actually your hypothesis is, indirectly, correct as the title is causing the
model to fail validation:
```
open-street-map(dev)> m=Message.find(381011)
Message Load (1.2ms) SELECT "messages".* FROM "messages" WHERE
"messages
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
tomass left a comment (openstreetmap/openstreetmap-website#6167)
Yes, I agree, and "delete POST" request does not seem to have subject text
anywhere in the request headers or body. But by external observation something
is happening in the backend/db where that subject is possibly having some
in
tomhughes left a comment (openstreetmap/openstreetmap-website#6167)
The delete should be ID based so I don't think the subject will have any effect.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6167#issuecomment-3035909520
Yo
tomass created an issue (openstreetmap/openstreetmap-website#6167)
### URL
https://www.openstreetmap.org/messages/inbox
### How to reproduce the issue?
In my personal list of messages I cannot delete some old messages, in
particular:
Inbox:
https://www.openstreetmap.org/messages/381262
https:/
tomhughes left a comment (openstreetmap/openstreetmap-website#6137)
Shouldn't the path be `@mapbox/mapbox-gl-rtl-text/dist/mapbox-gl-rtl-text.js`?
I don't see the version without `dist`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
pnorman left a comment (openstreetmap/openstreetmap-website#6137)
I'm not sure what the CI failure is from.
```
Sprockets::FileNotFound: couldn't find file
'@mapbox/mapbox-gl-rtl-text/mapbox-gl-rtl-text.js' (Sprockets::FileNotFound)
```
I don't get this in my local environment or see it in #4042
28 matches
Mail list logo