@hlfan pushed 1 commit.
e81bb9bd7139faa95b0ef4f6b34163e7d7db001a Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/5ac1b483f08bab249fe63f03221748a26640..e81bb9bd7139faa95b0ef4f6b34163e7d7db001a
You are rec
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" +
encodeURIComponent(data.icon))
+.append($("").attr({ src, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
@1ec5 commented on this pull request.
> @@ -1,10 +1,16 @@
(function () {
+ let abortController = null;
+ const langs = [...new Set([...OSM.preferred_languages.map(l =>
l.toLowerCase()), "mul", "en"])];
+ const wikis = [...new Set(langs.map(l => l.split("-")[0] + "wiki"))];
Wikimedia wiki c
@hlfan commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appe
@hlfan commented on this pull request.
> +.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
> "Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appendTo(cell);
+}
+if (data.label) {
+ $btn
+.siblings(`a[href*="
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Why should we cancel successfully run steps like [this
one](https://github.com/hlfan/openstreetmap-website/actions/runs/16058832401/job/45319779765#step:13:16)?
--
Reply to this email directly or view it on GitHub:
https://github.c
@hlfan pushed 1 commit.
5ac1b483f08bab249fe63f03221748a26640 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/d47b9f2e8a32e9ff5c92a19ab6b2b458c8d01105..5ac1b483f08bab249fe63f03221748a26640
You are rec
1ec5 left a comment (openstreetmap/openstreetmap-website#6165)
> This would make copying coordinates into development tools and code snippets
> much more convenient and reduce confusion or errors.
If one of the internal result’s labels is just regurgitating what the user
entered into the search
@1ec5 commented on this pull request.
> + icon: ["P8972", "P154", "P14"].reduce((out, prop) => out ??
> entity.claims[prop]?.[0]?.mainsnak?.datavalue?.value, null),
+ description: localizedProperty("descriptions", langs)?.value,
+ article: localizedProperty("sitelinks", wikis)
+
@1ec5 commented on this pull request.
> + $("")
+.attr("href", OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon)
+.append($("").attr({ src: OSM.WIKIMEDIA_COMMONS_URL +
"Special:FilePath/" + data.icon, height: "32" }))
+.addClass("float-end mb-1 ms-2")
+.appen
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
@Firefishy Did Wikimedia ever reacted to how we use their images in iD, or was
it just in wiki? Or are they already rate-limiting us in iD too but it's not
very noticeabe because images are small?
--
Reply to this email dire
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
> How does OSM TagPreview
> (https://github.com/openstreetmap/openstreetmap-website) look to you?
I think there shouldn't be a space in `OSM TagPreview`.
https://httpwg.org/specs/rfc9110.html#field.user-agent
--
Reply to th
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
Human-readable wikidata addon also limits image sizes (`?width=128`) which may
result in transfers for raster images
(https://www.openstreetmap.org/node/689097130 Starbucks logo: 19.40 kB in the
addon vs 54.21 kB in this PR),
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> we should add an Api-User-Agent header to the fetch in this PR
How does `OSM TagPreview
(https://github.com/openstreetmap/openstreetmap-website)` look to you? Any
other details I'm missing?
--
Reply to this email directly or vi
Merged #6166 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6166#event-18457465626
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6166)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6166#issuecomment-3033098045
You are receiving this because you are subscribed to this t
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
Hotlinking to images on Commons:
I'm not sure if it's allowed according to [their
policy](https://commons.wikimedia.org/w/index.php?title=Commons:HOTLINK), but
we're already doing it in iD.
--
Reply to this email directly o
@Pikse pushed 1 commit.
da0e2e4306274363ba1079dfd3f28648c068add6 Fix message reuse for Terms of Use
link in signup form
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6166/files/0ec6286129f73c516b775df5fd45c99642497599..da0e2e4306274363ba1079dfd3f28648c068add
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
We're using two Wikimedia services her, Wikidata and Commons.
Wikidata usage should be ok except for [user agent
header](https://www.mediawiki.org/wiki/API:Etiquette#The_User-Agent_header):
> It is best practice to set a desc
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
> Are WikiData ok with us doing this? Will they rate limit us like they do on
> wiki.osm.org with WikiCommons?
Are they rate-limiting users who click the currently available Qn wikidata
links?
--
Reply to this email dir
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5706)
> Just to confirm, does this PR result in actively presenting pre-2019 users
> with some sort of notice about the new terms, without having to visit the
> account settings first?
No it doesn't. There's no point in *actively p
@1ec5 approved this pull request.
The logic looks correct to me. Just to confirm, does this PR result in actively
presenting pre-2019 users with some sort of notice about the new terms, without
having to visit the account settings first? If not, we still need to do that as
tail work based on th
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6165)
Maybe we have space inside *Internal* to show both, like:
~~~
- lat, lon: lon, lat:
60.0, 30.030.0, 60.0
- lat, lon: lon, lat:
30.0, 60.060.0, 30.0
~~~
with only one result if lat is outsid
Currently `layouts.tou` message (link label) is reused in two different
sentences, i.e. in messages `accounts.terms.show.tou explain html` and
`users.new.by_signing_up.html`. In some languages however the link label needs
different declension in these sentences.
Here `users.new.by_signing_up.to
@AntonKhorev commented on this pull request.
> not_agreed_with_pd: "You haven't declared that you consider your
> edits to be in the Public Domain."
-pd_link_text: "declare"
+review: "Review the Terms"
+review_and_accept: "Review and accept the Terms"
+c
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6165)
[Geo URI](https://en.wikipedia.org/wiki/Geo_URI_scheme) uses lat,lon for
example.
> and mapping libraries such as [...] Leaflet
[Are you sure about that?](https://leafletjs.com/reference.html#latlng)
--
Reply to this email
@AntonKhorev pushed 1 commit.
cab7a34e965130aeda493cd67d072965bbaaccc4 Show terms acceptance dates and link
to terms on account page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5706/files/1c1753819257faefbf694ba5edb715c9fc9f9d19..cab7a34e965130aeda493cd67d
tomhughes left a comment (openstreetmap/openstreetmap-website#6165)
Firstly there is basically agreement at all on order and it's a complete toss
up whether any given tool/format puts latitude or longitude first.
Secondly I believe that the specific example you've shown (and it's not clear
if t
@1ec5 commented on this pull request.
> not_agreed_with_pd: "You haven't declared that you consider your
> edits to be in the Public Domain."
-pd_link_text: "declare"
+review: "Review the Terms"
+review_and_accept: "Review and accept the Terms"
+consider
daishu created an issue (openstreetmap/openstreetmap-website#6165)
Currently, OpenStreetMap displays coordinates in the latitude, longitude
(lat,lon) format. While this works well for most users, many d
hlfan left a comment (openstreetmap/openstreetmap-website#5854)
Should I split up the "Update and inline markers" commit into three parts and
temporarily make `OSM.getMarker` use a dict so I can update the options
separately?
Would that make this PR easier to digest?
--
Reply to this email dir
jachym left a comment (openstreetmap/openstreetmap-website#4042)
> I think the only thing is that somebody suggested (and I can't remember where
> I saw it) that the layer included additional buildings that weren't from OSM
> data but I haven't had a chance to investigate that claim yet.
This s
36 matches
Mail list logo
