petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
> Whether or not the style.json path definition changes, this now looks good to
> me. That could also be worth revisiting when there's more than one vector
> style. Tests pass in my fork
> [hlfan#18](https://github.com/hlfan/o
@hlfan approved this pull request.
Whether or not the style.json path definition changes, this now looks good to
me. That could also be worth revisiting when there's more than one vector style.
Tests pass in my fork https://github.com/hlfan/openstreetmap-website/pull/18.
If you wanna do other rev
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)
In the end I keep maplibre v4 with maplibre-gl-leaflet 0.0.22 since for some
reason the custom attribution got broken after updating. Someone else can
update this in some followup PR.
--
Reply to this email directly or view i
@petr-hajek pushed 1 commit.
cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a0fbba2fd57623718f90c56ba8d82c662368a7f..cc0297185f0ca64ce0b5ba06f2797b4d65bbc89b
You are receiving thi
@petr-hajek commented on this pull request.
> @@ -79,3 +79,18 @@
osm_france_link:
id: "osm_france"
href: "https://openstreetmap.fr/";
+
+- leafletOsmId: "OpenMapTiles"
+ code: "V"
+ layerId: "openmaptiles_osm"
+ nameId: "openmaptiles_osm"
+ apiKeyId: "maptiler_key"
@petr-hajek pushed 1 commit.
4a0fbba2fd57623718f90c56ba8d82c662368a7f Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/8fc98e107970781caffed51aa5adaee913315363..4a0fbba2fd57623718f90c56ba8d82c662368a7f
You are receiving thi
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6164)
> Unfortunate merge timing Mr. Hughes:
For the record:
Fixed with af0c68e
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6164#issuecomment-3029334292
You ar
@hlfan commented on this pull request.
> @@ -11,6 +11,7 @@ permissions:
jobs:
danger:
runs-on: ubuntu-latest
+timeout-minutes: 1
Well that has to be revised:
https://github.com/openstreetmap/openstreetmap-website/actions/runs/16033899766/job/45240902000?pr=6154
That's why I initia
maro-21 left a comment (openstreetmap/openstreetmap-website#5770)
After changes in
https://github.com/openstreetmap/openstreetmap-website/pull/5775,
https://github.com/openstreetmap/openstreetmap-website/commit/912521c1ba6a0013a42f7d3394ed59d19b988ad2,
https://github.com/openstreetmap/openstre
Closed #5770 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5770#event-18438024244
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@hlfan pushed 2 commits.
623db110e4d50b3b1f1177cdd3d1f4a49a4e1f11 Fix formatting of arrow function
45f8ed06bdb881b70188c1401061878e19281f28 Add reasonable workflow time limits
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/df9d34c332cc26c6cd2d242ca
hlfan left a comment (openstreetmap/openstreetmap-website#6154)
Maybe both?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-3028913120
You are receiving this because you are subscribed to this thread.
Message ID
tomhughes left a comment (openstreetmap/openstreetmap-website#6154)
Would it make more sense to set the timeout at the job level rather than just
on one step?
For the `docker` and `tests` workflow it would probably need to be 15 minutes
or so on the main job while `lint` probably just needs a m
Firefishy left a comment (openstreetmap/openstreetmap-website#6127)
Are WikiData ok with us doing this? Will they rate limit us like they do on
wiki.osm.org with WikiCommons?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#i
@hlfan pushed 1 commit.
86643d22c51ee3fed1c99d173a390b8a10a9a9bb Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/71aa64b26c32a3c21da04ad45fcd128780b2440d..86643d22c51ee3fed1c99d173a390b8a10a9a9bb
You are rec
@hlfan pushed 2 commits.
623db110e4d50b3b1f1177cdd3d1f4a49a4e1f11 Fix formatting of arrow function
71aa64b26c32a3c21da04ad45fcd128780b2440d Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/9f42faa59f74e2b1fd
hlfan left a comment (openstreetmap/openstreetmap-website#6164)
Unfortunate merge timing Mr. Hughes:
https://github.com/openstreetmap/openstreetmap-website/blob/ef2f248e0075a4cd7d77eefc77665f1730d6bd4b/app/assets/javascripts/leaflet.share.js#L15
--
Reply to this email directly or view it on GitH
@hlfan commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
+
Merged #6161 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6161#event-18436647244
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6162 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6162#event-18436647245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6164 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6164#event-18436647213
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6160 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6160#event-18436647265
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6164)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6164#issuecomment-3028663472
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6162)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6162#issuecomment-3028660201
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6161)
Looks good to me although really there are dozens of other pages you could add
the same test to - this just happened to be the one where it was broken.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
kcne left a comment (openstreetmap/openstreetmap-website#6154)
I also agree that adding reasonable timeouts is a good idea. It would help free
up resources and improve reliability -especially in cases where jobs silently
hang or get stuck without failing fast.
--
Reply to this email directly o
@AntonKhorev commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
@hlfan commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
+
@AntonKhorev commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
@AntonKhorev commented on this pull request.
> @@ -17,10 +17,16 @@ def format_value(key, value)
elsif wdt = wikidata_links(key, value)
# IMPORTANT: Note that wikidata_links() returns an array of hashes,
unlike for example wikipedia_link(),
# which just returns one such hash.
@kcne commented on this pull request.
>
-## Managing Users
+After creating a user through the web interface at
[http://localhost:3000](http://localhost:3000), you may need to perform
additional user management tasks. If you don't want to set up your development
box to send emails, you can m
@AntonKhorev commented on this pull request.
> + svg = tag.a :href => "", :class => "wdt-preview", :data => { :qids =>
> wdt.map { |w| w[:title] } } do
+tag.svg :width => 27, :height => 14, :class => "float-end m-1" do
Firefox on Ubuntu.
Buttons don't require padding, they have s
@kcne commented on this pull request.
>
-```
+After installing but before creating any users or data, import an extract with
[Osmosis](https://wiki.openstreetmap.org/wiki/Osmosis) and the
[`--write-apidb`](https://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage#--write-apidb_.28--wd.29)
@kcne commented on this pull request.
>
-These instructions are based on Ubuntu 24.04 LTS, which is the platform used
by the OSMF servers.
-The instructions also work, with only minor amendments, for all other current
Ubuntu releases, Fedora and MacOSX
+### Recommended: Containerized Install
kcne left a comment (openstreetmap/openstreetmap-website#6111)
> Please remove the duplicate lines you added.
Messed something up during the conflict. It should be resolved now. Please let
me know if there is any additional changes needed. Thank you.
--
Reply to this email directly or view it
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6163)
Rendering of this place should improve after the miles-yards changes are
deployed. There won't be km/mi buttons on the side.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap
@kcne pushed 3 commits.
f198c551f0c1b846f59ceb62c990a51f1846bbad Restructure INSTALL.md
0406ed38b934952be8de145f4e023d1280dc0609 Restructure CONTRIBUTING.md
060322e66d86c5cb8803007329210e1f884554e8 Restructure CONFIGURE.md
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
hlfan left a comment (openstreetmap/openstreetmap-website#6111)
Please remove the duplicate lines you added.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6111#issuecomment-3028249199
You are receiving this because you are subsc
@kcne pushed 3 commits.
6f4f967bb285ded4ffa97aceec02cc0ebe271842 Restructure INSTALL.md
7cd06bdb96e4eb44fc621b8d6c2ffd38c74deb70 Restructure CONTRIBUTING.md
0de9c0797c6d6cab6c55a4b44615800ba5c9a586 Restructure CONFIGURE.md
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
@HolgerJeromin approved this pull request.
I do not like stylistic eslint rules (but prettier is harder to add here) but
it is consistent.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6164#pullrequestreview-2978977874
You ar
tomhughes left a comment (openstreetmap/openstreetmap-website#6163)
Yes HTML is only allowed in certain specific strings because rails has to treat
anything that might contain HTML differently in order to avoid various security
issues.
In general we expect translations to remain true to the for
Closed #6163 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6163#event-18430624601
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
The arrow syntax should be equally as checked as the regular function syntax.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6164
-- Commit Summary --
* Enable arrow-spacing ESLint rule
-- File Changes --
M co
hlfan left a comment (openstreetmap/openstreetmap-website#6163)
i18n has two types of translations, ones handling text, ones handling html. The
html translations have that as a suffix.
Due to the increased control over the content, plain text translations are the
default and html ones should onl
hlfan left a comment (openstreetmap/openstreetmap-website#6163)
[Here](https://translatewiki.net/w/i.php?title=Special:Search&limit=50&offset=0&ns1222=1&search=insource%3Anbsp)'s
a list of containing inappropriately encoded U+00A0.
--
Reply to this email directly or view it on GitHub:
https://g
ricloy left a comment (openstreetmap/openstreetmap-website#6163)
AFAIK HTML entities are used and parsed correctly in a few other cases (e.g.
`©` and `®` in the copyright page); I think it would be plausible to
have the same behaviour with ` `; moreover I don't how many translators
are familiar
hlfan left a comment (openstreetmap/openstreetmap-website#6163)
There are two types of how translations are handled, either as plain text or as
full html. The latter is discouraged if it's not needed. This non-issue about
character encoding is exactly that, the U+00a0 characters already show up
ricloy created an issue (openstreetmap/openstreetmap-website#6163)
### URL
https://www.openstreetmap.org/directions?locale=et&engine=fossgis_osrm_car&route=43.96236%2C11.30708%3B43.96151%2C11.30427#map=18/43.961907/11.305688
### How to reproduce the issue?
Wherever translated text
[Osm:Javacri
Trade extra JS for extra HTML since that's now a thing
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6162
-- Commit Summary --
* Refactor share pane buttons to use Bootstrap tabs
-- File Changes --
M app/asse
tomhughes left a comment (openstreetmap/openstreetmap-website#4042)
I think the only thing is that somebody suggested (and I can't remember where I
saw it) that the layer included additional buildings that weren't from OSM data
but I haven't had a chance to investigate that claim yet.
--
Reply
50 matches
Mail list logo
