Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
pnorman left a comment (openstreetmap/openstreetmap-website#4042) I *think* there was a question that still needed answering from MapTiler about the featured layer discussions. I'll have to review emails or check notes to be sure -- Reply to this email directly or view it on GitHub: https://gi
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@hlfan pushed 1 commit. 9f42faa59f74e2b1fd05097fb16cde116a1338c2 Add human-readable wikidata explainations -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/c8f0ba4f5760a7593b574506de5a141e01fce39a..9f42faa59f74e2b1fd05097fb16cde116a1338c2 You are rec
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@hlfan pushed 1 commit. c8f0ba4f5760a7593b574506de5a141e01fce39a Add human-readable wikidata explainations -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/54d2eb08341fabe4b31942f87e781a75e8f67340..c8f0ba4f5760a7593b574506de5a141e01fce39a You are rec
Re: [openstreetmap/openstreetmap-website] Stop GitHub form cancelling related workflows early (PR #6151)
hlfan left a comment (openstreetmap/openstreetmap-website#6151) > If workflows fail only on real bugs, it makes sense to terminate early. That seems like an argument for #6154 to me. I'll get back to you on this once real bug caused failures like in this [Docker workflow](https://github.com/ope
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@hlfan commented on this pull request. > + svg = tag.a :href => "", :class => "wdt-preview", :data => { :qids => > wdt.map { |w| w[:title] } } do +tag.svg :width => 27, :height => 14, :class => "float-end m-1" do I already sliced the pixel perfect wikidata logo to not bloat up the
Re: [openstreetmap/openstreetmap-website] Stop GitHub form cancelling related workflows early (PR #6151)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151) If workflows fail only on real bugs, it makes sense to terminate early. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3025978203 You are rec
Re: [openstreetmap/openstreetmap-website] Omit changeset "💬" from changeset list where there are no comments (Issue #5757)
andrewharvey left a comment (openstreetmap/openstreetmap-website#5757) > @andrewharvey How does it look now with edit/comment counters arranged > horizontally? Looks good. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#i
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@AntonKhorev commented on this pull request. > + $("#sidebar_content").on("click", "a.wdt-preview", e => { +e.preventDefault(); +previewWikidataValue($(e.currentTarget)); + }); 1. Open any element page with wikidata. 2. Close the sidebar. 3. Press *back* to reopen the
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@AntonKhorev commented on this pull request. > + svg = tag.a :href => "", :class => "wdt-preview", :data => { :qids => > wdt.map { |w| w[:title] } } do +tag.svg :width => 27, :height => 14, :class => "float-end m-1" do Actually why is it a link and not a button? It doesn't have `h
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@AntonKhorev commented on this pull request. > + svg = tag.a :href => "", :class => "wdt-preview", :data => { :qids => > wdt.map { |w| w[:title] } } do +tag.svg :width => 27, :height => 14, :class => "float-end m-1" do Can you float the entire link? Otherwise its focus outline loo
Re: [openstreetmap/openstreetmap-website] Move set_locale as early as possible (PR #6157)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6157) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6157#issuecomment-3025874742 You are receiving this because you are subscribed to this thread.
[openstreetmap/openstreetmap-website] Add test for set_locale fix in notes controller (PR #6161)
Tests the fix in c266f3c90a154dcb43ab0ff2b2e4337c510707d8. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6161 -- Commit Summary -- * Add test for set_locale fix in notes controller -- File Changes -- M test/c
Re: [openstreetmap/openstreetmap-website] Move set_locale as early as possible (PR #6157)
Merged #6157 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6157#event-18421151517 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Notes controller calls set_locale after lookup_user which can cause unexpected language for 404 users notes (Issue #5251)
Closed #5251 as completed via c266f3c90a154dcb43ab0ff2b2e4337c510707d8. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5251#event-18421151532 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@hlfan commented on this pull request. > @@ -79,3 +79,18 @@ osm_france_link: id: "osm_france" href: "https://openstreetmap.fr/"; + +- leafletOsmId: "OpenMapTiles" + code: "V" + layerId: "openmaptiles_osm" + nameId: "openmaptiles_osm" + apiKeyId: "maptiler_key" If yo
[openstreetmap/openstreetmap-website] Bump eslint from 9.30.0 to 9.30.1 (PR #6160)
Bumps [eslint](https://github.com/eslint/eslint) from 9.30.0 to 9.30.1.AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757) @andrewharvey How does it look now with edit/comment counters arranged horizontally? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-302577
Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6084) Updated with unfoldable edit buttons in sidebar as shown in https://github.com/openstreetmap/openstreetmap-website/pull/6089#issuecomment-2973621776. Profile edit tests still haven't failed even once after I split the profile
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. fdc3e9da260c603bad306be6d28d58fc8018d109 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f8bd0b0153138be2f8c498370a3cc6665436b787..fdc3e9da260c603bad306be6d28d58fc8018d109 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)
hlfan left a comment (openstreetmap/openstreetmap-website#6065) If we go ahead with regarding the osm-related definition as too fuzzy for a section, even with a two icon approach you still need to make a decision about when to have two icons and when not. Just an "H" as a logo could be enough in
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 8fc98e107970781caffed51aa5adaee913315363 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/fdc3e9da260c603bad306be6d28d58fc8018d109..8fc98e107970781caffed51aa5adaee913315363 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@hlfan commented on this pull request. On vendor/assets/leaflet/leaflet.osm.vector.js: This shouldn't be under vendor but next to the leaflet.map.js you pulled it out of. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042#p
Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)
@hlfan pushed 1 commit. df9d34c332cc26c6cd2d242ca2617f3ef6b655b7 Add reasonable compile time limit -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154/files/52fd9795f8962df060f54e45775d9573effbf5c9..df9d34c332cc26c6cd2d242ca2617f3ef6b655b7 You are receiving th
Re: [openstreetmap/openstreetmap-website] Switch inline style to attributes (PR #6159)
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6159) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener
[openstreetmap/openstreetmap-website] Switch inline style to attributes (PR #6159)
Since I'd like to not have inline styles in icons and the other PR #6072 has had lowered activity I'm putting this here as an alternative that just removes style elements and attributes and converts the specifications to direct attributes. You can view, comment on, or merge this pull request onl
Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)
Firefishy left a comment (openstreetmap/openstreetmap-website#6154) https://github.com/user-attachments/assets/ebc9f809-399f-42ee-b412-42c581d0733d"; /> -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154#issuecomment-302531397
Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6154) I’ve frequently seen hanging test runs in cgimap, which turned out to be related to a used up quota. The job was being silently killed, and eventually hit the timeout, although it’s been dead for some minutes already. You should
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 8 commits. c98b771f624a84ca215888c98609113165e2d8e5 Refine dom structure assertions in profile and user tests 56d239401ec21a76b4d11ce6f4a8e414ae048f37 Make Rails handle SVG partials 0a5029653a3d6ccc9137085c1456916541cae150 Move search icons to partials f3efc28e0568a4036dc778b0bcb
Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)
Merged #6084 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6084#event-18416612528 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
[openstreetmap/openstreetmap-website] Allow customizing the text string for social media links on the profile page (Issue #6158)
bxl-forever created an issue (openstreetmap/openstreetmap-website#6158) ### Problem The new feature to add social links in nice. But links pointing to unknown websites (e.g. a home page, or a Mastodon instance that is not mastodon.social) will be trimmed and looks ugly. Also, if a user adds li
Re: [openstreetmap/openstreetmap-website] Simpliy linkify normalisation to use a single array of rules (PR #5862)
@hlfan commented on this pull request. > -linkify_hosts: ["www.openstreetmap.org", "www.osm.org", > "www.openstreetmap.com", "openstreetmap.org", "osm.org", "openstreetmap.com"] -# Shorter host to replace main hosts -linkify_hosts_replacement: "osm.org" -# Wiki website hosts to match in linkify
Re: [openstreetmap/openstreetmap-website] Simplify changeset icon definitions (PR #5884)
hlfan left a comment (openstreetmap/openstreetmap-website#5884) Since the merge of @AntonKhorev's #6155 the information about how often the icon was used before has been disjointed enough that defining the paths just once becomes unfeasible. However, the definitions can still be simplified. --
Re: [openstreetmap/openstreetmap-website] Simpliy linkify normalisation to use a single array of rules (PR #5862)
@tomhughes pushed 1 commit. f63dcf78d64ed6f34e1f18ba09214a5fb8dfbcd4 Simpliy linkify normalisation to use a single array of rules -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5862/files/f39078e058763eac04a74a03a447637d47db9e57..f63dcf78d64ed6f34e1f18ba09214
Re: [openstreetmap/openstreetmap-website] Can't see the itinerary's duration (Issue #6094)
Closed #6094 as completed via #6105. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6094#event-18417174468 You are receiving this because you are subscribed to this thread. Message ID: _
Re: [openstreetmap/openstreetmap-website] Make directions units button larger and add yards (PR #6105)
Merged #6105 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6105#event-18417173673 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Make directions units button larger and add yards (PR #6105)
tomhughes left a comment (openstreetmap/openstreetmap-website#6105) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6105#issuecomment-3025129775 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Simplify changeset icon definitions (PR #5884)
@hlfan pushed 1 commit. 73ef13fa723428f181237e481671cec9a7c8508b Simplify changeset icon definitions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5884/files/891597169452e0e20c356e361bfbfba94c87d112..73ef13fa723428f181237e481671cec9a7c8508b You are receiving
Re: [openstreetmap/openstreetmap-website] Show heatmap only to logged in users (PR #5829)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2976547233 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Make directions units button larger and add yards (PR #6105)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6105#pullrequestreview-2976539850 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)
tomhughes left a comment (openstreetmap/openstreetmap-website#6084) Very nice - looks good to me now, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6084#issuecomment-3025028897 You are receiving this because you are subs
Re: [openstreetmap/openstreetmap-website] Mark discussed changesets in the history (Issue #3621)
Closed #3621 as completed via #6155. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/3621#event-18416001832 You are receiving this because you are subscribed to this thread. Message ID: _
[openstreetmap/openstreetmap-website] Move set_locale as early as possible (PR #6157)
Fixes #5251 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6157 -- Commit Summary -- * Move set_locale as early as possible -- File Changes -- M app/controllers/notes_controller.rb (2) -- Patch Links -- ht
Re: [openstreetmap/openstreetmap-website] Reorganize changeset history info into two lines, reuse it in element details (PR #6155)
Merged #6155 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6155#event-18416001579 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Reorganize changeset history info into two lines, reuse it in element details (PR #6155)
tomhughes left a comment (openstreetmap/openstreetmap-website#6155) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6155#issuecomment-3024930225 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)
@AntonKhorev pushed 26 commits. f303b8cf3121391c6928b53ad40af94c4536d5dd Move Gravatar enabled/disabled messages to their controller 8e66e1e83bd62b8f755f7265893ad0f0231e2b90 Move profile resource to profile/description 28cb9e7699a305e04fbed9ee9c697654235c7a0e Test profile description show act
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. f8bd0b0153138be2f8c498370a3cc6665436b787 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/bd723208a345d1bcef325fdd233d777d0e2bca41..f8bd0b0153138be2f8c498370a3cc6665436b787 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. bd723208a345d1bcef325fdd233d777d0e2bca41 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/76ea626c96119c7fa401818efd264d58f0d2cb51..bd723208a345d1bcef325fdd233d777d0e2bca41 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Reorganize changeset history info into two lines, reuse it in element details (PR #6155)
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6155#pullrequestreview-2975960257 You are receiving this because you are subscribed to this thread. Message ID: __
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek commented on this pull request. > L.extend(L.LatLngBounds.prototype, { getSize: function () { return (this._northEast.lat - this._southWest.lat) * (this._northEast.lng - this._southWest.lng); } }); +if (OSM.MAPTILER_KEY) { + maplibregl.setRTLTextPlugin(OSM
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@hlfan commented on this pull request. I didn’t see anything particularly noteworthy in your changes compared to 4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86, the few comments I’ve left are about things you haven't touched yet. > + for (let i = 0; i < OSM.preferred_languages.length; i++) { +
Re: [openstreetmap/openstreetmap-website] openstreetmap在数据库的中有个表current_nodes中的tile是怎么计算的？ (Issue #6098)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6098) If you're checking out the repository using a Windows version of git, there's a setting somewhere for it to create symlinks. By default it was off last time I checked, which was a couple of years ago. And it was off because in
Re: [openstreetmap/openstreetmap-website] Notes 404 page can return in wrong language (Issue #6156)
Closed #6156 as duplicate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6156#event-18411334585 You are receiving this because you are subscribed to this thread. Message ID: ___ rai
Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)
Reopened #6154. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6154#event-18411050830 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailin
[openstreetmap/openstreetmap-website] Notes 404 page can return in wrong language (Issue #6156)
Firefishy created an issue (openstreetmap/openstreetmap-website#6156) ### URL https://www.openstreetmap.org/user/Clean%20Cuts%20Tree%20Care/notes ### How to reproduce the issue? After a few reloads of example page it will display in the wrong language. https://www.openstreetmap.org/user/Clean%
Re: [openstreetmap/openstreetmap-website] Add reasonable compile time limit (PR #6154)
Firefishy left a comment (openstreetmap/openstreetmap-website#6154) I think adding some timeout safeguards to our GitHub Actions would be a good idea. We don't have unlimited runtime and the default timeout is an extremely long 6 hours. -- Reply to this email directly or view it on GitHub: htt
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
petr-hajek left a comment (openstreetmap/openstreetmap-website#4042) @tomhughes I tried to address all the raised issues. Please bear with me as this is my first PR to this repo, I'm ready for the feedback. Could you authorize me to run the workflows to see if all the lints and test will pass?
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 76ea626c96119c7fa401818efd264d58f0d2cb51 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/7565be18217452402e4a51c331cdc2f84af26328..76ea626c96119c7fa401818efd264d58f0d2cb51 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. 7565be18217452402e4a51c331cdc2f84af26328 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/0881ffa40e2b07036e2d81b452704c8c0b2a4c50..7565be18217452402e4a51c331cdc2f84af26328 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
tomhughes left a comment (openstreetmap/openstreetmap-website#6138) Actually it's a bit more confusing that what I remember, or maybe something has changed. This is what I see in the network log when I hit the login button: 
@petr-hajek pushed 1 commit. 0881ffa40e2b07036e2d81b452704c8c0b2a4c50 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/f08892f2cc41deec0a88a60aefb1e184754b22b4..0881ffa40e2b07036e2d81b452704c8c0b2a4c50 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
tordans left a comment (openstreetmap/openstreetmap-website#6138) > > You also still haven't explained why your site appears to be doing the > > authorize flow via fetch in javascript which is really weird and which is > > breaking some browsers > > I cannot reproduce the issue you had with Fir
Re: [openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)
@petr-hajek pushed 1 commit. f08892f2cc41deec0a88a60aefb1e184754b22b4 Add MapTiler OMT vector map -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e0a533374d2127a2c3467bd6b090582f345bcaa7..f08892f2cc41deec0a88a60aefb1e184754b22b4 You are receiving thi
