@petr-hajek pushed 1 commit.
4a7b1374945d8577ea7ec5408b05aeca02e5c497 revert vsc settings change
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/a28f6dbbe4f4e12489c4ad91d38118de56958ff0..4a7b1374945d8577ea7ec5408b05aeca02e5c497
You are receiving this
@petr-hajek pushed 1 commit.
e0a533374d2127a2c3467bd6b090582f345bcaa7 fix trailing coma
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4a7b1374945d8577ea7ec5408b05aeca02e5c497..e0a533374d2127a2c3467bd6b090582f345bcaa7
You are receiving this because
@petr-hajek pushed 1 commit.
a28f6dbbe4f4e12489c4ad91d38118de56958ff0 Add MapTiler OMT vector map
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/4da96156a93c79c8e4e8f9c2e5aac308bf9e9d86..a28f6dbbe4f4e12489c4ad91d38118de56958ff0
You are receiving thi
YyJyyy left a comment (openstreetmap/openstreetmap-website#6098)
> Do you have symlinks enabled? `/public/iD` should be a symlink to iD inside
> `vendor/`.
Thank you very much. As a result of the system issue, I installed everything
directly on the Windows system using Docker. Everything else w
YyJyyy left a comment (openstreetmap/openstreetmap-website#6098)
> 您是否启用了符号链接？`/public/iD`应该是指向内部 iD 的符号链接`vendor/`。
Thank you very much. It's like a system issue. I installed everything directly
on the Windows system using Docker. Everything else was installed successfully,
but it was just like
YyJyyy left a comment (openstreetmap/openstreetmap-website#6098)
> 您是否启用了符号链接？`/public/iD`应该是指向内部 iD 的符号链接`vendor/`。
I'm sorry, I'm a bit confused about what you mean by 'change this'. Could you
please make it easier to understand
--
Reply to this email directly or view it on GitHub:
https://g
@AntonKhorev pushed 10 commits.
3baa5c2122a2a5e37d3e3f52059e8536c9e312d7 Wrap changeset id link in span that
serves as flex item
912521c1ba6a0013a42f7d3394ed59d19b988ad2 Create changeset line template
0e75d939b4f1a4469a833176cead0f1ff3fc6a8c Adjust right margin of changeset line
68103d6fe9d2a9
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6155
-- Commit Summary --
* Reorganize changeset history info into two lines
* Use link_to(changeset) in changeset history and element common details
* Wrap change
Closed #6154.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6154#event-18395676368
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#6154)
Those are all on a branch aren't they, so it's just a bug in the PR that should
be fixed.
Not that I'm sure why a missing file error doesn't just cause an immediate
abort? But finding out why and fixing that seems like a better
Another way of freeing up recources: a timeout.
For now, only where I've seen multiple workflows hang:
-
https://github.com/openstreetmap/openstreetmap-website/actions/runs/15960712372
-
https://github.com/openstreetmap/openstreetmap-website/actions/runs/15918518252
-
https://github.com/openstre
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
Well merging #6089 didn't fix all the tests, so that's no alternative.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3020481418
You are receiving
Reopened #6022.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#event-18393661624
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
hlfan left a comment (openstreetmap/openstreetmap-website#6022)
Well the
[`UserSocialLinksTest`](https://github.com/hlfan/openstreetmap-website/actions/runs/15981857333/job/45077819688#step:13:48)
just made a return
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
@hlfan pushed 8 commits.
8d8da6624603792095c29b2bb8d0971685f8b269 Refine dom structure assertions in
profile and user tests
538ffb56a93c050c047e68556e5c18329479baf1 Make Rails handle SVG partials
79323f76fe0c0d46633baaf098d7fd266e31f31c Move search icons to partials
00eec379d7edf0193fbbb2b5ba3
@hlfan pushed 7 commits.
6cff0e2b3978641032bdcb868508cb9906882310 Make Rails handle SVG partials
8ead5f3c86fd3b652361e2664d8ce24bc7ab66c9 Move search icons to partials
84978b5af1549f637a0432c5ddb39be398d98177 Move about icons to partials
2445604554cb1c37399065244bed8058af7922fa Move welcome ic
@pnorman pushed 1 commit.
7f98378630eaba699e152602046fa3a7eab924e1 Improve a vectortile comment
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/719be1bc44e6f8becf9c36edaff38985ca380d36..7f98378630eaba699e152602046fa3a7eab924e1
You are receiving this
@hlfan pushed 7 commits.
f3bbfca06b9768dae04df5eb604c3a2e09e659ab Make Rails handle SVG partials
2180bbed384b4f24b9238853fb8446195a215284 Move search icons to partials
52a5cad32ab0e9f8599b1143484a0f4aabfaf16a Move about icons to partials
920f7896816151aaa73cc4c3e9b200e0f0fd9911 Move welcome ic
@hlfan pushed 1 commit.
749f01e37f290f090ee915e7f96866da5a636c4e Invert icons in dark mode with common
class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/67df55900bcc6ded1c5cd76065e35c48911acb90..749f01e37f290f090ee915e7f96866da5a636c4e
You are r
@pnorman pushed 2 commits.
a9173ab7122ee5130d39119c68e669cac81dd9e9 Add yarn.lock
719be1bc44e6f8becf9c36edaff38985ca380d36 Add shortbread translation key
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6137/files/0ce5eefd7e75e02ed6a1b2e8e756810fe43051ae..719be
hlfan left a comment (openstreetmap/openstreetmap-website#6022)
For now this seems to have been fixed in #6089
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#issuecomment-3020237230
You are receiving this because you are s
Closed #6022 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6022#event-18392444276
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@hlfan pushed 1 commit.
54d2eb08341fabe4b31942f87e781a75e8f67340 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/3aebcb18fdf437b6994866fc66120f48e37f0cd2..54d2eb08341fabe4b31942f87e781a75e8f67340
You are rec
Closed #6152 as completed via #6153.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6152#event-18390514618
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #6153 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6153#event-18390514324
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6089 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6089#event-18390514338
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6089)
Regardless of how we handle editing there doesn't seem to be any disagreement
with the idea of moving stuff to the sidebar.
Ordinarily I might have suggested getting rid of the line under the social
links so the lines act as se
tomhughes left a comment (openstreetmap/openstreetmap-website#6153)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6153#issuecomment-3019735996
You are receiving this because you are subscribed to this t
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6153#pullrequestreview-2971748441
You are receiving this because you are subscribed to this thread.
Message ID:
__
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6098)
Do you have symlinks enabled? `/public/iD` should be a symlink to iD inside
`vendor/`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6098#issuecomment-3019
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6150)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6150#issuecomment-3019610155
You are receiving this because you are subscribed to this thread.
Merged #6150 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6150#event-18389400413
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
ae5392d50c26c03550b59bddf73f66a022511ba2 Specify element handlers more
compactly
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6149/files/38f7da07db34dec4234931cea61f8bd1b1472d53..ae5392d50c26c03550b59bddf73f66a022511ba2
You are recei
hlfan left a comment (openstreetmap/openstreetmap-website#6151)
This doesn't have to be an exclusive or, does it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3019543128
You are receiving this because you are
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6089#pullrequestreview-2971605371
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan commented on this pull request.
> +"/type:node way relation/:id(/history)": OSM.MappedElement(map),
+"/type:node way relation/:id/history/:version": OSM.Element(map),
Now I did...
Yet another point that the syntax now obscures this a bit
--
Reply to this email directly or view
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6151)
Or we can make the tests deterministic by merging #6089 and #6084. But instead
we decided to have a discussion about how many sections should there be in the
sidebar.
--
Reply to this email directly or view it on GitHub:
htt
@AntonKhorev commented on this pull request.
> +"/type:node way relation/:id(/history)": OSM.MappedElement(map),
+"/type:node way relation/:id/history/:version": OSM.Element(map),
Did you notice that there are four `MappedElement`s and two `Element`s?
--
Reply to this email directly o
Fixes #6152.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6153
-- Commit Summary --
* Use default backdrop and keyboard settings for language dialog
-- File Changes --
M app/views/layouts/_header.html.erb (2
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6152)
Nothing weird here, I copied an attribute that disabled the keyboard from one
of their examples without looking.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/iss
@AntonKhorev commented on this pull request.
> + $("#sidebar-content").on("turbo:before-stream-render", event => {
+const defaultRender = event.detail.render;
+event.detail.render = function (streamElement) {
+ defaultRender(streamElement);
+ markWikidataLi
tomhughes left a comment (openstreetmap/openstreetmap-website#6152)
That's a bit weird because
https://getbootstrap.com/docs/5.3/components/modal/#options says that the
`keyboard` option defaults to true...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6150#pullrequestreview-2971381858
You are receiving this because you are subscribed to this thread.
Message ID:
__
deevroman created an issue (openstreetmap/openstreetmap-website#6152)
### URL
https://openstreetmap.org
### How to reproduce the issue?
1. Click on the language selection button
2. Press Escape
Pressing triggers the animation, but does not close the window.
Firefox 141.0b3, Chrome 137.0.7151.
Most workflow cancellations occur just seconds before they would finish anyway,
so failing fast doesn't safe many resources, it just makes workflow
reattempts consume more.
As long as some tests continue to be as non-deterministic as they are
currently, I'd disallow GitHub to cancel parallel tes
@hlfan commented on this pull request.
> + $("#sidebar-content").on("turbo:before-stream-render", event => {
+const defaultRender = event.detail.render;
+event.detail.render = function (streamElement) {
+ defaultRender(streamElement);
+ markWikidataLinksAsE
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
> I'm also not sure we want to go down this path, both because it opens the
> door to lots of sites wanting to do the same thing and makes it hard to say
> no to others if we say yes here
We can say that we won't add other da
@AntonKhorev commented on this pull request.
> + $("#sidebar-content").on("turbo:before-stream-render", event => {
+const defaultRender = event.detail.render;
+event.detail.render = function (streamElement) {
+ defaultRender(streamElement);
+ markWikidataLi
Making it a bit more readable
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6150
-- Commit Summary --
* Modernize route.run
-- File Changes --
M app/assets/javascripts/router.js (6)
-- Patch Links --
https:
@hlfan pushed 1 commit.
3aebcb18fdf437b6994866fc66120f48e37f0cd2 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/0a0898ad53d11a2dd0be83b19d9d8c0824789460..3aebcb18fdf437b6994866fc66120f48e37f0cd2
You are rec
@AntonKhorev commented on this pull request.
> +$(`<${data.label ? "sup" : "div"}>`)
+ .append($("")
+.attr("href", `https://${data.article.site.slice(0,
-4)}.wikipedia.org/wiki/` + encodeURIComponent(data.article.title))
+.text(data.label ? data.article
@AntonKhorev commented on this pull request.
> @@ -136,6 +136,9 @@ overpass_credentials: false
graphhopper_url: "https://graphhopper.com/api/1/route";
fossgis_osrm_url: "https://routing.openstreetmap.de/";
fossgis_valhalla_url: "https://valhalla1.openstreetmap.de/route";
+# Endpoints for Wiki
### Description
Undoes 223d5fd13245308eaf0ee92e8f946aab078f4850 while introducing a Ruby word
array inspired enum placeholder.
### How has this been tested?
Local installation, DevTools & CI
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openst
YyJyyy left a comment (openstreetmap/openstreetmap-website#6098)
Hello, I deployed using Docker on a Windows system, and all other operations
are carried out according to the documentation. However, after c
54 matches
Mail list logo
