hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> Maybe float the image to the right side?
Done.
Also decreased the bottom margin to reduce unnecessarily text wrapping.
--
Reply to this e
@hlfan pushed 1 commit.
a3bd94a902c1aa12728122a64bb3b3105e6cd1f8 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/06580bd5ae9cd44decda9fd1cfe399686b8d..a3bd94a902c1aa12728122a64bb3b3105e6cd1f8
You are rec
@hlfan pushed 1 commit.
ef3f5e27616db82ff73d92f3b167a71d49220650 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/dd61d0717716b54bf5bc5d4b7e29bc64784e77d4..ef3f5e27616db82ff73d92f3b167a71d49220650
You are rec
@hlfan commented on this pull request.
> +.addClass("bg-body-tertiary");
+ labelLink
+.closest("tr")
+.after($("").append(cell));
+
+ if (data.icon) {
+$("")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, height: "3
@AntonKhorev commented on this pull request.
> +.addClass("bg-body-tertiary");
+ labelLink
+.closest("tr")
+.after($("").append(cell));
+
+ if (data.icon) {
+$("")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" +
data.icon, heig
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
Text is aligned to three different left edges.
Maybe float the image to the right side?
--
Reply to this email directly or view it on
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6146)
The moderator-only link looks like this:
I'll probably move it back to *Download XML* where it was previously.
--
Reply to this email d
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6146)
### Problem
Was
https://github.com/openstreetmap/openstreetmap-website/issues/6142#issuecomment-3015699689
>From [ceirios](https://www.openstreetmap.org/user/ceirios) on OSM World
>Discord (partially via private message
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6144#pullrequestreview-2969018253
You are receiving this because you are subscribed to this thread.
Message ID:
__
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6145)
### Problem
Ref #6117
>From [ceirios](https://www.openstreetmap.org/user/ceirios) on OSM World
>Discord (via private message)
> [this is] ideal for features with large versions, [though] perhaps [the
> amount of versio
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#1253)
Related #1376
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1253#issuecomment-3016088706
You are receiving this because you are subscribed to this thread
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6142)
>From [ceirios](https://www.openstreetmap.org/user/ceirios) on OSM World
>Discord (partially via private message)
> I quite like the new browser, it's growing on me [...] its easier [to use]
> im not sure how i feel about t
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6142)
@AntonKhorev Sorry for not making them separate issues and not properly
separating reproduction steps and issues.
It is understandable you went with this design.
You can keep the version list at the bottom. That is okay.
If
Closed #5757 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5757#event-18370368407
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5757)
There was enough time to answer
https://github.com/openstreetmap/openstreetmap-website/issues/5757#issuecomment-2713112562.
Since the original poster didn't answer it, I consider "hard to spot
changesets with comments vs thos
Closed #6142 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6142#event-18370055428
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6142)
This is four different issues, some are debatable. If you want to discuss the
following, please reopen separate issues for them:
- "it was weird to see a pagination list with no list of items below it" -
maybe will get moved t
Mentioned in #6142, "Non-functional scrollbar".
This is for browsers that display scrollbars not only during scrolling. On
Linux this is currently Chrome, but not Firefox.
If the version list is long enough to have the potentially scrollable part
(currently >= 5 versions) but it fits in the sid
@AntonKhorev pushed 1 commit.
119b3e05a1b5f4dcc86d0355e21f20ed23226abe Move scss @include color-mode(dark)
to the top level
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6143/files/285ee6768167f15b4f76e1c05b0547e14ea7c4eb..119b3e05a1b5f4dcc86d0355e21f20ed232
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6143
-- Commit Summary --
* Remove outdated css rule for changeset comments
* Combine sidebar icon css with other browse sidebar rules
* Remove unnecessary bottom
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6142)
### URL
_No response_
### How to reproduce the issue?
Ref #6120
I was looking at an object and noticed the new element navigation.
- Since the header 'version 3' and the version list are not directly next to
each other
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6139)
Ok, thanks for the reply.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6139#issuecomment-3015171794
You are receiving this because you are subscribed to
Closed #6139 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6139#event-18368208468
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@tordans pushed 1 commit.
5c63390f699335b8d422a1ca3b7baa3e6a57619f Remove code comment
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6138/files/0e160369a76b968b4fc71468f06506aabe8693c7..5c63390f699335b8d422a1ca3b7baa3e6a57619f
You are receiving this because y
@tordans commented on this pull request.
> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
before_action :require_cookies, :only => [:confirm]
def confirm
+# The post happens in confirm.html.erb and user.js
```suggestion
```
--
Reply to this email directly
tordans left a comment (openstreetmap/openstreetmap-website#6138)
> You also still haven't explained why your site appears to be doing the
> authorize flow via fetch in javascript which is really weird and which is
> breaking some browsers
I cannot reproduce the issue you had with Firefox on my
26 matches
Mail list logo
