Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
tomhughes left a comment (openstreetmap/openstreetmap-website#6138) Well it would probably help if you stopped thinking about is as an "OAuth POST" because it's not really anything to do with OAuth. Once the OAuth client redirects the user to the authorize endpoint everything that happens until
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
@tordans commented on this pull request. > @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController before_action :require_cookies, :only => [:confirm] def confirm +# The post happens in confirm.html.erb and user.js Please feel free to improve the wording and even rem
[openstreetmap/openstreetmap-website] Docs: Document how to setup OAuth in development (Issue #6141)
tordans created an issue (openstreetmap/openstreetmap-website#6141) I think we should document how to setup OAuth locally the same way it work on staging and production servers. The main thing that is different ATM is that https://www.openstreetmap.org/.well-known/openid-configuration is missin
Re: [openstreetmap/openstreetmap-website] Inline SVGs with helper module (PR #5938)
@hlfan pushed 7 commits. fac2bcbd37de845d15f46fe77310c84fce059743 Make Rails handle SVG partials 77783d315d947d68e0673aa1fcd09814544c8455 Move search icons to partials a0e08197d07dc6854f8899e4c3d3f9d1540be799 Move about icons to partials a26a893c54f5cef6e1a3706bb4c59960c928f1b0 Move welcome ic
Re: [openstreetmap/openstreetmap-website] Invert icons in dark mode with common class (PR #6052)
@hlfan pushed 1 commit. f4cac8897124af3ca2d987e4f8fbd6ff87384b9c Invert icons in dark mode with common class -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6052/files/5089344ab6e3bcf59995623af13403b195af2d7d..f4cac8897124af3ca2d987e4f8fbd6ff87384b9c You are r
Re: [openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)
@hlfan pushed 1 commit. 7030501ae30d095ae1eab877c3db63c26b49f02c Add geo URI handler registration on link interaction -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5968/files/16d3a21296bbaa8f605ef3c3f670919bc43ae226..7030501ae30d095ae1eab877c3db63c26b49f02c
Re: [openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
@hlfan pushed 1 commit. 5c417a3449d2df628225c2a6051a18dfa5486afb Add human-readable wikidata explainations -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/1dd9297d0f40e1497a79c1cbf8d5c300170e4c39..5c417a3449d2df628225c2a6051a18dfa5486afb You are rec
[openstreetmap/openstreetmap-website] Bump eslint from 9.29.0 to 9.30.0 (PR #6140)
Bumps [eslint](https://github.com/eslint/eslint) from 9.29.0 to 9.30.0.tomhughes left a comment (openstreetmap/openstreetmap-website#6139) I mean it says "traces" not "public traces"... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6139#issuecomment-3014371493 You are receiving this because you a
Re: [openstreetmap/openstreetmap-website] User with single trace has no public traces (Issue #6139)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6139) I think this has been forever this way. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6139#issuecomment-3014331983 You are receiving this because you are subscr
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
mmd-osm left a comment (openstreetmap/openstreetmap-website#6138) > I also did not manage to get an OAuth setup going locally for proper > debugging (I don't have > https://www.openstreetmap.org/.well-known/openid-configuration locally for > some reason). This topic came up recently: https://
[openstreetmap/openstreetmap-website] User with single trace has no public traces (Issue #6139)
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6139) https://www.openstreetmap.org/user/MiKa mentions the user has a single trace, but there are no public traces. Is it intended that this trace (I assume it is private) is counted towards Traces count in public user profile?
Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
Merged #5262 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5262#event-18361051238 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Element version navigation steps (PR #6134)
Merged #6134 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6134#event-18361051254 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
@tomhughes commented on this pull request. > @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController before_action :require_cookies, :only => [:confirm] def confirm +# The post happens in confirm.html.erb and user.js I don't think this is very useful - even if you ac
Re: [openstreetmap/openstreetmap-website] Element version navigation steps (PR #6134)
tomhughes left a comment (openstreetmap/openstreetmap-website#6134) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6134#issuecomment-3013643751 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Add older/newer links in front of diary, comment, issue, block pages (PR #5262)
tomhughes left a comment (openstreetmap/openstreetmap-website#5262) Sorry it's taken so long, but this looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5262#issuecomment-3013621406 You are receiving this b
Re: [openstreetmap/openstreetmap-website] Preserve `referer` during oauth JS confirmation (PR #6138)
tomhughes left a comment (openstreetmap/openstreetmap-website#6138) Assuming this is correct it really needs a test to ensure it doesn't get broken again... -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6138#issuecomment-301350
[openstreetmap/openstreetmap-website] Preserve `referrer` during oauth JS confirmation (PR #6138)
Closes https://github.com/openstreetmap/openstreetmap-website/issues/6130 Someone helped me debug https://github.com/openstreetmap/openstreetmap-website/issues/6130 and this change fixes the issue. The OAuth process starts as a GET and becomes a POST by submitting the form below in JS automati
Re: [openstreetmap/openstreetmap-website] Element version navigation steps (PR #6134)
@AntonKhorev pushed 2 commits. 9e18e6f2518bb71307b34bd150b208820c134904 Add links to versions with a fixed step 88e9ad353d91748405096e42744009af12fa3b41 Fill small version gaps -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6134/files/d148b15a503b6954ae8223a
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@AntonKhorev pushed 5 commits. 81658bc6964cf844d07affa0b9e98e301f39a310 Add generic api elements controller for multi fetches 0f6ca5f90d693ba274b161aee93d66c3145ae736 Add version support to element multi fetch 9cdb1736264b867b6c70a3f60608324c82527a2e Keep only unique elements for multi fetch
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#3715) I decided to address this completely: > Possibly it would better to add new tests rather than add lots of cases to > the existing ones. I suspect @gravitystorm will think so though he'd probably > also say we should split the
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@AntonKhorev pushed 4 commits. 570760f5150e62e50d6cc67d46f8be23ec58e2cf Add version support to element multi fetch 45220b4a7ef93d25b9b5bf44302fd24c6208f2ca Keep only unique elements for multi fetch both with and without versions 819a1b55044eef272fefb71aed85fd1ec519e161 Respond with not found
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@AntonKhorev pushed 7 commits. 54c2e352c0d9f5eb8376d83bc7e60658debd26a5 Split api elements controller index tests c516fcc42a59f32e08f638d96b6acb79088e8634 Test required parameter message in element multi fetch 7cabbc9fef146f26c146c336467e615f50a24423 Add generic api elements controller for m
Re: [openstreetmap/openstreetmap-website] Support versions in elements multi fetch (PR #3715)
@AntonKhorev pushed 8 commits. 9772284b0f8dafbd053a22e31dc71fa1b5d45349 Split api elements controller index tests ddc24981f0ced76d963383a7b2f1b492d95b826a Test required parameter message in element multi fetch d779d0d12fbe7dbb1dd576dce537cda7043dfc65 Add generic api elements controller for m
Re: [openstreetmap/openstreetmap-website] Add language dropdown menu to My Preferences (PR #4461)
AntonKhorev left a comment (openstreetmap/openstreetmap-website#4461) Superseded by #6024 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4461#issuecomment-3012774817 You are receiving this because you are subscribed to this threa
Re: [openstreetmap/openstreetmap-website] Add language dropdown menu to My Preferences (PR #4461)
Closed #4461. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4461#event-18356225265 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing
Re: [openstreetmap/openstreetmap-website] Add Shortbread-based vector tile layer (PR #6137)
tomhughes left a comment (openstreetmap/openstreetmap-website#6137) I think the options for dealing with the transformation are: * Don't set the style in the options so the maplibre map object is created with no style and then change your `onAdd` method to do `this.getMaplibreMap().setStyle(...
