hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> > Another way of looking at it is that editors like iD have long had this
> > same functionality.
>
> I don't understand this comment because I don't see anything like this in iD?
from 1.9.18 to 1.9.19.
Commits
tomhughes left a comment (openstreetmap/openstreetmap-website#6130)
If it's unrelated how is it helpful to mention it here?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6130#issuecomment-3001882858
You are receiving this beca
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6130)
cc: @k-yle ( I thought of unrelated and only somewhat similar issue
https://github.com/openstreetmap/iD/issues/10678 )
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
hlfan left a comment (openstreetmap/openstreetmap-website#6127)
> Yes. If this functionality becomes integrated into osm.org, I would take down
> my Chrome and Firefox plugins and archive the source code repository.
Or, at least for this version, it just becomes a plugin that clicks on every
`.
danieldegroot2 created an issue (openstreetmap/openstreetmap-website#6131)
Add test for oauth referrer if not yet.
> Ideally bug fixes like this - particularly for something that was broken due
> to a refactor - need a test added too. This will prevent the same bug from
> reappearing during any
tomhughes left a comment (openstreetmap/openstreetmap-website#6129)
So I think is this good to merge now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6129#issuecomment-3001549405
You are receiving this because you are
Damn... I ran rubocop again before adding the exclusion and it "fixed" it again.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/6da53d2f1aac8759c3952b3028edf8d96d2131de#commitcomment-160738159
You are receiving this because you
tomhughes left a comment (openstreetmap/openstreetmap-website#6130)
I think the double `?` is a red herring - there is one parameter who's value is
a URL that includes parameters.
I don't get as far as you though as I get a CORS failure when it tries to
redirect to the login page because the OA
but this didn't revert anything
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/commit/6da53d2f1aac8759c3952b3028edf8d96d2131de#commitcomment-160737897
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev commented on this pull request.
> -relation = create(:relation)
-create(:relation_member, :relation => relation, :member => member)
-sidebar_browse_check :node_path, member.id, "elements/show"
-assert_select "a[href='#{relation_path relation}']", :count => 1
- end
-
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6127)
## Danger has errored
[!] Invalid `Dangerfile` file: undefined method `many?` for
[#\, @formatter=nil, @logdev=nil, @level_override={}\>,
@working_directory=#\,
@repository=#\,
@index=#\,
@lib=#\, @formatter=nil,
@hlfan pushed 1 commit.
1dd9297d0f40e1497a79c1cbf8d5c300170e4c39 Add human-readable wikidata
explainations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/f73f2315b6633fddea8edcb9659bb000b28c1751..1dd9297d0f40e1497a79c1cbf8d5c300170e4c39
You are rec
tomhughes left a comment (openstreetmap/openstreetmap-website#6127)
> Another way of looking at it is that editors like iD have long had this same
> functionality.
I don't understand this comment because I don't see anything like this in iD?
--
Reply to this email directly or view it on GitHub
@AntonKhorev pushed 7 commits.
20b7f1960d17bd2fc21b97dd311e59e069021562 Remove border rounding/duplication
between adjacent version lists
6ef01b3483f6b77aba14e686bb8164b7749322c5 Reserve horizontal space for focus
outlines in middle version list
97cddd0f5df566134909887262b630d9d1355101 Extend
Merged #6128 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6128#event-18299746012
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
This is quite hard to remove just because in places it's deliberately removing
tests for things that aren't actually removed yet but will be.
I don't see any major issues, though adding lots more system tests while
technically the right thing to do is
Merged #6124 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#event-18299746001
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 5 commits.
61a69bb23d225ec9ebd1ae2890857f7ba1a6a250 Extend starting/ending version lists
containing active items
7583920e323b3741ef0afb4b7ddb6cd760fce59f Limit number of items in version lists
3b228c16fdc5b9c5db865a05feef798b061185a8 Scroll to active version in
navigation
tomhughes left a comment (openstreetmap/openstreetmap-website#6128)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6128#issuecomment-3001283382
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6124)
Thanks - it all looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6124#issuecomment-3001273781
You are receiving this because you are subscribed to
@AntonKhorev pushed 8 commits.
4af4754ce2eb86ec8c97802f415b0b41b1730505 Split long version lists into 3
parts, with middle list scrollable
f99a7578cf27b2611d7eb7dbe05cd8e953e77ec0 Remove border rounding/duplication
between adjacent version lists
50fd554c6af1544d710e607c2ae65f68aed61e99 Reserv
tordans created an issue (openstreetmap/openstreetmap-website#6130)
### URL
_No response_
### How to reproduce the issue?
I am having trouble with our registration workflow. It used to redirect users
back to our application. Now it returns them to the osm.org map.
(Logging into an existing ac
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6127)
How about:
- not requesting anything without the user asking for it (try using this on
element history pages)
- not rewriting the tag value
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
@hlfan pushed 1 commit.
7fb08eae16c3c08d9669c18a5211905f2ff30d4a Integrate human-readable wikidata
browser plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/9be598c725c58629c6520ee8c7ed6970a37321dc..7fb08eae16c3c08d9669c18a5211905f2ff30d4a
You
@hlfan pushed 1 commit.
9be598c725c58629c6520ee8c7ed6970a37321dc Integrate human-readable wikidata
browser plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127/files/e069d73d972b3a1527beef2199c2977637bb9b1f..9be598c725c58629c6520ee8c7ed6970a37321dc
You
hlfan left a comment (openstreetmap/openstreetmap-website#6129)
Could the 3 tests be split up over node/way/relation to have 9 files instead of
three over 300 lines long ones?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6129#
28 matches
Mail list logo
