@hlfan pushed 4 commits.
4c8351f5987cc9be63f903ce85acd8536210cf18 Write layer sidebar in erb template
28f942993bb678d9ddf4204a405b6abcc2539cac Move layer sidebar translations
07836ab067c4ee5ef56c5e612f3973d54db9d575 Add basic test for
LayersPanesController
25fed0332d09fb208716784295bd82830b959
@hlfan pushed 1 commit.
0b95246d53a29231e6cc8a24fd6db69b56435800 Add basic test for
SharePanesController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106/files/35f41669e45921c5f52500496e25e1892483a238..0b95246d53a29231e6cc8a24fd6db69b56435800
You are recei
@hlfan pushed 7 commits.
807ae9dee486d7f7c98dd831bfeaee195fc57bd6 Make Rails handle SVG partials
35520ba2bdfc265c454dcd0ee312c30e235bd2bb Move search icons to partials
b5e2e1e384e556c5c23dac21d1e19f4b0479f72b Move about icons to partials
13b5f3ed374b405544a044add716c22138492a9e Move welcome ic
@hlfan pushed 2 commits.
c7d69e9cdb411d8164c33f8ed2b1b11b5fc8246a Write share sidebar in erb template
35f41669e45921c5f52500496e25e1892483a238 Move share sidebar translations
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106/files/98d5d4e4ae36907adb7c001f3b
mmd-osm left a comment (openstreetmap/openstreetmap-website#6082)
> [github](https://github.com/CEPT-VZG/digipin)
This reference implementation is written in Javascript and would have to be
converted to Ruby (which is trivial thanks to LLMs). However, there are no unit
tests in the original rep
@tomhughes requested changes on this pull request.
As with #6107 this should be under panes and needs a basic test.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#pullrequestreview-2943749152
You are receiving this because
@tomhughes requested changes on this pull request.
Presumably this should now be under panes like the legend?
It should also have a basic controller test that checks the route and that the
action runs without error.
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
@tomhughes commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
The legend has been moved to `/panes/legend` now...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#discussion_r
Merged #6115 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6115#event-18233582918
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6113 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6113#event-18233582915
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6115)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6115#issuecomment-2988626343
You are receiving this because you are subscribed to this t
Merged #6117 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6117#event-18233582917
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6116 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6116#event-18233582910
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6113#pullrequestreview-2943577748
You are receiving this because you are subscribed to this thread.
Message ID
tomhughes left a comment (openstreetmap/openstreetmap-website#6117)
Looks good to me, and a really nice solution with turbo streams, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6117#issuecomment-2988619322
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#6116)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6116#issuecomment-2988593139
You are receiving this because you are subscribed to this t
angoca left a comment (openstreetmap/openstreetmap-website#6118)
That's why the code should be modified to be a normal string without that
pluralisable option.
These are some examples of what the bit community of translators faces:
Problematic string:
https://github.com/user-attachments/assets/
tomhughes left a comment (openstreetmap/openstreetmap-website#6118)
It doesn't have a singular part because it's not a pluralisable string - it's
not a resource called `social_links.show` with subkeys for pluratlisation, it's
a resource called `social_links.show.other` which is used for links wh
tomhughes left a comment (openstreetmap/openstreetmap-website#6118)
Doesn't seem to be anything to do with us though? That looks like somebody just
needs help from the TranslateWiki people with the correct syntax to use?
--
Reply to this email directly or view it on GitHub:
https://github.com/o
angoca left a comment (openstreetmap/openstreetmap-website#6118)
Source strings should be in the format singular | plural:
```
{{PLURAL|one=%{count} minute ago|%{count} minutes ago}}
```
But the problematic string does not have a singular part.
BTW, as a website maintainer, you should know abou
tomhughes left a comment (openstreetmap/openstreetmap-website#6118)
Ah I see.. That resource is not part of a counted resource, it's just a
resource that happens to be called `other` so it shouldn't be entered using the
counted resource syntax which is what I think you were trying to do but I'm
Closed #6118 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6118#event-18230329190
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
angoca created an issue (openstreetmap/openstreetmap-website#6118)
### Problem
There is an issue while trying to update this string: {{PLURAL|Other}}
Full description here:
https://translatewiki.net/wiki/Translating_talk:OpenStreetMap#About_Osm%3ASocial_links.show%2Fes
--
Reply to this email
@AntonKhorev approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6113#pullrequestreview-2942569848
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev commented on this pull request.
>before_action :authorize_web
before_action :set_locale
authorize_resource :class => false
def show
-expires_in 7.days, :public => true
There are reasons not to cache it, but yes, it can be removed in another PR.
--
Reply to this
@AntonKhorev commented on this pull request.
>
-These instructions are based on Ubuntu 24.04 LTS, which is the platform used
by the OSMF servers.
-The instructions also work, with only minor amendments, for all other current
Ubuntu releases, Fedora and MacOSX
+### Recommended: Containerized
@AntonKhorev commented on this pull request.
>
-```
+After installing but before creating any users or data, import an extract with
[Osmosis](https://wiki.openstreetmap.org/wiki/Osmosis) and the
[`--write-apidb`](https://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage#--write-apidb_.28--w
@hlfan commented on this pull request.
>
-## Managing Users
+After creating a user through the web interface at
[http://localhost:3000](http://localhost:3000), you may need to perform
additional user management tasks. If you don't want to set up your development
box to send emails, you can
kcne left a comment (openstreetmap/openstreetmap-website#6111)
> One thing that bugs me is the inconsistent level of explanation in _User
> Management_. The two parts could be consolidated:
>
> 1. Enter rails console
>
> 2. Find User
>
> 3. Modify as desired
>
>* ac
@kcne pushed 1 commit.
2082253a29fa104611a9bf928e35e1b53fcf8391 Restructure CONFIGURE.md
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6111/files/f41ffd9bfc5f14aa64ee510f163d565633304891..2082253a29fa104611a9bf928e35e1b53fcf8391
You are receiving this because
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058)
@1ec5: this change is probably only relevant for developers running their local
Rails instance. The code is not used in production.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstree
31 matches
Mail list logo
