This PR renames all references to "map key" to "legend" in
the codebase, as the term "legend" has less ambiguity and improves
clarity.
As an example, `(?
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6112)
...and responses have `cache-control: max-age=0, private, must-revalidate`
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6112#issuecomment-2977564302
You are
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6112)
> Technically it's only needed for user's that aren't logged in and that don't
> have a locale cookie.
Is it really needed if the request has `If-None-Match: W/"..."`?
--
Reply to this email directly or view it on GitHub:
ht
tomhughes left a comment (openstreetmap/openstreetmap-website#6112)
It's not just the map key surely, it's the entire site - the vary is needed to
ensure that a browser doesn't reuse a cached page when the client language
changes.
Technically it's only needed for user's that aren't logged in an
hlfan left a comment (openstreetmap/openstreetmap-website#6112)
Would this also remove the need for the xhr query parameter that was reinserted
with #5663?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6112#issuecomment-2977465
Problem:
1. open https://www.openstreetmap.org/traces (or any page with turbo pagination)
2. click *Older Traces* (or older whatever)
3. right-click the tab and select *duplicate* or *duplicate tab*
4. you'
hlfan left a comment (openstreetmap/openstreetmap-website#6111)
One thing that bugs me is the inconsistent level of explanation in _User
Management_.
The two parts could be consolidated:
1. Enter rails console
2. Find User
3. Modify as desired
- activate
- make moderator
- make administr
tomhughes left a comment (openstreetmap/openstreetmap-website#6103)
What size screen is that? I was using a Pixel 2 at 411x731 when testing...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6103#issuecomment-2977356207
You are re
hlfan left a comment (openstreetmap/openstreetmap-website#6109)
It doesn't make a difference to the area calculation, but it's more accurate to
what it says it does.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6109#issuecomme
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
I was going to say that if you
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
Are you sure you're not forget
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6109)
Merged, thanks. Although I don't know if this makes any difference because area
calculation is done only on enclosing features.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Merged #6109 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6109#event-18172912814
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
kcne left a comment (openstreetmap/openstreetmap-website#6111)
Oh and by the way this would be the one PR that tackles all files at once... If
you prefer this to be a PR per file for easier review I can restructure
accordingly.
--
Reply to this email directly or view it on GitHub:
https://git
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6111)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
### Description
Closes #6093
This PR restructures the core developer documentation (`INSTALL.md`,
`CONTRIBUTING.md`, and `CONFIGURE.md`) to improve clarity, navigation, and user
experience for new contributors.
### **Key Changes:**
**INSTALL.md:**
- Prioritized installation methods with Do
@hlfan commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
The share pane should update with co
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
After eight months of trying to move map keys out of site controller
https://github.com/openstreetmap/openstreetmap-website/pull/5024 I wasn't very
picky about its name. You don't n
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
> the underlying yaml file
Wh
@hlfan commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
And the MapKeysController doesn't control the API keys for the maps. Perhaps
moving the LegendPanesController to /panes/legend should come first to ensure
we proceed consistently.
--
Re
YyJyyy left a comment (openstreetmap/openstreetmap-website#6099)
> https://github.com/openstreetmap/quad_tile/blob/9fcba83fcbca8a206fa518da5a52f840dc2ecb09/ext/quad_tile/quad_tile.h#L3是从定点整数版本中的经度和纬度计算图块编号的基本函数。
Thank you so much. Your step-by-step guidance has helped me get what I want.
Thank y
tomhughes left a comment (openstreetmap/openstreetmap-website#6110)
Who is "the user" exactly and what is your relationship to them?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6110#issuecomment-2976136630
You are receiving
@hlfan commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
Can the sidebar panes (map key too)
octavo created an issue (openstreetmap/openstreetmap-website#6110)
The user would like to osm.org/s?q=cph.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6110
You are receiving this because you are subscribed to this thread.
M
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
This controller doesn't control "shares". It controls the share sidebar pane.
The name could be `SharePanesController`.
--
Reply to this email directly or view it on GitHub:
https:
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+ before_action :authorize_web
+ before_action :set_locale
+ authorize_resource :class => false
+
+ def show
+expires_in 7.days, :public => true
This caching is what I wanted
@hlfan pushed 7 commits.
5fd15f97f395cb07f5caa995a088c8054a6682d0 Make Rails handle SVG partials
8206038221dc2e9b9d169ff2ee2c049b5f470f33 Move search icons to partials
32d7fe2706163dda188baab90bebaaae0248ef09 Move about icons to partials
82a1d23b54d06b1beef8fe7d10e5e5be12174b08 Move welcome ic
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6108)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6108#issuecomment-2975706055
You are receiving this because you are subscribed to this thread.
Merged #6108 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6108#event-18165452646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6103)
I tried using Bootstrap dropdown for this months ago. Results are significantly
worse.
Your small screen is not small enough, and browser dev tools make it look
larger by not showing parts of the screen space taken by various
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
https://dupnotes.webmapping.cyou/creator_om.html has a few examples like
https://www.openstreetmap.org/note/4806005 and
https://www.openstreetmap.org/note/4806010 where the user has added additional
text "It is now changed to Bel
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6100)
> In particular I find it unlikely that multiple users would come up with the
> exact same text.
They don't come up with the text, the app does it for them. You get several
"Place doesn't exits" notes at the exact same locati
BathoryPeter left a comment (openstreetmap/openstreetmap-website#5596)
Yes, it works as expected.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5596#issuecomment-2975430985
You are receiving this because you are subscribed to
Closed #5596 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5596#event-18164090873
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
34 matches
Mail list logo
