tomhughes left a comment (openstreetmap/openstreetmap-website#6099)
https://github.com/openstreetmap/quad_tile/blob/9fcba83fcbca8a206fa518da5a52f840dc2ecb09/ext/quad_tile/quad_tile.h#L3
is the basic function to calculate a tile number from lon and lat in their
fixed point integer versions.
--
Keeps the width of the antimeridian at 0.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6109
-- Commit Summary --
* Fix antimeridian bounds size
-- File Changes --
M app/assets/javascripts/index/query.js (2)
YyJyyy left a comment (openstreetmap/openstreetmap-website#6099)
> 顺便说一下，调用原始 Rails 代码将返回以下结果：
>
> ```
> QuadTile.tile_for_point(35.2000381, 114.6629926)
> => 3875963095
> ```
>
> 这匹配：
>
> ```
> id | latitude | longitude | changeset_id | visible |
> timestamp |
YyJyyy left a comment (openstreetmap/openstreetmap-website#6099)
> 顺便说一下，调用原始 Rails 代码将返回以下结果：
>
> ```
> QuadTile.tile_for_point(35.2000381, 114.6629926)
> => 3875963095
> ```
>
> 这匹配：
>
> ```
> id | latitude | longitude | changeset_id | visible |
> timestamp |
hlfan left a comment (openstreetmap/openstreetmap-website#6108)
Definitely better than gathering translations from all over like in #5938
(ignoring the added redundancy).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6108#issue
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6108#pullrequestreview-2930345758
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6108#pullrequestreview-2930339222
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #6091 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6091#event-18159250097
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6108
-- Commit Summary --
* Make ARIA labels on diary cards translatable
-- File Changes --
M app/views/diary_entries/_profile_diaries.html.erb (6)
M config/
tomhughes left a comment (openstreetmap/openstreetmap-website#6091)
I think this is resolved now and the relevant resources have been identified.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6091#issuecomment-2974687541
You a
@hlfan pushed 1 commit.
104e7fe33ddcc42be0a6e4abbd590849ec9f31cf Make layers zoom handling more terse
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6107/files/ed700b7107f00880db8b882d7bb823f9b89d1c18..104e7fe33ddcc42be0a6e4abbd590849ec9f31cf
You are receiving
Half of #6063 regarding the layers sidebar
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6107
-- Commit Summary --
* Write layer sidebar in erb template
* Move layer sidebar translations
* Make layers zoom hand
Half of #6063 regarding the share sidebar
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6106
-- Commit Summary --
* Write share sidebar in erb template
* Move share sidebar translations
-- File Changes --
M
@hlfan pushed 5 commits.
7ead530b267705b6b8b226e590a9f4c236797660 Write share sidebar in erb template
1778b5953e3a303f3d810e9d845e624b52681517 Write layer sidebar in erb template
33f0e885cadb724140ccb63e78ff9e500bec0079 Move share sidebar translations
db7cd2c8ee0594938ea71051fdd70d646a62ff26 M
biodranik left a comment (openstreetmap/openstreetmap-website#6100)
1. It would be great to reopen the issue and continue the discussion, to
highlight it.
2.
> One thing I find interesting is that StreetComplete, for some reason, manages
> to create almost 120 times fewer duplicate notes compar
Merged #6101 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6101#event-18156318418
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the fix - this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6101#pullrequestreview-2929512670
You are receiving this because you are subscribed to this thread.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6105
-- Commit Summary --
* Revert "Refactor directions output rendering and unit handling"
* Move units buttons above distance/time outputs
* Use unabbreviated la
@AntonKhorev pushed 3 commits.
f19c848cf55144f386ed3ea40eeea07abd1fe260 Add units buttons collapse toggle
1a047b99f5f1aaf66b99b06c804f89828e2e0e83 Prepare for extra miles subunit
7957b6b7e4d650ee8b165e9e38137f4961bb6865 Add miles-yards distance units
--
View it on GitHub:
https://github.com/o
AntMadeira left a comment (openstreetmap/openstreetmap-website#6104)
Ok, I noticed these strings were changed at Translatewiki 7 days ago. Probably
they weren't updated yet.
I'll close this issue for now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/ope
Closed #6104 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6104#event-18155605829
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@hlfan pushed 1 commit.
938212c429a159a1ceeec13b91c4ae966ef6663e Load map key only once from
sidebar-pane
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6101/files/4f0fbf11bb05b3575bae6f6cd1f451b6d7db0a1d..938212c429a159a1ceeec13b91c4ae966ef6663e
You are rece
AntMadeira created an issue (openstreetmap/openstreetmap-website#6104)
### URL
https://www.openstreetmap.org/copyright
### How to reproduce the issue?
Although all pages in the website are in the correct idiom (Portuguese),
several parts of the copyright page are in Brazilian Portuguese (the o
@hlfan pushed 7 commits.
e2dab279c84559be9b0b213ad54aacd9e207bb16 Make Rails handle SVG partials
16ad90c17acae8e024d90b291ae267748cee0023 Move search icons to partials
796e1f3fa363591fa77c98030f1b1b8f1029abea Move about icons to partials
c953b83310867229d2e2907abeb67a743eb3a641 Move welcome ic
tomhughes left a comment (openstreetmap/openstreetmap-website#6102)
I think this all looks good, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6102#issuecomment-2973689628
You are receiving this because you are subscribe
Merged #6102 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6102#event-18155408733
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -250,34 +242,31 @@ OSM.Query = function (map) {
* In both cases we then ask to retrieve tags and the geometry
* for each object.
*/
- function queryOverpass(lat, lng) {
-const latlng = L.latLng(lat, lng).wrap(),
- bounds =
@hlfan commented on this pull request.
> @@ -250,34 +242,31 @@ OSM.Query = function (map) {
* In both cases we then ask to retrieve tags and the geometry
* for each object.
*/
- function queryOverpass(lat, lng) {
-const latlng = L.latLng(lat, lng).wrap(),
- bounds = map
@tomhughes commented on this pull request.
> @@ -250,34 +242,31 @@ OSM.Query = function (map) {
* In both cases we then ask to retrieve tags and the geometry
* for each object.
*/
- function queryOverpass(lat, lng) {
-const latlng = L.latLng(lat, lng).wrap(),
- bounds =
@tomhughes requested changes on this pull request.
This doesn't actually handle changes to the base layer or zoom level that occur
while the key is hidden (which is always for layer changes) as hiding the key
disables the event listeners and then nothing runs `update` when it's shown
again.
This updates the new locale menu to use a bootstrap dropdown instead of a
simple HTML select so that it's appearance better matches the rest of the
site.
To do this I had to move the selector out of the secondary nav bar which
probably isn't ideal but without that something in bootstrap was gra
Building on the changes from #6076 that didn't involve ripping out leaflet
for consistency and instead prepare the bounds explicitly.
And another few things that caught my eye there.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-w
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100)
@AntonKhorev : the main issue here is about creating multiple identical notes
(same lat/lon & note description), presumably as a result of some technical
glitch. I don't think we would end up with that many identical notes for the
HarelM left a comment (openstreetmap/openstreetmap-website#3236)
I don't think this is a very interesting flow to be honest, just wanted to
report it in case there's an interest to solve it.
If this is no longer a possible flow, feel free to close the issue.
--
Reply to this email directly or v
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6089)
Edit buttons in sidebar:
- One button is bad because which edit page added in #6084 should it open?
- Many buttons bad because clutter and they make the sidebar look significantly
different to the owner, if compared to how it l
Closed #6076.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076#event-18154752511
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan pushed 2 commits.
a99f753870c8abf91b996bc78d7254850fcb8fb3 Directly assign bounds without leaflet
c4c9c174c6239593078d15738d943f0f3df8f521 Combine bounds area functions and
reduce leaflet dependency
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076/
Pulling this first part out of #6063.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6101
-- Commit Summary --
* Add padding class in erb
* Load map key only once from sidebar-pane
-- File Changes --
M app/a
hlfan left a comment (openstreetmap/openstreetmap-website#6063)
> under some common prefix
Good point, what do you think of "/panes/{pane}"?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6063#issuecomment-2973561664
You are rec
tomhughes left a comment (openstreetmap/openstreetmap-website#6063)
I mean it is already split into separate commits I think and I did have a quick
look at it reviewing each commit but I've been meaning to come back and have a
better look... As I recall my main question was whether the URLs shou
40 matches
Mail list logo
