Re: [openstreetmap/openstreetmap-website] Move html from javascript to views (PR #6063)

2025-06-14 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6063) Sure, the map key sidebar pane content loading update would need to be merged before the other panes' PRs as they would depend on that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstre

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-14 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 4 commits. 5329d25e9eb5aa2e8c31cdfce59a59e8ebbdd8cb Remove I18n.t references from user company system test d4b1590f1c0e24d0ff08d17dba96f084b69774b9 Remove Bootstrap icon class checks from profile tests bb2eaa5f165ec23b83828befb209feef2adb1dd7 Test user company record when

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > > Which section should get an edit button? > > I'd say make one edit button for the whole sidebar. Having any more just > clutteres up the space considerably. This is one step away from having one edit button for the whole

Re: [openstreetmap/openstreetmap-website] Language switcher on the homepage (#1115)

2025-06-14 Thread Holger Jeromin via rails-dev
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#1115) Can this be closed with the merge of #5201 ? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1115#issuecomment-2973521393 You are receiving this because you

Re: [openstreetmap/openstreetmap-website] Move html from javascript to views (PR #6063)

2025-06-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6063) Is it possible to split this pull request per each sidebar pane? For example, to make a PR that moves only the map key first? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetma

Re: [openstreetmap/openstreetmap-website] Problematic login-logout flow (#3236)

2025-06-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#3236) Was this issue about `/user/:display_name/account` pages? Account/profile/preferences settings pages no longer have usernames in their paths, so the scenario as described in this issue is not going to happen. -- Reply to thi

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-14 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -369,6 +368,14 @@ L.extend(L.Icon.Default.prototype, { } }); +OSM.boundsArea = function ([[minLat, minLon], [maxLat, maxLon]]) { + const height = maxLat - minLat; + let width = maxLon - minLon; + + if (width < 0) width += 360; This fix

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-14 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -55,10 +55,10 @@ describe("OSM", function () { it("parses bbox params", function () { const expected = L.latLngBounds([57.6247, -3.6845], [57.7247, -3.7845]); let params = OSM.mapParams("?bbox=-3.6845,57.6247,-3.7845,57.7247");

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6100) Maps.me and its descendants place notes on some kind of centroids of line/area features. You tap some place in something large enough like a forest and you get a note at its center. Somebody else taps some different place of t

Re: [openstreetmap/openstreetmap-website] Map doesn't zoom to Note if URL contains comment ID (Issue #5596)

2025-06-14 Thread Máté Gyöngyösi via rails-dev
gy-mate left a comment (openstreetmap/openstreetmap-website#5596) I couldn't reproduce the issue anymore. @BathoryPeter, can you also confirm that this is fixed? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5596#issuecomment

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099) By the way, calling the original Rails code returns the following result: ``` QuadTile.tile_for_point(35.2000381, 114.6629926) => 3875963095 ``` This matches: ``` id | latitude | longitude | changeset_id | visible |

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100) > Here are some stats https://dupnotes.webmapping.cyou/ with a [subset of > Organic Maps duplicated > notes](https://dupnotes.webmapping.cyou/organic-maps/om-dupe-notes.json). So > it is still an issue. One thing I find interest

Re: [openstreetmap/openstreetmap-website] Idempotency for API 0.6 (#2201)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#2201) In the meantime, there are Gems like https://github.com/julik/idempo available that implement idempotency more generically (untested). -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstr

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread Alexander Borsuk via rails-dev
biodranik left a comment (openstreetmap/openstreetmap-website#6100) Thanks for the reference to a similar #2201 issue. I read comments there, and do not understand why this (and that) issue was closed: 1. #2201 was closed just because nobody commented there. The problem of duplication in the da

Re: [openstreetmap/openstreetmap-website] Proposal: Seamless Sign-On for OpenStreetMap users from 3rd party apps (Issue #4128)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#4128) I believe this was resolved by #4455. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4128#issuecomment-2972808484 You are receiving this because you are subscr

Re: [openstreetmap/openstreetmap-website] Proposal: Seamless Sign-On for OpenStreetMap users from 3rd party apps (Issue #4128)

2025-06-14 Thread Tom Hughes via rails-dev
Closed #4128 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4128#event-18149811157 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-14 Thread Tom Hughes via rails-dev
Merged #5201 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201#event-18148516349 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add a locale selector (PR #3618)

2025-06-14 Thread Tom Hughes via rails-dev
Closed #3618. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3618#event-18148527981 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add a locale selector (PR #3618)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#3618) Superseded by #5201. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3618#issuecomment-2972623027 You are receiving this because you are subscribed to this thread

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#5201) I think this is fine as a starting point and we should merge it - we can always look to improve things further later. Thanks for all the work on it. -- Reply to this email directly or view it on GitHub: https://github.com/open

Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.28.0 to 9.29.0 (PR #6097)

2025-06-14 Thread Tom Hughes via rails-dev
Merged #6097 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6097#event-18148439114 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Maximum field length for Home Location (PR #6095)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6095) Sorry I merged this accidentally. I've removed it now, but please open a new one once you're updated it as requested. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread Tom Hughes via rails-dev
Closed #6099 as duplicate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6099#event-18147598174 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Maximum field length for Home Location (PR #6095)

2025-06-14 Thread Tom Hughes via rails-dev
Merged #6095 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6095#event-18148425981 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread Tom Hughes via rails-dev
Closed #6100 as duplicate. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6100#event-18148269608 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] Problematic login-logout flow (#3236)

2025-06-14 Thread Nitishsuman1 via rails-dev
Nitishsuman1 left a comment (openstreetmap/openstreetmap-website#3236) After logout, session data is cleared. When User B logs in, they’re redirected to / or their dashboard — not User A’s settings. Unauthorized redirects are avoided or blocked with checks. -- Reply to this email directly or

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099) Also, please stop spamming unrelated repos: https://github.com/openstreetmap/iD/issues/11132 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6099#issuecomment-29

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6099) Please don't open a new ticket - you already have a ticket so please discuss this on #6098 to keep the discussion in one place. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetma

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6100) What you probably want are idempotent API endpoints like we’ve been discussing in #2201 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6100#issuecomment-2972565

Re: [openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6100) Well why would it check? It's hardly an obvious thing to do and once we start doing things like that where do we stop? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6099) No idea what you’re trying to achieve. Why don’t you use the API or some external tool like osmosis to load the data. It seems very odd that you’re fudging with the tile field calculation. -- Reply to this email directly or vie

Re: [openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread YyJ via rails-dev
YyJyyy left a comment (openstreetmap/openstreetmap-website#6099) > Also, please stop spamming unrelated repos: > [openstreetmap/iD#11132](https://github.com/openstreetmap/iD/issues/11132) Could you please help solve this problem -- Reply to this email directly or view it on GitHub: https://git

[openstreetmap/openstreetmap-website] [notes API] Prevent duplication of the same note with equal coordinates and text (Issue #6100)

2025-06-14 Thread Alexander Borsuk via rails-dev
biodranik created an issue (openstreetmap/openstreetmap-website#6100) ### URL https://osm.org/note/4801754 ### How to reproduce the issue? In some cases, e.g. when a client didn't receive a success response from the notes API (bad network, app killed by the system, etc.), it may try to recreat

Re: [openstreetmap/openstreetmap-website] openstreetmap在数据库的中有个表current_nodes中的tile是怎么计算的? (Issue #6098)

2025-06-14 Thread YyJ via rails-dev
YyJyyy left a comment (openstreetmap/openstreetmap-website#6098) Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? My results 请输入纬度(可整数1e7或度数):35.2000381 请输入经度(可整数1e7或度数):114.6629926 tile = 1040445921102437142 ![Image](

[openstreetmap/openstreetmap-website] Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? (Issue #6099)

2025-06-14 Thread YyJ via rails-dev
YyJyyy created an issue (openstreetmap/openstreetmap-website#6099) ### Problem Hello, no matter how I calculate the tile according to the official method, it is always incorrect. Can someone help explain? My results 请输入纬度(可整数*1e7或度数):35.2000381 请输入经度(可整数*1e7或度数):114.6629926 tile = 1040445921102