Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
@hlfan commented on this pull request. > @@ -252,7 +247,7 @@ OSM.Query = function (map) { */ function queryOverpass(lat, lng) { const latlng = L.latLng(lat, lng).wrap(), - bounds = map.getBounds().wrap(), + bounds = map.wrapLatLngBounds(map.getBounds()), Removed, p

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 3 commits. 4ac8b1f95f6d54da415d36c8e24a4067ff3d3c43 Drop unnecessary custom wrap function d183de86d71143a6d9f424e80746220b118e98cf Directly assign bounds without leaflet 2ff145d2192f02edcf62421f7852e33132305859 Combine bounds area functions and reduce leaflet dependency -- View

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) > Which section should get an edit button? I'd say make one edit button for the whole sidebar. Having any more just clutteres up the space considerably. -- Reply to this email directly or view it on GitHub: https://github.com/opens

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6072) > But there's also the ogf wiki. The ogf wiki's logo is considerably different from the icon of other wikis as it resembles more 💭 than a W. > If I add a link to my other osm account, which icon should it get, a large > osm logo or

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 2 commits. 94753cb9835202fd9aabe1bfecf8d4fbf43185a3 Use only differences to OSM logo in internal social link icons 6bac01a5c7e3ffa47a476cb69d1e9fef982ee3a4 Add OSM logo indicator for related social links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-websi

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-06 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -252,7 +247,7 @@ OSM.Query = function (map) { */ function queryOverpass(lat, lng) { const latlng = L.latLng(lat, lng).wrap(), - bounds = map.getBounds().wrap(), + bounds = map.wrapLatLngBounds(map.getBounds()), What

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > I'm thinking of wikidata style grouping. Depending on the type of claim, it's > placed either in the statements or the identifiers section, regardless where > it was entered. And the ordering in the edit page wouldn't change

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) I'm thinking of wikidata style grouping. Depending on the type of claim, it's placed either in the statements or the identifiers section, regardless where it was entered. And the ordering in the edit page wouldn't change. Then, if

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6072) > > Why is it the osm logo that's getting shrunk and not the wiki/forum? > > Because it's not the important part, you see the e.g. the W icon which > narrows the platforms down to two options, and the indicator just says if >

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > Is something speaking against all of the above? So you want a section for links to: - osm - osm wiki - osm forum - osm mastodon - maybe even ohm, depending on your answer elsewhere Do these links also get their own edit pag

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Minh Nguyá»…n via rails-dev
1ec5 left a comment (openstreetmap/openstreetmap-website#6072) What if we reduce the OHM icon to the outline of the map with the H centered inside of it, similar to [the Public Domain Map logo](https://commons.wikimedia.org/wiki/File:Public_Domain_Map_logo.svg)? This would just be an icon anywa

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) Is something speaking against all of the above? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2949985172 You are receiving this because you are su

Re: [openstreetmap/openstreetmap-website] User Social profile links should contribute to Spam Score (Issue #6090)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6090) Could the ratio or relative percentage of links with :platform == "other" be possible to consider? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6090#issuecomme

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6072) > Why is it the osm logo that's getting shrunk and not the wiki/forum? Because it's not the important part, you see the e.g. the W icon which narrows the platforms down to two options, and the indicator just says if it's osm affili

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6072) The advantage of badges is that the icons take the "same" space, which helps with their alignment. That comes at a cost of adding smaller icons. If you want to shink the osm logo, you'll have to keep its colors, otherwise it

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-06 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > Separating them into a section would fit quite well to #6089. Which ones should be separated into a section? Osm (sub)domains, osm + ohm + ogf, osm + osm Mastodon? -- Reply to this email directly or view it on GitHub: http

Re: [openstreetmap/openstreetmap-website] Use only differences to OSM logo in internal social link icons (PR #6072)

2025-06-06 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -5,6 +5,11 @@ <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", :alt => social_link.parsed[:platform].nil? ? t(".other") : social_link.parsed[:

Re: [openstreetmap/openstreetmap-website] User Social profile links should contribute to Spam Score (Issue #6090)

2025-06-06 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6090) I understand the logic but it will be next to impossible to do I fear as all users will be filling this in equally so you'll just be giving basically every a baseline score. -- Reply to this email directly or view it on GitHub

[openstreetmap/openstreetmap-website] User Social profile links should contribute to Spam Score (Issue #6090)

2025-06-06 Thread Grant via rails-dev
Firefishy created an issue (openstreetmap/openstreetmap-website#6090) ### How to reproduce the issue? Previously spammers would use their user profile description for promoting their spam links, this would affect their User Spam Score. Spammers are now using the Social profile links feature for

Re: [openstreetmap/openstreetmap-website] Landing page to promote OSM (Issue #6006)

2025-06-06 Thread danieldegroot2 via rails-dev
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#6006) Related - https://github.com/osmlab/osm-planning/issues/13 - Improve welcome page with description (see [1](https://github.com/osmlab/osm-planning/issues/22#issuecomment-416035520), [2](https://community.openstreetmap.org/t