Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6089) ...or wider buttons with subtler borders: ![image](https://github.com/user-attachments/assets/35e9864f-3506-4ccf-bcd1-700a86531189) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/opens

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6089) A version with secondary-color buttons: ![image](https://github.com/user-attachments/assets/9c1d1bef-e750-4f3d-b204-bf4152bfcc40) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstr

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 7800f7f086e8688d7226d26ce763d6279898e62a Move profile location and company to sidebar -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6089/files/611deb67867afe9de6ba5d55e05b254f4ef5b706..7800f7f086e8688d7226d26ce763d6279898e62a Yo

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-05 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) > That's a change to how link ordering currently works. Separating them into a section would fit quite well to #6089. But that aside, what do you think of badges like in #6072? -- Reply to this email directly or view it on GitHub:

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6089) This is how it's going to look with edit buttons added: ![image](https://github.com/user-attachments/assets/0a095f64-9de8-4e9c-bb67-53501d4b59d8) -- Reply to this email directly or view it on GitHub: https://github.com/opens

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6089) > Then it will be a distinct "section without links" above the "section with > links". Maybe we'll add links from company to organized mapping wiki page. -- Reply to this email directly or view it on GitHub: https://github.c

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6089) I think the general idea here is nice, and should help with the edit buttons so I guess we just need to figure out the best presentation. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/op

Re: [openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6089) Having both the home location and the company in one section would be cleaner imo. Then it will be a distinct "section without links" above the "section with links". -- Reply to this email directly or view it on GitHub: https://gi

Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6084) We can do #6089 and have all edit buttons in the content body instead of trying to squeeze them in the heading, like the current version of this PR does: ![image](https://github.com/user-attachments/assets/7c76633d-2200-4593-8

[openstreetmap/openstreetmap-website] Move profile location and company to sidebar (PR #6089)

2025-06-05 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6089 -- Commit Summary -- * Remove I18n.t references from user company system test * Remove Bootstrap icon class checks from profile tests * Test user company reco

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.4.0 to 4.4.1 (PR #6087)

2025-06-05 Thread Tom Hughes via rails-dev
Merged #6087 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6087#event-18005041716 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Tom Hughes via rails-dev
Merged #6083 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083#event-18005041741 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump rack from 3.1.15 to 3.1.16 (PR #6088)

2025-06-05 Thread Tom Hughes via rails-dev
Merged #6088 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6088#event-18005041750 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6083) Thanks... This look good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083#issuecomment-2945128748 You are receiving this because you are subscribed

Re: [openstreetmap/openstreetmap-website] default INSTALL.md instructions don't seem to work for Ubuntu 24.04 (Issue #6086)

2025-06-05 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6086) I think `bundle` doesn't try to write to system directories if you install a version of ruby using `rbenv`. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/6

Re: [openstreetmap/openstreetmap-website] Profile edit tabs (PR #6084)

2025-06-05 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6084) I don't think even a tooltip would make it discoverable enough, I think it needs a label, either "Edit" again or at least the icon currently used for `changeset.num_changes`. -- Reply to this email directly or view it on GitHub: h

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Marwin Hochfelsner via rails-dev
@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2900614794 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Martin Raifer via rails-dev
@tyrasd commented on this pull request. > @@ -7,5 +7,5 @@ data[:zoom] = @zoom if @zoom data[:gpx] = trace_data_url(params[:gpx], :format => :xml) if params[:gpx] data[:url] = id_url(:locale => params[:locale]) %> - <%= tag.iframe "", :frameBorder => 0, :id => "id-embed", :clas

Re: [openstreetmap/openstreetmap-website] make sure iD's iframe is focused on startup (PR #6083)

2025-06-05 Thread Martin Raifer via rails-dev
@tyrasd pushed 1 commit. ac07dbfd69b5831d9f5ad2502ac1086aa1d3c6d2 make sure iD's iframe is focused on startup -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6083/files/145ee61e56b426f66f40acd5bea92db73f20c910..ac07dbfd69b5831d9f5ad2502ac1086aa1d3c6d2 You are