@AntonKhorev pushed 2 commits.
7f79983682f74779e26cea6b2f3d7096a96e4757 Add "Edit Company" button to user
profile
fcee3918d8dc07c5e7f3f9d2b3f2e8a716da12b6 Add "Edit Location" button to user
profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6084/files/6
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6083)
So what if it's newly available? The worst thing that would happen is that
autofocus won't work. Update your browser then. Many of browsers that had
`autofocus` added recently are mobile versions, where it's mostly irrelevant.
hlfan left a comment (openstreetmap/openstreetmap-website#5328)
That has been declared as out of scope for this project, the relevant issue for
this layer is https://github.com/gravitystorm/openstreetmap-carto/issues/4412.
--
Reply to this email directly or view it on GitHub:
https://github.com
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6084)
Replaced one "Edit Profile" button with multiple buttons, one for each tab. One
of them is the avatar image, that's how it's done on GitHub.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
@AntonKhorev pushed 2 commits.
22a1814c8600ffa78674b0c71b6be33bde0eebb1 Add "Edit Company" button to user
profile
605cc8f98a0aea38ee25bdcc0750b417e4690118 Add "Edit Location" button to user
profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6084/files/b
vitaly-zdanevich left a comment (openstreetmap/openstreetmap-website#5328)
> > Where? How to enable them?
>
> Account > My Preferences > Preferred Map Color Scheme
Is this a dark map?
--
Reply to this em
@AntonKhorev pushed 2 commits.
a3c257ea6457e0207de93d78c8d516762c4941b0 Add "Edit Company" button to user
profile
bc9d05c8b640c48eb612a891fb940803de4576b9 Add "Edit Location" button to user
profile
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6084/files/b
@AntonKhorev pushed 2 commits.
295bbe6899210bad96183a4d5750b378409250b4 Replace "Edit Profile" button with
"Edit Links" and "Edit Description"
bfc6596b5f8017a2bbe27015ed9dba9b7081eb94 Turn own profile image into an edit
link
--
View it on GitHub:
https://github.com/openstreetmap/openstreetma
mxdanger left a comment (openstreetmap/openstreetmap-website#5328)
> Where? How to enable them?
Account > My Preferences > Preferred Map Color Scheme
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2937862028
vitaly-zdanevich left a comment (openstreetmap/openstreetmap-website#5328)
> I'm closing this issue now, because the dark mode maps are now implemented as
> described above.
Where? How to enable them?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openst
pnorman left a comment (openstreetmap/openstreetmap-website#6006)
> Can i work on this issue.
Anyone can work on this issue. It might not be a great starting place for
someone new. The technical changes are likely to be easy, the hard part is
figuring out what text to have in which place.
--
vitaly-zdanevich left a comment (openstreetmap/openstreetmap-website#5328)
I wrote
[userstyle](https://gitlab.com/vitaly-zdanevich-styles/openstreetmap/-/tree/master)
```
@-moz-document domain('openstreetmap.org') {
.leaflet-tile-container img
{
filter: invert() h
@AntonKhorev pushed 2 commits.
d374796fa8be91205ffa5a84d340349ab2b1fd8e Rename profile update system tests to
match controller names
4b6d07c214af8a2ed4af85c365f1dd3dcff3c72a Replace "Edit Profile" button with
"Edit Links" and "Edit Description"
--
View it on GitHub:
https://github.com/openst
@hlfan pushed 7 commits.
622e5dbfb95b287492b3c3e7afedf41c5cc28fa8 Write layer sidebar in erb template
fc0114fabf6c4c8adf2e57e33fb619608523bf63 Write share sidebar in erb template
09977de846efd8ddf2fe8c5196a4781afbd65edd Move layer sidebar translations
2d293ff3a80b111901eb0e4e07ef140a00e22022 M
@hlfan pushed 2 commits.
4645a45d9b55cb1d0cb36f01fe78f04011eeab7b Add OSM logo badge for related social
links
85ce4b0afee5e0ecd3148998618b14c293d4038e Use only differences to OSM logo in
internal social link icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
Merged #6085 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6085#event-17968124359
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tyrasd left a comment (openstreetmap/openstreetmap-website#6083)
> Have you tried adding
> [`autofocus`](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/autofocus)
> to the ``?
I haven't, but given that the attribute is still marked as (kind of) _newly
available_,
@tyrasd commented on this pull request.
> @@ -37,7 +37,8 @@ $(function () {
id.attr("src", idData.url + "#" + params);
id.ready(function () {
-if (!this.contentWindow.location.href.startsWith(idData.url)) {
+id.focus();
+if (this.contentWindow &&
!this.contentWindow.location
tyrasd left a comment (openstreetmap/openstreetmap-website#6083)
> Does this run the fix of causing keyboards to popup on mobile devices?
I tested it now, and it does not cause the keyboard from opening on a mobile
browser. Is there a known bug where this is the case? :thinking:
--
Reply to
hlfan left a comment (openstreetmap/openstreetmap-website#6072)
I've introduced badges for osm related links:
--
Re
Contains a singular bugfix for a major bug in iD:
https://github.com/openstreetmap/iD/issues/11076
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6085
-- Commit Summary --
* Update to iD v2.34.1
-- File Changes --
@hlfan pushed 2 commits.
3f22b2af81bb8a4b4e620a597eac6700209731c9 Add OSM logo badge for related social
links
7a8246c3f2bfcda5e1f443ac1a0a54389ec7f732 Use only differences to OSM logo in
internal social link icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
@hlfan pushed 2 commits.
ae8c6f84e5ab169b1645fa4b0a483f4dd91026c5 Add OSM logo badge for related social
links
6ed22bf36e104964226157d8c088941571102cfa Use only differences to OSM logo in
internal social link icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
tomhughes left a comment (openstreetmap/openstreetmap-website#6084)
This looks pretty good to me.
The only thing that concerns me is that setting up a new account becomes quite
long winded - you start editing the profile and fill in one tab and hit update
and it sends you back to the profile an
@AntonKhorev pushed 15 commits.
6eccbe935ee9f3e07ad984d8a96178cb1411089a Remove I18n.t references from user
company system test
b20949770f35e55c5e32d8c17ad83eb24a667ada Move profile resource to
profile/description
320e8701212dcecee9fbe130e57afe87208d32bc Test profile description show action
b
tomhughes left a comment (openstreetmap/openstreetmap-website#6081)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6081#issuecomment-2936192070
You are receiving this because you are subscribed to this t
@AntonKhorev pushed 15 commits.
0f36b5653f01dd092cc1d9d4bd6f8992b9b8f03e Move Gravatar enabled/disabled
messages to their controller
805e3a8eec5d28721ec229f573277357bc063473 Move profile resource to
profile/description
4325360637710e9fd59704043c888578c66d Test profile description show act
@AntonKhorev pushed 15 commits.
fd6dfb1cd37a2a93523e03e05751e67783683f89 Move Gravatar enabled/disabled
messages to their controller
89825322e2f301cf169385366f62f3745afdc1cc Move profile resource to
profile/description
6d73d3b63c657242cba0189d8e7d57c4280c Test profile description show act
Merged #6081 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6081#event-17962795224
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 4 commits.
bbfae509cbc265fda2a129816d03300687d5d3b7 Ensure comparison with latLngBounds
bc65e7ed857ecd97bb3a8e5669d777ba549855ff Drop custom wrap function in favor of
wrapLatLngBounds
901bb98d3fea571c4620623624446022b813ebde Directly assign bounds without leaflet
64496d73b1965db0
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6084)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6084
-- Commit Summary --
* Fix template rendered on profile update failure
* Move profile resource to profile/description
* Test profile description show action
PinJinx left a comment (openstreetmap/openstreetmap-website#6006)
Can i work on this issue. I am new to this repo, So i may take some time to
figure things out
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6006#issuecomment-2
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6083)
Have you tried adding `autofocus` to the ``?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6083#issuecomment-2935266169
You are receiving this because you are
tomhughes left a comment (openstreetmap/openstreetmap-website#6083)
Does this run the fix of causing keyboards to popup on mobile devices? or are
we safe because it's not an input field being focused?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
@hlfan commented on this pull request.
> @@ -37,7 +37,8 @@ $(function () {
id.attr("src", idData.url + "#" + params);
id.ready(function () {
-if (!this.contentWindow.location.href.startsWith(idData.url)) {
+id.focus();
+if (this.contentWindow &&
!this.contentWindow.location.
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6076)
Why do you want to add a Leaflet dependency to the code that doesn't use
Leaflet?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076#issuecomment-2935185541
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6083#pullrequestreview-2892221348
You are receiving this because you are subscribed to this thread.
Message ID:
__
Focus iD's iframe element to allow iD to receive keyboard shortcuts
directly after loading. This is useful when people want to start adding new
elements right away using the shortcuts (`1`, `2`, `3`), to pan/zoom the map
using the arrow keys, to open the help dialog `?`, to directly perform
ope
tomhughes left a comment (openstreetmap/openstreetmap-website#6082)
Proprietary players support Google's version but we have so far refused to
support that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6082#issuecomment-2933
40 matches
Mail list logo
