Re: [openstreetmap/openstreetmap-website] support new indian Digipin address format (Issue #6082)

2025-06-02 Thread test2a via rails-dev
test2a left a comment (openstreetmap/openstreetmap-website#6082) i understand the reluctance but this is going to be a reality for 1/6 of human population, not just a "country". proprietary players will happily support it so that will leave foss users at a disadvantage whereby the ecosystem won

Re: [openstreetmap/openstreetmap-website] support new indian Digipin address format (Issue #6082)

2025-06-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6082) Given our previously expressed reluctance to add support for several such systems that operate on a global level I think we would be even more reluctant to start adding support for systems that are specific to a single country.

[openstreetmap/openstreetmap-website] support new indian Digipin address format (Issue #6082)

2025-06-02 Thread test2a via rails-dev
test2a created an issue (openstreetmap/openstreetmap-website#6082) ### Problem DigiPin is india's answer to what3words. this is a static 10 character address format similar to what3words that is for india only. ### Description this format will aide in direct address lookup and routing/address

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. eecc9414a91d71e3d6a677fa14b3caca9cad9998 Centralize antimeridian bounds handling -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/e6d248208a16022c9fe7623de4bba52a6a1d717b..eecc9414a91d71e3d6a677fa14b3caca9cad9998 You are recei

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. e6d248208a16022c9fe7623de4bba52a6a1d717b Centralize antimeridian bounds handling -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/883c7a6d57a76d73b1c372ce1cd6caf9e8cef805..e6d248208a16022c9fe7623de4bba52a6a1d717b You are recei

Re: [openstreetmap/openstreetmap-website] Reuse bounds size functions (PR #6076)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 4 commits. 1a0a1c47c6d59f07b9d012a34c463d1b9a99f9d6 Reuse error printing 966a5f3916022640f16fe951e5c60797537812e5 Fix bounding box coordinates in OSM.location test d88d39e05ccce9b6722378dcbcbf8282b8321677 Remove unused distance function and its tests 883c7a6d57a76d73b1c372ce1cd6

[openstreetmap/openstreetmap-website] Fix template rendered on profile update failure (PR #6081)

2025-06-02 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6081 -- Commit Summary -- * Fix template rendered on profile update failure -- File Changes -- M app/controllers/profiles_controller.rb (2) M test/controller

Re: [openstreetmap/openstreetmap-website] Test sorting multiple enclosing features across antimeridian (PR #6078)

2025-06-02 Thread Tom Hughes via rails-dev
Merged #6078 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6078#event-17937893225 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove "preferences updated" flash fallback to old message (PR #6080)

2025-06-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6080) Regardless of whether it's worth having it all this looks fine to me as it stands, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6080#issuecomment-2931

Re: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079)

2025-06-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6079) Based on what @lonvia says I think we have to refuse this as it stands but thanks for trying to address the issue and I'd encourage you to work with @lonvia and the Nominatim side to get the necessary information coming from No

Re: [openstreetmap/openstreetmap-website] Remove "preferences updated" flash fallback to old message (PR #6080)

2025-06-02 Thread Tom Hughes via rails-dev
Merged #6080 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6080#event-17937893236 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Add dir=auto to user generated content (PR #3429)

2025-06-02 Thread Tom Hughes via rails-dev
@tomhughes pushed 2 commits. c56c1d3c40a3bf9e2cbc793c86d98685972ed84d Add dir=auto to user generated content 4375464f7ccfa39c266493352cf0e880bc7e7dc2 Add dir=auto to usernames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/6e904d18a1ee8638d0951c9e4

Re: [openstreetmap/openstreetmap-website] Test sorting multiple enclosing features across antimeridian (PR #6078)

2025-06-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6078) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6078#issuecomment-2931420825 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079)

2025-06-02 Thread Tom Hughes via rails-dev
Closed #6079. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6079#event-17937846216 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-02 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + gl: Galician + gsw: Alemannic (specifically Swiss German, Alsatian) + gu: Gujarati + he: Hebrew + hi: Hindi + hr: Croatian + hsb: Sorbian, Upper + hu: Hungarian + ia: Interlingua + id: Indonesian +

Re: [openstreetmap/openstreetmap-website] Remove "preferences updated" flash fallback to old message (PR #6080)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6080) Do we really need these 20 chars in a separate file? Couldn't this be done using `render :text => t ".message"` instead of `render :partial => ...`? -- Reply to this email directly or view it on GitHub: https://github.com/openstree

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-02 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > Should the osm.town Mastodon also get osm-related treatment? Maybe. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2931238593 You are rece

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) Should the osm.town Mastodon also get osm-related treatment? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2931200787 You are receiving this becau

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-02 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) > > no "iki" in microscopic font size > > which makes the icon barely different from the Wikipedia icon, sans serif W > vs. serif W That's why two icons for osm subdomains. > > two icons for osm for osm subdomains > > Not e

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-02 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6065) > no "iki" in microscopic font size which makes the icon barely different from the Wikipedia icon, sans serif W vs. serif W > two icons for osm for osm subdomains Not everything has to be indicated by an additional icon, which als

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-02 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -0,0 +1,15 @@ + + + + + <% unless disabled %> + + <% Locale.available + .select { |locale| I18n.exists? "shared.language_selector.#{locale}" } + .sort_by { |locale| t(".#{locale}") } +

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-02 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -0,0 +1,15 @@ + + + + + <% unless disabled %> + + <% Locale.available + .select { |locale| I18n.exists? "shared.language_selector.#{locale}" } can be resolved with https://github.com/openstreetmap/openstreetmap-

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2025-06-02 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > + + <% Locale.available + .select { |locale| I18n.exists? "shared.language_selector.#{locale}" } + .sort_by { |locale| t(".#{locale}") } + .each do |locale| %> +><%= t(".#{locale}") %> +

Re: [openstreetmap/openstreetmap-website] Make "W" in osm wiki social icon more readable (PR #6065)

2025-06-02 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6065) How about this: - no "iki" in microscopic font size (#6072 still wants it) - two icons for osm for osm subdomains, like this: (forum icon).(osm logo) - similarly two icons for ohm and ogf subdomains -- Reply to this email dir

[openstreetmap/openstreetmap-website] Remove "preferences updated" flash fallback to old message (PR #6080)

2025-06-02 Thread Anton Khorev via rails-dev
It was necessary for tests relying on old French message before getting an update from Translatewiki. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6080 -- Commit Summary -- * Remove "preferences updated" flash fa

Re: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073)

2025-06-02 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6073) No there are no versions because we're only really concerned about building the code for openstreetmap.org and if people want to use it for other things then that's up to them but we don't need versioned releases for our purpose

Re: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073)

2025-06-02 Thread Mahmoud Hanafy via rails-dev
mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6073) Thanks for your response. I have another question, not related to this issue. but appreciate if you can reply. Are there versions for openstreetmaps-website? I mean like stable versions that can be used instead of using th

Re: [openstreetmap/openstreetmap-website] JOSM can't use OAuth2 to connect to my local osm-website (Issue #6073)

2025-06-02 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073) https://github.com/openstreetmap/openstreetmap-website/issues/5950#issuecomment-2830201587 has some previous discussion on this topic. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstr

Re: [openstreetmap/openstreetmap-website] Add lang attribute to Nominatim results from CJK languages (PR #6079)

2025-06-02 Thread Sarah Hoffmann via rails-dev
@lonvia commented on this pull request. > @@ -12,6 +14,14 @@ def create # ask nominatim response = fetch_xml(nominatim_reverse_query_url(:format => "xml")) + # add lang attribute for frontend in certain regions + addressparts = response.elements["reversegeocode/addressp