@1ec5 commented on this pull request.
> @@ -12,6 +14,14 @@ def create
# ask nominatim
response = fetch_xml(nominatim_reverse_query_url(:format => "xml"))
+ # add lang attribute for frontend in certain regions
+ addressparts = response.elements["reversegeocode/addresspar
@mapmeld pushed 2 commits.
b905080241450f94fb00a87e4479c22695f21ee3 nominatim stubs
84726db2e95ef0899021e3edbbb2dacc4a7ecb25 reverse geocoder
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6079/files/72a1995031f0ff809d977fcc933ffe7893da5530..84726db2e95ef0899
### Description
In Unicode, some CJK characters such as 化 have one codepoint but will appear
differently in Simplified Chinese (化), Traditional Chinese (化), and Japanese (化). On the frontend, we can display names
c
@hlfan pushed 1 commit.
47913851f0d57ab1068cfec90dda6920f86c5489 Reuse bounds and size functions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/9db226ca03bd4a4c5cf09774aba5455a4ae94155..47913851f0d57ab1068cfec90dda6920f86c5489
You are receiving this
#6076 as it currently is will fail this test.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6078
-- Commit Summary --
* Test sorting multiple enclosing features across antimeridian
-- File Changes --
M test/s
hlfan left a comment (openstreetmap/openstreetmap-website#6076)
Updated `.getSize()` so `.wrap()` isn't necessary anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076#issuecomment-2928189028
You are receiving this because
@hlfan pushed 1 commit.
58256f357c30676600354f975b85c2f5edfa3946 Use only differences to OSM logo in
internal social link icons
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/ba8b9ed6d358880f38540cb8b6c2eb7c1ea54b51..58256f357c30676600354f975b85c2f
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6076)
What do you think `.wrap()` on `L.LatLngBounds` does? See
https://github.com/openstreetmap/openstreetmap-website/pull/5473#issue-2770179737.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
@hlfan pushed 7 commits.
db7905d9338d256f412fa9a12c1f6bbf2e0671d6 Write layer sidebar in erb template
a11951a0b6210a0913a2638a1183ce8b69fa712e Write share sidebar in erb template
2e7df28874f87c4e92f4e51c2736fa8fcff2d6b2 Move layer sidebar translations
f544258ce635be552152051138b0ad0d88e63c5d M
@hlfan pushed 2 commits.
12f9398b6d39d4e05e11f2c3897f7bfcfceb24d9 Reuse error printing
9db226ca03bd4a4c5cf09774aba5455a4ae94155 Reuse bounds and size functions
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6076/files/89b2d81e5b7f5d5bd1e424aabb9ffbfa349e930b.
Merged #6077 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6077#event-17919472698
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6077)
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6077#issuecomment-2928116090
You are receiving this because you are subscribed to this thread.
Closed #6075 as completed via d9b758267c169f29560c824dee81f8ace77de11d.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6075#event-17919472645
You are receiving this because you are subscribed to this thread.
Message ID:
__
Avoid accidental changes to `I18n.locale` when a request is made as a logged in
user with a different language preference.
Fixes #6075.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6077
-- Commit Summary --
* P
Reuse more utilities instead of redoing from scratch.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6076
-- Commit Summary --
* Reuse error printing
* Reuse bounds and size functions
-- File Changes --
M ap
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
https://josm.openstreetmap.de/changeset/18991/josm talks about leveraging [RFC
8414](https://datatracker.ietf.org/doc/html/rfc8414) to determine
authorization_endpoint and token_endpoint fields. I think that's more of a
convenien
tomhughes left a comment (openstreetmap/openstreetmap-website#6075)
Yes there are four tests that leave `I18n.locale` set to `fr` and one that
leaves it set to `ru` and if the next test is something like a helper test that
doesn't call `set_locale` as part of running an action then it will run i
tomhughes left a comment (openstreetmap/openstreetmap-website#6075)
I've seen Russian as well... Still looking into it but I don't think it's
actually the language preference as such as all the new tests around that are
changing the preference on a temporary user that won't last past the test.
hlfan created an issue (openstreetmap/openstreetmap-website#6075)
Lately I've seen multiple tests fail because the tests are expecting an English
site but it's rendered in French.
```diff
--- expected
+++ actual
@@ -1 +1 @@
-"building=yes, shop=gift, and tourism=museum"
+"building=yes, shop=gift
hlfan left a comment (openstreetmap/openstreetmap-website#5854)
Hey @AntonKhorev, when you get a chance, would love your eyes on this one if
it’s not getting in the way of your daily PR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/
tomhughes left a comment (openstreetmap/openstreetmap-website#6070)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6070#issuecomment-2927297151
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6073)
Yes that's an OpenID Connect endpoint not an OAuth endpoint - no idea why JOSM
wants to hit that because it's not necessary and I don't think it even existed
when they first added OAUth 2 support.
It doesn't strictly speaking n
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
The issue is that JOSM requires the /.well-known/oauth-authorization-server
endpoint to be around, and for some reason Doorkeeper disables this endpoint
unless you define a doorkeeper_signing_key. That's mostly in place so that JO
tomhughes left a comment (openstreetmap/openstreetmap-website#6074)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6074#issuecomment-2927599057
You are receiving this because you are subscribed to this t
tomhughes left a comment (openstreetmap/openstreetmap-website#6073)
Really? So JOSM uses id tokens not just auth tokens?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927612475
You are receiving this because
@hlfan pushed 7 commits.
f8bd61518203286d3001da2b2899b43ea4a2db28 Make Rails handle SVG partials
c82c39a043e9bec74d0b9b1e70299bf19c8e4f2c Move search icons to partials
324b27e9da5e5a9f1986e547b67295ba2db58ff7 Move about icons to partials
3b4f65c8081ae94d19a5ec978ac2aa79e4a07e53 Move welcome ic
@tomhughes pushed 2 commits.
bc513474d85733de14f909e9468ffbf9ad635bc4 Add dir=auto to user generated content
6e904d18a1ee8638d0951c9e4d3187eb980ad407 Add dir=auto to usernames
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3429/files/deb0ed84c4fe5435d72043a18
mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6073)
Hi Tom, Thanks for your response.
The problem I currently have is that the authorisation button is disabled. and
I see the following message in JOSM logs
```
2025-06-01 14:37:05.429 INFO: GET
https://osm.test/.well-known/oa
tomhughes left a comment (openstreetmap/openstreetmap-website#6069)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6069#issuecomment-2927608607
You are receiving this because you are subscribed to this t
Merged #6074 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6074#event-17916412498
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6069 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6069#event-17916412499
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
mmd-osm left a comment (openstreetmap/openstreetmap-website#6073)
Did you configure doorkeeper_signing_key in your settings.local.yml?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6073#issuecomment-2927568676
You are receivin
@hlfan pushed 7 commits.
73f51a8dacdc896d1c9a24a5804217935b01e4d0 Write layer sidebar in erb template
912d58d71d14e7eb9069986e0406f9d932c0e4f7 Write share sidebar in erb template
437ba4650c07801c79b0670c844a86ab880778a6 Move layer sidebar translations
fe9c6c02dc35c28e0897265ce6ad8c25f0775b85 M
hlfan left a comment (openstreetmap/openstreetmap-website#6072)
>Let's start with a change that shouldn't be in this PR
Removed since taken care of in #6074
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6072#issuecomment-292750
@hlfan pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6072/files/2fab010e80017837e110a9bf147a3ad6c67eb2ed..ba8b9ed6d358880f38540cb8b6c2eb7c1ea54b51
You are receiving this because you are subscribed to this thread.
Message ID:
__
#6072 tried to change the color of the ogf icon to match the colors of other
social icons. Except that wouldn't work as intended because the lines in
the ogf icon are narrower than 1px. It already looks bleak, and with that color
change it's going to be bleaker. There's not much to be done about
@AntonKhorev pushed 3 commits.
acfadceb6d0686e809f914485a3cfa450fc56542 Fix overpass query feature areas for
bounds including antimeridian
0495960282330c697609494c19c7fd2a34f498f6 Remove unnecessary consts in overpass
query js controller
740b5720317208fd72e9f450bedda1ffebf993a2 Test overpass
Closed #2581 as completed via #6024.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2581#event-17915210565
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #6073 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6073#event-17915111619
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Merged #6024 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6024#event-17915210508
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
I guess a static file works as well at least for now, so I think this is good
to merge, thaks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6024#pullrequestreview-2885744240
You are rec
tomhughes left a comment (openstreetmap/openstreetmap-website#6073)
Username and password have nothing to do with OAuth2 though? If you were using
OAuth2 you wouldn't give those to JOSM but instead you would be directed to the
web site to login and get a token for JOSM.
You will to register an
Merged #6070 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6070#event-17914637462
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6068 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6068#event-17914637473
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
mahmoudhanafy created an issue (openstreetmap/openstreetmap-website#6073)
Hi Team,
I'm trying to connect from JOSM to osm using OAuth2 but I see this the
following in the logs:
```
2025-06-01 14:35:14.134 SEVERE: Authentication failed - Authentication at
the OSM server with the username 'my_us
Closed #6057 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6057#event-17914289685
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6057)
Thanks for your response @HolgerJeromin
I didn't know about cgimap before, I'm using it now and it's working much
faster.
I'm going to close this issue, as it should be fixed by the PR I merged.
--
Reply to this email dire
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6072)
Let's start with a change that shouldn't be in this PR. "Use bs light mode bg
secondary color consistently". Are you taking line width into account? (no)
--
Reply to this email directly or view it on GitHub:
https://github.co
48 matches
Mail list logo
