1ec5 left a comment (openstreetmap/openstreetmap-website#5769)
> Or we could leave it as an absolute timestamp and rely on JavaScript to
> relativize it on the fly.
Another advantage of client-side relative dates is that we can make them update
dynamically as you’re viewing the page. For exampl
This implements the suggestion from #6022 to upload any screenshots from
failing system tests as an artefact.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6066
-- Commit Summary --
* Save any screenshots when tes
@hlfan pushed 7 commits.
9d2ef5134bde358688b95a5decbe6cda776fc461 Make Rails handle SVG partials
a9219646089ecdc31800d1e423cffca06c615a67 Move search icons to partials
0ca0d5c8493012e8c7e0dff6ab97687567446000 Move about icons to partials
1ab22cc75897d3696a3f554a410128496f2abfbb Move welcome ic
@tomhughes pushed 1 commit.
e811fd6cf24da4b1b060fc7a2896bf5b44de542d Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/114ebc8d0d421d51dae0077ddfdd666fd01f99fe..e811fd6cf24da4b1b060fc7a2896b
@hlfan pushed 7 commits.
5c20d43efc57b37240755ebc542fed3046c4f456 Write layer sidebar in erb template
bac00d69b7d5d9ff5a703e811d3353046b6a6486 Write share sidebar in erb template
910e3ff5867dc9775d57f2ac3f187e77a574461a Move layer sidebar translations
f6d46ce019095d8936162577af1e6ad588a79e70 M
tomhughes left a comment (openstreetmap/openstreetmap-website#6058)
Thanks for the additions. I think this looks good to merge now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-2920046492
You are receiving thi
Merged #6058 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6058#event-17872163502
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6064 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6064#event-17872163495
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6064)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6064#issuecomment-2920017042
You are receiving this because you are subscribed to this t
hlfan left a comment (openstreetmap/openstreetmap-website#6064)
> If icons are kept with colors, the dark mode filter would have to be changed
> because currently the icons look like this
Or just inline the icons so they can use currentColor, then the osm logo
derivates (ohm, forum, wiki) can b
hlfan left a comment (openstreetmap/openstreetmap-website#6065)
It is the logo in the wiki, idk why it isn't the favicon.
@1ec5 was involved in the discussion about it not showing up in the vector 2022
skin.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap
hlfan left a comment (openstreetmap/openstreetmap-website#6064)
The OGF icon doesn't even need a filter:
```svg
http://www.w3.org/2000/svg"; width="16" height="16" viewBox="41.59
94.407 107.43229 100.52796" fill="none" stroke="#212529" stroke-linecap="round"
stroke-linejoin="round">
Merged #6062 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6062#event-17871507807
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6065)
Where did that icon come from? It doesn't seem to be the favicon for the wiki?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2919936480
You ar
tomhughes left a comment (openstreetmap/openstreetmap-website#6062)
I think this looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6062#issuecomment-2919932523
You are receiving this because you are subscribe
hlfan left a comment (openstreetmap/openstreetmap-website#6065)
Shouldn't alterations to official logos involve the LWG?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6065#issuecomment-2919912386
You are receiving this because y
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5956)
Merged, thanks.
If we also need that "Routing services allow checking..." disclaimer, we can
put it for example on the bottom of the directions panel, somewhere here:
![image](https://github.com/user-attachments/assets/b42f7fd
Merged #5956 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5956#event-17871075625
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
The icon currently has "Wiki" inside the magnifying glass. I
don't think anyone can read "iki" there without zooming in really
far. "iki" also takes away space that can be used to make
"W" more readable.
This PR removes "iki" and makes "W" larger.
Before:
After in Firefox:
You can view, comment on, or merge this pull request online at:
https://githu
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#6063)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener
Closes #5616 as a partial spiritual successor of #4335
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6063
-- Commit Summary --
* Write layer sidebar in erb template
* Write share sidebar in erb template
* Move
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6062)
> Is the `javascripts.social_links.remove` translation still used somewhere
> else? Otherwise it should be removed since it's already a duplicate.
It's not used. That's why it was already removed.
--
Reply to this email dire
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6062)
> The only real use I could think of was accessibility but the actual links
> aren't numbered once they're filled in so it doesn't seem like it helps with
> relating them to the remove buttons.
Placeholders are announced by s
@AntonKhorev pushed 5 commits.
5c5364bcce7f63f4561deaf4b47cf8bbef93afff Remove unnecessary
event.preventDefault() from "Add Social Link"
3ac83941881536743ef8eb1b999fca1bf33abbe2 Remove unused ids from social link
inputs
5ee22cd407d836e195e3ea0d897dd015fd2f208e Add social link controls using h
Hello, my name is Jędrzej Steckiewicz from Poland (user: JayStecki) and I
am an entry-level Technical Writer, that graduates last weekend.
https://www.linkedin.com/in/j%C4%99drzej-j-steckiewicz-395659334/
https://github.com/JayStecki
As a thesis, I have done a proposal to migrate the OpenStreetMa
hlfan left a comment (openstreetmap/openstreetmap-website#6062)
Is the `javascripts.social_links.remove` translation still used somewhere else?
Otherwise it should be removed since it's already a duplicate.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/o
nertc left a comment (openstreetmap/openstreetmap-website#5987)
PR was updated. `master` was merged. Merge conflicts were resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-2918612267
You are receiving thi
mmd-osm left a comment (openstreetmap/openstreetmap-website#2185)
I'm not seeing any error messages on Rails 8 anymore in case
config/settings.local.yml is missing. Is this working as expected? Maybe we
could remove the respective section in the readme file now.
--
Reply to this email directly
@nertc pushed 1 commit.
35cc26cb6ad172ab85eb49c484199cc87dadc2f7 Company Name on Profile Page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/1581f36730d20e9c91b10ea5dfd904b9f2edf7b7..35cc26cb6ad172ab85eb49c484199cc87dadc2f7
You are receiving this be
kcne left a comment (openstreetmap/openstreetmap-website#5853)
@tomhughes Just let me know if there are any policy updates to update the PR
and resolve conflicts. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5853#is
31 matches
Mail list logo
