Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)

2025-05-28 Thread Simon Poole via rails-dev
simonpoole left a comment (openstreetmap/openstreetmap-website#6028) > is routed through njy-newark That explains everything: they are taking a leaf out of the book of the FAA. Sorry sometimes some comic relief is necessary :-) -- Reply to this email directly or view it on GitHub: https://git

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-28 Thread Tom Hughes via rails-dev
Merged #6059 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6059#event-17855927624 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Rename confirmations controller test class (PR #6061)

2025-05-28 Thread Tom Hughes via rails-dev
Merged #6061 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6061#event-17855927632 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove /edit from profile form path (PR #6060)

2025-05-28 Thread Tom Hughes via rails-dev
Merged #6060 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6060#event-17855927601 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Always use button elements for Remove social link buttons (PR #6062)

2025-05-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6062) Looks good... I think my only question is whether numbering the links is helpful? The only real use I could think of was accessibility but the actual links aren't numbered once they're filled in so it doesn't seem like it helps

Re: [openstreetmap/openstreetmap-website] Rename confirmations controller test class (PR #6061)

2025-05-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6061) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6061#issuecomment-2917172937 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Remove /edit from profile form path (PR #6060)

2025-05-28 Thread Tom Hughes via rails-dev
tomhughes left a comment (openstreetmap/openstreetmap-website#6060) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6060#issuecomment-2917171276 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-28 Thread Tom Hughes via rails-dev
@tomhughes approved this pull request. Thanks. I think this is good now. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6059#pullrequestreview-2875969796 You are receiving this because you are subscribed to this thread. Messag

Re: [openstreetmap/openstreetmap-website] alias_method_chain deprecation (#1602)

2025-05-28 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#1602) @tomhughes : the PR is quite old... `bundle exec rails test` seems to work without deadlock_retry Gem these days. Was there some other reason to add it back then? Can we retire it? -- Reply to this email directly or view it on

Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)

2025-05-28 Thread elevenchars via rails-dev
elevenchars left a comment (openstreetmap/openstreetmap-website#6028) I haven't experienced this since the day of the report. I rewrote the reproduction steps to make it clearer to those who might find this issue that this is for a very specific type of error and not general issues with the edi

Re: [openstreetmap/openstreetmap-website] Always use button elements for Remove social link buttons (PR #6062)

2025-05-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 73a8cdcd9af692e6bc032b3fc60d2693a41131af Add social link controls using html template 79c51e5472f32ab9cba8b0ac4bbe92015ef3ac2d Add placeholders/titles to social link controls 01d077693637ec628642029ca015b86ab9c63581 Make remove social link buttons always actual

Re: [openstreetmap/openstreetmap-website] Always use button elements for Remove social link buttons (PR #6062)

2025-05-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. 0f667a94f3ce46ea4a9111474b7f3205a1df3385 Add social link controls using html template 88018e61505dd08c035e36d11cbfcf48963d3a31 Add placeholders/titles to social link controls 37927d8f8366fd769dc51c2475583dac437b5e75 Make remove social link buttons always actual

[openstreetmap/openstreetmap-website] Always use button elements for Remove social link buttons (PR #6062)

2025-05-28 Thread Anton Khorev via rails-dev
Fixes https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2904227124 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6062 -- Commit Summary -- * Remove unnecessary event.preventDefault() fr

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread Mahmoud Hanafy via rails-dev
mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6058) In my case it was taking around 21-21 seconds after this change it's now taking around 7 seconds. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuec

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread mmd via rails-dev
mmd-osm left a comment (openstreetmap/openstreetmap-website#6058) How much faster is this now compared to the original version? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-2916602284 You are receiving this be

Re: [openstreetmap/openstreetmap-website] retina compatible icons (#850)

2025-05-28 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#850) Do you think the marker on the export page needs to be an SVG as well? And if so, should it be a separate file or defined in the export view? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/open

[openstreetmap/openstreetmap-website] Rename confirmations controller test class (PR #6061)

2025-05-28 Thread Anton Khorev via rails-dev
Change the class name to ConfirmationsControllerTest to match the filename and the tested controller. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6061 -- Commit Summary -- * Rename confirmations controller test

Re: [openstreetmap/openstreetmap-website] Remove /edit from profile form path (PR #6060)

2025-05-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. c7aa86f5be2730359cad1d2b701e5f74261b743d Remove /edit from profile form path -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6060/files/ad7aaba3b6c3c024315afc220a7fd6fd3b887ba6..c7aa86f5be2730359cad1d2b701e5f74261b743d You are rece

[openstreetmap/openstreetmap-website] Remove /edit from profile form path (PR #6060)

2025-05-28 Thread Anton Khorev via rails-dev
Changes `/profile/edit` path to `/profile`. This makes it similar to account and preferences paths that also don't have `/edit`. Getting `/profile` is now allowed, making it possible to reload the profile edit form page. You can view, comment on, or merge this pull request online at: https:/

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-28 Thread David Tsiklauri via rails-dev
nertc left a comment (openstreetmap/openstreetmap-website#5987) PR was updated. `master` was merged. Merge conflicts were resolved. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5987#issuecomment-2915775616 You are receiving thi

Re: [openstreetmap/openstreetmap-website] Company Name on Profile Page (PR #5987)

2025-05-28 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 1581f36730d20e9c91b10ea5dfd904b9f2edf7b7 Company Name on Profile Page -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5987/files/6bc4fab7bc1427966d4615afe42bc5e31ec244bc..1581f36730d20e9c91b10ea5dfd904b9f2edf7b7 You are receiving this be

Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

2025-05-28 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 3 commits. c8fa8ebbed185c77e912b297924751b770004fe3 Allow to revisit terms page if already agreed db1ab99c6d52137eb2a55d9fdf01a02974ac379f Allow to agree to new terms if already agreed to old terms 1c1753819257faefbf694ba5edb715c9fc9f9d19 Show terms acceptance dates and li

Re: [openstreetmap/openstreetmap-website] Intermittent CORS issues with editing API (Issue #6028)

2025-05-28 Thread Grant via rails-dev
Firefishy left a comment (openstreetmap/openstreetmap-website#6028) It is possible the CORS error was due to Cloudflare running an experiment. They occasionally run live experiments on our tier before full rollout / rollback. -- Reply to this email directly or view it on GitHub: https://github.

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread Mahmoud Hanafy via rails-dev
mahmoudhanafy left a comment (openstreetmap/openstreetmap-website#6058) Hi @tomhughes Thanks for the feedback, I have updated the PR. Please have a look. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-29154545

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread Mahmoud Hanafy via rails-dev
@mahmoudhanafy pushed 1 commit. 41e0f758ac9f50b60d84f47c4aa64196841c2688 Preload changeset, relation_members, relation_tags -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058/files/8675f6b352fe0d15e27fe2302eeb3611723bc83a..41e0f758ac9f50b60d84f47c4aa64196841

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread Mahmoud Hanafy via rails-dev
abohanafy left a comment (openstreetmap/openstreetmap-website#6058) Hi @tomhughes Thanks for the feedback, I have updated the PR. Please have a look. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058#issuecomment-2915386261 Yo

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-28 Thread Mahmoud Hanafy via rails-dev
@mahmoudhanafy pushed 1 commit. 14027d982279f98da40fda6435abf6ebef9e4f9a Preload changeset, relation_members, relation_tags -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6058/files/41e0f758ac9f50b60d84f47c4aa64196841c2688..14027d982279f98da40fda6435abf6ebef9