Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Anton Khorev via rails-dev
@AntonKhorev commented on this pull request. > @@ -112,7 +116,10 @@ OSM.History = function (map) { function toggleChangesetHighlight(id, state) { changesetsLayer.toggleChangesetHighlight(id, state); -$("#changeset_" + id).toggleClass("selected", state); +$("#sidebar_content .ch

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 8708d91e9620b461a9ef48a03f8de495d35700af Avoid highlighting multiple changesets in history sidebar -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6059/files/b65eed6189d216c0741d01805c21d0bfd6726482..8708d91e9620b461a9ef48a03f8de4

Re: [openstreetmap/openstreetmap-website] Drop selenium monkey patch in favour of upstream fix (PR #6053)

2025-05-27 Thread Anton Khorev via rails-dev
AntonKhorev left a comment (openstreetmap/openstreetmap-website#6053) Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6053#issuecomment-2912496948 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Filter out invisible nodes and ways during initial selection (PR #5589)

2025-05-27 Thread Tom Hughes via rails-dev
@tomhughes pushed 1 commit. 114ebc8d0d421d51dae0077ddfdd666fd01f99fe Filter out invisible nodes and ways during initial selection -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/da0577a4205305b801ab9e742cad10cd8def842c..114ebc8d0d421d51dae0077ddfdd6

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.2.0 to 4.4.0 (PR #6055)

2025-05-27 Thread Tom Hughes via rails-dev
Merged #6055 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6055#event-17835314449 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. > @@ -112,7 +116,10 @@ OSM.History = function (map) { function toggleChangesetHighlight(id, state) { changesetsLayer.toggleChangesetHighlight(id, state); -$("#changeset_" + id).toggleClass("selected", state); +$("#sidebar_content .chan

Re: [openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-27 Thread Tom Hughes via rails-dev
@tomhughes commented on this pull request. This is fine as far as it goes, but you could also add changesets to the `Way.preload` call and also add preloading of changesets to the `Relation.nodes` and `Relation.ways` calls. It would also be worth preloading `:relation_members` and `:relation_ta

Re: [openstreetmap/openstreetmap-website] Add routing provider tips (PR #5956)

2025-05-27 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. c07d5752c573ef249c0d3a2bb348393e4592920a Add routing provider tips -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5956/files/b5c180c4eb1f109c6b06ce7bdbbf90e1cd2d625b..c07d5752c573ef249c0d3a2bb348393e4592920a You are receiving this becau

Re: [openstreetmap/openstreetmap-website] Use same logic for feature names (PR #6037)

2025-05-27 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 2fbf735eb16fa2293c572a2efcdf88fd0653c3c0 Use same logic for feature names -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6037/files/507579af021b0ba28901833a8d9b83c1fa044365..2fbf735eb16fa2293c572a2efcdf88fd0653c3c0 You are receiving thi

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. b65eed6189d216c0741d01805c21d0bfd6726482 Avoid highlighting multiple changesets in history sidebar -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6059/files/ada39e959d4b58047f6c44b80e612cf498760ec8..b65eed6189d216c0741d01805c21d0

Re: [openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 4 commits. 79b9d32a2feccb50325108cff00805eb5f59afe0 Add "Scroll to changeset" context menu item to history pages cb2bd176d1b38a59e96defef6625f29524416b18 Remove nested .changesets from lists on history pages efc52b4af3976a85b86cba2684605600e26db991 Use within_sidebar inste

[openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

2025-05-27 Thread Anton Khorev via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6059 -- Commit Summary -- * Add "Scroll to changeset" context menu item to history pages * Remove nested .changesets from lists on history pages * Use within_sideb

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.2.0 to 4.4.0 (PR #6055)

2025-05-27 Thread dependabot[bot] via rails-dev
dependabot[bot] left a comment (openstreetmap/openstreetmap-website#6055) Sorry, only users with push access can use that command. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6055#issuecomment-2913009386 You are receiving this

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.2.0 to 4.4.0 (PR #6055)

2025-05-27 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6055) Aw, man. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6055#issuecomment-2913010481 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.2.0 to 4.4.0 (PR #6055)

2025-05-27 Thread Marwin Hochfelsner via rails-dev
hlfan left a comment (openstreetmap/openstreetmap-website#6055) Maybe I can rerun the failed UserLocationChangeTest by @dependabot rebase -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6055#issuecomment-2913009272 You are receivi

Re: [openstreetmap/openstreetmap-website] Drop selenium monkey patch in favour of upstream fix (PR #6053)

2025-05-27 Thread Anton Khorev via rails-dev
Merged #6053 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6053#event-17830558116 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Slow response in rendering phase while calling /map endpoint (Issue #6057)

2025-05-27 Thread Holger Jeromin via rails-dev
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#6057) > So I'm wondering if there is any type of caching or multi-threading happening > on the public website but not happening on my version. The main performance boost is that the public website does not run this code at all :-

[openstreetmap/openstreetmap-website] Include changeset with node instead of loading it while rendering (PR #6058)

2025-05-27 Thread Mahmoud Hanafy via rails-dev
Related to this issue: https://github.com/openstreetmap/openstreetmap-website/issues/6057 The exact details in the issue above. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6058 -- Commit Summary -- * Include c